Re: Trouble passing variables - C# Discussion Boards

drgsldr6927-Aug-12 2:26

27-Aug-12 2:26

But I have, they are the dice.Roll5D6 which works perfectly and gives me the scores I am looking for. I just don't want to call the dice.Roll5D6 again because that will just reroll them.

Wes Aday27-Aug-12 2:54

27-Aug-12 2:54

drgsldr69 wrote:
But I have

public void Character()
       {
          string N;
          N = base.Name();
          Console.Write("\n");
          Console.Write("Your Name is: {0} \n", N);
          abilities.ShowAbilities(Str, Dex, Con, Int, Wis, Cha);
       }

You have? Where are they defined in this method? You have a scoping issue.

Why is common sense not common?
Never argue with an idiot. They will drag you down to their level where they are an expert.
Sometimes it takes a lot of work to be lazy
Please stand in front of my pistol, smile and wait for the flash - JSOP 2012

drgsldr6927-Aug-12 3:20

27-Aug-12 3:20

They are set in RollStr,

public void RollStr()
{
    Abilities BaseClass = new Abilities();
    int Str;

    Str = dice.Roll5D6();
    Console.Write("Str: {0} \n", Str);
    //Reroll the dice
    char MyChoice;
    string MyInput;
    char ReRoll = Convert.ToChar("y");

    Console.Write("Would you like to reroll this score?");
    MyInput = Console.ReadLine();
    MyChoice = Convert.ToChar(MyInput);

    if (MyInput == Convert.ToString(ReRoll))
    {
        BaseClass.RollStr();
    }

}

used in RollAbilities()

public void ShowAbilities(int Str, int Dex, int Con, int Int, int Wis, int Cha)
{
    Console.WriteLine("Strength:     {0}\n", Str);
    Console.WriteLine("Dexterity:    {0}\n", Dex);
    Console.WriteLine("Constitution: {0}\n", Con);
    Console.WriteLine("Intelligence: {0}\n", Int);
    Console.WriteLine("Wisdom:       {0}\n", Wis);
    Console.WriteLine("Charisma:     {0}\n", Cha);
}

which i was informed I could pass them from there to ShowAbilities which I use in

Abilities abilities = new Abilities();
  public void Character()
   {
      string N;
      N = base.Name();
      Console.Write("\n");
      Console.Write("Your Name is: {0} \n", N);
      abilities.ShowAbilities(Str, Dex, Con, Int, Wis, Cha);
   }

All I want ShowAbilities to do is output the scores saved from RollAbilities. That way I can call it in Character()

Wes Aday27-Aug-12 3:29

27-Aug-12 3:29

drgsldr69 wrote:
int Str;

First of all, you are only defining a local variable Str of type int. That has nothing at all to do with your ShowAbilites method. You have not defined Int, Dex, or any of the other variables that you want to display. Your problem is that you do not understand variable scope.

If you are looking for a way to display them, in the limited view of your architecture that we have, you would need to pass Str, Int and the rest to your Character method so that they could in turn be passed to your ShowAbilites method. Or declare Str, Int and the rest as class level variables.

drgsldr6927-Aug-12 5:29

27-Aug-12 5:29

Ok I think you have it backwords. I have it going from rollstr to rollabilities to showabilities then to character. Character is the final stage of it which should do nothing but call the function ShowAbilities()Which is supposed to have the variables and values stored in it.Which obviously I am having a problem figuring out how to do.I have it all working great up till showabilities being called in character. Once I try to do that it doesn't want to display anything.

Wes Aday27-Aug-12 5:34

27-Aug-12 5:34

drgsldr69 wrote:
want to display anything

Because you are not giving it anyting to display. You are declaring your variables, apparently, as local variables which your other methods do not know anything about. Your ShowAbilites method cannot display data that it does not have access to. It's called "variable scope".

drgsldr6927-Aug-12 5:36

27-Aug-12 5:36

Ok then can you please explain what I would have to do to make that work? Or at least give me an example code that I could use to figure it out? Cause as it sits right now I am lost. Below is the entire ability class

class Abilities
{
    //Start Abilities
    //-----------------------------------------------------------------------------------------------------------------------------------
    Dice dice = new Dice();

    public void ShowAbilities(int Str, int Dex, int Con, int Int, int Wis, int Cha)
    {
        Console.WriteLine("Strength:     {0}\n", Str);
        Console.WriteLine("Dexterity:    {0}\n", Dex);
        Console.WriteLine("Constitution: {0}\n", Con);
        Console.WriteLine("Intelligence: {0}\n", Int);
        Console.WriteLine("Wisdom:       {0}\n", Wis);
        Console.WriteLine("Charisma:     {0}\n", Cha);
    }

    public void RollAbilities()
    {
        Abilities BaseClass = new Abilities();
        BaseClass.RollStr();
        BaseClass.RollDex();
        BaseClass.RollCon();
        BaseClass.RollInt();
        BaseClass.RollWis();
        BaseClass.RollCha();
    }

    public void RollStr()
    {
        Abilities BaseClass = new Abilities();
        int Str;

        Str = dice.Roll5D6();
        Console.Write("Str: {0} \n", Str);
        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollStr();
        }

    }

    public void RollDex()
    {
        Abilities BaseClass = new Abilities();
        int Dex;

        Dex = dice.Roll5D6();
        Console.Write("Dex: {0} \n", Dex);

        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollDex();
        }
    }

    public void RollCon()
    {
        Abilities BaseClass = new Abilities();
        int Con;

        Con = dice.Roll5D6();
        Console.Write("Con: {0} \n", Con);

        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollCon();
        }

    }

    public void RollInt()
    {
        Abilities BaseClass = new Abilities();
        int Int;

        Int = dice.Roll5D6();
        Console.Write("Int: {0} \n", Int);

        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollInt();
        }

    }

    public void RollWis()
    {
        Abilities BaseClass = new Abilities();
        int Wis;

        Wis = dice.Roll5D6();
        Console.Write("Wis: {0} \n", Wis);

        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollWis();
        }

    }

    public void RollCha()
    {
        Abilities BaseClass = new Abilities();
        int Cha;

        Cha = dice.Roll5D6();
        Console.Write("Cha: {0} \n", Cha);

        //Reroll the dice
        char MyChoice;
        string MyInput;
        char ReRoll = Convert.ToChar("y");

        Console.Write("Would you like to reroll this score?");
        MyInput = Console.ReadLine();
        MyChoice = Convert.ToChar(MyInput);

        if (MyInput == Convert.ToString(ReRoll))
        {
            BaseClass.RollCha();
        }

    }


    //End Abilities
    //-----------------------------------------------------------------------------------------------------------------------------------

I was trying to pass Showabilities over to the class that holds the actual character generator which is below.

public class Fighter : attributes
 {
    Abilities abilities = new Abilities();
      public void Character()
       {
          string N;
          N = base.Name();
          Console.Write("\n");
          Console.Write("Your Name is: {0} \n", N);
          abilities.ShowAbilities(Str, Dex, Con, Int, Wis, Cha);
       }

Wes Aday27-Aug-12 5:42

27-Aug-12 5:42

drgsldr69 wrote:
I would have to do to make that work

Sorry, I do not know what else I could do. I have explained what you need to do over and over. You either need to declare your variable at the class level so your other methods have access to them (fields or properties) or you need to pass the variables around to the methods that need them.

drgsldr6927-Aug-12 5:45

27-Aug-12 5:45

And that is the problem I am having. I don't know how to do either of what you said since nothing I have tried so far has worked. Could you give me an example so I have something to look at to help me?

Wes Aday27-Aug-12 6:02

27-Aug-12 6:02

drgsldr69 wrote:
an example

First, your textbook should show you all of this. Second I cannot fix your code because it does not make any sense. I do not know what "dice" is or "BaseClass". But

public void Character(int Str)
{
    string N;
    //N = base.Name();
    Console.Write("\n");
    Console.Write("Your Name is: {0} \n", N);
    //abilities.ShowAbilities(Str, Dex, Con, Int, Wis, Cha);
    ShowAbilities(Str);
}

public void ShowAbilities(int Str)
{
    Console.WriteLine("Strength:     {0}\n", Str);
    //Console.WriteLine("Dexterity:    {0}\n", Dex);
    //Console.WriteLine("Constitution: {0}\n", Con);
    //Console.WriteLine("Intelligence: {0}\n", Int);
    //Console.WriteLine("Wisdom:       {0}\n", Wis);
    //Console.WriteLine("Charisma:     {0}\n", Cha);
}

public void RollStr()
{
    //Abilities BaseClass = new Abilities();
    int Str;

    Str = dice.Roll5D6();
    Console.Write("Str: {0} \n", Str);
    //Reroll the dice
    char MyChoice;
    string MyInput;
    char ReRoll = Convert.ToChar("y");

    Console.Write("Would you like to reroll this score?");
    MyInput = Console.ReadLine();
    MyChoice = Convert.ToChar(MyInput);

    if (MyInput == Convert.ToString(ReRoll))
    {
        BaseClass.RollStr();
    }
    Character(Str);
}

should be enough to show you how to pass a variable from you RollStr method to your Character method and then to your ShowAbilites method. How you think you will do this in your real application is beyond me as you have not defined what your classes are or how they relate to each other.

drgsldr6927-Aug-12 6:18

27-Aug-12 6:18

Wes Aday wrote:
//abilities.ShowAbilities(Str, Dex, Con, Int, Wis, Cha);
ShowAbilities(Str);

On this part here in bold it doesn't want to accept that because it doesn't see ShowAbilities in that function. Which is why i have the Abilities abilities = new Abilities(); in and abilities.ShowAbilities(Str, etc) which it doesn't want to read right. I did edit my second or third post above this one with the ENTIRE ability class. The only class I didn't paste in this thread now is my dice class which is just to give random numbers between 1 and 6 to the ability score. but I also have other dice in there which ain't being used as of yet.

Wes Aday27-Aug-12 6:34

27-Aug-12 6:34

See if this makes any more sense. I did not compile this as I cannot. But should get you closer. Pay attention to the comments.

class Abilities
 {
     private int Str;
     private int Intelligence;
     private int Dexterity;


     // OR
     // public int Strength {get; set; } this is a property

     Dice dice = new Dice();

     public void ShowAbilities()
     {
         Console.WriteLine("Strength:     {0}\n", Str); // <- {0} makes no sense here.
         // Console.WriteLine(string.Format("Strength:     {0}\n", Strength")); Using a property
         Console.WriteLine(string.Format("Dexterity:    {0}\n", Dexterity));
         //Console.WriteLine("Constitution: {0}\n", Con);
         Console.WriteLine("Intelligence: {0}\n", Intelligence);
         //Console.WriteLine("Wisdom:       {0}\n", Wis);
         //Console.WriteLine("Charisma:     {0}\n", Cha);
     }

     public void RollAbilities()
     {
         Abilities BaseClass = new Abilities();
         BaseClass.RollStr();
         BaseClass.RollDex();
         BaseClass.RollCon();
         BaseClass.RollInt();
         BaseClass.RollWis();
         BaseClass.RollCha();
     }

     public void RollStr()
     {
         Abilities BaseClass = new Abilities();
         Str = dice.Roll5D6();
         // Or
         //Strength = dice.Roll5D6();
         Console.Write("Str: {0} \n", Str);
         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollStr();
         }

     }

     public void RollDex()
     {
         Abilities BaseClass = new Abilities();

         Dexterity = dice.Roll5D6();
         Console.Write("Dex: {0} \n", Dex);

         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollDex();
         }
     }

     public void RollCon()
     {
         Abilities BaseClass = new Abilities();
         int Con;

         Con = dice.Roll5D6();
         Console.Write("Con: {0} \n", Con);

         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollCon();
         }

     }

     public void RollInt()
     {
         Abilities BaseClass = new Abilities();

         Intelligence = dice.Roll5D6();
         Console.Write("Int: {0} \n", Int);

         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollInt();
         }

     }

     public void RollWis()
     {
         Abilities BaseClass = new Abilities();
         int Wis;

         Wis = dice.Roll5D6();
         Console.Write("Wis: {0} \n", Wis);

         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollWis();
         }

     }

     public void RollCha()
     {
         Abilities BaseClass = new Abilities();
         int Cha;

         Cha = dice.Roll5D6();
         Console.Write("Cha: {0} \n", Cha);

         //Reroll the dice
         char MyChoice;
         string MyInput;
         char ReRoll = Convert.ToChar("y");

         Console.Write("Would you like to reroll this score?");
         MyInput = Console.ReadLine();
         MyChoice = Convert.ToChar(MyInput);

         if (MyInput == Convert.ToString(ReRoll))
         {
             BaseClass.RollCha();
         }

     }

drgsldr6927-Aug-12 7:54

27-Aug-12 7:54

Thanks that basically worked I just need to call the function to roll the ability scores first I guess since right now it is showing them as all 0 lol but at least it is printing them.

drgsldr6927-Aug-12 7:58

27-Aug-12 7:58

Ok I take that back even running RollAbility() first didn't populate the ability scores. Or should I say didn't save them and pass them.It rolls the dice perfectly re-rolls, them great,but still shows each score at 0 when you run the ShowAbilities()

Wes Aday27-Aug-12 8:15

27-Aug-12 8:15

Your additional problem is probably:

public void RollAbilities()
        {
            Abilities BaseClass = new Abilities();
            BaseClass.RollStr();
            BaseClass.RollDex();
            BaseClass.RollCon();
            BaseClass.RollInt();
            BaseClass.RollWis();
            BaseClass.RollCha();
        }

You are creating a new instance of Abilities, rolling your dice and then your instance goes out of scope so you get nothing. Change that to

public void RollAbilities()
        {
            RollStr();
            RollDex();
            RollCon();
            RollInt();
            RollWis();
            RollCha();
        }

drgsldr6927-Aug-12 13:53

27-Aug-12 13:53

Ok this is solved now. Granted I am having other problems but that would be for a different thread lol

BillWoodruff26-Aug-12 15:23

BillWoodruff

26-Aug-12 15:23

I think Wes has effectively answered your questions.

But, a word of advice, it's good to make clear that what you are passing in this case to a function is not a "variable" but the value (in this case a string) contained inside that variable.

When you are ready, you should examine the keywords 'ref, and 'out to understand the possibilities of what may happen when you want a change to a passed in value within some function to affect the variable that was the source of the parameter in the function.

best, Bill

"If you shoot at mimes, should you use a silencer ?" Stephen Wright

drgsldr6926-Aug-12 15:44

Database Connection on Deployment

26-Aug-12 15:44

Thanks everyone that has helped. This is part of a character generator for a D&D type game. I'm just hoping I get it in right I have a couple hours before I have to turn it in so wish me luck lol. If I run into any other problems I will be sure to come back.

SHASHANK SAGAR26-Aug-12 8:36

SHASHANK SAGAR

26-Aug-12 8:36

How to add new connection string to the application on deployment of application on any other system using setup ?

Shashank Sagar

Eddy Vluggen26-Aug-12 8:49

Eddy Vluggen

26-Aug-12 8:49

Why "during setup"? Your app can determine where it is installed once it's installed; simply ask the current assembly for it's location. You can then dynamically build a correct connectionstring, based on the circumstances;

Will you be installing Sql Server Express? Will the database be auto-attaching, or always attached under a alias? It'd be preferably to name the instance, if it's not shared; and depending on your security-settings, you might be using Windows authentication or Sql Server authentication.

How the connection-string will ultimately look varies per database; you can find examples here[^].

..and what does it have to do with C#?

Bastard Programmer from Hell Suspicious | :suss:

if you can't read my code, try converting it here[^]

Vijay Selvaraj26-Aug-12 21:53

Vijay Selvaraj

26-Aug-12 21:53

hi you can use web.config file it will much better

SHASHANK SAGAR27-Aug-12 3:07

SHASHANK SAGAR

27-Aug-12 3:07

that is for websites not for windows application.

Shashank Sagar