The Weird and The Wonderful

David MacDermot wrote:

enamored of the ternary operator

iScreen = iScreen < 8 ? iScreen + 1 :
          iScreen < 10 ? iScreen + 4 :
          iScreen < 11 ? iScreen + 5 :
          iScreen < 12 ? iScreen + 10 :
          iScreen < 16 ? iScreen + 12 :
          iScreen < 20 ? iScreen + 24 :
          iScreen < 22 ? iScreen + 45 :
          22 == iScreen ? iScreen + 53 :
          23 == iScreen ? iScreen + 57 :
          iScreen < 26 ? iScreen + 65 :
          iScreen < 28 ? iScreen + 72 :
          iScreen < 30 ? iScreen + 152 :
          30 == iScreen ? iScreen + 160 :
          iScreen < 33 ? iScreen + 169 :
          33 == iScreen ? iScreen + 170 :
          34 == iScreen ? iScreen + 171 :
          35 == iScreen ? iScreen + 175 :
          iScreen < 41 ? iScreen + 176 :
          41 == iScreen ? iScreen + 203 :
          42 == iScreen ? iScreen + 208 :
                          iScreen + 212;

iScreen = iScreen + 
   iScreen <  8 ?   1 :
   iScreen < 10 ?   4 :
   iScreen < 11 ?   5 :
   iScreen < 12 ?  10 :
   iScreen < 16 ?  12 :
   iScreen < 20 ?  24 :
   iScreen < 22 ?  45 :
   22== iScreen ?  53 :
   23== iScreen ?  57 :
   iScreen < 26 ?  65 :
   iScreen < 28 ?  72 :
   iScreen < 30 ? 152 :
   30 == iScreen? 160 :
   iScreen < 33 ? 169 :
   33 == iScreen? 170 :
   34 == iScreen? 171 :
   35 == iScreen? 175 :
   iScreen < 41 ? 176 :
   41 == iScreen? 203 :
   42 == iScreen? 208 :
                  212;

OrderedMap<int, int> screenDeltas = { 7=>1, 9=>4, 10=>5, ..., 42=>208, 43=>212 };

function getScreenDelta(iScreen){
 foreach(MapEntry<int, int> delta in screenDeltas)
  if(iScreen <= delta.Key) return delta.Value;
}

int[] screenDeltas = new[] { 1, 1, 1, 1, 1, 1, 1, 1, 1, 4, 4, /* ... */ };
/* ... */
iScreen += iScreen < 0 ? 1 :
           iScreen > 42 ? 212 : /* Is 42 significant here? Are you building Deep Thought? */
           screenDeltas[iScreen];

BobJanova wrote:

Yes, or at least bind the items to an object, of which this magic number was a property.

public class Display
{
    public static readonly Display OpeningSplashdisplay =
        new Display(1, "Opening Splash display");
    public static readonly Display StartUpDateConfig =
        new Display(2, "start up date config");

    //
    // Skip a lot of Displays
    //

    /// <summary>
    /// Enumerate the Display objects.
    /// </summary>
    public static IEnumerable<Display> Values
    {
        get
        {
            object temp = null;
            FieldInfo[] fields = typeof(Display).GetFields(); // Obtain all fields
            foreach (FieldInfo field in fields)
            {
                temp = field.GetValue(null);
                if (temp is Display)
                    yield return (Display)temp;
            }
        }
    }

    private readonly byte value;
    private readonly string name;

    /// <summary>
    /// Enum constructor.
    /// </summary>
    /// <param name="value">The numeric value of this object.</param>
    /// <param name="name">The string representation of this object.</param>
    Display(byte value, string name)
    {
        this.value = value;
        this.name = name;
    }

    /// <summary>
    /// Get the numeric value of this object.
    /// </summary>
    /// <returns>The value as byte.</returns>
    public byte ToByte() { return value; }

    /// <summary>
    /// Get the string representation of this object.
    /// </summary>
    /// <returns>A string.</returns>
    public override string ToString() { return name; }

    /// <summary>
    /// Convert byte representation to Language object.
    /// </summary>
    /// <param name="value">A byte.</param>
    /// <returns>A Display enumerated object.</returns>
    public static Display ParseByte(byte value)
    {
        foreach (Display d in Display.Values)
        {
            if (d.ToByte() == value)
                return d;
        }

        // If we reach here return default
        return Display.OpeningSplashdisplay;
    }
}

cmbDisplay.Items.AddRange(new List<Display>(Display.Values).ToArray());

private void cmbDisplay_SelectedIndexChanged(object sender, EventArgs e)
{
    ComboBox c = (ComboBox)sender;
    Display selected = (Display)c.SelectedItem;
    _RawData[2] = selected.ToByte();
}

AspDotNetDev wrote:

It's hard to find anything NOT wrong with this

Dim oDAdapt As SqlClient.SqlDataAdapter

Dim cmdSQL As String = sSQL

Dim oRs As New DataSet
' ...not so many lines later...
oRs = New DataSet

AspDotNetDev wrote:

I really don't like when the parens aren't put after calling a constructor