The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: Attack of the stord proc

virang_218-Jun-12 2:52

virang_21

8-Jun-12 2:52

yea mate ... after long debug spelling doesn't matter much.. and English ( Engrish ) is not my first language.. I still swear in my mother tongue when I am frustrated...

Zen and the art of software maintenance : rm -rf *

Math is like love : a simple idea but it can get complicated.

Re: Attack of the stord proc

Pascal Ganaye8-Jun-12 11:28

Pascal Ganaye

8-Jun-12 11:28

This post made me laugh.
It's not his native language neither mine for that matter.

No shame there, the guy is frustrated.

Re: Attack of the stord proc

Eddy Vluggen7-Jun-12 23:28

Eddy Vluggen

7-Jun-12 23:28

virang_21 wrote:
Some are at least 500 lines long and loop within loop within loop and so on but this is insane why in the world you have one strod proc that do every CURD operation ? Why .

For fun, I do not see any other 'advantages'.

Nice prefixes - must have been written by a VB6-programmer Smile | :)

Bastard Programmer from Hell Suspicious | :suss:

Re: Attack of the stord proc

loctrice8-Jun-12 3:46

loctrice

8-Jun-12 3:46

Eddy Vluggen wrote:
must have been written by a VB6-programmer

This joke is less and less funny when you know, work with, and refactor code by vb6 programmers D'Oh! | :doh:

If it moves, compile it

Re: Attack of the stord proc

Eddy Vluggen8-Jun-12 11:32

Eddy Vluggen

8-Jun-12 11:32

loctrice wrote:
This joke is less and less funny when you know, work with, and refactor code by vb6 programmers

It's not a joke, it's sarcasm. Those prefixes are heavily in use by both Access (VBA) and VB6 developers. You won't see these kind of examples in a book on Sql. Most "experienced" programmers that I worked with are multi-lingual and rarely label themselves using a certain language.

..and yes, I too, worked a lot with VB6. The Professional edition! Roll eyes | :rolleyes:

Bastard Programmer from Hell Suspicious | :suss:

Re: Attack of the stord proc

Pascal Ganaye8-Jun-12 11:32

Pascal Ganaye

8-Jun-12 11:32

Type prefixing is far more common in C++ than VB.
http://en.wikipedia.org/wiki/Hungarian_notation[^]

Re: Attack of the stord proc

Eddy Vluggen8-Jun-12 11:39

Eddy Vluggen

8-Jun-12 11:39

Pascal Ganaye wrote:
Type prefixing is far more common in C++ than VB.

Granted; and Apps Hungarian is still in use, with a good reason. Systems Hungarian has been abandoned, also with a good reason. It's not a problem to have used it, but it IS a problem if you still see a modern-day use. Especially since the argument is over ten years old.

..and ffs, why in Sql? Is it really that complex code? No, it simply someone religiously following his "coding standard".

Bastard Programmer from Hell Suspicious | :suss:

Re: Attack of the stord proc

Jan Steyn14-Jun-12 1:36

Jan Steyn

14-Jun-12 1:36

Sometimes because "Our Dear Leader" dictated that all stored procs shall be prefixed with

SQL

sp_

at least I could convince him that we should use

SQL

usp_

, with difficulty... Sys Hungarian is also common throughout the system, such that

Dim iVariable As String

also happens to be a common sight Sigh | :sigh:

Re: Attack of the stord proc

Eddy Vluggen14-Jun-12 1:51

Eddy Vluggen

14-Jun-12 1:51

Whehe, aight Big Grin | :-D

The last example shows how it does more damage than good. I've seen these quite often, and it costs more time than that it actually helps.

Was I right in my guess? And if I also guess he's Dutch?

Bastard Programmer from Hell Suspicious | :suss:

Re: Attack of the stord proc

Pascal Ganaye8-Jun-12 11:35

Pascal Ganaye

8-Jun-12 11:35

Again I am playing devil's advocate here.
I am not suggesting that you should write this code.

However

Sometime the DBA through SQL user access rights settings won't let program access the database through SELECT/INSERT/UPDATE statements but allow execution of stored procedures.

In those scenario you must use STORED procedures to do anything.

Re: Attack of the stord proc

virang_218-Jun-12 12:39

virang_21

8-Jun-12 12:39

I don't mind use of stored proc.. It is terrible when INSERT/UPDATE/DELETE done in the same stored proc and code is calling the same stored proc with only way to find what operation it is doing is via flag is a big fat FAIL !!!

Zen and the art of software maintenance : rm -rf *

Math is like love : a simple idea but it can get complicated.

N00btacular

AspDotNetDev7-Jun-12 15:12

AspDotNetDev

7-Jun-12 15:12

Just came across this code from an ex-coworker (names changed to protect the innocent):

VB.NET

Select Case DoStuff(SomeVariable)
    Case 0
        ' Do something with SomeVariable.
    Case 1, 2
        ' Do something else with SomeVariable.
    Case Else
        result = "omgnub"
End Select

When I saw that, I Big Grin | :-D

. Well played, n00b, well played.

Thou mewling ill-breeding pignut!

Re: N00btacular

Paul Conrad8-Jun-12 12:02

Paul Conrad

8-Jun-12 12:02

Nice, that's epic! Big Grin | :-D

""Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon

Re: N00btacular

Brisingr Aerowing9-Jun-12 7:41

Brisingr Aerowing

9-Jun-12 7:41

That reminded me of a custom exception one of my friends made: NoobDetectedException. He said he would take it out when he turned in the project, but he didn't. The professor hit the exception, and was not very pleased.

The professor showed the class the exception, which had the message: "You are a noob. You will be assimilated. There will be no escape. (This also applies to <professor name omitted>")

public class SysAdmin : Employee
{

     public override void DoWork(IWorkItem workItem)
     {
          if (workItem.User.Type == UserType.NoLearn){
             throw new NoIWillNotFixYourComputerException(new Luser(workItem.User));
          }else{
               base.DoWork(workItem);
          }
     }

}

Pro Cache Usage

Member 41627846-Jun-12 5:03

Member 4162784

6-Jun-12 5:03

good practices to use a memcached client to make your site faster!

XML

public IEnumerable<Product> GetProductList()
{
    List<Product> data = null;
    var key = string.Format("{0}", "Some_Beautiful_Key");
    if (_cache != null)
        if (_cache.Contains(key))
            data = _cache.Get< List <Product> >(key);
    data = TheDao.GetProductTable();
    if (_cache != null)
        _cache.SaveOrUpdate(key, data);

    return data;
}

Rudy Alvarez // rdebug.com

Re: Pro Cache Usage

RobCroll6-Jun-12 17:42

RobCroll

6-Jun-12 17:42

Cache smash. Who needs it anyway?

"You get that on the big jobs."

Re: Pro Cache Usage

Bernhard Hiller7-Jun-12 23:02

Bernhard Hiller

7-Jun-12 23:02

When you already omit the {curly brackets}, you should not hesitate and do the next step: omit indentation, or better use random indentation.

XML

public IEnumerable<Product> GetProductList()
{
    List<Product> data = null;
    var key = string.Format("{0}", "Some_Beautiful_Key");
    if (_cache != null)
        if (_cache.Contains(key)) data = _cache.Get<List<Product>&gt;(key);
            data = TheDao.GetProductTable();
        if (_cache != null) _cache.SaveOrUpdate(key, data);
            return data;
}

And such features will be even harder to spot for the guys who have to fix your code.

Re: Pro Cache Usage

BobJanova8-Jun-12 0:24

BobJanova

8-Jun-12 0:24

Eww ... *shivers*

Re: Pro Cache Usage

Member 41627848-Jun-12 11:52

Member 4162784

8-Jun-12 11:52

I'm the guy that fix code :'( jajajaja

ArrayList.Contains() isn't bool?

Ankush Bansal6-Jun-12 1:36

Ankush Bansal

6-Jun-12 1:36

Just saw this legacy gem

if(myArrayList.Contains(something)==true || myArrayList.Count>0)
{
   if(myArrayList.Contains(something)==false)
   {
      default=something;
   }
   else
   {
     default=myArrayList[0];
   }
}

this is for C#.net.

Re: ArrayList.Contains() isn't bool?

OriginalGriff6-Jun-12 2:02

OriginalGriff

6-Jun-12 2:02

If you look at MSDN[^] you will see it returns a virtual bool, so obviously you can't trust it! Laugh | :laugh:

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

Re: ArrayList.Contains() isn't bool?

Ankush Bansal6-Jun-12 2:53

Ankush Bansal

6-Jun-12 2:53

"virtual bool" so anyone can override to make it float. Big Grin | :-D

Re: ArrayList.Contains() isn't bool?

OriginalGriff6-Jun-12 3:34

OriginalGriff

6-Jun-12 3:34

Well, you wouldn't want it to sink, would you? Laugh | :laugh:

Ideological Purity is no substitute for being able to stick your thumb down a pipe to stop the water

Re: ArrayList.Contains() isn't bool?

Member 20530067-Jun-12 6:02

Member 2053006

7-Jun-12 6:02

I love how the first Contains is redundant and the default does not get set if myArrayList is empty.

Re: ArrayList.Contains() isn't bool?

Bernhard Hiller7-Jun-12 23:19

Bernhard Hiller

7-Jun-12 23:19

Still worse: when the array list does not contain "something", the default is set to something. When the array list contains something, the default is set to the first element of the array list, which may or may not be "something"...

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.