Re: Get File Extension - C / C++ / MFC Discussion Boards

Aescleal26-Apr-12 4:35

26-Apr-12 4:35

If you change wszFilename to a const char * you can avoid the cast. I can't see anywhere wszFilename is modified so you should be alright.

Another thing you might not be aware of: In C you don't need to cast the return value of malloc or calloc - void * is type compatible with any sort of pointer so (at least in C90, not sure about C99) you can convert them to anything implicitly.

Cheers,

Ash

Re: Get File Extension

Randor 26-Apr-12 1:01

Randor

26-Apr-12 1:01

Well,

I realize that it is just a code sample... but there are alot of novice programmers learning by reading these forums. You might want to free() the memory you allocated for the extension and you forgot to return an integer for the main() function.

Best Wishes,
-David Delaune

Re: Get File Extension

enhzflep26-Apr-12 3:47

enhzflep

26-Apr-12 3:47

Thanks David,

I certainly had overlooked both of these points. Time I exercised a little more diligence.. Thumbs Up | :thumbsup:

Simon

Re: Get File Extension

Joe Woodbury29-Apr-12 7:06

Joe Woodbury

29-Apr-12 7:06

What if the path is \\server\share\path.path\file?

Re: Get File Extension

Randor 26-Apr-12 0:57

Randor

26-Apr-12 0:57

Jim,

When you are working with paths on the windows platform I would recommend using the Shell Path Handling Functions[^]. You are probably looking for the PathFindExtension function[^].

Best Wishes,
-David Delaune

Re: Get File Extension

jkirkerx26-Apr-12 7:10

jkirkerx

26-Apr-12 7:10

You kidding me, there's an app for that!

So PathFinderExtension trumps the sample function posted earlier?

Thanks Dave, spent way too much time on it last night.

Re: Get File Extension

«_Superman_»26-Apr-12 19:49

«_Superman_»

26-Apr-12 19:49

There's also a CRT function for this - _splitpath_s/_wsplitpath_s

«_Superman_»
I love work. It gives me something to do between weekends.

Microsoft MVP (Visual C++)

Polymorphism in C

Re: Get File Extension

jkirkerx26-Apr-12 10:08

jkirkerx

26-Apr-12 10:08

That works great. Thanks

But I don't get it. I'm not sure if the wcsncpy_s bombed, or if I have some kind of buffer error, that never got flagged.

I have a registry function that's doing the same thing, but just the 1, so far, all others work fine.

I'm going to post it in a new post.

Re: Get File Extension

Randor 26-Apr-12 18:23

Randor

26-Apr-12 18:23

jkirkerx wrote:
I have a registry function that's doing the same thing, but just the 1, so far, all others work fine.

Not sure but if you post the contents of the function and the calling function I might be able to pinpoint your problem.

Because I am somewhat familiar with the project you are working on... last comment about path handling:
In the future I would recommend that you use the Shell Path Handling Functions[^] when working on the windows platform rather than attempting to implement your own path parser. Over the past 20 years or so there have been hundreds of vulnerabilities associated with path handling/parsing... because many software engineers attempted to implement an algorithm of their own.

Best Wishes,
-David Delaune

Re: Get File Extension

Le Quang Long27-Apr-12 15:10

Le Quang Long

27-Apr-12 15:10

Dear Mr. David Delaune,

I have received your feedback.
Thank you so much. please give me your email!

Best Regards,

L.Q.LONG

Re: Get File Extension

Randor 28-Apr-12 0:14

Randor

28-Apr-12 0:14

Le Quang Long wrote:
Dear Mr. David Delaune,

I have received your feedback.

What feedback?

Re: Get File Extension

JohnCz29-Apr-12 4:28

JohnCz

29-Apr-12 4:28

THe code snippet assumes UNICODE is being used.
I would suggest to use generic mapping that will work for both: ANSII and UNICODE:
As for retrieving parts of the path why not to let CRT do it for you using generic (_tsplitpath_s)?
For example:

C++

LPTSTR lpszPath = _T("project.config.user");
TCHAR szFilename[MAX_PATH] = {0};
TCHAR szExt[MAX_PATH] = {0};

_tsplitpath_s(lpszPath, NULL, NULL, NULL, NULL, szFilename, _MAX_FNAME, szExt, _MAX_EXT);

JohnCz

Re: Get File Extension

jkirkerx29-Apr-12 9:27

jkirkerx

29-Apr-12 9:27

I implemented the PathFinderExtension from Dave's Suggestion, but your suggestion looks quite interesting. hmm.

I didn't know about that function and how to implement it.

The PathFinderExtension is working quite well now, but let me fix my errors first before making any more changes.

CALLING A NEW DIALOG

Le Quang Long25-Apr-12 4:01

Le Quang Long

25-Apr-12 4:01

Dear all everyone,

Please help me calling a dialog in project, I am using visual studio 2005(MFC, detail as below:
- My project have 2 dialogs(1 dialog to show data, 1 dialog login( user name and password) to protect data dialog)
- I created 1 dialog to show data is ok, but when I add a new dialog into this project and can not call dialog). So please help me!

Thanks and Best regards,

Re: CALLING A NEW DIALOG

Albert Holguin25-Apr-12 4:15

Albert Holguin

25-Apr-12 4:15

How are you trying to call the dialog? ...you have to show some applicable code.

Re: CALLING A NEW DIALOG

JohnCz29-Apr-12 4:54

JohnCz

29-Apr-12 4:54

I am not sure why check for valid password in OnInitDlg, while it seems that it should be checked before main dialog is invoked. No need for posting any messages to the thread.

Besides, log in dialog should not be checked for cancel only but validate password and/or username.
This code snippet shows how this can be done:

C++

	CLoginDlg loginDlg;
	loginDlg.DoModal();
	INT_PTR nResponse = loginDlg.DoModal();

	if(nResponse == IDCANCEL)
	{
		return FALSE; // canceled exit app, terminate
	}
	
	if(loginDlg.m_csUser.CompareNoCase(lpszUser))
	{
		return FALSE; // no match exit app, terminate
	}

	if(loginDlg.m_csPassword.Compare(lpszPassword))
	{
		return FALSE; // no match exit app, terminate
	}

	CMainDlg dlg;
	m_pMainWnd = &dlg;
	INT_PTR nResponse = dlg.DoModal();
.
.
.

JohnCz

Re: CALLING A NEW DIALOG

Maximilien25-Apr-12 5:28

Maximilien

25-Apr-12 5:28

I would do something like :

pre-requisite.
CLoginDialog: your login dialog.
CDataDialog; your main application dialog

The CDataDialog is the main application dialog (for example created via the wizard).

When the CDataDialog is created, you can call/create the login dialog in the OnInitDialog; if the login is valid, just continue, if it is invalid, you can either close the main application, or better continue but disable some stuff or not load the data.

For example ...

C++

BOOL Ctest_dialogDlg::OnInitDialog()
{
	CDialog::OnInitDialog();

/// ....
	LoginDialog dlg;
	if ( dlg.DoModal() == IDCANCEL)
	{
		PostQuitMessage(42);
		return FALSE;
	}
	return TRUE;  // return TRUE  unless you set the focus to a control
}

Watched code never compiles.

Re: CALLING A NEW DIALOG

Chris Meech25-Apr-12 7:30

Chris Meech

25-Apr-12 7:30

Maximilien wrote:
PostQuitMessage(42);

Best way to end an application ever. Smile | :)

Chris Meech
I am Canadian. [heard in a local bar]

In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]

posting about Crystal Reports here is like discussing gay marriage on a catholic church’s website.[Nishant Sivakumar]

Re: CALLING A NEW DIALOG

Le Quang Long27-Apr-12 15:17

Le Quang Long

27-Apr-12 15:17

Thank you so much!
Please give me your email!

Re: CALLING A NEW DIALOG

Le Quang Long28-Apr-12 18:10

Le Quang Long

28-Apr-12 18:10

Dear Maximilien,

Thank for your feedback! I want to show CLoginDialog(first). After input userID and password successfully, conntinue show CDataDialog(second) and I can type data on this CDataDialog.

Best Regards,

LQL

Re: CALLING A NEW DIALOG

David Crow25-Apr-12 5:40

David Crow

25-Apr-12 5:40

Le Quang Long wrote:
...but when I add a new dialog into this project...

Are you talking about adding a new dialog template in the project's .rc file, or adding a new CDialog-based class?

Le Quang Long wrote:
...and can not call dialog).

Why not? Isn't it just like the other (first) dialog?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Re: CALLING A NEW DIALOG

Le Quang Long25-Apr-12 14:29

Le Quang Long

25-Apr-12 14:29

I talking about adding a new dialog the same dialog-based.
Thanks,

Re: CALLING A NEW DIALOG

Le Quang Long25-Apr-12 14:30

Le Quang Long

25-Apr-12 14:30

I talking about adding a new dialog the same dialog-based.
I can not call this new dialog!
Thanks,

Re: CALLING A NEW DIALOG

Le Quang Long25-Apr-12 14:32

Le Quang Long

25-Apr-12 14:32

I talking about adding a new dialog the same dialog-based.
I can not call this new dialog( second dialog)! Pls give me a source code(ex)?
Thanks,

Re: CALLING A NEW DIALOG

Richard MacCutchan25-Apr-12 21:16

Richard MacCutchan

25-Apr-12 21:16

How can we give you source code when we have no idea what your program is doing? If you cannot call a dialog in your program then you need to give a much better explanation, including showing the code that does not work, and explaining what happens when you try.

Binding 100,000 items to a list box can be just silly regardless of what pattern you are following. Jeremy Likness

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.