Re: Tooltip issue with dialog app - C / C++ / MFC Discussion Boards

Code-o-mat wrote:
Show us some relevant code...

BOOL CMyDialog::OnToolTipText(UINT, NMHDR* pNMHDR, LRESULT* pResult)
{
    ENSURE_ARG(pNMHDR != NULL);
    ENSURE_ARG(pResult != NULL);
    ASSERT(pNMHDR->code == TTN_NEEDTEXTA || pNMHDR->code == TTN_NEEDTEXTW);

    // need to handle both ANSI and UNICODE versions of the message
    TOOLTIPTEXTA* pTTTA = (TOOLTIPTEXTA*)pNMHDR;
    TOOLTIPTEXTW* pTTTW = (TOOLTIPTEXTW*)pNMHDR;
    TCHAR szFullText[256];
    UINT_PTR nID = pNMHDR->idFrom;
    BOOL bReturn FALSE;

    if (pNMHDR->code == TTN_NEEDTEXTA && (pTTTA->uFlags & TTF_IDISHWND) ||
        pNMHDR->code == TTN_NEEDTEXTW && (pTTTW->uFlags & TTF_IDISHWND))
    {
        // idFrom is actually the HWND of the tool
        nID = ::GetDlgCtrlID((HWND)nID);
    }

    if (nID != 0) // will be zero on a separator
    {
        // don't handle the message if no string resource found
        if (AfxLoadString((UINT)nID, szFullText) != 0)
        {
#ifndef _UNICODE
            if (pNMHDR->code == TTN_NEEDTEXTA)
                strncpy_s(pTTTA->szText, _countof(pTTTA->szText), strFullText, _TRUNCATE);
            else
                _mbstowcsz(pTTTW->szText, strFullText, _countof(pTTTW->szText));
#else
            if (pNMHDR->code == TTN_NEEDTEXTA)
                _wcstombsz(pTTTA->szText, strFullText, _countof(pTTTA->szText));
            else
                wcsncpy_s(pTTTW->szText, _countof(pTTTW->szText), strFullText, _TRUNCATE);
#endif

            bReturn = TRUE;
	}
    }

    *pResult = 0;

    // bring the tooltip window above other popup windows
    ::SetWindowPos(pNMHDR->hwndFrom, HWND_TOP, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOSIZE | SWP_NOMOVE | SWP_NOOWNERZORDER);

    return bReturn;
}

Code-o-mat wrote:
...show us the assertion that fails, please.

line 896 of wincore.cpp:

ASSERT(::IsWindow(m_hWnd));

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

modified 28-Mar-12 15:01pm.

DavidCrow wrote:
line 896 of wincore.cpp:

ASSERT(::IsWindow(m_hWnd));

Well, this still doesn't tell much because i have 2 versions of wincore.cpp, the one that comes with VS2003 and the one that comes with VS2010 and neither of them has an ASSERT of any kind on line 896. Could it be that here:

DavidCrow wrote:
::SetWindowPos(pNMHDR->hwndFrom, HWND_TOP, 0, 0, 0, 0, SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE|SWP_NOOWNERZORDER);

the handle you specify isn't correct?

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> If it doesn't matter, it's antimatter.<

Code-o-mat wrote:

line 896 of wincore.cpp:

ASSERT(::IsWindow(m_hWnd));
Well, this still doesn't tell much because i have 2 versions of wincore.cpp, the one that comes with VS2003 and the one that comes with VS2010 and neither of them has an ASSERT of any kind on line 896.

What about near line 896 (I'm using VS2008)? It's in the CWnd::AssertValid() method.

Code-o-mat wrote:
Could it be that here:

DavidCrow wrote:
::SetWindowPos(pNMHDR->hwndFrom, HWND_TOP, 0, 0, 0, 0, SWP_NOACTIVATE|SWP_NOSIZE|SWP_NOMOVE|SWP_NOOWNERZORDER);
the handle you specify isn't correct?

No, because I initially did not have that statement. It was the last differing statement (from winfrm.cpp) that I added, but made no difference.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Still not enough information to say what is wrong. What's in the call stack?

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> If it doesn't matter, it's antimatter.<

Code-o-mat wrote:
What's in the call stack?

From the time I click a button to bring up the dialog until the assertion fires:

mfc90ud.dll!CWnd::AssertValid() Line 896 + 0x24 bytes C++
mfc90ud.dll!AfxAssertValidObject(const CObject * pOb=0x00837b60, const char * lpszFileName=0x60cb4838, int nLine=2433) Line 107 C++
mfc90ud.dll!CWnd::GetTopLevelParent() Line 2435 C++
mfc90ud.dll!AfxInternalPreTranslateMessage(tagMSG * pMsg=0x0073dce8) Line 241 + 0x8 bytes C++
mfc90ud.dll!CWinThread::PreTranslateMessage(tagMSG * pMsg=0x0073dce8) Line 777 + 0x9 bytes C++
mfc90ud.dll!AfxPreTranslateMessage(tagMSG * pMsg=0x0073dce8) Line 252 + 0x11 bytes C++
mfc90ud.dll!AfxInternalPumpMessage() Line 178 + 0x18 bytes C++
mfc90ud.dll!CWinThread::PumpMessage() Line 900 C++
mfc90ud.dll!AfxPumpMessage() Line 190 + 0xd bytes C++
mfc90ud.dll!CWnd::RunModalLoop(unsigned long dwFlags=4) Line 4386 + 0x5 bytes C++
mfc90ud.dll!CPropertySheet::DoModal() Line 954 + 0xc bytes C++
StafTrakrAdmin.exe!CStafTrakrAdminDialog::OnBnClickedDefault() Line 158 C++

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

I'm afraid i still can't say what is wrong, sorry, unless you are willing to share the project (or some extract of it), maybe it would help if i could look around it a bit, see variables and such.

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> If it doesn't matter, it's antimatter.<

Code-o-mat wrote:
...maybe it would help if i could look around it a bit, see variables and such.

It's extremely easy to duplicate.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

David,

It looks like this is happening within the MFC framework. Double click on this line:

DavidCrow wrote:
mfc90ud.dll!AfxInternalPreTranslateMessage(tagMSG * pMsg=0x0073dce8) Line 241 + 0x8 bytes C++

The memory address 0x0073dce8 is a MSG struct[^]. Please try to find the value of MSG.message so we know what window message is being processed by the MFC framework. Your debugger should be able to show you this. It would be nice to know what window message we are dealing with.

The debug string you posted implies that the assertion occured at:

C++

ASSERT(::IsWindow(m_hWnd));

Which means the m_hWnd member of the CWnd/CTempWnd object that is returned by GetTopLevelParent() is apparently not a valid window.

Best Wishes,
-David Delaune

Randor wrote:
Please try to find the value of MSG.message so we know what window message is being processed by the MFC framework. Your debugger should be able to show you this. It would be nice to know what window message we are dealing with.

The message is 512 (WM_MOUSEFIRST).

Randor wrote:
The debug string you posted implies that the assertion occured at:
C++
ASSERT(::IsWindow(m_hWnd));
Which means the m_hWnd member of the CWnd/CTempWnd object that is returned by GetTopLevelParent() is apparently not a valid window.

It's as though a second tooltip window is being requested (i.e., a tooltip for a tooltip?) before the first one is completely destroyed.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Hey David,

DavidCrow wrote:
The message is 512 (WM_MOUSEFIRST).

Well the WM_MOUSEFIRST definition is not a window message it was defined to make it easier to find the range of mouse message with WM_MOUSEFIRST/WM_MOUSELAST. However WM_MOUSEFIRST is equal to WM_MOUSEMOVE. It is actually the WM_MOUSEMOVE message being processed.

DavidCrow wrote:
It's as though a second tooltip window is being requested (i.e., a tooltip for a
tooltip?) before the first one is completely destroyed.

My guess:
I would guess that it might have something to do with the way your creating or passing the CWnd that owns the tooltip. The MFC framework probably expects the handle to the owner CWnd to be in the permanent handle map. I suspect that what is happening... is that a CTempWnd object owns the tooltip... and the MFC framework is deleting the temporary CTempWnd object. When you move your mouse over the tooltip the memory address at m_hWnd may be invalid because the CTempWnd was deleted. This is the only thing I can think of that would cause what you decribe.

Are you using the GetDlgItem function anywhere? Because when GetDlgItem cannot find a permanent object in the MFC CHandleMap it will return a pointer to a temporary CTempWnd object. You should never pass the HWND returned from GetDlgItem to other functions...

Could you tell me more about the window that owns the tooltip?

Also... please call CWnd::FromHandlePermanent()[^] to check if the tooltips owner CWnd is in the MFC permanent handle map. If it returns NULL then this is most likely your problem and we can fix it.

Best Wishes,
-David Delaune

The only thing I did was copy the code in CFrameWnd::OnToolTipText() to my dialog, and then call EnableToolTips(TRUE) from within OnInitDialog().

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

I'm using the method described in the MSDN article Handling TTN_NEEDTEXT Notification for Tool Tips[^] and never had problems. However, this requires that every control has its tool tip text in a string resource with the same ID as the control.

Jochen Arndt wrote:
I'm using the method described in the MSDN article Handling TTN_NEEDTEXT Notification for Tool Tips[^] and never had problems.

With VS2008?

Jochen Arndt wrote:
However, this requires that every control has its tool tip text in a string resource with the same ID as the control.

Yes, that part was assumed.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

With VS 2003. I supplied the link for 2005. But you may selcet other versions on top of the page. Providing the text by a buffer or by ID should make no difference. But all the MSDN examples did not call SetWindowPos().

Jochen Arndt wrote:
With VS 2003. I supplied the link for 2005. But you may selcet other versions on top of the page.

I realize that. The point I was trying to make is that MFC may have changed from one version to the next. This same code I've been using worked fine in VS6.

Jochen Arndt wrote:
But all the MSDN examples did not call SetWindowPos().

See my reply here.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Sorry, the thread is quite long.

But there is another difference between your code and the MSDN examples:

You are always returning TRUE indicating that the message has been handled. The examples (and my code) only return TRUE when the TTF_IDISHWND flag is set and the control's ID can be determined from the HWND.

DavidCrow wrote:
The only thing I did was copy the code in
CFrameWnd::OnToolTipText() to my dialog, and then call
EnableToolTips(TRUE) from within OnInitDialog().

The tooltip related code you pasted is perfectly fine. You never answered any of my questions about the window hierarchy so I have to make further guesses. I am guessing that the tooltip being shown is for a dynamically created window. There is probably no member variable associated with the window. Read my previous statements regarding CTempWnd objects.

Best Wishes,
-David Delaune

Randor wrote:
You never answered any of my questions about the window hierarchy so I have to make further guesses.

I guess I don't understand. Other than calling EnableToolTips(), adding to the message map, and providing a notification handler, I don't do anything regarding creating temp windows, adding to maps, or calling GetDlgItem().

Randor wrote:
There is probably no member variable associated with the window.

Actually there is. That's what I use to set/get values from the controls.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Hi David,

Could you answer each of these questions?

1.) Are you saying that the assertion occurs when the mouse moves over ALL tooltips belonging to child windows of the dialog? Or does the assertion occur for only one of them.

2.) If it is just 1 window that causes tooltip asserts... Does the assertion occur on a window that is dynamically created such as the CListCtrl you were working on last week[^]?

I apologize for all the questions... but if you would have been very detailed in your initial description we could have avoided the guessing. Considering that you have been a member here for nearly a decade I would expect your questions to be a long narrative. Maybe even with diagrams, debugger stack frames and sprinkled with source snippets. Big Grin | :-D

Thanks,
-David Delaune

Randor wrote:
1.) Are you saying that the assertion occurs when the mouse moves over ALL tooltips belonging to child windows of the dialog? Or does the assertion occur for only one of them.

All tooltips. Do you have VS2008 on your end?

Randor wrote:
2.) If it is just 1 window that causes tooltip asserts... Does the assertion occur on a window that is dynamically created such as the CListCtrl you were working on last week[^]?

Same project Wink | ;)

, but this particular dialog has only controls created at design time.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

David,

DavidCrow wrote:
All tooltips.

That changes everything. It implies that CWnd::FilterToolTipMessage[^] is not being called to handle the tooltip messages... (This is why you should be very detailed in the initial question)

Do you have a WindowProc function? It is possible to call FilterToolTipMessage from there... but we should find out why the framework is not filtering tooltip messages. I assume that you called EnableToolTips. Is this an ActiveX control?

DavidCrow wrote:
Do you have VS2008 on your end?

Absolutely. I have VC6, 2005,2008,2010 installed on my workstation.

Randor wrote:
Do you have a WindowProc function?

No.

Randor wrote:
I assume that you called EnableToolTips.

Yes, otherwise the tooltip would not be displayed at all.

Randor wrote:
Is this an ActiveX control?

No, just a plain ol' dialog box with an edit control.

Randor wrote:
Absolutely. I have VC6, 2005,2008,2010 installed on my workstation.

Can you reproduce this?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

Hi David,

DavidCrow wrote:
Can you reproduce this?

No, the tooltip code you posted looks perfect and there is absolutely nothing wrong with it.

There is something fundamentaly wrong... but I have to keep guessing because I cannot see your project and debugger output. At this point the only other thing I can think of would be an invalid AFX_MODULE_STATE. Are you mixing static linked MFC based libraries with dynamic?

Best Wishes,
-David Delaune

Randor wrote:
Are you mixing static linked MFC based libraries with dynamic?

Linking with MFC libraries dynamically.

When I get back to the office on Friday, I can zip the project up and email it to you if you'd like.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

David,

DavidCrow wrote:
When I get back to the office on Friday, I can zip the project up and email it to you if you'd like.

That would probably be the best way to avoid a half dozen more questions. Smile | :)

As you probably already know... you can click 'Email' at the bottom of this post and I will recieve the message.

Best Wishes,
-David Delaune