Re: OnTimer function is killed automatically when the dialog is closed - C / C++ / MFC Discussion Boards

KASR124-Feb-12 0:06

24-Feb-12 0:06

I am getting follwoing error when compiling in VS2010. The same code compiles in VC6. Any help on this?

error C2535: 'bool std::binder2nd<_Fn2>::operator ()(const long &) const' : member function already defined or declared
d:\program files\microsoft visual studio 10.0\vc\include\xfunctional    341 TestVect

In Test.h file:

C++

struct VerifyAddressAtAllSlots:
public binary_function<const long, const long, bool>
{
    VerifyAddressAtAllSlots()
    {
    }
    const bool
    operator()(const long& thisAddress,
               const long&  thatAddress) const
    {
        return true;
    }
};

In Test.cpp file:

C++

std::vector<long> addrList;

long verifyAddress = 0;

for_each(addrList.begin(), addrList.end(), bind2nd(VerifyAddressAtAllSlots(), verifyAddress));

Re: How to fix compile error error C2535

Code-o-mat24-Feb-12 22:50

Code-o-mat

24-Feb-12 22:50

Try making the operator inline:

inline const bool
operator()(const long& thisAddress,
           const long&  thatAddress) const
{
    return true;
}

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> If it doesn't matter, it's antimatter.<

How to create toolbar on the dialog.

appollosputnik23-Feb-12 23:11

appollosputnik

23-Feb-12 23:11

I have created a toolbar in mfc. I want to add this toolbar on my dialog. So in the dialog's OnInitDialog() function I am trying to create this toolbar. But the toolbar is not coming. Please tell me how can create it.

[code]
BOOL CDlgsViewDlg::OnInitDialog()
{
CDialog::OnInitDialog();
CToolBar toolBar;
CRect rcClientOld; // Old Client Rect
CRect rcClientNew; // New Client Rect with Tollbar Added
GetClientRect(rcClientOld); // Retrive the Old Client WindowSize
toolBar.Create(this);
toolBar.LoadToolBar(IDR_MAINFRAME);
RepositionBars(AFX_IDW_CONTROLBAR_FIRST, AFX_IDW_CONTROLBAR_LAST,0,reposQuery,rcClientNew);
return TRUE; // return TRUE unless you set the focus to a control
}
[/code]

Re: How to create toolbar on the dialog.

_AnsHUMAN_ 24-Feb-12 1:24

_AnsHUMAN_

24-Feb-12 1:24

See here[^]

You talk about Being HUMAN. I have it in my name
AnsHUMAN

Re: How to create toolbar on the dialog.

David Crow24-Feb-12 3:15

David Crow

24-Feb-12 3:15

sujandasmahapatra wrote:
CToolBar toolBar;

Shouldn't this be a member variable?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

OnTimer function is killed automatically when the dialog is closed

shanmugarajaa23-Feb-12 21:50

shanmugarajaa

23-Feb-12 21:50

Hi friends,
When i close the dialog that time OnTimer function is automaticaly killed. I dont know what is the reason behind this. For your information this dialog is added in the PropertySheet. Normally, if dialog is closed also the onTimer function keep run.. But i my case OnTimer function is get killed.

Dialog contain CaptureOn and CaptureOff button. when captureOn button is pressed that time SetTime function get invoked and CapStopWatch function is called, to calculate and display time(like stopwatch) and when i press the CaptureOff button then timer get killed.

If i press CaptureOn button and close the dialog that time OnTimer function automatically get killed. When same dialog invoked after, OnTimer called automatically, and its operate every slower(more than 1000 to 2000) but Initially i called set timer function with 100millisecond and i given code for your reference.

void CReplay::OnCaptureOn() 
{
   CapWatchID = SetTimer(CAP_STOPWATCH, 100, TIMERPROC);
}
void CReplay::OnTimer(UINT nIDEvent) 
{ 
  if(CapWatchID)
  {
     CapStopWatch();
   }
}
 
void CReplay::CapStopWatch()
{
    CString sTime;
    static clock_t tThisTime;
    static int TempSec=0;
    static int idelay=0;
 
    tThisTime = clock();
 
   dMin1++;
 
  if(dMin1 == 10) 
  {
     double TimeDiff = (double) ( tThisTime - tSimTime ) / CLOCKS_PER_SEC;
     TempSec = (int)TimeDiff;
 
    if( TempSec >= 60 )
    {
         niSec++;
         tSimTime = clock();
    }
    else
        niSec++;
 
    if( niSec >= 60 )
    {
        nMin++;
        niSec -= 60;
    }
    if( nMin >= 60 )
   {
        nHr++;
        nTotHr++;
        nMin -= 60;
        tSimTime = clock();
   }
 
     sTime.Format("%02d:%02d:%02d",nHr,nMin,niSec);
     iHrEnd = iCurHr= nHr;
     iMinEnd = iCurMin= nMin;
     iSecEnd = iCurSec = niSec;
 
     if(CaptureRunning == 1)
     {
        m_CaptureSW.SetFont(&StopWatchFont);
         m_CaptureSW.SetWindowText(sTime);
     }
    else if(ReplayRunning =1)
    {
        m_Elapsed.SetFont(&StopWatchFont);
        m_Elapsed.SetWindowText(sTime);
    }
  }
    if(nHr==12)
      nHr=0;
  }
 
   if(dMin1 >= 10)
    dMin1 =0; 
}

Kindly help me friends...

Regards
S.Shanmugaraja.

Re: OnTimer function is killed automatically when the dialog is closed

Jochen Arndt23-Feb-12 22:21

Jochen Arndt

23-Feb-12 22:21

A timer should be killed when the window that calls SetTimer() is closed / destroyed. If you need a timer that is also running when specific dialogs are not active, you should use it from within other windows like your main frame window.

Re: OnTimer function is killed automatically when the dialog is closed

Richard MacCutchan23-Feb-12 22:24

Richard MacCutchan

23-Feb-12 22:24

Without seeing some of your code it is impossible to guess what may be happening. Where is your timer created and where is it destroyed?

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa23-Feb-12 23:28

shanmugarajaa

23-Feb-12 23:28

Dialog contain CaptureOn and CaptureOff button. when captureOn button is pressed that time SetTime function get invoked and CapStopWatch function is called, to calculate and display time(like stopwatch) and when i press the CaptureOff button then timer get killed.

If i press CaptureOn button and close the dialog that time OnTimer function automatically get killed. When same dialog invoked after, OnTimer called automatically, and its operate every slower(more than 1000 to 2000) but Initially i called set timer function with 100millisecond and i given code for your reference.

void CReplay::OnCaptureOn()
{
CapWatchID = SetTimer(CAP_STOPWATCH, 100, TIMERPROC);
}
void CReplay::OnTimer(UINT nIDEvent)
{
if(CapWatchID)
{
CapStopWatch();
}
}

void CReplay::CapStopWatch()
{
CString sTime;
static clock_t tThisTime;
static int TempSec=0;
static int idelay=0;

tThisTime = clock();

dMin1++;

if(dMin1 == 10)
{
double TimeDiff = (double) ( tThisTime - tSimTime ) / CLOCKS_PER_SEC;
TempSec = (int)TimeDiff;

if( TempSec >= 60 )
{
niSec++;
tSimTime = clock();
}
else
niSec++;

if( niSec >= 60 )
{
nMin++;
niSec -= 60;
}
if( nMin >= 60 )
{
nHr++;
nTotHr++;
nMin -= 60;
tSimTime = clock();
}

sTime.Format("%02d:%02d:%02d",nHr,nMin,niSec);
iHrEnd = iCurHr= nHr;
iMinEnd = iCurMin= nMin;
iSecEnd = iCurSec = niSec;

if(CaptureRunning == 1)
{
m_CaptureSW.SetFont(&StopWatchFont);
m_CaptureSW.SetWindowText(sTime);

}
else if(ReplayRunning =1)
{
m_Elapsed.SetFont(&StopWatchFont);
m_Elapsed.SetWindowText(sTime);
}
}
if(nHr==12)
nHr=0;
}

if(dMin1 >= 10)
dMin1 =0;
}

Re: OnTimer function is killed automatically when the dialog is closed

Richard MacCutchan23-Feb-12 23:40

Richard MacCutchan

23-Feb-12 23:40

Please edit your previous message and put <pre> tags around your code; as it stands it's very difficult to understand.

Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht23-Feb-12 22:29

bjorn_ht

23-Feb-12 22:29

I assume you talk about MFC and CWnd::OnTimer()? If so, what you describe is how I would expect it to work.

That function and CWnd::SetTimer is a thin layer on the Win API ::SetTimer function and WM_TIMER message, where ::SetTimer is called with CWnd::m_hWnd as first arg.

If you want the timer to continue after the window is destroyed, why don't you just call ::SetTimer directly with a NULL hWnd and a TIMERPROC? That way your timer will run as long as the thread runs or until you destroy it with a call to ::KilllTimer.

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa23-Feb-12 23:37

shanmugarajaa

23-Feb-12 23:37

Hi,
how to create "TIMERPROC".. Right now my application is developed using MCF. can you provide me any example code that may help me to resolve my problem.

Regrads,
S.Shanmugaraja

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht24-Feb-12 1:22

bjorn_ht

24-Feb-12 1:22

Create a console app and put this code in to see how it works, then you can adapt "myOnTimer" and the call to ::SetTimer to your code.

C++

#include <windows.h>
#include <iostream>

void CALLBACK myOnTimer(HWND hwnd, UINT uMsg, UINT_PTR idEvent, DWORD tickCount)
{
  std::cout << "Timer. id = " << idEvent << ", tick = " << tickCount << std::endl;
}

int main(int argc, char * argv[])
{
  MSG msg;

  UINT_PTR timerId = ::SetTimer(0, 42, 1000, myOnTimer);

  std::cout << "Timer set, id = " << timerId << std::endl;

  // This is done by MFC in your application but needed for the example.
  while(GetMessage(&msg, 0, 0, 0))
  {
    TranslateMessage(&msg);
    DispatchMessage(&msg);
  }
  return 0;
}

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa24-Feb-12 1:53

shanmugarajaa

24-Feb-12 1:53

But I am get error when i try to implement UINT_PTR timerId = ::SetTimer(0, 42, 1000, myOnTimer);
in MFC VS6

ErrorReport:

'SetTimer' : cannot convert parameter 4 from 'void (struct HWND__ *,unsigned int,unsigned long,unsigned long)' to 'void (__stdcall *)(struct HWND__ *,unsigned int,unsigned int,unsigned long)'

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht24-Feb-12 3:18

bjorn_ht

24-Feb-12 3:18

I wrote that example for VS 2008, looks like the callback signature has changed a little since VS6. Try to change it to

C++

void __stdcall myOnTimer(HWND hwnd, unsigned int uMsg, unsigned int idEvent, DWORD tickCount)
{
  // ...
}

as the error message suggests. If you have an MSDN library with your VS then you should be able to find the correct callback function signature there. Maybe even an example.

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa24-Feb-12 19:49

shanmugarajaa

24-Feb-12 19:49

Thanks you so much.

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa26-Feb-12 20:16

shanmugarajaa

26-Feb-12 20:16

Hi code working good.. but I cant able to kill this timer... can you help to kill this call..

Regards,
S.Shanmugaraja

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht26-Feb-12 22:31

bjorn_ht

26-Feb-12 22:31

You just call ::KillTimer(0, timerId); where timerId is the timer id value you got back from ::SetTimer.

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa27-Feb-12 0:38

shanmugarajaa

27-Feb-12 0:38

Thanks Thanks so much Smile | :)

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa27-Feb-12 17:49

shanmugarajaa

27-Feb-12 17:49

Hi,
I am beginner to MFC application. I need your suggestion to improve my skill in MFC. How you come know about __stdcall and other functionality of MFC. Any material you have been using? kindly share your views and ideas. It may help me to improve my MFC skills. I am looking forward your valuable suggestion.

Regards,
S.Shanmugaraja

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht28-Feb-12 21:38

bjorn_ht

28-Feb-12 21:38

This is not MFC as such. SetTimer and KillTimer Windows system functions documented by Microsoft.

http://msdn.microsoft.com/library/default.aspx[^]

There are many good books and online resources on the subject of C++ programming, Windows system programming and MFC. I suggest you try searching the net for recommendations and book reviews.

Re: OnTimer function is killed automatically when the dialog is closed

shanmugarajaa28-Feb-12 2:41

shanmugarajaa

28-Feb-12 2:41

Hi,
I am Calling CapWatchID: = ::SetTimer(SetTimer(0, 42, 1000, CaptureStopWatchT); and after sometime I killed this running timer using ::KillTimer(0, CapWatchID);. But the problem is, when I start the same timer again then Updation time became lessthan 1000 millisecond. Why its happing like this. kindly help me to fix this problem.

Regards,
S.Shanmugaraja.

Re: OnTimer function is killed automatically when the dialog is closed

bjorn_ht28-Feb-12 21:46

bjorn_ht

28-Feb-12 21:46

I have not observed similar behavior so I'm afraid I can't help with that.

Also please note that the number 42 as second parameter to SetTimer in my example was chosen randomly. Probably, it would be more correct in your context to use the value 0.

Re: OnTimer function is killed automatically when the dialog is closed

David Crow24-Feb-12 3:18

David Crow

24-Feb-12 3:18

shanmugarajaa wrote:
how to create "TIMERPROC"..

It's in the docs: http://msdn.microsoft.com/en-us/library/windows/desktop/ms644901(v=vs.85).aspx#creating_timer[^]

Leap year algorithm

marca29223-Feb-12 20:52

marca292

23-Feb-12 20:52

Hi,
I want to have a fast algorithm to determine if it’s leap year, is this a good one?

C++

bool isLeapYear(int year)
{
    bool leapYear = year%4 == 0 && (year %100 != 0 || year%400 == 0;
    return leapYear;
}

Thanks!

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.