|
This is pure genius, if he gets paid by the line that is.
If this method is ran while the battery is charging, is there a chance that it would return "NA" because the battery percentage changed at the correct moment? 
Giraffes are not real.
|
|
|
|
|
Wow!
This is only not worse than what I've seen, because the DB field length related to what I found is small:
public string GetStringToDatabase(int value)
{
if (value > 99999999)
return "0" + value.ToString();
else if (value > 9999999)
return "00" + value.ToString();
else if (value > 999999)
return "000" + value.ToString();
.
.
.
}
"To alcohol! The cause of, and solution to, all of life's problems" - Homer Simpson
|
|
|
|
|
I did something like this when I was programming in assembly language back in college. I was making a way to get a value out of a register out to the terminal in an integer form. Then, we only had 16 bit registers and could only output -32738 to 32737. But, there was no library routines to output to the terminal.
|
|
|
|
|
Well, although in assembly one can develop a routine for that, it's forgivable if you don't, specially in college while learning.
What's unforgivable is having this in a high level language in production code for a mission critical application.
"To alcohol! The cause of, and solution to, all of life's problems" - Homer Simpson
|
|
|
|
|
Maybe they got paid by the line
|
|
|
|
|
Should be an philosopher, not a programmer. This is pure, unadulterated logic.
|
|
|
|
|
I am wondering if the statement continues to reach 0%. To return a result, the program will have to add a power source somewhere.
TOMZ_KV
|
|
|
|
|
Could have made a better case for switch/case statements. And if the device needed display "NA" it probably wouldn't have been running anyway.
I'm not a programmer but I play one at the office
|
|
|
|
|
I like the ToString...
If SystemInformation.PowerStatus.BatteryLifePercent = 1.00f then ...
is such a PITA
Paulo Gomes
Over and Out 
|
|
|
|
|
What a shortcut! A qualified programmer would have accounted for the fact that BatteryLifePercent is floating point, and may not be in increments of 1/100th. What if it's 0.975? Obviously this should have been written as:
If SystemInformation.PowerStatus.BatteryLifePercent <= 1 And
SystemInformation.PowerStatus.BatteryLifePercent > 0.99 then Return "99%"
ElseIf SystemInformation.PowerStatus.BatteryLifePercent <= 0.99 And
SystemInformation.PowerStatus.BatteryLifePercent > 0.98 then Return "98%"
...
|
|
|
|
|
They are clearly just coding around a bad framework. There's a field called BatteryLifePercent, but it's not actually a percentage number. Obviously the framework is incorrect.
|
|
|
|
|
Option Strict is off or the Property would have an As clause!
Correct would've been:
Public ReadOnly Property BatteryPercent As Percent
Get
If SystemInformation.PowerStatus.BatteryLifePercent.ToString = "1" Then
Return Convert.ToPercentage("100%")
Now that just made a world of difference
It's an OO world.
public class Naerling : Lazy<Person>{
public void DoWork(){ throw new NotImplementedException(); }
}
|
|
|
|
|
Could be wrong but it looks like a case of lack of knowledge, not knwoing/understanding that there is a better/more effecoent way to achieve teh same goal.
I work in RDBMS (sepcifcally SQL Server) and I routinely see this same kind of bad design choice and usually its due to a lack of knowledge/eductaion on the product/system. For example when the develoepr needs to store a bolean value ( 0 and <>0 ) they use a NUMERIC data type which [by default) uses 9 bytes instead of using the smaller BIT data type.
|
|
|
|
|
That's horrible. Everyone knows that you should use a varchar and store it as 'True' or 'False'.
|
|
|
|
|
This is why degrees are useful. You may not be the best programmer in the world after graduating, but at least you should learn enough to avoid code like this. Having a get-r-done attitude is fine and all, but a get-r-done intelligently attitude is much better.
Somebody in an online forum wrote: INTJs never really joke. They make a point. The joke is just a gift wrapper.
|
|
|
|
|
You were joking right?
I saw graduates that couldn't tell a variable from an array from a class from an object (etc...).
Oh, and they weren't like barely getting their grades, in fact, they were top of the class (due to compensating programming with communication or economics, plus getting their projects done by others).
'As programmers go, I'm fairly social. Which still means I'm a borderline sociopath by normal standards.' Jeff Atwood
'I'm French! Why do you think I've got this outrrrrageous accent?' Monty Python and the Holy Grail
|
|
|
|
|
Nope, not joking. Not everybody who goes through college is a better programmer than a non-college programmer. Though I'd say more college grads have better sense. Of course, that's from my anecdotal experience*, so YMMV.
*For example, I wrote my 558 Lines of QuickBasic Glory before I went to college. Relying on file IO, "unnecessary" optimizations, and third party libraries seemed like too much work at the time.
Somebody in an online forum wrote: INTJs never really joke. They make a point. The joke is just a gift wrapper.
|
|
|
|
|
I guess if you take a statistical sample of graduates vs non-graduates, the average is better, and the deviation lower.
I was worried that you'd equate degree with competence 
'As programmers go, I'm fairly social. Which still means I'm a borderline sociopath by normal standards.' Jeff Atwood
'I'm French! Why do you think I've got this outrrrrageous accent?' Monty Python and the Holy Grail
|
|
|
|
|
Although, I know doesn't look all that good. There may be come consideration to optimization. Does the huge case statement cost less than a few function calls? Just a thought, and like to play devils advocate.
|
|
|
|
|
That is a joke right? Does this joke include enough to go all the way to 0%?
|
|
|
|
|
Well, I can see he has time to do code )))))))))
|
|
|
|
|
Quote: ' This code will retrieve the BatteryLifePercent property and convert it to a percent.
Really?
Why would someone convert something to percent which is already in percent?
|
|
|
|
|
Its just as well we have a logic object here, as the programmer's grasp obviously leaves something to be desired.
If logic.doLogic(sender, "Update") Then
flushMessages(sender.Page)
Else
flushMessages(sender.Page)
Exit Sub
End If
I should qualify, (before someone points it out) that this is at the end of the containing method, so the Exit Sub was redundant)
|
|
|
|
|
Pehaps the original coder thought
If not logic.doLogic(sender, "Update") Then
Exit Sub
End If
would mean his code is not logical, because of the Not logic statement 
|
|
|
|
|
Not the first horror of this type. I think that VB .NET programmers miss a RegardlessOf keyword. Usage:
RegardlessOf boolean-expression
a code block which is always executed
End RegardlessOf
Greetings - Jacek
modified 18-Dec-11 9:34am.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
