|
Hi,
1.
in general there are many ways to organize things, many bad ways, some good ones, maybe one or several excellent ones. In this instance, your fundamental question is: should there be a Queen class, and if so what would be its role? To solve that question, think about it both ways.
With a full-fledged Queen class, each Queen instance would represent one chess piece, it would know where it is, paint itself, but having 8 Queen instances would not directly help at solving the problem, as they need to know each other's position in order to solve the problem, i.e. the problem is not at the level of the individual Queen.
Without a Queen class, the Board would need to know there are 8 queens, with their positions. It would have to figure out a set of positions that satisfies the requirements, then paint the 32 white and 32 black squares and the 8 queens.
Thirdly, one could opt for a way in the middle; a limited Queen class could take care of painting the symbol, and maybe help in deciding which squares are attacked by it.
And finally, one could even create a Square class, where a board is just a collection of 64 instances of Square, each square knowing where it is and painting itself (and not doing anything else, as board squares are really stupid).
Now it is up to you to choose. All these approaches are valid, one could be simpler than another, and one could be more academic.
2.
Member 8466234 wrote: I ... get confused when trying to type the code in.
That is indicative of a lack of "design". You should sit down and think about your approach before you start typing anything. Come up with an architecture, don't try and put bricks one on top of another until you happen to have the house you wanted to build. Make a plan first.
3.
On coding style: you have chosen not to have a Square class, which is fine as painting the 64 cells at once isn't hard at all. You did surprise me a lot by having that as a BackgroundPaint though. If the class is Board, then painting itself is a regular Paint IMO, not a background. But it is still OK.
Yhe names you have chosen for identifiers are really confusing; your paint is a Brush, why not call it brush then? your color is the entire Graphics object, so it is NOT a color. If you have a cat, would you call it "Dog"?
Finally your isBlack manipulations seem correct, however I would do it slightly different, probably like so:
graphics.FillRectangle((i+j)%2==0?Brushes.Black:Brushes.Gray), new Rectangle(...));
that would not need a separate variable, but more importantly it would not rely on sequential painting of the cells, each cell now calculates its color on its own, i.e. less error prone without significantly adding to the calculation cost.
4.
You're not the first one to attempt the 8 queens problem. The internet holds hundreds of attempts. There are some articles on the subject here at CodeProject. Did you look at any of them? Are you familiar with the CodeProject search facilities? Did you consider asking Google? You would get a number examples (of different quality levels) that could guide and insipre you.
|
|
|
|
|
The reason I went graphic first is because I already had a algorithm code. The problem with the algorithm is that it runs perfectly on console but i do not know how to make it run on windows form. Here is what I have:
It is changed up because I tried to make it a form
using System;
using System.Collections.Generic;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Windows.Forms;
namespace ConsoleApplication7
{
class Program
{
public enum Square
{
size = 8
}
public class EightQueen
{
public static int count = 0;
public static bool isValidMove(int[,] Array, int row, int col)
{
for (int i = 0; i < Square.size.GetHashCode(); i++)
if (Array[row, i] == 1)
return false;
for (int i = 0; i < Square.size.GetHashCode(); i++)
if (Array[i, col] == 1)
return false;
int tempCol = col + 1, tempRow = row;
for (int i = row + 1; i < Square.size.GetHashCode(); i++)
{
if (tempCol < Square.size.GetHashCode())
{
if (Array[i, tempCol] == 1)
return false;
else
tempCol++;
}
else
break;
}
tempCol = col - 1;
for (int i = row - 1; i >= 0; i--)
{
if (tempCol >= 0)
{
if (Array[i, tempCol] == 1)
return false;
else
tempCol--;
}
else
break;
}
tempCol = col - 1;
for (int i = row + 1; i < Square.size.GetHashCode(); i++)
{
if (tempCol >= 0)
{
if (Array[i, tempCol] == 1)
return false;
else
tempCol--;
}
else
break;
}
tempCol = col + 1;
for (int i = row - 1; i >= 0; i--)
{
if (tempCol < Square.size.GetHashCode())
{
if (Array[i, tempCol] == 1)
return false;
else
tempCol++;
}
else
break;
}
return true;
}
public static void DisplayChessBoard(int[,] boardArr)
{
int count = 0;
for (int i = 0; i < Square.size.GetHashCode(); i++)
for (int j = 0; j < Square.size.GetHashCode(); j++)
if (boardArr[i, j] == 1)
count++;
if (count >= 8)
ShowBoard(boardArr);
}
public static void ShowBoard(int[,] boardArray)
{
for (int i = 0; i < Square.size.GetHashCode(); i++)
{
for (int j = 0; j < Square.size.GetHashCode(); j++)
Console.Write("{0} ", boardArray[i, j]);
Console.WriteLine();
}
count++;
Console.WriteLine();
}
public static void Chessboard(int[,] boardArr, int row, int col)
{
for (int i = row; i < Square.size.GetHashCode(); i++)
{
for (int j = 0; j < Square.size.GetHashCode(); j++)
{
if (isValidMove(boardArr, i, j))
{
boardArr[i, j] = 1;
DisplayChessBoard(boardArr);
Chessboard(boardArr, i + 1, j + 1);
boardArr[i, j] = 0;
}
}
}
}
static void Main()
{
Application.EnableVisualStyles();
int[,] boardArr = new int[Square.size.GetHashCode(), Square.size.GetHashCode()];
for (int i = 0; i < Square.size.GetHashCode(); i++)
for (int j = 0; j < Square.size.GetHashCode(); j++)
boardArr[i, j] = 0;
Chessboard(boardArr, 0, 0);
Console.WriteLine("Total Solutions {0}", count);
Application.Run(new Form1());
}
}
}
}
|
|
|
|
|
Member 8466234 wrote: I already had a algorithm code
you could have said that right away.
I'm not impressed by your algorithm; there is no need to check for queens in the same row; just put one in each row to begin with. And put them all in different columns too, that reduces the problem to just the permutations of the numbers 1 thru 8. All that needs checking then is for the absence of diagonal attacks.
you did tackle it without a Queen class, why would you suddenly consider having one?
And what is with all that GetHashCode()?
Why can't you just paint some symbol where a queen is supposed to surface? use Graphics.DrawImage with some small Bitmap.
|
|
|
|
|
I seen a couple of c++ users and vb.net users using queen classes and thought I needed it. The GetHashCode() was the only code I knew how to use.
The main thing i'm just having trouble with is putting this into a form program. It seems like its a whole new concept. For example, I can imagine clicking the button and its suppose to do the calculations and pop up on the chessboard but I don't know what code goes where.
Should I throw the whole algorithm/graphics under btnClick?
Main question: How would I throw the Graphics.DrawImage in the algorithm? Sorry I been studying this since beginning of fall and didnt have a great teacher.
|
|
|
|
|
GetHashCode() makes no sense at all here, throw it away completely. Have you any idea what a hash code is? How could it be justified here?
Member 8466234 wrote: Should I throw the whole algorithm/graphics under btnClick?
No.
1. Graphics operations must go in the Paint handler. Here[^] is an article that explains how things should be done.
2. You can do calculations (but not the graphics painting!) in a Click handler, provided they're done in less than say 50 msec. If they take longer, you ought to put them in a separate thread (maybe a BackgroundWorker) otherwise your program will be non-reponsive to Windows events and that is not acceptable to the users. You are clearly not ready for threads though.
Member 8466234 wrote: I been studying this since beginning of fall
I strongly suggest you choose, buy and study an introductory book on C# programming, so you can get rid of some bad habits, and learn how to do things properly. There are lots of good books, look at ten books and choose the one or two that appeal most to you.
|
|
|
|
|
Personally, I wouldn't even think about how it's presented before I have the algorithm working.
|
|
|
|
|
Timezone parsing issue - borrowing code from here[^]
When parsing for example “4:01PM EST”, we offset the time by five hours – date string becomes “4:01PM -0500″, all good. This said, "Date" is wrong. It is 10 DEC 2011 (This is "Tomorrow") but it should really be 8 DEC 2011 - (but offset in terms of hours/minutes correct)
Note, I’m now in Hong Kong 9 DEC 2011 12pm translates to 8 DEC 2011 23:02 in NYC (i.e. HK is 13 hrs ahead of NYC).
ConvertedDate = Convert.ToDateTime(NewDateStr);
What do I need to do? Manually compensate for this by subtracting two days off?
ConvertedDate = ConvertedDate.AddDays(-2);
Thanks
dev
modified 8-Dec-11 23:25pm.
|
|
|
|
|
Check that your input conforms to the rules as laid down here[^]. You should not need to do any further modifications to your results from the parsing operation.
Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman
|
|
|
|
|
It would help if you posted exact code you are using including input strings and how you are displaying the output.
FYI - text literals for time zones are NOT unique. So if you have a specific problem then using that might work but it will not work in all cases.
|
|
|
|
|
I have a List<> of ShipSprite (a struct). I need to "sort" that list very often. But every once in a while, it Throws this Exception:
ArgumentException.Message: IComparer (or the IComparable methods it relies upon) did not return zero when Array.Sort called x. CompareTo(x). x: '' x's type: 'ShipSprite' The IComparer: 'ChangeDBLOL.ShipSpriteComparer'.
Here is the code for the IComparer.Compare method:
int IComparer<ShipSprite>.Compare(ShipSprite x, ShipSprite y)
{
if (!(x.Confirmed ^ y.Confirmed))
{
if (x.State == y.State)
{
if (x.TA == y.TA)
{
if (x.Equals(y)) {
return 0;
}
else {
int res = Utils.r.Next(2) == 0 ? 1 : -1;
return res;
}
}
else
{
return x.TA.CompareTo(y.TA);
}
}
else
{
return x.State.CompareTo(y.State);
}
}
if (x.Confirmed) return -1;
if (y.Confirmed) return 1;
return 0x1Dead;
}
Just to be clear, I use this code for testing:
List<ShipSprite> sort = new List<ShipSprite>(sprites);
int k = 0;
StringBuilder sb = new StringBuilder();
while (true)
{
sb.AppendLine((k++).ToString());
sort.Sort(new ShipSpriteComparer());
sb.AppendLine("~~~~~Result list~~~~~");
foreach (ShipSprite s in sort)
{
sb.AppendLine(s.ToString());
}
}
What bugs me is that this exception only occurs once every 25~40 sort. Do you guys have any idea of what might be the problem?
Oxfords English < Official CCC Players Dictionary
Excuse me for my improper grammar and typos.
It's because English is my primary language, not my first language.
My first languages are C# and Java.
VB, ASP, JS, PHP and SQL are my second language.
Indonesian came as my third language.
My fourth language? I'm still creating it, I'll let you know when it's done! 
modified 8-Dec-11 22:14pm.
|
|
|
|
|
|
Well,This List is used in Genetic algorithm, so I need to "sort" it very often. Here's the rule for sort:
1. Confirmed ShipSprite goes first
2. Sort according ShipStates
3. If above return 0, sort based on TA
4. If above return 0, check if it's the same ShipSprite and return 0 if it's same (so that we don't get that error)
4b. Random any ShipSprite that doesn't fulfill above conditions.
Oxfords English < Official CCC Players Dictionary
Excuse me for my improper grammar and typos.
It's because English is my primary language, not my first language.
My first languages are C# and Java.
VB, ASP, JS, PHP and SQL are my second language.
Indonesian came as my third language.
My fourth language? I'm still creating it, I'll let you know when it's done!
|
|
|
|
|
Hi,
1.
I would write all that quite differently, see consecutive diff calculations under "composite sort criteria" in my article here[^].
2.
I don't like your random stuff a bit, and I guess neither does the sorting algorithm. It really wants IComparer(x,y) to be trustworthy, i.e. to ALWAYS return the same result. If you need some randomness, I think you should somehow store the result of the RNG and make sure you return consistent values (otherwise X<Y and Y<Z might not imply X<Z, which would upset most everyone).
[EDIT] The right thing to do for randomness would be like this: give your "objects" one more field, which you fill with random integer numbers beforehand; then use that field as the last sort criterion. [/EDIT]
[ADDED] FWIW: If I were to need data sorted, the first thing I'd do is make them real objects (i.e. reference type), not structs. It would avoid all boxing/unboxing pitfalls and costs, and it most likely would sort faster as now only the pointers need being swapped, not the entire object values. [/ADDED]
|
|
|
|
|
What confuses me is that the previous version works fine even with this "random sort" 
Yeah, I'll try to add a field and fill it with random value before sort. Also, that struct is a gift from previous developer. 
Oxfords English < Official CCC Players Dictionary
Excuse me for my improper grammar and typos.
It's because English is my primary language, not my first language.
My first languages are C# and Java.
VB, ASP, JS, PHP and SQL are my second language.
Indonesian came as my third language.
My fourth language? I'm still creating it, I'll let you know when it's done!
|
|
|
|
|
A sort algorithm should always return consistent results, i.e. don't do the random thing. If two items are sort-order-equivalent, the comparison should return 0.
Why are you doing that weird XOR check when it seems to be equivalent to [ if(x.Confirmed == y.Confirmed) ]? Not that I think that's responsible for the problem but it is needlessly confusing.
What types are TA and State, and do they have comparators (or equality operator overrides) which could mess things up?
Did you override Equals on ShipSprite, and if so did you do it correctly?
As an aside, why is this a struct? It looks complex enough that it should be a class. Sorting a list of structs requires moving around and copying a lot more bits of memory.
|
|
|
|
|
Well, TA is a DateTime and State is an int, so they shouldn't mess things up. I have also checked Equals on ShipSprite and it seems fine. I will do as Luc's suggestion, create a new field and fill it with random value before sorting.
That XOR and struct is results of fluctuate requirement and management's motto "Previous developer did it fine this way, don't change it!"
Oxfords English < Official CCC Players Dictionary
Excuse me for my improper grammar and typos.
It's because English is my primary language, not my first language.
My first languages are C# and Java.
VB, ASP, JS, PHP and SQL are my second language.
Indonesian came as my third language.
My fourth language? I'm still creating it, I'll let you know when it's done!
|
|
|
|
|
Hi all,
I'm porting a C# 2 application from Visual Studio 2005 to 2010 .Net 4, and getting a baffling error:
"Error 1 'Could not load file or assembly 'Aurigma.GraphicsMill' or one of its dependencies. Could not find or load a specific file. (Exception from HRESULT: 0x80131621)' C:\Alan\Label Designer\64-bit\Source\LabelDesigner\LC LabelDesigner"
It's complaining about not being able to load Aurigma.GraphicsMill but the damn DLL is there! It's maddening. The same files run perfectly under VS 2005. It also mentions an "LC" file, but no file has anything like that name anywhere under this project folder, or the original which compiles.
I tried deleting the GraphicsMill reference and re-adding it, but got the same results.
Wasted hours on this; I'm calling it a day.
Can anyone make any suggestions of what to try next?
modified 12-Dec-11 11:24am.
|
|
|
|
|
I noticed the 64-bit in your path above. Could it be that you are creating a 64-bit app and this dll is a) stored in the 32-bit directory or b) not available in 64-bit? Just a guess.
Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman
|
|
|
|
|
Thanks for the suggestion, but at this point it's 32-bit. (64-bit is a later goal, but the first step is just to get it working under VS 2010.)
|
|
|
|
|
I put that error code into Google and came up with this[^]; the first link looks like it may be of use - if you understand what they are saying.
Unrequited desire is character building. OriginalGriff
I'm sitting here giving you a standing ovation - Len Goodman
|
|
|
|
|
Thanks. I did the same thing! Great minds think alike. Microsoft has no workaround for this artificial "bug" they've caused. I've emailed Aurigma to see they have an updated DLL for .NET 4.
|
|
|
|
|
|
Hi,
I have a "asp:listview" bind to web service without database.
I don't use "ObjectDataSource" and in my contol "ListView" : I haven't atribut "DataKeyNames" and "DataSourceID"
I bind to it in code-behind 
protected void Page_Load(object sender, System.EventArgs e)
{
Act ActWEBService = WebServiceFactory.CreateInstance().CreateActWebService();
ActStruct[] myActs = ActWEBService.GetActs(nameIdItemDataBound);
mSeenFromPageState.Acts = new ActStruct[myActs.Length];
foreach(ActStruct act in myActs)
{
ListViewActs.DataSource = ActWEBService.GetActs(nameIdItemDataBound);
ListViewActs.DataBind();
}
protected void OurListView_ItemDataBound(object sender, ListViewItemEventArgs e)
{
if (e.Item.ItemType == ListViewItemType.DataItem)
{
System.Data.DataRowView rowView = e.Item.DataItem as System.Data.DataRowView;
ListViewDataItem dataItem = (ListViewDataItem)e.Item;
Act ActWEBService = WebServiceFactory.CreateInstance().CreateActWebService();
ActStruct[] myActs = ActWEBService.GetActs(nameIdItemDataBound);
So here is my list on screen :
nameIdItemDataBound....thatOneId............name
11BB...................................1..............................john
13AA...................................3..............................alice
15AAA..................................2..............................roxy
16TXQ..................................1..............................jean
But I want items that have [3] in their [thatOneId], does not appear in my list!
"if statement" does not use with Listview so I must put a filter...
like this : Where(a => a.name != value);
oreach(ActStruct act in myActs)
{
ListViewActs.DataSource = ActWEBService.GetActs(nameIdItemDataBound).Where(d => d.thatOneId != 3);
ListViewActs.DataBind();
}
I have a message error :
'ListView with id 'ListViewActs' must have a data source that either implements ICollection or can perform data source paging if AllowPaging is true.' (line Ligne : 82 )
Could you help me for this ? 
|
|
|
|
|
Hi all,
I seem to be having a problem with value validation of a list in a foreach loop and was wondering if you could please point out where the logic/syntactic error is?
Basically I am enumerating the Windows Application log for an eventid value then for a timewritten value. If the value is not found the code should run. If the value is found but is older than 1 hour then the code should run. If the value is found and is not 1 hour old then the code should not run. This is what I have but the code runs on my 2-minute timer anyway indicating that the value is not being found (I think)
public void OnTimedEvent(object source, ElapsedEventArgs e)
{
int run;
run = 0;
EventLog eLog = new EventLog("Application");
foreach (EventLogEntry entry in eLog.Entries)
{
if (entry.EventID == 13162)
{
List<int> evid = new List<int>();
evid.Add(entry.EventID);
foreach (int IDNo in evid)
{
if (entry.TimeWritten > DateTime.Now.AddHours(-1))
{
run = 1;
}
else run = 2;
}
}
}
if(run == 0 ||run == 1)
{
}
if (!EventLog.SourceExists("mylog")) EventLog.CreateEventSource("mylog", "Application");
EventLog.WriteEntry("mylog", "code has run", EventLogEntryType.Information, 13162);
}
This has been driving me nuts for nearly 3 days now and I just can't figure it out. I have tried evid.contains and evid.find methods but either the //do stuff won't run at all or it keeps running on the timedevent, i.e. every 2 minutes. Could you help please?
|
|
|
|
|
I would change this piece of code
foreach (EventLogEntry entry in eLog.Entries)
{
if (entry.EventID == 13162)
{
List<int> evid = new List<int>();
evid.Add(entry.EventID);
foreach (int IDNo in evid)
{
if (entry.TimeWritten > DateTime.Now.AddHours(-1))
{
run = 1;
}
else run = 2;
}
}
}
for
foreach (EventLogEntry entry in eLog.Entries)
{
if (entry.EventID == 13162)
{
if (entry.TimeWritten > DateTime.Now.AddHours(-1))
{
run = 1;
}
else run = 2;
}
}
}
Please let me know if it works.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
