|
Well, I use to resolve this kind of problem with a Ctrl+H, replacing '= True Then' by 'Then', simply.
I hate a dirty code....
Ygor Lazaro
|
|
|
|
|
Don't know about VB, but in C++ a boolean can sometimes have other values then true / false that would go through if you did something like this:
if(boolvalue){
}
but would do it correctly when doing this:
if(boolvalue == true){
}
V.
|
|
|
|
|
Agreed.
Anyway, writing
if(boolvalue == true){
}
is like saying "if boolvalue is true is true" 
|
|
|
|
|
I confess that I tend to do this, but I do have a reason.
I program in multiple languages. Not explicitly calling out an equality in a dynamic and loosely typed language like Ruby can give you unexpected results. A variable will evaluate to true if it is true or has an assigned value (even if it's an empty string). It will evaluate to false if it is false or nil.
In the interest of clarity I tend to make logical tests explicit and let the compiler take care of things. Turbo C 1.5 optimized this way back when, so I'm sure VS2010 can handle it.
There's no harm in being explicit in one's source code. It's like using "extra" parentheses. It doesn't matter to the tools, but it sure does make reading the code easier for us humans. Not to say i don't appreciate obfuscated C, it's just I do't want to have to modify it and make it work.
|
|
|
|
|
In c# I prefer
if (((boolVar == true) == true) == true) {
I find that three levels is optimum
|
|
|
|
|
Using the same technique thrice may not guarantee correct results. So you may want to try:
if (((boolVar.ToString().ToLower().Equals("true") == true) == (true == true)) {
}
"Don't confuse experts with facts" - Eric_V
|
|
|
|
|
That won't work on a German system: boolVar.ToString evaluates to "Wahr" or "Falsch". Some time ago I posted a coding horror where just that happened by implicit conversion from bool to string.
|
|
|
|
|
|
I hope this code didn't get in to production  because it doesn't work. Try
TruthChecker(false, 1)
I think this will return true 
|
|
|
|
|
I feel that it makes reading a program easier when actually seeing the True as well as it's less error prone:
MY ARGUMENT TO MY 2 POINTS:
1) VISIBLE
Using the statement:
If (myControl.Visible = True) Then
I immediatly know that Visible is a boolean.
2) LESS ERROR PRONE
What happens if Visible is actually an unsigned int which can range from 0 to 10 but the programmer forgot to program it correctly?
E.g.
HE WROTE:
If (myControl.Visible)
INSTEAD OF:
If (myControl.Visible < 10)
This type of bug would be difficult to find if you write your boolean if statements without the True, however easy if not.
"Program testing can be used to show the presence of bugs, but never to show their absence."
<< please vote!! >>
|
|
|
|
|
I've seen similar stuff many, many, many times. I believe the author is paid not only for lines of code but for columns as well.
|
|
|
|
|
I hate to say it, but I do that boolean crap in if...thens. It's the only way some people can understand the code when they read it.
|
|
|
|
|
Just found this piece of quality in our production code.
try
{
Class1.NullableInt1 = int.Parse(txtSomeUserInput.Text);
}
catch
{
Class1.NullableInt1 = null;
}
...
NB: Class, property and input names changed to protect the inocent.
And people here wonder why our web forms can take 1 minute or more to post back!
|
|
|
|
|
Sadly, the sucker never heard of the Convert class...
|
|
|
|
|
|
Seeing far too much code like that is what made me choose my signature line.
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
if (FileType = 0) then
FileSaveAs(Sender)
else begin
case FileType of
1:SaveCDL(FileName,List);
2:SaveDXF(FileName,List);
3:SaveFile(FileName,List);
end;
end;
I came across this in some code (written by someone else) that I am looking through to find the cause of a save/load error. 
The United States invariably does the right thing, after having exhausted every other alternative. -Winston Churchill
America is the only country that went from barbarism to decadence without civilization in between. -Oscar Wilde
Wow, even the French showed a little more spine than that before they got their sh*t pushed in.[^] -Colin Mullikin
|
|
|
|
|
|
Is it about
FileType=0 being an assignment instead of comparison?
Greetings - Jacek
|
|
|
|
|
no, this is the VB way of comparison
|
|
|
|
|
It seems to be Pascal, not VB. But, in Pascal = is also a comparison, AFAIR. Frankly, I don't see where the horror is.
Greetings - Jacek
|
|
|
|
|
omg yes it's PASCAL ... guess the horror is the fact, that there is no need for the outer IF, because it could be handled inside the CASE as well
|
|
|
|
|
TorstenFrings wrote: no need for the outer IF, because it could be handled inside the CASE
Yeah, that's it. Having the if instead of just case 0 seems a bit like someone wasn't actually thinking about what they were coding.
The United States invariably does the right thing, after having exhausted every other alternative. -Winston Churchill
America is the only country that went from barbarism to decadence without civilization in between. -Oscar Wilde
Wow, even the French showed a little more spine than that before they got their sh*t pushed in.[^] -Colin Mullikin
|
|
|
|
|
Jacek Gajek wrote: It seems to be Pascal, not VB.
It's Delphi. So, you were almost right.
The United States invariably does the right thing, after having exhausted every other alternative. -Winston Churchill
America is the only country that went from barbarism to decadence without civilization in between. -Oscar Wilde
Wow, even the French showed a little more spine than that before they got their sh*t pushed in.[^] -Colin Mullikin
|
|
|
|
|
Colin Mullikin wrote: It's Delphi. So, you were almost right.
He was absolutely right. Delphi is not a programming language, it's IDE just like Visual Studio. Object Pascal is used as a programming language inside. I know what I'm talking about. I had the pleasure of working with Delphi/C++ Builder. It was more than 5 years ago though. I still remember C++ Builder 6. But Borland is dead now .
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
