|
The kind of company, that relies more on titles... 
(yes|no|maybe)*
|
|
|
|
|
UserProfile selectedUser = null;
selectedUser = Sql.GetUserDetails(username.Value);
You might want to confirm that your KPI isn't based on the number of lines you write.
"You get that on the big jobs."
|
|
|
|
|
We've outsourced some of our dev work, everytime they do something we have to check it because they keep on making mistakes.....
...when testing a change one of the developers made I noticed that the expected change didn't happen.
He said to me it should work, and he's created a unit test to test the change works...
...I then looked at his unit test:
if (order.Allocations[0].TriPartyEligibilityCriteria != null)
{ Assert.IsTrue(order.Allocations[0].TriPartyEligibilityCriteria.Length > 0); }
I had to walk him through this to explain to him just why his test was bad, very bad indeed and it took me over an hour to explain why that was bad and what he should have done instead!
The amount of time we spend inspecting their code and refactoring makes this whole outsourcing exercise a joke
|
|
|
|
|
Suffering in a similar fashion though the code, itself, works most of the time. They are just so untidy.
"If you think it's expensive to hire a professional to do the job, wait until you hire an amateur." Red Adair.
nils illegitimus carborundum
me, me, me
|
|
|
|
|
Perhaps I'm missing the obvious, but why couldn't that be a valid part of a unit test?
|
|
|
|
|
You could certainly assert the length as part of the test, but the check for null is wrong - you should know if the value will be null or not and do an assertion on that (it may be valid for it to be null, for example if some other property is invalid, but this should be part of the spec).
|
|
|
|
|
I agree it should be part of the spec. There's nothing to indicate in the message or sample that it's incorrect for it to be optional element which can be null. (Only that if it isn't null then it should have a length greater than zero).
|
|
|
|
|
Me (paraphrasing): No, colleague, putting each one of a list of 24 values into its own text box is not an efficient method of data storage. How about putting them into an array, then you can reference them by number.
Colleague: I didn't know about arrays.
Me: (stunned silence)
Colleague: I use gotos to get to the code that reads data from the right text box.
Me: Modern programming recommendations are that you keep usage of gotos to a minimum because it makes determining program flow very difficult.
Colleague: Really?
Me:
|
|
|
|
|
There comes a time when some should consider alternate career paths. I believe the local Burger King is hiring.
I wasn't, now I am, then I won't be anymore.
|
|
|
|
|
He or his colleague 
(yes|no|maybe)*
|
|
|
|
|
Let's just say that somebody should goto Burger King.
|
|
|
|
|
Me, Me,,, I'm hungry
But my boss is staring this way 
|
|
|
|
|
And he shall never return... unless he got some burgers with him 
(yes|no|maybe)*
|
|
|
|
|
Ok, you convinced me. I will do that right after work.
"I just exchanged opinions with my boss. I went in with mine and came out with his." - me, 2011
---
I am endeavoring, Madam, to construct a mnemonic memory circuit using stone knives and bearskins - Mr. Spock 1935 and me 2011
|
|
|
|
|
Probably thinks he's a data visualization expert. 
"You get that on the big jobs."
|
|
|
|
|
Is the colleague actually a programmer? If so, I echo said "stunned silence".
|
|
|
|
|
So it sounds like he has effectively implemented his own array, albeit with poor choices in how to store and access the data, but I think that shows good logic. After all, he doesn't know what an array is, yet he has decided an array style function is the best approach.
He may not have the "experience" of a great developer, but being able to think for himself is a good thing. I think too many programmers are around that just do what the book says, and therefore struggle to be creative when a need arises for something that has yet to be documented.
I may or may not be responsible for my own actions
|
|
|
|
|
If the "colleague" was a high school intern who has never taken a programming class, then yes their logical abilities show promise and they could be trained. However, if this is someone with a degree in programming then they really missed some very basic stuff. 
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
That is a serious gap in knowledge! 
Did this person graduate with a programming related degree.
Just because the code works, it doesn't mean that it is good code.
|
|
|
|
|
The degree bit is not relevant - I'm self-taught, but can read books too. This is really really basic.
|
|
|
|
|
Public Sub SomeMethod()
For Each da As DataRow In myTable.Rows
da(11) = i + 1
items(i) = da(0) & ":" & da(1) & ":NaN:" & da(3) & ":" & da(4) & ":" & da(5) &
":" & da(6) & ":" & da(7) & ":" & da(8) & ":" & da(9) & ":" & da(10) & ":" & da(11) & ":" & da(1)
i += 1
Next
Session("itemTable") = items
End Sub
<AjaxMethod()> _
Public Function GetSessionData(ByVal name As String) As Object
Return HttpContext.Current.Session(name)
End Function
That is some code I just came across (I took out some stuff and renamed some things to protect the innocent). That basically gets information from a DataTable by index (rather than by field name), puts it into a colon-separated-value string (some of the data items include company names and addresses, which could potentially contain colons) that is stored in an array that gets shoved into the session. There is then some JavaScript that calls the server to get that session data (or any session data a client script feels like grabbing).
Luckily, I am replacing this code entirely.
|
|
|
|
|
Let me guess. The programmer thought CSV meant "Colon Separated Values". 
Any reason for "da(1)" to be included twice.
Chris Meech
I am Canadian. [heard in a local bar]
In theory there is no difference between theory and practice. In practice there is. [Yogi Berra]
posting about Crystal Reports here is like discussing gay marriage on a catholic church’s website.[Nishant Sivakumar]
|
|
|
|
|
CSV is actually a great example of how not to design a text-based data format. UNIX-style DSV is much more sane, and there colon is the default separator. So I wouldn't make fun of using colons to delimiter values, even though the rest of the code is horrible.
|
|
|
|
|
AspDotNetDev wrote: I am replacing this code entirely
Changing or replacing it is easy, but will it be an improvement?
Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum
Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.
|
|
|
|
|
Well it doesn't get any worse than the code already is, so there's really only one direction to go. Rapture, here I come!
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
