|
I was just discussing the case that someone said that line was incorrect and downvoted my answer when in reality I just copied the OP's line and changed the = to == which is what was actually stopping it from working as expected.
I prefer the double ampersand as well as a standard, the same way I always try to use short circuiting in VB which doesn't seem to be common practice, at least in online samples and articles.
|
|
|
|
|
Ahem!
The real Hall of Shame is the lack of brackets - pure laziness without realizing a simple misstyping mistiping mistyping can change the behaviour of code.
...most people are not a programming god who knows all precedence rules!
|
|
|
|
|
In the case you have posted the final result would be the same as if you had used the && operator. There is, however, an important difference between & and &&. Have a look at this example:
ICollection col = null;
if (col != null && col.Count > 0)
This would first check this expression: col != null; like it is false and we are using && operator, it would not even try to check the second operand, becouse the final result will be false. However, if we use just the bitwise & operator:
ICollection col = null;
if (col != null & col.Count > 0)
Since & operator is a bitwise operator it will try to check both operands so, in this case, it would throw a NullReferenceException when trying to evaluate the result of the second operand. That is why we always use the && operator in our boolean expressions, placing each operand in the right place. I guess this is what others have been trying to explain to you in this thread.
That said, I would not have downvoted your answer just for this if the rest of the answer is correct, and I think that not being able to make you understand this is not reason enough to tell them to RTFM.
|
|
|
|
|
Again, what makes you think I don't know the difference between & and &&?!
I never said they do the same thing and I do know that && is the most commonly used. That, however, does not make it wrong to use & between two boolean and it does not invalidate the fact that in that case it makes no difference. And if someone says it does then they should RTFM!
|
|
|
|
|
Fabio V Silva wrote: what makes you think I don't know the difference between & and &&?!
Oh, nothing at all but, you know, this is a public forum, and although there are many posts in this thread none of them was giving a good explanation about the differencies between those operators, becouse there are differencies, I know them, you know them and I know you know them, but a beginner might get confused after reading this thread. That's all.
|
|
|
|
|
|
forget it Keith, it's not gonna make any difference, I'm afraid you've just opened a can of worms.
|
|
|
|
|
Fabio V Silva wrote: in that case it makes no difference
Wrong. Take notes if you like:
A && B
In this scenario A is evaluated and if it is true then B is evaluated and that is the result, otherwise the result is false and B never gets evaluated.
A & B
Both A and B are evaluated and the values are then combined using a Bitwise And operation, the output of which is cast to a Boolean for the result.
At any level, these are two very diferent operations.
Fabio V Silva wrote: And if someone says it does then they should RTFM!
Manual read and understood, I still says it does.
Panic, Chaos, Destruction.
My work here is done.
or "Drink. Get drunk. Fall over." - P O'H
OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre
Have a bit more patience with newbies. Of course some of them act dumb -- they're often *students*, for heaven's sake. -- (Terry Pratchett, alt.fan.pratchett)
|
|
|
|
|
Jesus, why do people pretend to know the absolute truth about things without even bothering to do some minimal research.
What you are stating is completely wrong.
The & operator is an OVERLOADABLE operator. As such, it has predefined behaviours for integral types and boolean types.
(int & int) IS NOT THE SAME AS bool & bool. The first performs a logical bitwise AND operation while the latter performs a LOGICAL AND operation. There is no bitwise operation at all if the operator is dealing with two booleans. It is exactly the same as bool && bool except that both terms are evaluated no matter what the first expression evaluates to.
If you are not convinced then please read the following MSDN C# reference link: http://msdn.microsoft.com/en-us/library/sbf85k1c.aspx[^] or better yet: http://msdn.microsoft.com/en-us/library/2a723cdk.aspx[^]
|
|
|
|
|
Come on, guys. Stop this mess, ok? I don't pretend to know the absolute truth about this but, man, you are wrong or, at least, you might be confusing beginners.
The fact that, as you say, "both terms are evaluated no matter what the first expression evaluates to" with the & operator is the key, and it is not a trivial difference. See this example:
string s = null;
bool b1 = s != null && s.Length == 0;
bool b2 = s != null & s.Length == 0;
You see the operands here are boolean expressions. However, while b1 would be assigned false without any problem, a runtime NullReferenceException would be thrown when trying to assing the value to b2. This is a really important difference. Both operands are not the same and can never be considered as if they were the same. Under some circumstances they can return the same result, yes, but that does not mean that they are exactly the same or that you can use any of them when you use boolean expressions.
Can we, please, go on with our lifes now?
|
|
|
|
|
Gets my five - nicely argued.
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
Manfred R. Bihy: "Looks as if OP is learning resistant."
|
|
|
|
|
I'm just a novice programmer and didn't even realize (or I forgot?) that & was a legal command. I've always just used &&. I'm so confused by the last 30 some posts, I'm going to keep it simple and make sure I never use &.
|
|
|
|
|
Wise decision!
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
Manfred R. Bihy: "Looks as if OP is learning resistant."
|
|
|
|
|
Agreed! That is of course only if he meant to say: "I'll never use & with boolean operands." 
|
|
|
|
|
That's how I read it.
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
Manfred R. Bihy: "Looks as if OP is learning resistant."
|
|
|
|
|
Indeed. & and | on ints (or uints) is very useful.
|
|
|
|
|
Absolutely, because && and || wouldn't work with ints (and uints).
|
|
|
|
|
Well f. me sideways and call me Dr Dream. You come and tell me that I don't know what I'm saying and immediately say what I said.
Bitwise means EVERYTHING is evaluated and then anded ored noted xored and stuck through the mincer. Binary menas once the result is known it stops. I appologise if using technical terms confussed you but that's it.
Panic, Chaos, Destruction.
My work here is done.
or "Drink. Get drunk. Fall over." - P O'H
OK, I will win to day or my name isn't Ethel Crudacre! - DD Ethel Crudacre
Have a bit more patience with newbies. Of course some of them act dumb -- they're often *students*, for heaven's sake. -- (Terry Pratchett, alt.fan.pratchett)
|
|
|
|
|
Shut the f... up.
Ego non sum semper iustus tamen Ego sum nunquam nefas!
|
|
|
|
|
So if I have this straight, in your example:
if(UsernameTextBox.Text == "Manager" & PasswordTextBox.Text == "Maintenance")
because both arguments are boolean, the '&' is effectively acting just like a '&&' except for being trivially less efficient because it is always doing both of the string compares.
I know in this case you were merely quoting previous post using '&', but even if the non-short-circuit behaviour would be useful sometime, I'd avoid it because it just looks wrong to me. We're in a mixed C++/C# environment here, and I have to be on the lookout for misused '&'s in the code as it is. Allowing for false positives is not in the cards here.
That said, I think you got a raw deal.
|
|
|
|
|
And quite rightly so.
While for booleans, & can work as a logical operator, in all other cases it is bitwise. For consistency, use a single operatopr to represent logical operators throughout, the C# designers (C really) chose && for this purpose.
It may work, but its obfuscated, and should be rejected or corrected by any reasonable code review, regardless of any appeals you make to technical documentation.
|
|
|
|
|
Rob, I think the problem is that you are assuming human beings are rational/reasonable.
Where I am currently, I have to fill out a form and get authorization to fix a simple memory leak. The code base is several million lines of C++, suffering from 20 years of technical debt. Since I already have a reputation for being "too critical about code quality" which causes my input to get knocked down a level or two, I have to bite my tongue a lot.
It's a grand learning experience, but I'll be glad when I figure out what the lesson is!
|
|
|
|
|
The lesson : Never start a fight in the Hall of Shame 
|
|
|
|
|
The "answer" person's assumptions doesn't seem to match with what you have in your message.
Using & is different than using && and the results could be different, depending on what you are comparing. Since both return either true of false, there will not be a difference in the result. (The only difference is how the result is achieved.)
In C and C++, you can "AND items that are not boolean as:
int i, j;
i = 1;
j = 2;
if (i and j) --> result is false (bitwise AND: 1 & 2 yields 0 or false).
if (i and j) --> result is true (logical AND: 1 && 2 yields non-zero or true).
Hope this helps.
|
|
|
|
|
I like this:
#define TRUE (rand() > 0.1 ? TRUE : FALSE) // happy debugging losers 
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
