|
Albert Holguin wrote: - index i never gets initialized
My bet is on that one. 
I agree that there are many other problems, e. g. it should be just while (in) since ch==0 is a valid input. Also, why not use >> operators rather than get()?
Besides, @OP, use the <pre> tags to format a block of code, not <code>.
|
|
|
|
|
don't know if I'd agree with using >> instead of get(), but there's a lot of problems in that code either way. i hope this is OP's homework and not work.
|
|
|
|
|
My point of using >> is that you can read a variable with just one command rather than put it together byte by byte. It might be difficult though to change the code, depending on the complexity of the data structure within that file. Also, the data in that file have to be stored in the right way, i. e. using <<, to make sure they will be properly read using >>.
If all you ever use from ifstream is get(), then I have to ask, why use ifstream at all? That's like using MS Word for SMS... 
|
|
|
|
|
>> is not type safe and reading incorrect input type leads to undefined behavior
|
|
|
|
|
Same with bytewise input: you just delay the problem from the reading part to the interpreting part. In either case you have to somehow validate the resulting values. Unfortunately this is almost impossible with binary inputs, and for that reason alone I'd retract my suggestion of using >> here.
|
|
|
|
|
a couple of other things... this is managed C++, belongs in the C++/CLI forum... what happens if your open file fails? the function will lead to a program crash since you have no error handling... i really hope this is just pseudo-code and not your real thing, if its your real thing, you may want to take a step back to the basics.
|
|
|
|
|
Its the real thing. Yea I know its bad but it works for what i'm doing. Suggestions on how to improve it are welcome.
|
|
|
|
|
As a rule of thumb, I found that most crashes that only happen in release versions are due to lack of intialization: In debug mode, all variables are initialized with 0 by default. In release mode, this is not the case. Specifically for pointers this can have disastrous consequences, e. g. when you test try to delete an object from a non-null pointer which presumably points to an object created by new.
The best way to avoid these type of errors is to always explicitely initialize a variable on the same line that declares them.
The best way to treat with these errors is locate the part of the code that causes it, and make sure every variable is properly initialized.
|
|
|
|
|
Well you guys were right about not initializing those variables. That fixed the problem. Thanks.
I'm not sure what's wrong with my code. How would you re-write it. I'm checking for under scores to check for the next score.
The file looks like this:
100_
200_
300_
400_
|
|
|
|
|
Wait, are you saying you're reading a standard ASCII text file?  If so, why bother reading it as binary, byte by byte? Just open a normal file stream and use its standard operator >> to stream the numbers into your variables.
Try these functions to write and read your
void WriteScores(const std::vector<int>& scores) {
int nscores = (int) scores.size();
std::ofstream scorestream("Myscores.txt");
scorestream << nscores;
for (int i=0; i < nscores; ++i)
scorestream << ' ' << scores[i];
}
int ReadScores(std::vector<int>& scores) {
int nscores = 0;
std::ifstream scorestream("Myscores.txt");
scorestream >> nscores;
scores.resize(nscores);
for (int i=0; i < nscores; ++i)
scorestream >> scores[i];
return nscores;
}
You may want to add in some extra code to check for premature end of file or failure to create/write or read the file. You might also want to check the state of the filestream after reading each number to make sure an actual integer was read (if there was no integer, the resulting value will be 0, but since 0 may be a valid value, you can check on the state of your stream variable instead)
|
|
|
|
|
I've noticed that every new porject I create that utilizes the menu class from the MFC Feature Pack appears to utilize cleartype (or some form of font smoothing) regardless of my system settings.
I've looked for some way to disable it but so far have not found anything.
Does anyone know how to manipulate the settings for whether a CMFCMenuBar uses ClearType (or any type of font smoothing in general)?
UPDATE:
This might do the trick (Appears to work so far) and it appears to carry over to status bar, view tabs, etc...
void CMainFrame::DisableClearType(BOOL bDisable)
{
LOGFONT logFont = {0};
CFont& font = (CFont&)CMFCMenuBar::GetMenuFont();
font.GetLogFont(&logFont);
if (bDisable) {
logFont.lfQuality &= (~ANTIALIASED_QUALITY);
} else {
logFont.lfQuality |= ANTIALIASED_QUALITY;
}
CMFCMenuBar::SetMenuFont(&logFont);
}
void CMainFrame::OnApplicationLook(UINT id)
{
CWaitCursor wait;
theApp.m_nAppLook = id;
switch (theApp.m_nAppLook)
{
case ID_VIEW_APPLOOK_WIN_2000:
CMFCVisualManager::SetDefaultManager(RUNTIME_CLASS(CMFCVisualManager));
DisableClearType(TRUE);
break;
case ID_VIEW_APPLOOK_OFF_XP:
CMFCVisualManager::SetDefaultManager(RUNTIME_CLASS(CMFCVisualManagerOfficeXP));
DisableClearType(FALSE);
break;
...
modified on Monday, April 11, 2011 3:53 PM
|
|
|
|
|
You can do it for the entire system, but I don't know of any way to do it for just one app. You might check the BCGSoft forums, they might have a secret API.
|
|
|
|
|
Hans Dietrich wrote: You can do it for the entire system, but I don't know of any way to do it for
just one app
The single MFC Feature Pack application is ignoring my system settings so I thought there might be a way to force it to behave and pay attention to the system settings but so far, I've dug around in the BCGSoft/Microsoft source code for CMFCVisualManager and the label/caption drawing code simply uses the DC passed in so I guess I need to see where that DC comes from and see if it can be modified.
I'll dig around the BCGSoft site. I have to say, by the time I figure out how to use this Feature Pack stuff, they'll have moved on to something new again.
|
|
|
|
|
Post a question on the BCGSoft forums.
|
|
|
|
|
Didn't have the secret API but something in the BCGSoft FAQ made a neuron fire.
Thanks for the assistance.
|
|
|
|
|
Hi All,
I have to hit a WebSocket server and have to maintain the connection alive.
Please share some article about implementing a WebSocket Client application in C.
Thanks All.
Do your Duty and Don't expect the Result
|
|
|
|
|
For a socket client in Windows you basically need to call the following functions in order -
WSAStartup[^] - Initialize winsock.
socket[^] - Create the socket specifying the required protocol like TCP, UDP etc.
connect[^] - Connect the previously created socket to the specified server.
After this step the connection is ready.
To communicate with the server you can use the following functions -
send[^]/sendto[^] - Send a stream of bytes to the server.
recv[^]/recvfrom[^] - Receive a stream of bytes from the server.
To tear down the connection the following functions must be called -
closesocket[^] - Disconnect
WSACleanup[^] - Cleanup winsock.
|
|
|
|
|
|
The WebSocket protocol works on top of a normal TCP socket connection, so you must understand Winsock first before you can start implementing WebSockets.
|
|
|
|
|
Thanks for the reponses.. guess i'm not clear with my question..
I'm clear about the WinSocket APIs.. just need to know the WebSocket Handshake details..
I got the below header from Wikipedia & i want to know what are all the things are variable values in this header?
GET /demo HTTP/1.1
Upgrade: WebSocket
Connection: Upgrade
Host: example.com
Origin: http:
Sec-WebSocket-Key1: 4 @1 46546xW%0l 1 5
Sec-WebSocket-Key2: 12998 5 Y3 1 .P00
^n:ds[4U
As far as i know the /demo in first line, Host & Origin will change.. but exactly what will be the values?
Will the values of Key1, Key2 & the last 8 byte values also change?
I have to hit the server which has the format as ws://xxx.xxx.xxx.xxx:8181/websock
Also is it possible to send any extra information in the above handshake header? if so what will be its format?
Thanks Again.
Do your Duty and Don't expect the Result
|
|
|
|
|
|
Can websockets be implemented using CURL ?
Also it seems that once the client receives "HTTP/1.1 101 WebSocket Protocol Handshake" it should just wait on recv or recvfrom. Am I correct ? If so, who closes the socket connection once all communication is done? The server or the client ?
Thanks
|
|
|
|
|
If I have an LPCTSTR lpszString , how can I check if lpszString is empty ? Either , if is NULL , is correct lpszString == NULL ?
Thank you .
|
|
|
|
|
The best way is to make two checks:
if ((lpszString == NULL) || (lpszString[0] == 0))
{
[lpszString is NULL or empty ]
}
|
|
|
|
|
Thank you , does function .
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
