The Weird and The Wonderful

OriginalGriff wrote:

Three unnecessary int-to-string conversions

OriginalGriff wrote:

One unnecessary Parse operation

(float)Convert.ToDouble(cmd.ExecuteScalar());

float result = (float)cmd.ExecuteScalar();

var cmd = new SqlCommand("Select SUM(myField) From myTable Where myOtherField = 'Value'", con);
var resultString = cmd.ExecuteScalar().ToString();

var result = (!string.IsNullOrEmpty(result) & !result.Equals("0"))
	? (float)System.Convert.ToDouble(resultString)
	: 0F;

SqlCommand cmd = new SqlCommand("...", con);
float result = 0;
float.TryParse(cmd.ExecuteScalar().ToString(), out result);
return result;

SqlCommand cmd = new SqlCommand("...", con);
float result = 0;
float.TryParse(cmd.ExecuteScalar() AS string, out result);
return result;

SqlCommand cmd = new SqlCommand("...", con);
float result = 0;
object cmdResult = cmd.ExecuteScalar();
if(cmdResult != null)
     float.TryParse(cmdResult.ToString(), out result);
return result;

GibbleCH wrote:

I use it everywhere since my variable names are clear

musefan wrote:

float.TryParse(cmd.ExecuteScalar().ToString(), out result);

object obj = cmd.ExecuteScalar();
if (obj != null)
   // Now you can make the conversion

musefan wrote:

...so how would you write that bit of code?

musefan wrote:

Need to get it to a float somehow

int? result = (int?)cmd.ExecuteScalar();
return (float)result.GetValueOrDefault();

musefan wrote:

What deserves a vote of 1?

_Erik_ wrote:

The nullable type to use must be the one which fits with the one defined into the database

object obj = 1;
float? f = (float?)obj;

if(string.IsNullOrWhitespace(customMessage))
  ...

musefan wrote:

What is wrong with that?

string customMessage = null;
if (string.IsNullOrEmpty(customMessage.Trim()))
  ...

string customMessage = GetCustomMessage();
if (string.IsNullOrEmpty(customMessage.Trim()))
   ...

string GetCustomMessage(){
   string result = GetSomeDataFromSomewhere();
   return result ?? "";//or in times of old... return result == null ? "" : result;
}

musefan wrote:

there is no evidence that it is unsafe to assume that customMessage will never be null

string s = "";//empty and want to handle (length is 0 so fine)
string s = "\t";//as good as empty and want to handle (length is 1 so problem here)
string s = @"data 1\tdata 2\t";//some useful data and this will not be 'caught' by the trim test

// This is the same as the original code - if customMessage
// is null then they'll be an exception
if (customMessage.Trim().Length == 0)
  ...