|
|
Having multiple threads in the application to use the same helper class what is the better approach to code it in terms of performance and thread safety? static or non-static?
There is only one method in class.
static public class Img
{
static public Bitmap Crop(Bitmap image, Rectangle rect)
{
Bitmap cropped = new Bitmap(rect.Width, rect.Height, image.PixelFormat);
using (Graphics g = Graphics.FromImage(cropped))
{
g.DrawImageUnscaledAndClipped(image, rect);
return cropped;
}
}
}
Will the access to image parameter be safe? Each thread has its own image object created and disposed.
Will there be the performance bottleneck in that function?
Чесноков
|
|
|
|
|
According to the docs, Graphics.FromImage[^] is thread-safe (thread safety section is at the bottom of this very long doc). Your code does not have or need explicit locking, so it would not create additional synchronization bottlenecks. However, in the unlikely case that Graphics.FromImage uses explicit synchronization, your code would become a synchronization bottleneck implicitly.
|
|
|
|
|
Are the parameters passed to static Crop() function are also thread safe inside the function body similar to local variables? Bitmap image is a reference type, each thread creates it inside its worker method and passes to Crop().
Чесноков
|
|
|
|
|
As long as threads do not share instances of Bitmap image (as you indicated), there is no difference between local variables and parameters.
|
|
|
|
|
There should be no problem with your static method as long as it uses the image parameter only for reading purposes. Problems might arise if any other thread of your application is also attempting to write into of this object, remember, the one referenced by the image parameter.
|
|
|
|
|
I'm disturbed about static function reference object parameters thread safety.
Local parameters in the function are safe, they are created for each thread, e.g. cropped image.
2nd parameter is value object Rectangle is also safe, copy is created as you pass it.
1st parameter is reference object Bitmap. There is no writing to that parameter as you can see in the code. There should not be any difference if you modify it either if it is safe.
My question is whether parameters to static function are passed in a thread safe approach?
That is do they have the same thread safety as local variables in that static function body?
Чесноков
|
|
|
|
|
Chesnokov Yuriy wrote: whether parameters to static function are passed in a thread safe approach?
the question doesn't make sense. there is no such thing as "passing parameters in a thread-safe way".
parameters get handled by the method called, whether it is static or not.
and they exist on behalf of the caller, who could or could not share them with other code on other threads.
Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum
Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.
|
|
|
|
|
May be I've overworked but having N threads in Crop() function.
cropped is local variable and safe, each thread has its own object created.
Each thread has its own Bitmap passed to Crop().
Will 1st parameter image in Crop() function when accessed by one of N threads at the same time be refering to its own thread?
Чесноков
|
|
|
|
|
when a reference type is passed to a method (static or not), nothing happens to the object. All that happens is the method is given a way to work with that object.
objects in general don't know about threads, they don't "refer to a thread".
Chesnokov Yuriy wrote: Each thread has its own Bitmap passed to Crop().
So what problem could arise?
you can open 10 distinct documents with MS Word at the same time; they won't interfere with one another; executing the same code on different objects does not cause failure. Only having multiple threads working on the same data may cause problems.
Luc Pattyn [Forum Guidelines] [My Articles] Nil Volentibus Arduum
Please use <PRE> tags for code snippets, they preserve indentation, improve readability, and make me actually look at the code.
|
|
|
|
|
As far as I know, passing parameters to a static method is not different than passing them to instance ones, I mean, if another thread might be writing the image parameter of your sample, then you should explicitly synchronize the threads to make sure the program will not try to read and write at the same time, becouse in that case your reading operations might read "trash bytes" due to a not finished writing operation.
|
|
|
|
|
hello,
i have been using using Microsoft.Office.Interop.Word in my webserver (yes, i know it is not recommended)
when i ran it on my machine it runs fine but when running on the server i get time out on the line:
Documents.Open //when trying to open the file.
is there something im missing?
is there a better way to edit word document within web servers/ websites? (i can't create a new one using string builder or outputting into file i need to edit an existing one that sits on the server)
any input will be appreciated as I'm stuck on this for few days already...
thanks
|
|
|
|
|
Filepaths.
That is usually the problem, check them before anything else.
------------------------------------
I will never again mention that I was the poster of the One Millionth Lounge Post, nor that it was complete drivel. Dalek Dave
CCC Link[ ^]
Trolls[ ^]
|
|
|
|
|
thank you but i already checked that and the file exists...
|
|
|
|
|
Could be a lot of reasons. Security settings: Word creates a ~MyDocucemt.docx file in the directory - has the user write access to that directory.
Or a message box popping up from Word (e.g. confirm conversion, confirm share) - nobody will be able to click OK there...
|
|
|
|
|
Thank you everyone for trying, checked all ideas but it didnt work
thank you anyway
|
|
|
|
|
Hi All,
I want to pass only the single object of
dtoSourece sObj = new dtoSourece(); for xml serialization.
but cannot access sObj.applicant.firstname
Please help me with this?
static void Main(string[] args)
{
dtoSourece sObj = new dtoSourece();
sObj.name = "ram";
sObj.age = "25";
jlvformApplicant s = new jlvformApplicant();
s.firstname = "india";
Console.WriteLine("india=" + sObj.applicant.firstname);//getting error
Console.ReadLine();
}
class dtoSourece
{
public string name { get; set; }
public string age { get; set; }
private jlvformApplicant applicantField;
public jlvformApplicant applicant
{
get
{
return this.applicantField;
}
set
{
this.applicantField = value;
}
}
}
public class jlvformApplicant
{
private string firstnameField;
private string lastnameField;
/// <remarks>
/// <remarks>
public string firstname
{
get
{
return this.firstnameField;
}
set
{
this.firstnameField = value;
}
}
/// <remarks>
public string lastname
{
get
{
return this.lastnameField;
}
set
{
this.lastnameField = value;
}
}
}
Ramkumar
("When you build bridges you can keep crossing them. ")
http://ramkumarishere.blogspot.com
|
|
|
|
|
it would be so much easier to read if you used the formatting provided by CP rather than just plonking the code in like that.
As far as I can see from a quick look, your dtoSourec object has a property applciant which is never set to any value.
So if you do something like
dtoSourece sObj = new dtoSourece();
sObj.name = "ram";
sObj.age = "25";
jlvformApplicant s = new jlvformApplicant();
s.firstname = "india";
sObj.applicant= s;
Console.WriteLine("india=" + sObj.applicant.firstname);
Console.ReadLine();
You should be OK/.
___________________________________________
.\\axxx
(That's an 'M')
|
|
|
|
|
You are not setting the applicant property of your sObj which is why I suspect that you are getting the error.
BTW: You will get more help, more quickly, if you:
a) put your code inside <pre> your code goes here </pre> tags. Doing that makes it easier to read.
b) give full information about the problem you are having. e.g. the exact wording of the exception.
In your case I suspect that the error is a 'null reference exception' but I can't be sure.
My suggestion to resolve your problem is below.
static void Main(string[] args)
{
dtoSourece sObj = new dtoSourece();
sObj.name = "ram";
sObj.age = "25";
jlvformApplicant s = new jlvformApplicant();
s.firstname = "india";
sObj.applicant = s;
Console.WriteLine("india=" + sObj.applicant.firstname);
Console.ReadLine();
}
Henry Minute
Do not read medical books! You could die of a misprint. - Mark Twain
Girl: (staring) "Why do you need an icy cucumber?"
“I want to report a fraud. The government is lying to us all.”
I wouldn't let CG touch my Abacus!
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is.
|
|
|
|
|
Thanks
Ramkumar
("When you build bridges you can keep crossing them. ")
http://ramkumarishere.blogspot.com
|
|
|
|
|
My pleasure.
Henry Minute
Do not read medical books! You could die of a misprint. - Mark Twain
Girl: (staring) "Why do you need an icy cucumber?"
“I want to report a fraud. The government is lying to us all.”
I wouldn't let CG touch my Abacus!
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is.
|
|
|
|
|
You haven't set sObj.applicant to a value so it is null.
Your missing
sObj.applicant = s;
Just a note for the future. wrap your code in the pre tags (code block) so the code is formated. It makes it easier to read.
"You get that on the big jobs."
|
|
|
|
|
You really should read the other answers before posting.
Henry Minute
Do not read medical books! You could die of a misprint. - Mark Twain
Girl: (staring) "Why do you need an icy cucumber?"
“I want to report a fraud. The government is lying to us all.”
I wouldn't let CG touch my Abacus!
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is.
|
|
|
|
|
to be fair, you posted the same answer as me after my post 
(I wouldn't point it out, but the op thanked you 
___________________________________________
.\\axxx
(That's an 'M')
|
|
|
|
|
_Maxxx_ wrote: to be fair, you posted the same answer as me after my post
I was typing mine as yours was being posted, so I was not aware that you had done so, NOT 4 hours later as in this case.
Henry Minute
Do not read medical books! You could die of a misprint. - Mark Twain
Girl: (staring) "Why do you need an icy cucumber?"
“I want to report a fraud. The government is lying to us all.”
I wouldn't let CG touch my Abacus!
When you're wrestling a gorilla, you don't stop when you're tired, you stop when the gorilla is.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
