|
That's waaaaay over 9000 lines o_O
|
|
|
|
|
Two million and six, indented for readability! 
(that may have contributed to the load time... )
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
To bad you don't get paid per line right? 
|
|
|
|
|
I don't get paid on Saturdays anyway 
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
Maybe your app should have emitted IL code rather than C# code.
|
|
|
|
|
Luc Pattyn wrote: hould have emitted IL code
 
Good idea - but it would have defeated the purpose of the timing tests. I would have written the IL code as assembler: numeric index into jump table, or string pointer table maybe. I was more interested in how the compiler would handle the problem than I was in how I would handle it!
PiebaldConsult came up with an idea for a web service backed by a database, so I mocked up the database version (with a SqlCE DB) that works up to 1,000,000 - a total of a 92MB DB - it seems pretty fast and the code is pretty small. Do you think I should post it as a new Tip / Trick: "Numbers to words : the Extra Credit version"?
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
OriginalGriff wrote: it would have defeated the purpose
rather than write code, you should have read this then: Something You May Not Know About the Switch Statement in C/C++[^]. And if you are convinced C# may behave differently, it would deserve a real article.
OriginalGriff wrote: Do you think I should post it as a new Tip / Trick
Absolutely, a tip or article. And please include an SQL file with the data, so others can set up their own DB.
OriginalGriff wrote: Five hundred and twenty three
There seems to be one more issue that needs getting settled: should or shouldn't you use a hyphen in those inverted decimal-and-unit combinations? And if both are acceptable, how to let the user choose?
|
|
|
|
|
Luc Pattyn wrote: should or shouldn't you use a hyphen in those inverted decimal-and-unit combinations?
Thank you for pointing out this problem; you are indeed quite correct and there should be a hyphen between the tens digit and the units digit for all values between 21 and 99, excepting (of course) those integrally divisible by ten. This also applies to such numbers when considered as part of a larger number: "one thousand and sixty-seven" or "three hundred and fourty-eight thousand". In addition, there may be a comma between the magnitude indicator and the lesser value ("one thousand, three hundred and sixty-seven") although this is not compulsory (unless there is a decimal point in the number, in which case it should appear at each three digit position to the right of the decimal).
I had completely forgotten this point, and have modified the Tip / Trick accordingly. In my defence, it has been many years since I last wrote a cheque and thus any numbers as words! Even then, to exceed one thousand on a personal cheque was not an everyday occurrence... 
I have corrected this, and provided credit as is only appropriate.
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
Thanks for the clarification, and of course the credit.
I didn't know at all about the thousands separators turning into comma's (and I hope you really mean "," and not "comma").
How about the ultimate edition, dealing with floating-point numbers? (could be double, float, decimal)
|
|
|
|
|
Luc Pattyn wrote: How about the ultimate edition, dealing with floating-point numbers?
I think that is the "Pro Ultimate Gold Team Edition for Workgroups Turbo CRXVI-DiD" due for simultaneous release with the "Hades Low Temperature Food Storage Conditions" application. The release date of the later is, unfortunately, beyond my control - but is estimated to be when Microsoft release a bug-free version of Visual Studio.
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
The beauty of the database solution is that you can easily add globalization -- a new language/culture is simply another column in the table. 
|
|
|
|
|
Yep. And you can outsource it, all it takes is a linguist, not a programmer. Maybe there is a business opportunity here.
Or there could soon be a new homework assignment: given a numbers-to-words database in language A, translate it automatically to language B.
|
|
|
|
|
|
Hi,
I know you are not totally serious but what is the correct way and why should it not be faster than a large switch? I think the created IL code behaves similar to a very large if-then-elseif construct. Thus the switch-solution will get slower if you increase the range of supported numbers.
btw: I would create a "real algorithm" to produce the strings and pair it with a dictionary as a cache.
Robert
|
|
|
|
|
There are many ways to do a switch: For example, you could set up a table of delegates (each delegate referring to a method which executes the case block). To implement the switch for a numeric value, you need only use the parameter as an index into the table. No comparisons are required, so executions speed is excellent and the time taken to get to the code for the case block is the same for each case. To implement this with an if-then-else requires a comparison for each case in turn - this is understandably slower, and the execution time differs for each case.
There are other ways - the above is only suitable for densely populated cases - but I hope that makes some sense!
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
Robert Rohde wrote: I think the created IL code behaves similar to a very large if-then-elseif construct. Thus the switch-solution will get slower if you increase the range of supported numbers.
Wrong. IL has a special instruction for switch which the JIT translates into a jump table. Switches of consecutive integer values (so that a table without large holes is possible) don't get slower if you add cases. Switches of strings are implemented using a Dictionary<string, int> and the IL switch instruction on the resulting int.
|
|
|
|
|
|
|
Can you think of why a programmer would ever use a string to act as a bitmap field?
e.g.
DECLARE @Bitmap varchar(20)
SELECT @Bitmap = '00110100100011011110'
The beauty of bitmasks is that the values are compact (at one bit each) and you get the benefit of bitwise ANDing and ORing.
I winced at this, but can you think of an instance where this might make sense (except for the obvious "Hey, I just read a cool article about bitmaps! Computer scientists use 'em all the time.")
|
|
|
|
|
Yes; because he didn't ask me for advice first.
To make it worse, he used 8s rather than 0s.  By the time he showed me what he'd done it was too late and not worth the trouble to fix, so it's still like that in production. 
Neither of us works for that company anymore, so we just laugh about it. What the heck, it works!
|
|
|
|
|
I started out on a computer with a hex keyboard and learned there how to mask or test some bits. Nowadays I still often use them, for example in some entity in a web application.
But along the way I met several young and promising code monkeys who easily understood that you should use some kind of integer for that and what the bits are good for. But all of them had real trouble with this arcane AND and OR stuff. I guess the real horror here is, how somebody can have trouble understanding such a fundamental thing.
A while ago he asked me what he should have printed on my business cards. I said 'Wizard'.
I read books which nobody else understand. Then I do something which nobody understands. After that the computer does something which nobody understands. When asked, I say things about the results which nobody understand. But everybody expects miracles from me on a regular basis. Looks to me like the classical definition of a wizard.
|
|
|
|
|
"But all of them had real trouble with this arcane AND and OR stuff."
Believe me, I was in a fog about that my first two years programming. And XOR made me weep like a little girl!
Thanks for sharing your dark secrets, Mr. Wizard.
|
|
|
|
|
I must admit in the dim and distant past I did something not terribly dissimilar to that. Indeed if you search MSDN you can still find the evidence.
http://msdn.microsoft.com/en-us/library/aa239702(VS.60).aspx[^]
Now, It's too long ago for me to try justify exactly what I was doing, but here is what I remember of it:
1. The "bits" in this case represented meta-data which were stored in an XML document.
2. I wasn't going to be AND'ing or OR'ing the fields as a whole.
3. Any performance or space savings from using actual bits would have been outweighed by the benefit of being able to see the string of 1s and 0s in XML, rather than a cryptic Numerical value
4. Keeping the string of 1s and 0s in XML but actual bit logic in code would have meant translating back and forth needlessly.
So there it is.
I'm a huge fan of bitmap fields and use them all the time, but in that instance and at that time I felt comfortable with a string.
But yes, my default attitude is that a string is rarely the right way to go. 99% of the time I'd expect it to be a bad idea, and the remaining 1% of times I'd expect it to be seriously debatable.
|
|
|
|
|
Cool article. Thanks for the thoughts.
|
|
|
|
|
Thanks for the excuse to go back and look at that again.
It's hard to believe that back then I thought that CCustomerCol was a good naming convention.
And as for LetXML and GetXML!?!?!
To this day nobody has ever noticed (or at least admitted noticing) the following:
CustCol.Customer(1).Company = "LA"
CustCol.Customer(1).ContactName = "Sandy"
CustCol.Customer(1).Phone = "555-2312"
In the movie LA Story Sarah Jessica Parker's character is called Sandy and gives Steve Martin's character her phone number which is...555-2312.
The movie happened to be on tv in the background when I was writing the article. Just when I needed a bit of sample data that scene happened.
According to
http://www.radivarl.demon.co.uk/nick/media/555.htm[^]
I misspelled her name.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
