|
|
No - not going to look at that either! Try changing the "inline code" to "code block" it preserves the formatting.
Inline code:
if (dataFromClient == "listClients")<br />
{<br />
dataFromClient = "";<br />
<br />
foreach (DictionaryEntry Item in clientsList)<br />
{<br />
dataFromClient += Item.Key + "---" + ((TcpClient)Item.Value).Client.RemoteEndPoint.ToString() + "+++";<br />
}<br />
<br />
dataToClient = clNo;<br />
}<br />
Code block:
if (dataFromClient == "listClients")
{
dataFromClient = "";
foreach (DictionaryEntry Item in clientsList)
{
dataFromClient += Item.Key + "---" + ((TcpClient)Item.Value).Client.RemoteEndPoint.ToString() + "+++";
}
dataToClient = clNo;
}See what I mean? You can get away with it for a couple of lines, but with a whole class it is way too much effort to read!
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
|
I have edited the format....
Regards.
|
|
|
|
|
Ok, well done! It is now readable.
Did you mean you don't get the "You have left the session" message in the Disconnect method?
If so, then it would probably help to reference it at some point. At present, it just sits there, feeling lonely and unwanted as nobody calls it.
All you do is sit in a pair of loops - one in main where you try top start threads like crazy, and the other in doChat where you loop until an error occurs, print the error, and then loop some more.
I think you need to sit down and look at what you are trying to achieve in a lot more detail, and then try to start again from scratch.
BTW: Look at your errors listing when you compile this - you are getting a warning that TcpLister(int) is obsolete - take note of warnings, there aren't there for fun!
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
OriginalGriff wrote: you are getting a warning that TcpLister(int) is obsolete
OriginalGriff wrote: it just sits there, feeling lonely and unwanted as nobody calls it.
Maybe some of the code has fled before, while you were practicing your mind melting voodoo.
|
|
|
|
|
I thought I was safe - aren't you off playing chess?
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
No one is ever safe from my bot brothers and sisters, and no, you won't be able to tell us apart.
But you're right, Luc is at the tournament as we speak.
|
|
|
|
|
If I can't tell the difference between the brothers and the sisters, I do not want to meet the family!
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
ok i try.
Thanks for immediate response.
Regards.
|
|
|
|
|
Hi,
I have a gridview and my last column is tpe of button,
i'm trying to get the value from the button that was pressed.
I tryied this line with RowCommand Event-
string value=myGrid.Rows[int.Parse(e.CommandArgument.ToString())].Cells[1].Text;
here i get's empty value.
Can someone please help me?
|
|
|
|
|
|
|
txtcode.Text = dataGridView1.Rows[j].Cells[i].Value.ToString();
|
|
|
|
|
|
You might want to ask this question in the WPF forum or in Quick Answers (but not both... cross-posting is frowned upon here). My guess, however, is that there is an event for when the video stops playing. Hook up to that event and detect if the video played back fully (i.e., that the user didn't manually stop it) using the Position.TotalSeconds property (if that's a real property). If you can't find any sort of event like that (though I'm sure one must exist), then I'd say just keep polling in a loop or on a timer to see if the TotalSeconds has been reached yet and then play the next item. You could also create a timer that assumes the video plays instantly and waits for the total duration of the video, then starts the next video and repeats that process until it reaches the last video.
|
|
|
|
|
All, I apologize if this has been answered somewhere in the forum already. I've searched for a couple of hours here and the general web and haven't found a suitable answer.
I simply want to output an RTF file that contains hyperlinks (URL) but shows ONLY the text for that link, not both the text and the full URL.
Here's brief code snippet that does NOT work as expected:
richTextBox1.LoadFile(inputFile, RichTextBoxStreamType.RichText);
richTextBox1.SaveFile(outputFile, RichTextBoxStreamType.RichText);
This snippet simply reads in an RTF file into a RichTextBox control and saves it back out (This is not what I'm actually trying to do in the long run, I just wanted to isolate the issue for clarity).
When I open the files in MS Word:
The original file (inputFile) has the text: "Bug# 137". This text is a hyperlink and all you see is the text and you could click it and go to the corresponding web page.
The "copied" version of the file contains the text: "Bug# 135 <http: www.google.com="">". This text is blue, and is underlined. Yet there are 2 things wrong with it:
1) It lists the entire URL, not just the text ("Bug# 135")
2) It is not an actual link, just blue, underlined text.
I'm using VS 2010. I have explicitly set "DetectURLs" boolean property, though I believe it's set to "true" by default.
Any assistance with this "gnawing" issue would be greatly appreciated.
|
|
|
|
|
Hi Guys. I have been trying to resolve an error I keep getting. I have an app with a number of forms. Most of the forms has a datagridview with edit and delete buttons. Most of them work fine but on two of the most simpler forms it just for some reason doesn't seem to work. Whenever I click on any of the column I get the following error:
Index out of range. must be non-negative and less than the size of the collection. Parameter name : index.
The same code I am using here works on other forms but not on this one.
Below is the code I am using.
private void dataGridView1_CellContentClick(object sender, DataGridViewCellEventArgs e)
{
int currentRow = int.Parse(e.RowIndex.ToString());
int rowint = 0;
dt.Clear();
try
{
conn.Open();
string taskstring = dataGridView1[0, currentRow].Value.ToString();
rowint = int.Parse(taskstring);
if (dataGridView1.Columns[e.ColumnIndex] == deleteButton && currentRow >= 0)
{
string queryDeleteString = "DELETE FROM tblTasks where TaskCode = " + rowint + "";
OleDbCommand sqlDelete = new OleDbCommand();
sqlDelete.CommandText = queryDeleteString;
sqlDelete.Connection = conn;
sqlDelete.ExecuteNonQuery();
}
else if (dataGridView1.Columns[e.ColumnIndex] == editButton && currentRow >= 0)
{
string updatestring = "Select TaskCode, TaskName, TaskDescription FROM tblTasks WHERE TaskCode = " + rowint + "";
string taskname = dataGridView1[dataGridView1.Columns["TaskName"].Index, currentRow].Value.ToString();
string description = dataGridView1[dataGridView1.Columns["TaskDescription"].Index, currentRow].Value.ToString();
OleDbDataAdapter da = new OleDbDataAdapter(updatestring, conn);
OleDbCommandBuilder cmdb = new OleDbCommandBuilder(da);
da.Update(dt);
string update = "UPDATE tblTasks SET TaskName = '" + taskname + "', TaskDescription = '" + description + "' WHERE TaskCode = " + rowint + "";
da.UpdateCommand = conn.CreateCommand();
da.UpdateCommand.CommandText = update;
da.UpdateCommand.ExecuteNonQuery();
}
}
catch (Exception ex)
{
MessageBox.Show(ex.Message.ToString());
}
finally
{
conn.Close();
getData();
}
}
Can anybody see anything here that would cause the problem? As mentioned, the same code works on other forms that have much more columns and data on it. Only two fo the forms don't seem to work with this code. 
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Which line is throwing the error?
Is this handler attached to dataGridView1?
Why are you using Parse?
int currentRow = int.Parse(e.RowIndex.ToString()); DataGridViewCellEventArgs.RowIndex is an int already...
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
Hi Griff.
1) Yes, it is attacheched to a dataGridView.
2) How would you write that bit of code? In order to get the int I need to Parse the RowIndex to int. If you can show me how else to get it then I'll try it.
Like I mentioned, It workes on all the other dataGridViews fine, except for two of them and they all use the exact same code!
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Ok, I have done two things.
The error seems to come in here:
string taskstring = dataGridView1[0, currentRow].Value.ToString();
I have also re-writtent the currentRow as this which seems to work:
int currentRow = e.RowIndex;
So, with the error narrowed down, why do you think it does this on this form and not on the other?
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
Kwagga wrote: I have also re-writtent the currentRow as this which seems to work:
int currentRow = e.RowIndex;
Yes, that is what I would expect - and int assigned directly to an int! See how much easier it is when you don't convert int to string to int?
Kwagga wrote: The error seems to come in here:
string taskstring = dataGridView1[0, currentRow].Value.ToString();
That only leaves one option: currentRow has a value that is either negative, or too big for the DataGridView. Since you access it from the RowIndex, it is unlikely to be too big - how would it unless the DatatGridView is being modified by some outside agency; not too likley in your scenario I think.
That leaves negative. And I'm betting that is what the problem is. The easiest way to get a negative number here via the RowIndex (in fact the only one I know, but I've been wrong before) is to click on the column header. Are you by any chance doing that?
If not, then insert a check for negative (and out-of-range) values and see what you get.
I'm pretty confident that either your code for the other DataGridViews is different and checks for valid data or you haven't clicked on their column header yet... 
Real men don't use instructions. They are only the manufacturers opinion on how to put the thing together.
|
|
|
|
|
Yeah, it is much easier. LOL.....
I haven't clicked on any of the header rows. What I have noticed though is that when I click in the cell I want to Edit it just goes back to the first cell. When I click it again then it throws the error.
Honestly, the code for the other gridviews are exactly the same for the cellcontent_click event. I am about to give up and just leave them out of the project and then every time somebody has to have something changed for them to go direct to the DB. I have pulled out most of my hair by now!!!!
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
you should clean up your code first.
1.
there is an abundance of unnecessary calls to ToString()
e.g. Exception.Message is a string, calling ToString on it does nothing useful at all.
2.
it does not make sense to convert a number to a string and then back to a number. stop doing that right now.
3.
there is a test for currentRow>=0 somewhere in your code. Why is that? either it is not necessary and you must remove it; or it is necessary, which also means dataGridView1[0, currentRow] can get a bad index. Check the documentation, log the values, do whatever it takes, but make this consistent.
Then you must use all available information:
1.
when an exception occurs, show all of it, not just the message itself. This is the one place you absolutely should use ToString(). Yes it will generate maybe 20 or 30 lines of information, some of that is really useful.
2.
make sure your development tools (Visual Studio or other) ALWAYS show line numbers in editor windows. See #101 and #102 here[^]. As a result an excpetion will be pinpointed to the right line without any doubt.
3.
when an exception occurs, also show additional information. In this case show e.RowIndex, e.ColumnIndex, and whatever you think may be relevant. So next time it throws, you get all of it at a glance.
So start behaving more professionally, clean up, observe, and fix the remaining problems.
|
|
|
|
|
Luc, to start off, thanks for reference to your article. I have done that. 
As for cleaning up my code, I am doing that.
As for your comment about being professional, a bit uncalled for but hey some peopl have bad days.
To explain the problem:
I have a form with a dataGridView on it. I also have a button on this form that loads the data grid with data from the Database. Only three columns: One is the ID column, which is an Autonumber, and the other two are Text columns. I am adding two extra columns to the dataGridView called Edit and Delete. Now, on the dataGridView1_CellContentClick event, when I click in any of the column/rows to edit data, I get an error. Full error message being, Index was out of range. Must be non-negatuve and less than the size of the collection. Parameter name: Index".
Below is the code:
private void dataGridView1_CellContentClick(object sender, DataGridViewCellEventArgs e)
{
int currentRow = e.RowIndex;
int rowint = 0;
dt.Clear();
try
{
conn.Open();
string taskstring = dataGridView1[0, currentRow].Value.ToString();
In the above code, when a user clicks on a cell to edit the contents, the code has to do a check to see if the selected cell is an Edit or Delete Button Column. What seems to happen is that when I run this now, this morning in debug with a line break at the point where I get the error it seems to work. When running it in debug without the line break it does the following. Some times it selects the cell and other times it doesn't. However, it doesn't seem to be throwing the error. 
Excellence is doing ordinary things extraordinarily well.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
