Re: CTabCtrl color background Problem - C / C++ / MFC Discussion Boards

Re: Crash Window on Close

ThatsAlok22-Jul-10 0:35

ThatsAlok

22-Jul-10 0:35

kindly let us know,Is crash is appearing in Debug Mode or release mode!

"Opinions are neither right nor wrong. I cannot change your opinion. I can, however, change what influences your opinion." - David Crow
Never mind - my own stupidity is the source of every "problem" - Mixture

cheers,
Alok Gupta
VC Forum Q&A :- I/IV
Support CRY- Child Relief and You

Memory Leak

Fareed Rizkalla21-Jul-10 13:36

Fareed Rizkalla

21-Jul-10 13:36

I ran code analysis on my project.
It told me I had a memory leak.

I have a Linked List class with an Add function.
The Add function receives parameters, then it creates a node and fills it with those parameters.
I can't understand why their is a leak!

Re: Memory Leak

Maximilien21-Jul-10 13:54

Maximilien

21-Jul-10 13:54

ok, but how do you remove items from the list ? is it done automatically by the list class destructor ?

Watched code never compiles.

Re: Memory Leak

Fareed Rizkalla21-Jul-10 14:08

Fareed Rizkalla

21-Jul-10 14:08

list class destructor!

Re: Memory Leak

Aescleal21-Jul-10 22:14

Aescleal

21-Jul-10 22:14

This may sound like a daft couple of questions...

- Are you sure the memory leak is in your class? Try swapping it for one that you know doesn't leak like std::list and run your analysis again.

- Why on earth are you writing your own linked list? std::list will probably do as good a job in most cases.

Ash

Re: Memory Leak

David Crow22-Jul-10 3:03

David Crow

22-Jul-10 3:03

Aescleal wrote:
- Why on earth are you writing your own linked list?

Academia.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Man who follows car will be exhausted." - Confucius

CTabCtrl color background Problem [modified]

etipaq21-Jul-10 5:50

etipaq

21-Jul-10 5:50

Hi all,

I have a problem to set correctly the color background of a CTabCtrl under Windows XP. IT work great under Vista/Seven. But XP still not working after many try.

So you can see 2 print screen (one in Vista and one in XP) you will see that the one on XP don't paint correctly the background windows (right beside the last tab).

http://www.devntic.com/IMAGES/PrintSreenVista.jpg[^]

http://www.devntic.com/IMAGES/printscreenXP.JPG[^]

this is my code to do what you see in these print screen..

I have a Class to manage CTabCtrl --> in this case COnglet (it's Tab in french)

BOOL COnglet::OnEraseBkgnd(CDC* pDC)
{
	//(HDC)wParam3
	RECT rect;
	this->GetWindowRect(&rect);
	::FillRect(pDC->GetSafeHdc(), &rect, static_cast<HBRUSH>(((CDlg_Modele*)m_TabOnglet[0]->ptrEcran)->m_DlgBGColor));

	return FALSE; // don't do the default erase
}

void COnglet::DrawItem(LPDRAWITEMSTRUCT lpDrawItemStruct) 
{	
	CRect rect = lpDrawItemStruct->rcItem;
	rect.top += ::GetSystemMetrics(SM_CYEDGE);
....
...

	pDC->SetBkMode(TRANSPARENT);
	pDC->FillSolidRect(rect, ((CDlg_Modele*)m_TabOnglet[0]->ptrEcran)->m_bgColor);
	
...
...

	pDC->RestoreDC(nSavedDC);
}

Thanks in advance for any help you could provide to me

regard Etienne

PS: sorry, my english is not perfect.

modified on Wednesday, July 21, 2010 3:18 PM

Re: CTabCtrl color background Problem

Niklas L21-Jul-10 10:12

Niklas L

21-Jul-10 10:12

I gave the class an English sounding name, et voilà

BOOL CMyTabCtrl::OnEraseBkgnd(CDC* pDC)
{
	//(HDC)wParam3
	RECT rect;
	this->GetWindowRect(&rect);

	//----------------
	ScreenToClient(&rect); // (And added this)
	//----------------

	::FillRect(pDC->GetSafeHdc(), &rect, static_cast<HBRUSH>(((CDlg_Modele*)m_TabOnglet[0]->ptrEcran)->m_DlgBGColor));

	return FALSE; // don't do the default erase
}

I strongly suggest that you give identifiers English names, unless a customer demands another language in a contract. And even then, try to convince him before accepting.

A simple thing as asking for help might reduce your chances of getting a good response. But there are better reasons, working with developers from different countries being one. Going public with parts of your code being another. I once had an interface file for a complex system completely in Dutch in my hands. Oh my oh my...

home

Re: CTabCtrl color background Problem

Code-o-mat21-Jul-10 10:34

Code-o-mat

21-Jul-10 10:34

Was it Dutch, Dutch++ or maybe Dutch#? Big Grin | :-D

> The problem with computers is that they do what you tell them to do and not what you want them to do. <
> "It doesn't work, fix it" does not qualify as a bug report. <
> Amazing what new features none of the programmers working on the project ever heard of you can learn about when reading what the marketing guys wrote about it. <

Re: CTabCtrl color background Problem

Niklas L21-Jul-10 10:54

Niklas L

21-Jul-10 10:54

I'm glad you see the problem Smile | :)

home

Re: CTabCtrl color background Problem

etipaq21-Jul-10 15:59

etipaq

21-Jul-10 15:59

Thanks for your reply and your advice.

I added the line of code that you suggested but it seems not to be working anyway in windows XP (Tested on Windows XP sp3).
To see whitch area i painted In OnEraseBkgnd, i changed the color and in Vista all seems to be in good place like you can see on this printscreen

http://www.devntic.com/IMAGES/VistaGreen.jpg[^]

but in XP i didn't see anything changing.

So what's wrong With XP and CTabCtrl?

Thanks again.

Character Exception

Pryabu21-Jul-10 3:54

Pryabu

21-Jul-10 3:54

Hi,

Im having a LPSTR variable.I want to copy a string to this variable. The application is getting crashed while copying this string.I want to catch this exception.I have used exception class,but its not capturing that one.Please suggest me to do this.Im using the following code.

LPSTR lpszstr;
try
{
wsprintf(lpszstr,"%s","sdfsdfsd fsdfsdfsdf");
}
catch (CException *why)
{
::MessageBox(NULL,"test123","test",MB_OK);
}

Thanks,

Re: Character Exception

Aescleal21-Jul-10 4:15

Aescleal

21-Jul-10 4:15

People on these forums seem a bit obsessed by exceptions...

- wsprintf is a windows API function. Windows API function have a C interface, not a C++ one. As C compilers don't understand C++ exception handling Windows API functions don't throw C++ exceptions. Therefore whatever wsprintf does it won't throw, ever.

- CException is an MFC class. The only thing that throws exceptions based on CException is MFC and clients of MFC. Even if the previous point didn't apply then wsprintf couldn't throw a CException.

- IF wsprintf threw a CException derived class you're still using it wrong. MFC (due to it's long history of working on brain damaged compilers) throws exceptions by pointer and not by value. When you catch an MFC exception AND handle it you have to delete the exception afterwards. Not generally using the delete operator either. Have a look at the docs for details.

- finally even if wsprintf threw what you want it to catching it would be a bad idea. You've got code that's writing to a random area of memory. Do you really expect to be able to scribble over your process address space and get away with it? Sometimes you might be able to recover and keep going, hopefully most of the time your code will crash in a heap.

So:

- stop obsessing about exceptions but if you can't stop learn the difference between a processor exception, an operating system exception and a C++ exception

- stop mucking about with low level stuff. Don't use array of characters use vectors or strings. Don't think they're something advanced - it's the stuff you're doing (pointers and arrays and not knowing the differences between them, using C functions like sprintf when stringstreams do in a far safer manner) that's advanced

Ash

Re: Character Exception

Sauro Viti21-Jul-10 4:35

Sauro Viti

21-Jul-10 4:35

In addition to what Ash said, note that:

LPSTR is a pointer to a multi-byte string (i.e. char *), but you are using wsprintf which is an unicode function (i.e. it works on wchar_t)
when used with wsprintf, the format string "%s" stand for an unicode string, but you are passing a multi-byte string instead: probably this is the reason of the crashes you are experiencing. Replace wsprintf with sprintf
to avoid problems with buffer overrun improved versions of sprintf and wsprintf are privided: think using printf_s and wsprintf_s

Re: Character Exception

Aescleal21-Jul-10 4:55

Aescleal

21-Jul-10 4:55

Hi Sauro,

wsprintf (which resolves into wsprintfA and wsprintfW) is a version of either sprintf or swprintf implemented by USER (IIRC, might be KERNEL). swprintf is the unicode sprintf like function - nice of them to change a couple of letters like that!

To add to the confusion wsprintf can't handle any floating point formats the way sprintf and swprintf can and can only handle 1k of characters.

Cheers,

Ash

Re: Character Exception

Richard MacCutchan21-Jul-10 5:19

Richard MacCutchan

21-Jul-10 5:19

Sauro Viti wrote:
wsprintf which is an unicode function

1. Not true, it works on either and is actually defined to wsprintfA or wsprintfW depending on the setting of UNICODE.

2. see 1, but also the reason for the crash is that lpszstr is not initialised to point to anything.

3. wsprintf_s does not exist. As far as I recall the wxxx functions were created for windows programs that did not include stdio.h.

It's time for a new signature.

Re: Character Exception

C^hris L^osinger21-Jul-10 4:36

C^hris L^osinger

21-Jul-10 4:36

LPSTR lpszstr;

this is a pointer, not a string. and it doesn't point anywhere (you haven't initialized it). you need to allocate some memory for a string, and then use that in your wsprintf.
you need something like this:

TCHAR str[100];
wsprintf(str,"%s","sdfsdfsd fsdfsdfsdf");

also, it might be good to read about the differences between pointers and arrays[^].

image processing toolkits | batch image processing

Re: Character Exception

Cool_Dev21-Jul-10 4:38

Cool_Dev

21-Jul-10 4:38

if you didn't allocate enough memory for lpszstr to hold the string you copy to it, definitly access violation will happen, and as wsprintf() doesn't throw any exception, you can't expect to catch it

关于32/64位操作系统下,应用程序兼容性问题

xjh_sz20-Jul-10 23:38

xjh_sz

20-Jul-10 23:38

最近在写个驱动安装程序,里面用到一些内核函数比如UpdateDriverforPlugAndDevice(),用的vs2008,在32位操作系统下工作正常,win32的程序可以在x64下运行，但是在64位下就会出错,比如UpdateDriverforPlugAndDevice(),我用GetLastError（），看到出错。后来我在64位系统下装了vs2008，编译出x64程序，一切运行正常，但是这个程序无法在win32下运行。问题是解决了，但是我现在用维护两个版本32下一个，64位一个；不知道大家有什么好方法，只要运行一个版本。

Re: 关于32/64位操作系统下,应用程序兼容性问题

Richard MacCutchan21-Jul-10 0:13

Richard MacCutchan

21-Jul-10 0:13

Sorry, but we cannot understand this, can you please have your question translated into English?

It's time for a new signature.

Re: 关于32/64位操作系统下,应用程序兼容性问题

Sauro Viti21-Jul-10 1:00

Sauro Viti

21-Jul-10 1:00

This is an english only website, please translate your question: we are not able to understand it

Re: 关于32/64位操作系统下,应用程序兼容性问题

Luc Pattyn21-Jul-10 14:41

Luc Pattyn

21-Jul-10 14:41

No it isn't. We even have non-English forums, such as this http://www.codeproject.com/Forums/1580230/General-Programming-Chinese.aspx[^]

Smile | :)

Luc Pattyn [Forum Guidelines] [Why QA sucks] [My Articles] Nil Volentibus Arduum

Please use <PRE> tags for code snippets, they preserve indentation, and improve readability.

Re: About 32/64 bit operating system, application compatibility issues

David Crow21-Jul-10 3:09

David Crow

21-Jul-10 3:09

xjh_sz wrote:
For example UpdateDriverforPlugAndDevice (), I used GetLastError (), see the error.

And what is that error?

xjh_sz wrote:
The problem is solved, but I now maintain two versions with the next 32, 64 a; do not know what a good way, just run a version.

Not sure I understand this. Are you wanting one set of source code, but two separate exe files?

Re: About 32/64 bit operating system, application compatibility issues

Yusuf21-Jul-10 7:08

Yusuf

21-Jul-10 7:08

Dave,
It is nice of you to translate OP question and try to give some clue. Shouldn't you tranlated your answer to chinease though Poke tongue | ;-P

Yusuf
May I help you?

Re: About 32/64 bit operating system, application compatibility issues

David Crow21-Jul-10 7:41

David Crow

21-Jul-10 7:41

Yusuf wrote:
Shouldn't you tranlated your answer to chinease though

不，我不会说中文。

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.