|
case WM_SIZE:
{
wchar_t Width[5];
wchar_t Height[5];
_ltow_s((WCA.right-WCA.left), Width, 5, 10);
_ltow_s((WCA.bottom-WCA.top), Height, 5, 10);
if (RegDeleteKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Width") == ERROR_SUCCESS)
RegSetKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Width", REG_SZ, Width, wcslen(Width)*2);
if (RegDeleteKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Height") == ERROR_SUCCESS)
RegSetKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Height", REG_SZ, Height, wcslen(Height)*2);
return 0;
}
case WM_MOVE:
{
wchar_t Left[5];
wchar_t Top[5];
if ((int)(short)LOWORD(lParam) > 0)
_ltow_s((int)(short)LOWORD(lParam), Left, 5, 10);
if ((int)(short)HIWORD(lParam) > 0)
_ltow_s((int)(short)HIWORD(lParam), Top, 5, 10);
if (RegDeleteKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Left") == ERROR_SUCCESS)
RegSetKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Left", REG_SZ, Left, wcslen(Left)*2);
if (RegDeleteKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Top") == ERROR_SUCCESS)
RegSetKeyValue(HKEY_CURRENT_USER, RegistrySubKey, L"Top", REG_SZ, Top, wcslen(Top)*2);
return 0;
}
I'm using these 2 events to record my window position and size. However by running and closing my app and running it again, without changing any of the dimensions. It is just affected by running and closing! 
Changing size on it's own!
|
|
|
|
|
I'm not sure what you're asking exactly, but there is a little problem with your code. It's probably not a good idea to manipulate the registry in every sizing event. Just record the size when the window is destroyed and read-and-set when the window is created.
Steve
|
|
|
|
|
The problem isn't with the saving, can you imagine when you close and reopen the application.
The window changes size on it's own, although I haven't modified or changed the window coordinates in anyway. If not dimensions or position!
|
|
|
|
|
Nevertheless, accessing the registry on every size event is an insane design.
Steve
|
|
|
|
|
The user won't change the size of the window every moment, because the program is still buggy.
I was trying to maintain the last state, to ensure the crashes didn't harm much of the program.
|
|
|
|
|
Firstly, don't access the registry in these notifications: it's crazy and will slow down your application's responsiveness. If your going to do something, don't stuff it up before you start!
Secondly, WM_SIZE and WM_MOVE events will be sent during the creation of the window, even without any user interaction. This is what most people would expect (think of it this way: the windows is being moved and sized by the system when it's created).
Finally you don't seem to be doing any coordinate mapping (see ClientToScreen[^]), although I admit you haven't posted the code which restores the window position and size at startup.
Steve
|
|
|
|
|
I suggest a general logging technique like below;
case WM_CREATE[
{
RECT rect;
GetWindowRect(hWnd, &rect);
write_log("WM_CREATE: %d, %d, %d, %d\n",
rect.left, rect.top, rect.right, rect.bottom);
... other codes ...
return 0;
}
case WM_SIZE:
{
write_log("WM_SIZE: %d, %d, %d, %d\n",
WCA.left, WCA.top, WCA.right, WCA.bottom);
return 0;
}
break;
case WM_MOVE:
{
write_log("WM_MOVE: %d, %d\n",
LOWORD(lParam), HIWORD(lParam));
return 0;
}
write_log() maybe like this;
void __cdecl write_log(const char* format, ...)
{
va_list(args);
va_start(args, format);
FILE* fp = fopen("trace.log", "a");
vfprintf(fp, format, args);
fclose(fp);
}
You might be able to catch the point with the log file.
|
|
|
|
|
Have you bothered to set breakpoints on the RegSetKeyValue() calls and use the debugger to see if the variables have the expected values? Anything short of that is a waste of time.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Man who follows car will be exhausted." - Confucius
|
|
|
|
|
I am using Joseph M. Newcomer's WaitInfo
An Introduction to Processes: Asynchronous Process Notification[^]
to run multiple processes. I needed multiple WaitInfo because each time it will overwrite the hProcess info so I made WaitInfo into a vector
std::vector<WaitInfo> waiter
Next I have it
HANDLE hProcess = Launch(_T("notepad.exe"));
int idx = (int)waiter.size() + 1;
waiter.resize(idx);
waiter.at(idx-1).requestNotification(hProcess, this);
The code can launch 3 notepad without a problem.
However upon terminating either first two notepad it would crash. If I terminate the last one it would fine.
I traced it back to
::WaitForSingleObject(hProcess, INFINITE);
notifyee->PostMessage(UWM_PROCESS_TERMINATED, 0, (LPARAM)hProcess);
For the first two hProcess became 0xfeefee and the last process had the correct hProcess value.
I am unsure why the first two lost it's hProcess value. At the time of WaitForSingleObject their hProcess were correct. Since each WaitInfo has it's own vector so it shouldn't overwrite or clear the first two.
Well from the looks of it notifyee is gone as well.  
modified on Thursday, May 13, 2010 5:58 PM
|
|
|
|
|
Orion Star wrote: waiter.resize(idx); // Increase vector size for the new process
waiter.at(idx-1).requestNotification(hProcess, this);
Is WaitInfo copy constructible and assignable. Perhaps when the vector is reallocating it's storage and copying the old contents to the new buffer a problem is occurring. Test this by calling reserve on the vector to set the final size before adding and elements:
std::vector<WaitInfo> waiter;
waiter.reserve(10);
Steve
|
|
|
|
|
Doesn't look like it
I tried
waiter.reserve(idx+1) and waiter.reserve(idx+10)
before I resize. Same problem
The thing is I checked waiter content, hProcess and notifyee, right after
waiter.at(idx-1).requestNotification(hProcess, this);
HANDLE check = waiter.at(idx-1).GetHandle()
and each time it's correct from my program side.
I just don't know why they are gone after the process ends
|
|
|
|
|
That's fundamentally unsafe…when you call requestNotification, the WaitInfo class passes its address to the thread it creates, and uses that address. When you resize a vector, it's likely to move its content when it has to reallocate storage, invalidating the pointer that was passed to the thread.
You're probably better off using a std::list, as it doesn't move items when it is altered. It's also just as easy to use (you could use the insertion code I show for vector as well…):
std::list<WaitInfo> waiter;
HANDLE hProcess = Launch(_T("notepad.exe"));
waiter.push_back(WaitInfo());
waiter.back().requestNotification(hProcess, this);
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
CodeProject MVP for 2010 - who'd'a thunk it!
|
|
|
|
|
I will give that a shot and see how that goes
I happy to report you are correct. I was able to close them without crashing and from my trace they have the correct value.
Thanks 
|
|
|
|
|
How would I choose between writing into files in big-endian or little-endian format? Is there a way to tell fwrite() to do this?
|
|
|
|
|
fwrite or any other file operation will not do it for you.
You will have to do it yourself.
Windows is by default little-endian.
You can use the socket functions htonl and htons to toggle between big-endian and little-endian.
|
|
|
|
|
fwrite writes bytes. it doesn't know anything about endianness. so, if you're writing an int, you'll get the bytes from that int in the order they're stored in memory.
if that's not the order you want, you'll need to swap the bytes before calling fwrite.
|
|
|
|
|
hi guys
I have an app that has some dialogs opened, is kind of storage system.
When i update a price in a dialog i want the other ones to be notified of the change, is there a way to do this?
I know that using messages is an option but how to signal all dialogs.
Thanks 
|
|
|
|
|
You could implement a simple Observer[^] mechanism.
Watched code never compiles.
|
|
|
|
|
Are the dialogs modal or modeless. Do they have a common parent?
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"Man who follows car will be exhausted." - Confucius
|
|
|
|
|
some are modal and some not but there could be at the same time 1 or more modeless with a modal
|
|
|
|
|
The application and all its dialogs can use RegisterWindowMessage[^] with the same string to get the same value.
Now use SendMessage[^] and specify the hWnd parameter as HWND_BROADCAST and the Msg parameter as the value returned by RegisterWindowMessage.
|
|
|
|
|
thanks, They should all have the same parent window?
|
|
|
|
|
Broadcast is only sent to top level windows and not child windows.
|
|
|
|
|
Hi ,
I am trying to get running application process ID So I am iterating every exe name and comapring using EnumProcessModules.
It is wroking fine on XP but on vista I am not getting name for all running process.For some process I am able to see the process name but not for all.
What might be the issue?
|
|
|
|
|
It could be a permission issue.
Try running application with administrator privileges. Right click -> Run as administrator.
|
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
