The Weird and The Wonderful

Andrew Rissing wrote:

It would just seem since all the classes that derive from WaitHandle all throw an exception when exitContext is true that Microsoft would just remove that parameter entirely.

public abstract class AbstractThing
{
  abstract public void Foo(MyOtherThing t);
}

public class ConcreteThing1 : AbstractThing
{
  override public void Foo(MyOtherThing t) { ... }
}

public abstract class AbstractThing
{
  abstract public void Foo(MyOtherThing t);

  virtual public void Foo(MyOtherThing t, bool exitContext)
  {
     if (exitContext) 
       throw new NotSupportedException(); //TODO: message ;-)

     Foo(t);
  }
}

public class ConcreteThing1 : AbstractThing
{
  override public void Foo(MyOtherThing t) { ... }
}

if ((millisecondsTimeout < 0) && (millisecondsTimeout != -1))

if(millisecondsTimeout < -1)

dojohansen wrote:

And I thought the compiler optimization would have caught that one

&& (millisecondsTimeout != Timeout.Infinite)

private void ReceiveMessageAsync(object state)
{
  SubscriptionMessage sm;
  CommandMessage cm;
  ReplyMessage rm;
 
  if ((sm = (state as SubscriptionMessage)) != null)
    OnSubscriptionUpdate(sm.Source, sm.Topic, sm.Item);
  else if ((cm = (state as CommandMessage)) != null)
    OnCommandReceived(cm);
  else if ((rm = (state as ReplyMessage)) != null)
    OnReplyReceived(rm);
}

private const int COUNT = 100000000;
 
public class Base { }
public class Derived : Base { }
 
static void Main(string[] args)
{
    object o = new Derived();
    Derived result;
    bool b;
 
    Stopwatch sw;
 
    sw = Stopwatch.StartNew();
 
    for (int i = 0; i < COUNT; )
    {
        if ((result = (o as Derived)) != null)
        {
            ++i;
        }
    }
 
    sw.Stop();
 
    Console.WriteLine("'As' Elapsed: {0}", sw.ElapsedMilliseconds);
 
    sw = Stopwatch.StartNew();
 
    for (int i = 0; i < COUNT; )
    {
        if (o is Derived)
            ++i;
    }
 
    sw.Stop();
 
    Console.WriteLine("'Is' Elapsed: {0}", sw.ElapsedMilliseconds);
    Console.ReadLine();
}

'As' Elapsed: 460
'Is' Elapsed: 414

Ian Shlasko wrote:

Granted, each of these messages is coming across a network connection, so 50ms per 100 million messages is completely insignificant, but it's the principle of the thing

enum MessageTypes { Command, Reply, Subscription }

class Message { 
public abstract MessageTypes MessageType { get; };
 (...)
 }

if (msg.MessageType == MessageTypes.Command) {
}
else if (...)

Function CAMBIADECIMAL(ByVal NUMERO As String, ByVal TIPO As Integer) As String
    Dim I As Integer
    Dim J As Integer

    Dim ss As String
    Dim ss1 As String
    Dim PARTE1 As String
    Dim PARTE2 As String

    Select Case TIPO
        Case 1
            ss = NUMERO
            I = ss.IndexOf(".")

            If I > 0 Then
                J = ss.Length - I - 1
                PARTE1 = ss.Substring(0, I)
                PARTE2 = ss.Substring(I + 1, J)
                ss1 = PARTE1 + "," + PARTE2
                Return (ss1)
            End If
            Return ss
        Case 2
            ss = NUMERO
            I = ss.IndexOf(",")

            If I > 0 Then
                J = ss.Length - I - 1
                PARTE1 = ss.Substring(0, I)
                PARTE2 = ss.Substring(I + 1, J)
                ss1 = PARTE1 + "." + PARTE2
                Return (ss1)
            End If
            Return ss
    End Select
End Function