C / C++ / MFC

31-Mar-10 18:38

i am using ListView_SortItems(hDlg, SortListCompareFunc, hDlg);
for sorting my list view
but my call back method SortListCompareFunc is never getting called
do i need to do any thing else

Cool_Dev31-Mar-10 19:18

Cool_Dev

31-Mar-10 19:18

posting piece of relevant code may help u to get quick solution..

arun_pk31-Mar-10 19:22

31-Mar-10 19:22

Iain Clarke, Warrior Programmer

Iain Clarke, Warrior Programmer31-Mar-10 21:23

31-Mar-10 21:23

arun_pk wrote:

Don't be sad, be pro-active.

Cool_Dev is quite right. It's not reasonable for you to expect us to be psychic. You might have done millions of things wrongly.

If in real doubt... Make a mew dialog box application, essentially with just this feature. A list box, and maybe two sort buttons. In those buttons' code, use different sort functions. When that works, then you'll see what you did wrong in your "real" application.

Iain.

I have now moved to Sweden for love (awwww).

arun_pk31-Mar-10 22:02

31-Mar-10 22:02

thanks for your concern
my mistake was the first parameter in ListView_SortItems
1st parameter was not indicating the listview
now i made it as listview handler .....
Eugan gave me the solution ..
Smile | :)

Eugen Podsypalnikov31-Mar-10 19:40

31-Mar-10 19:40

Please note,
that the first parameter of the macro ListView_SortItems
should get the handle of the list, not of the dialog... Smile | :)

virtual void BeHappy() = 0;

arun_pk31-Mar-10 19:50

31-Mar-10 19:50

Good morning Eugen

its reaching inside the sortFunction
what do i write inside that function to sort
sorry i m totally new to vc++

Eugen Podsypalnikov31-Mar-10 20:39

31-Mar-10 20:39

Good Morning, Arun Smile | :)

The sorting function has the following prototype:
int CALLBACK CompareFunc(LPARAM lParam1, LPARAM lParam2, LPARAM lParamSort);, where
- lParamSort is the third parameter of your above placed macro (hDlg in your case)
- lParam1 - is the Data associated with the first coming item to compare
- lParam1 - is the Data associated with the second coming item to compare

At the inserting of the items
you should associate a data (for example a number or pointer to a data set) with the item.
Please see the area Adding List-View Items and Subitems
at http://msdn.microsoft.com/en-us/library/bb774736(VS.85).aspx[^] Smile | :)

It is shown there
how you could associate a pointer to a data set
(line: lvI.lParam = (LPARAM) &rgPetInfo[index];) Smile | :)

Then, in your sorting function you could operate with the data:
just cast and operate with two data sets, for example:

PETINFO* petInfo1 =  (PETINFO*) lParam1;
PETINFO* petInfo2 =  (PETINFO*) lParam2;
return _tcscmp(petInfo1->szKind, petInfo2->szKind);

virtual void BeHappy() = 0;

arun_pk31-Mar-10 20:44

31-Mar-10 20:44

Thanks Eugen

i m workg out as per your comments

will let you know after i complete

arun_pk20-Apr-10 19:30

20-Apr-10 19:30

Good morning Eugen

this is how my existing project sorting functionality

HD_NOTIFY *phdntfy = (HD_NOTIFY *) lparam;

if (phdntfy->hdr.code == HDN_ITEMCLICK)
{
if (phdntfy->iItem == Sort1)
{
SortOrder[phdntfy->iItem] *= -1;
}
else {
Sort2 = Sort1; Sort1 = phdntfy->iItem; }

ListView_SortItems(hwndLV, ListViewCompareProc, Sort1);
}

break;

but in my project there is no LPARAM in notify method
Notify(HWND hDlg, int idCtrl, NMHDR *pnmh) these are the params of notify method
how do i get HD_NOTIFY

Eugen Podsypalnikov20-Apr-10 21:53

20-Apr-10 21:53

Do you mean, that the lparam is NULL at the first line ? Smile | :)

virtual void BeHappy() = 0;

arun_pk20-Apr-10 22:07

20-Apr-10 22:07

I mean to say in my already existing notify method does not have LPARAM parameter
these are the parameters of my notofy function
Notify(HWND hDlg, int idCtrl, NMHDR *pnmh)

Eugen Podsypalnikov20-Apr-10 22:09

20-Apr-10 22:09

Why are you needing that LPARAM ? Smile | :)

virtual void BeHappy() = 0;

arun_pk20-Apr-10 22:13

20-Apr-10 22:13

Coz
this is how they finds whether sorting has to be done in reverse order or ascending....

if (phdntfy->hdr.code == HDN_ITEMCLICK)
//&& (phdntfy->iItem < 5))
{
if (phdntfy->iItem == Sort1) // if same sort, reverse order
{
SortOrder[phdntfy->iItem] *= -1;
}
else // else, perform secondary sort
{
Sort2 = Sort1; // primary sort becomes secondary sort
Sort1 = phdntfy->iItem; // new primary second sort
}

Eugen Podsypalnikov20-Apr-10 22:15

20-Apr-10 22:15

You could sort your list at the init state
and save the order in your own variable,
then - change it, at the next sorting... Smile | :)

virtual void BeHappy() = 0;

arun_pk20-Apr-10 22:09

20-Apr-10 22:09

there is no lparam in my notify method

***************
HD_NOTIFY *phdntfy = (HD_NOTIFY *) lparam; /this code is there in some other dialog's notify method where they get lParam

Eugen Podsypalnikov20-Apr-10 22:12

20-Apr-10 22:12

Could you post the whole function (that has your switch), please ? Smile | :)

virtual void BeHappy() = 0;

arun_pk20-Apr-10 22:14

20-Apr-10 22:14

case LVN_COLUMNCLICK:
{
LPARAM lParam=(LPARAM)pnmh;
LPNMLISTVIEW pLVInfo = (LPNMLISTVIEW)pnmh->code;
HD_NOTIFY *phdntfy = (HD_NOTIFY *) pnmh->code;
if (phdntfy->hdr.code == HDN_ITEMCLICK) //&& (phdntfy->iItem < 5))
{
if (phdntfy->iItem == Sort1) // if same sort, reverse order
{
SortOrder[phdntfy->iItem] *= -1;
}
else // else, perform secondary sort
{
Sort2 = Sort1; // primary sort becomes secondary sort
Sort1 = phdntfy->iItem; // new primary second sort
}
ListView_SortItems(pLVInfo->hdr.hwndFrom, ListViewCompareProc, Sort1);
}

break;
}

Eugen Podsypalnikov20-Apr-10 22:37

20-Apr-10 22:37

Try something like it Smile | :)

// your orders:
#define COL_COUNT 6               // Count of cols
bool g_arOrders[COL_COUNT] = {0}; // init state: no sorted cols yet
   
...
{
..
case WM_NOTIFY: 
  switch (((LPNMHDR) lParam)->code) {
    case LVN_COLUMNCLICK: {
      int iCol = ((LPNMLISTVIEW) lParam)->iSubItem;
      if (0 <= iCol && iCol < COL_COUNT) {
        g_arOrders[iCol] = !g_arOrders[iCol]; // order reversing,
                                              // will be used at comparing
        ListView_SortItems(hwndList, ListViewCompareProc, iCol);
      }
    }
    break;
...
}
...

virtual void BeHappy() = 0;

arun_pk20-Apr-10 22:44

20-Apr-10 22:44

ok thanks

arun_pk20-Apr-10 23:54

20-Apr-10 23:54

Now i have given Like this

typedef struct tagNOTATIONINFO
{
	int nEpoch;
	TCHAR szDateTime[20];
	TCHAR szEvent[100];
}
NOTATIONINFO;




int CALLBACK ListViewCompareProc(LPARAM lParam1, LPARAM lParam2, LPARAM lParamSort)
{
	NOTATIONINFO* nNot1=(NOTATIONINFO*) lParam1;
 	NOTATIONINFO* nNot2=(NOTATIONINFO*) lParam2;
return  _tcscmp(nNot1->szEvent,nNot2->szEvent);
}

just comparing the event parameter
nothing happening
is there any thing extra i need to do ???

Eugen Podsypalnikov21-Apr-10 0:00

21-Apr-10 0:00

I have some questions Smile | :)

:
0) Will the comparing function be called, can you verify it ?
1) The structure instances must be associated with list items.
How were the items inserted ?

virtual void BeHappy() = 0;

arun_pk21-Apr-10 0:27

21-Apr-10 0:27

yes the comparing function is getting called.

ListView items are added from a file

at every Loop i m adding to global structure variable of NOTATIONINFO

Eugen Podsypalnikov21-Apr-10 0:33