Re: CListCtrl won't update as expected - C / C++ / MFC Discussion Boards

Vaclav_31-Mar-10 14:05

31-Mar-10 14:05

Basically, I have nested loops changing one COM parameter at a time, outputing simple command ( 5 bytes ) to a serial device ( ham radio ) and reading the response ( frequency ). If the response is valid ( numeric characters ) I assume that the COM setup is correct.
The entire process ( about 80 steps) is displayed in a list control for about 2 seconds ( time for the hardware to react).
The code I used here was just to get the display working after each setup is completed.
The UpdateData was incorrect way to accomplish this( see last entry in thread).
Vaclav

Re: CListCtrl won't update as expected

Maximilien31-Mar-10 6:45

Maximilien

31-Mar-10 6:45

When dealing with a large number of items in a list ( CListBox, CListCtrl), it is best to learn how to use virtual list boxes (owner drawn lists ) ( read this :virtual lists[^] )

This technique will remove most (if not all) performance issues, mostly when inserting a large number of items at one time in the list.

Another suggestion if you just want to "make it work" is to disable the drawing when inserting items in the list with CWnd::LockWindowUpdate and CWnd::UnlockWindowUpdate.

Watched code never compiles.

Re: CListCtrl won't update as expected

Vaclav_31-Mar-10 7:13

Vaclav_

31-Mar-10 7:13

Nope, it did nor work using CWnd::LockWindowUpdate and CWnd::UnlockWindowUpdate.
And yes, the documentation say that about UpdateData() ,apparently correctly because it does not do anything (visible) in my code.
But, CListCtrl is in DDX. It should do something, and it probably does when the function is finished.
I think stopping the windows from hogging the process is the key.

But I would expect at least one good pass. That is bugging me.

Thanks for your input.

Re: CListCtrl won't update as expected

krmed31-Mar-10 7:05

krmed

31-Mar-10 7:05

Try using

m_list.UpdateWindow()

whenever you want to display the new information.

Hope that helps.

Karl - WK5M
PP-ASEL-IA (N43CS)
PGP Key: 0xDB02E193
PGP Key Fingerprint: 8F06 5A2E 2735 892B 821C 871A 0411 94EA DB02 E193

Re: CListCtrl won't update as expected SOLVED with a hack

Vaclav_31-Mar-10 7:30

Vaclav_

31-Mar-10 7:30

Sorry Karl, no cigar!
But I found something, hold on to your hat!
If I take the scroll bars off the report list - it works as expected!
Using m_list_UpdateData(); after the "minor" loop!

Thanks all for sticking with me and helping me to "solve" this.
I guess to do it right - hide the control, disable the scroll bars and unhide it.
I just cannot help to say this - so much for multitasking operating system.
73 Vaclav

Re: CListCtrl won't update as expected SOLVED with a hack

Maximilien31-Mar-10 7:34

Maximilien

31-Mar-10 7:34

it's a hack, and probably a bad one.

but if it works for you...

Watched code never compiles.

Re: CListCtrl won't update as expected SOLVED with a hack

Vaclav_31-Mar-10 7:44

Vaclav_

31-Mar-10 7:44

Even better - sort off.
m_list.Update(0);
The flicker is ok in my case - feedback to user.

Re: CListCtrl won't update as expected

David Crow31-Mar-10 7:58

David Crow

31-Mar-10 7:58

Vaclav_Sal wrote:
What am I missing?

The primary thread is busy counting, thus it has no time for painting windows. Use a secondary thread to do the counting. See here for more.

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Man who follows car will be exhausted." - Confucius

Re: CListCtrl won't update as expected

Vaclav_31-Mar-10 8:17

Vaclav_

31-Mar-10 8:17

I actually started going that direction. But I slept on it and decided to do it the old fashioned way - KISS.
I really do not want to get tangled in another controversy here.
I have had enough recently. I'll just say one thing - who is on first here? Programmer or OS? Is OS really "too busy"? I want to process milisecond long singal and the OS is too busy painting?
Enough.
Cheers
Vaclav

Re: CListCtrl won't update as expected

David Crow31-Mar-10 8:24

David Crow

31-Mar-10 8:24

Vaclav_Sal wrote:
I really do not want to get tangled in another controversy here.

What is controversial about creating a secondary thread?

Vaclav_Sal wrote:
Is OS really "too busy"?

Since WM_PAINT messages are very low priority, all else is going to take precedence over them.

Vaclav_Sal wrote:
...and the OS is too busy painting?

No, if the OS was busy painting, you'd see the list control being painted along with the numbers being counted. In other words, the three loops are tying the CPU up and no WM_PAINT messages are being processed.

Re: CListCtrl won't update as expected

Vaclav_31-Mar-10 8:51

Vaclav_

31-Mar-10 8:51

FYI Here is my best solution:

iCountLog = m_list.GetItemCount();
m_list.RedrawItems(0,iCountLog );
UpdateWindow();

It uses methods available to CListCtrl.
It is simple, and looks OK on the desktop.
It draws item list LIFO fashion, as required.
It may be doing some unnecessary work - but it will do for now.
What bugs me - why did it took me so long to find it?
Cheers
Vaclav

Problem in c atof

RakeshManohar31-Mar-10 4:12

RakeshManohar

31-Mar-10 4:12

when i tried to convert a char array to double using atof() i am getting value 1077162803.000000

Re: Problem in c atof

Maximilien31-Mar-10 4:20

Maximilien

31-Mar-10 4:20

Show us the code.

Watched code never compiles.

Re: Problem in c atof

Cedric Moonen31-Mar-10 4:28

Cedric Moonen

31-Mar-10 4:28

Yes, and what is the problem ? What did you expect as output ?

Cédric Moonen
Software developer

Charting control [v3.0]
OpenGL game tutorial in C++

Re: Problem in c atof

David Crow31-Mar-10 4:48

David Crow

31-Mar-10 4:48

Are you doing something like:

double d = atof("1077162803.0");

Serial Port configuration

rick742331-Mar-10 3:59

rick7423

31-Mar-10 3:59

Unfortunately, I have a project where I need to use the serial port to communicate with an older device on our shop floor. I have a SERIALIO class that used to work with VC 6, but now when I try to use it with VS 2K5 it does not seem to work anymore and I cannot figure out why. I am assuming that the issue is with how the port is being initialized, because the device is not always getting a signal. I can determine this by watching the communications LED on the device itself.

Essentially, the process is to
1. Initialize the port
2. Send data string to device (*ID-)
3. get response from device (coded in a timeout function so that if the process takes more than 5S, will return TIMEOUT string)
4. Process the return string

What is happening is that device is either returning "ER" or the function will return "TIMEOUT". The "ER" means that the device does recognize the command sent.

When I use Hyper-Terminal and set the properties to 4800, n,8,1,Flow Control to use XON/XOFF, I get response every time. But, the following code fails and I am lost. Can anyone help?
(Sorry for the lengthy code to follow)
Here is my configuration script to initialize the serial port:

<br />
SerialIO::SerialIO(	LPCWSTR port,<br />
					long baud,<br />
					LPCSTR parity,<br />
					long data,<br />
					long stop){<br />
	USES_CONVERSION;<br />
	char initstr[256];<br />
	char errmsg[256];<br />
	COMMTIMEOUTS timeouts;<br />
	bf="";<br />
	buffer[0]='\0';<br />
	DCB dcb={0};<br />
	<br />
	<br />
	sprintf_s(initstr,"baud=%ld parity=%s data=%ld stop=%ld",<br />
			baud,parity,data,stop);<br />
	idCommDev=CreateFileW(	port,<br />
							GENERIC_READ|GENERIC_WRITE,<br />
							0,<br />
							NULL,<br />
							OPEN_EXISTING,<br />
							0,<br />
							NULL);<br />
	<br />
	if(idCommDev!=INVALID_HANDLE_VALUE)	{<br />
		if(baud){<br />
			//  Initialize the DCB structure.<br />
			SecureZeroMemory(&dcb, sizeof(DCB));<br />
			dcb.DCBlength = sizeof(DCB);<br />
			//fsuccess = GetCommState(idCommDev, &dcb);<br />
			if(GetCommState(idCommDev, &dcb))<br />
			{<br />
				//  Fill in some DCB values and set the com state: <br />
				//  4800 bps, 8 data bits, no parity, and 1 stop bit.<br />
				dcb.BaudRate = CBR_4800;     //  baud rate<br />
				dcb.ByteSize = 8;             //  data size, xmit and rcv<br />
				dcb.Parity   = NOPARITY;      //  parity bit<br />
				dcb.StopBits = ONESTOPBIT;    //  stop bit<br />
				dcb.fInX=FALSE;<br />
				dcb.fOutX=FALSE;	<br />
				dcb.fOutxCtsFlow=FALSE;		<br />
				dcb.fRtsControl=RTS_CONTROL_DISABLE;<br />
				dcb.fOutxDsrFlow=FALSE;<br />
				if(!SetCommState(idCommDev, &dcb))<br />
				{<br />
					CString lpMsgBuf;<br />
					char lpDisplayBuf[512];<br />
					DWORD dw = GetLastError(); <br />
					FormatMessage(<br />
						FORMAT_MESSAGE_ALLOCATE_BUFFER | <br />
						FORMAT_MESSAGE_FROM_SYSTEM |<br />
						FORMAT_MESSAGE_IGNORE_INSERTS,<br />
						NULL,<br />
						dw,<br />
						MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),<br />
						(LPTSTR) &lpMsgBuf,<br />
						0, NULL );<br />
					sprintf_s(lpDisplayBuf, "SetCommState failed with error:\r\n(%d): %s",dw,W2A(lpMsgBuf));<br />
					MessageBoxW(NULL, A2W(lpDisplayBuf), L"Error", MB_OK); <br />
				}<br />
				if(!GetCommState(idCommDev, &dcb))<br />
				{<br />
					CString lpMsgBuf;<br />
					char lpDisplayBuf[512];<br />
					DWORD dw = GetLastError(); <br />
					FormatMessage(<br />
						FORMAT_MESSAGE_ALLOCATE_BUFFER | <br />
						FORMAT_MESSAGE_FROM_SYSTEM |<br />
						FORMAT_MESSAGE_IGNORE_INSERTS,<br />
						NULL,<br />
						dw,<br />
						MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),<br />
						(LPTSTR) &lpMsgBuf,<br />
						0, NULL );<br />
					sprintf_s(lpDisplayBuf, "GetCommState after SetCommState with error:\r\n(%d): %s",dw,W2A(lpMsgBuf));<br />
					MessageBoxW(NULL, A2W(lpDisplayBuf), L"Error", MB_OK); <br />
				}<br />
			}<br />
			else<br />
		    {<br />
				CString lpMsgBuf;<br />
				char lpDisplayBuf[512];<br />
				DWORD dw = GetLastError(); <br />
				FormatMessage(<br />
					FORMAT_MESSAGE_ALLOCATE_BUFFER | <br />
					FORMAT_MESSAGE_FROM_SYSTEM |<br />
					FORMAT_MESSAGE_IGNORE_INSERTS,<br />
					NULL,<br />
					dw,<br />
					MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),<br />
					(LPTSTR) &lpMsgBuf,<br />
					0, NULL );<br />
				sprintf_s(lpDisplayBuf, "GetCommState (Initial) failed with error:\r\n (%d): %s",dw,W2A(lpMsgBuf));<br />
				MessageBoxW(NULL, A2W(lpDisplayBuf), L"Error", MB_OK); <br />
			}<br />
		}<br />
<br />
		SetupComm(idCommDev,(DWORD)1600,(DWORD)1600);<br />
		timeouts.ReadIntervalTimeout=MAXDWORD;<br />
		timeouts.ReadTotalTimeoutMultiplier=MAXDWORD;<br />
		timeouts.ReadTotalTimeoutConstant=10000;<br />
		timeouts.WriteTotalTimeoutMultiplier=0;<br />
		timeouts.ReadTotalTimeoutConstant=0;<br />
		SetCommTimeouts(idCommDev,&timeouts);<br />
		ReadMutex=NULL;<br />
	}<br />
	else {<br />
		CString lpMsgBuf;<br />
		char lpDisplayBuf[512];<br />
		DWORD dw = GetLastError(); <br />
		FormatMessage(<br />
			FORMAT_MESSAGE_ALLOCATE_BUFFER | <br />
			FORMAT_MESSAGE_FROM_SYSTEM |<br />
			FORMAT_MESSAGE_IGNORE_INSERTS,<br />
			NULL,<br />
			dw,<br />
			MAKELANGID(LANG_NEUTRAL, SUBLANG_DEFAULT),<br />
			(LPTSTR) &lpMsgBuf,<br />
			0, NULL );<br />
		sprintf_s(lpDisplayBuf, "Error Creating SERIALIO Comm Object with error:\r\n (%d): %s",dw,W2A(lpMsgBuf));<br />
		MessageBoxW(NULL, A2W(lpDisplayBuf), L"Error", MB_OK); 		<br />
	}<br />
}<br />

When I send a data packet to the device, I am expecting to receive the response immediately. So, I have a function called SendForResponce, which is as follows:

<br />
LPCSTR SerialIO::SendforResponse(LPCSTR outstr,<br />
								char abortc,<br />
								DWORD Timeout,<br />
								DWORD ch_delay){<br />
	DWORD count,mask;<br />
	char c='\0';<br />
	int i, canceled=0;<br />
	DWORD cTime=GetTickCount();//Current start time (milliseconds)<br />
	COMMTIMEOUTS timeouts,oldtimeouts;<br />
	DWORD pauset;<br />
	if(abortc!='\0'){<br />
		dcb.EvtChar=abortc;<br />
		SetCommState(idCommDev,&dcb);<br />
		mask=EV_RXCHAR|EV_RXFLAG;<br />
	}<br />
	else {mask=EV_RXCHAR;}<br />
	SetCommMask(idCommDev,mask);<br />
	//Adjust timeout to reflect user request.<br />
	GetCommTimeouts(idCommDev,&oldtimeouts);<br />
	timeouts=oldtimeouts;<br />
	timeouts.ReadIntervalTimeout=0;<br />
	timeouts.ReadTotalTimeoutMultiplier=0;<br />
	timeouts.ReadTotalTimeoutConstant=Timeout;<br />
	SetCommTimeouts(idCommDev,&timeouts);<br />
<br />
	PurgeComm(idCommDev,PURGE_RXCLEAR|PURGE_TXCLEAR);<br />
	buffer[0]='\0';<br />
	if(strlen(outstr)){<br />
		if(ch_delay){<br />
			for(i=0;(unsigned)i<strlen(outstr) && !canceled;i++){<br />
				pauset=GetTickCount();<br />
				if(!WriteFile(idCommDev,(LPCVOID)(&(outstr[i])),(DWORD)1L, &count,NULL)){ <br />
					canceled=1;<br />
				}<br />
				while((GetTickCount()-pauset)<ch_delay); //pause between characters.<br />
			}<br />
		}<br />
		else if(!WriteFile(idCommDev,(LPCVOID )outstr,(DWORD)strlen(outstr), &count,NULL)){canceled=1;}<br />
		if(!canceled && (GetTickCount()-cTime)<Timeout){<br />
			for(i=0;c!='\r' && c!='\n' && c!=abortc;i++){<br />
				if(!ReadFile(idCommDev,&c,1,&count,NULL)){MessageBoxW(NULL,(LPCTSTR)"SERIALIO Read Failed",(LPCTSTR)"Debug",MB_OK);;}<br />
				else{<br />
					if((GetTickCount()-cTime)>=Timeout){<br />
						strcpy_s(buffer,TIMEOUT_STR);<br />
						c=abortc;<br />
					}<br />
					else if(c==abortc){<br />
						buffer[0]='\0';<br />
						canceled=1;<br />
					}<br />
					else if((int)c==8 && i>0){<br />
						i-=2;<br />
						buffer[i+1]='\0';<br />
					}<br />
					else if(c!='\r' && c!='\n'){<br />
						buffer[i]=c;<br />
						buffer[i+1]='\0';<br />
					}<br />
				}<br />
			}//end for<br />
		}//end if(!canceled)<br />
	}//end if(WriteFile(idCommDev,(LPCVOID )outstr,(DWORD)strlen(outstr),&count,NULL))<br />
	else {<br />
	if(canceled){PurgeComm(idCommDev,PURGE_RXCLEAR);}<br />
	SetCommTimeouts(idCommDev,&oldtimeouts);<br />
	return buffer;<br />
}<br />

There are 10 kinds of people, those that understand binary and those that don't.

Re: Serial Port configuration

Jonathan Davies31-Mar-10 4:14

Jonathan Davies

31-Mar-10 4:14

Try using the a port monitor such as PortMon which will show you exactly what instructions the port is getting (rather than code showing what you think it is getting) and it will also show exatly what is being sent/received.

Re: Serial Port configuration

jeron131-Mar-10 5:19

jeron1

31-Mar-10 5:19

rick7423 wrote:
When I use Hyper-Terminal and set the properties to 4800, n,8,1,Flow Control to use XON/XOFF, I get response every time.

Shouldn't then the following be set to TRUE?

dcb.fInX=FALSE;
dcb.fOutX=FALSE;

Re: Serial Port configuration

rick742331-Mar-10 5:32

rick7423

31-Mar-10 5:32

Yes, but when I set those state values the utility just hangs.

I am using the PORT monitor and I am starting to think that the input timeouts/buffer receive portion may be the issue. I can replicate the port settings exactly to what Hyper-terminal is doing but it appears as though the receive portion is just hanging now (open comm state acts like an application hang).

Port Monitor is a godsend, that tool is helping alot.

There are 10 kinds of people, those that understand binary and those that don't.

Re: Serial Port configuration

Vaclav_31-Mar-10 6:19

Vaclav_

31-Mar-10 6:19

Would it help if I send you my code? It is not complete (and not if one fuction either)and may confuse the issue.
I am currently working on COM application and it should be done using "assynchronous code". Your ReadFile last parameter should point to OVELLAPED structure to do so.
FYI I have found two conflicting API descriptions of ReadFile when used for COM port. As far as I can tell you code look OK, however, I have learn that one needs to keep track of various API retrun values.
I for example check the last error of ReadFile before even looking at the return value.
Vaclav

Re: Serial Port configuration

rick742331-Mar-10 6:56

rick7423

31-Mar-10 6:56

Actually, yes, that would be good. I have looked at several classes found online but most were written years ago and have issues with VC2K5.

Even if your code points me in the right direction, that is good.
send to: rickr at nurserysupplies dot com

There are 10 kinds of people, those that understand binary and those that don't.

Re: Serial Port configuration

rick742331-Mar-10 9:34

rick7423

31-Mar-10 9:34

Could this be a problem with the WIDE characters? With the original application (Visual Studio 6), I did not use wide chars at all. This one has it turned on by default. I never thought it would cause a problem, but it may here.

Any thoughts on this?

There are 10 kinds of people, those that understand binary and those that don't.

Re: Serial Port configuration

rick74231-Apr-10 2:24

rick7423

1-Apr-10 2:24

By default, the VS2K5 project set the Character set to "Use Unicode Character set". Could this be part of the problem?

If so, is there any way to force the Serial Comm class to NOT be Uni-Code?

There are 10 kinds of people, those that understand binary and those that don't.

Re: Serial Port configuration

jeron11-Apr-10 5:09

jeron1

1-Apr-10 5:09

Could you use PortMon to logdata from your app, then look at it with DEBUG to see exactly what hex data is in there? If the data is not what you (or the receiving device) wants then yes, unicode could be a problem. Can't you disable unicode for the entire application if it's not needed?

Re: Serial Port configuration

rick74231-Apr-10 6:50

rick7423

1-Apr-10 6:50

I am in the process of converting to non-Unicode now, but man, it generated HUNDREDS of errors. This will take awhile to resolve.

I was hoping that it would be easier to force the data string to ANSI, but am not sure exactly how to do that. Blush | :O

There are 10 kinds of people, those that understand binary and those that don't.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.