|
The problem is maybe that char in C++ is an ASCII char (1 byte) and the char in C# is unicode (2 bytes).
Now if you look at the ctext += 32; statement.
The results will differ in C++ and C# for values above 223:
C++: 225 + 32 = 257 -> cast to char = 2
C#: 225 + 32 = 257 -> cast to char = 257!
Hope that helps.Greetings
Covean
|
|
|
|
|
Your method is not a copy of the C++ code. Read over the two, understand the logic and you'll see the issues in the listings.
To be a little more accurate, I normally start by writing each line from the original, finding the language equivalent. If I meet something that doesn't have an equivalent, then I work to understand what it does so I can imitate it. When I've written the code, I then go back to refactor it or improve on it.
|
|
|
|
|
Try using:
byte[] bytes = System.Text.Encoding.ASCII.GetBytes(text); and then use bytes[a] instead of text[a]You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
|
|
|
|
|
public static uint CRCRC(string text)
{
uint retHash = 0;
int a = 0;
byte[] bytes = System.Text.Encoding.ASCII.GetBytes(text);
if (bytes[0] == 34)
a = 1;
for (; a < bytes.Length; a++)
{
byte val = bytes[a];
if (val == 34)
break;
if (val - 65 > 25)
{
if (val == 92)
val = 47;
}
else
val += 32;
retHash = (1025 * (retHash + val) >> 6) ^ 1025 * (retHash + val);
}
return 32769 * (9 * retHash ^ (9 * retHash >> 11));
}
not working 
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
modified on Wednesday, February 17, 2010 8:20 AM
|
|
|
|
|
In the original, the code is using textLen, not text.
|
|
|
|
|
When you say "not working" what is not working? Remember, I can't see your screen, just what you tell me.
Check your logic - I notice that your loop is different from the C++ version which misses the first char if the string starts with '"' - yours ends the loop when it meets the first '"'. And please, don't use "magic numbers" - they make code really difficult to follow and maintain.You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
|
|
|
|
|
not working mean, it suppose to return D18AA035 for B5_CUT2_1 but its returning 334A644A
OriginalGriff wrote: Check your logic - I notice that your loop is different from the C++ version which misses the first char if the string starts with '"' - yours ends the loop when it meets the first '"'.
I modified the code
OriginalGriff wrote: And please, don't use "magic numbers" - they make code really difficult to follow and maintain.
where ??
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
modified on Wednesday, February 17, 2010 8:16 AM
|
|
|
|
|
Xmen W.K. wrote: OriginalGriff wrote:
And please, don't use "magic numbers" - they make code really difficult to follow and maintain.
where ??
public static uint CRCRC(string text)
{
uint retHash = 0;
int a = 0;
byte[] bytes = System.Text.Encoding.ASCII.GetBytes(text);
if (bytes[0] == 34)
a = 1;
for (; a < bytes.Length; a++)
{
byte val = bytes[a];
if (val == 34)
break;
if (val - 65 > 25)
{
if (val == 92)
val = 47;
}
else
val += 32;
retHash = (1025 * (retHash + val) >> 6) ^ 1025 * (retHash + val);
}
return 32769 * (9 * retHash ^ (9 * retHash >> 11));
}
34, 65, 25, 92, 47, 32 - these are all "magic numbers". Wiki - see Unnamed numerical constants here.[^] So called because they are necessary to the code but there is no explanation as to what the hell they are or do!
Looking at the original C++ code there is also a magic number 32769 - why? Does this have anything to do with the length of an int?
I am not convinced that the original code actually works (or even compiles): what is textLen[i] doing? textLen is a size_t (which is an unsigned int) not an array.
Try this[^] - I don't know that it works, I haven't tried it, but it is at least written in C# and looks like a CRC32 algorithm!You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
|
|
|
|
|
That code is for specific CRC...I dunno why the author did that...I just got the code from a site that says its for that purpose(I need) so I simply tried to convert it to C# but I thought I may did something wrong. Thats why I asked here.
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
| If you have to use this specific code for a specific purpose then the original author is naughty to call it CRC32 if it isn't. The best way to proceed if you have to use this code and no other is to compile the C++ code into a managed DLL and include that assembly in your C# code - then it will only generate the wrong results if the original code is wrong as well! You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
|
|
|
|
|
yupp I thought of that...but now I got the bug in the written code (C++). So all working fine now.
Btw, I can see somebody voted you 1. It wasn't me
Anyway, thanks for your time buddy. Have a nice day 
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
Xmen W.K. wrote: So all working fine now
Glad to hear it!
Xmen W.K. wrote: Btw, I can see somebody voted you 1. It wasn't me
Didn't think it was - it's just an idiot you who thinks he's clever - I'm not bothered! 
[edit]Typo as shown[/edit]You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
modified on Thursday, February 18, 2010 8:27 AM
|
|
|
|
|
OriginalGriff wrote: you thinks he's clever
what made you think like that
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
Sorry about that! Typing error caused by insufficient coffee! Was intended to read "who thinks he's clever" - fixed now.  You should never use standby on an elephant. It always crashes when you lift the ears. - Mark Wallace
C/C++ (I dont see a huge difference between them, and the 'benefits' of C++ are questionable, who needs inheritance when you have copy and paste) - fat_boy
|
|
|
|
|
hehe
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
In your first sample the line
char ctext = textLen[i];
will produce bogus results. I think you mean to select the next character in the text string, the above instruction will pluck some random value from memory.txtspeak is the realm of 9 year old children, not developers. Christian Graus
|
|
|
|
|
|
http://www.codeproject.com/Messages/3371420/Re-Cplusplus-to-CSharp.aspx[^]
TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia> -----------------------------------------------
128 bit encrypted signature, crack if you can
|
|
|
|
|
Hi All,
I am using Asp.Net 2.0 with C#, Crystal Reports(VS 2005). I am trying to open a report by passing 4 parameters but it gives an error called "Object reference not set to an instance of an object.". While I debug, I did not get err at any line. It goes smooth but finally it gives an error. Can you guide me?. Pls find below my code
crvSTT.RefreshReport();
ReportDocument rptDoc = new ReportDocument();
rptDoc.Load(Server.MapPath("Reports/STTCertificateAnnual1.rpt"));
ParameterFields paramFields = new ParameterFields();
ParameterField pfYear = new ParameterField();
ParameterField pfBACode = new ParameterField();
ParameterField pfFromClientCode = new ParameterField();
ParameterField pfToClientCode = new ParameterField();
pfBACode.ParameterFieldName = "pBACode";
ParameterDiscreteValue pdvBACode;
pdvBACode = new ParameterDiscreteValue();
pdvBACode.Value = strUserId;
pfBACode.CurrentValues.Add(pdvBACode);
paramFields.Add(pfBACode);
pfFromClientCode.ParameterFieldName = "pFromClientCode";
ParameterDiscreteValue pdvFromClientCode;
pdvFromClientCode = new ParameterDiscreteValue();
pdvFromClientCode.Value = txtFromCC.Text;
pfFromClientCode.CurrentValues.Add(pdvFromClientCode);
paramFields.Add(pfFromClientCode);
pfToClientCode.ParameterFieldName = "pToClientCode";
ParameterDiscreteValue pdvToClientCode;
pdvToClientCode = new ParameterDiscreteValue();
pdvToClientCode.Value = txtToCC.Text;
pfToClientCode.CurrentValues.Add(pdvToClientCode);
paramFields.Add(pfToClientCode);
pfYear.ParameterFieldName = "pYear";
ParameterDiscreteValue pdvYear;
pdvYear = new ParameterDiscreteValue();
pdvYear.Value = "Current";
pfYear.CurrentValues.Add(pdvYear);
paramFields.Add(pfYear);
crvSTT.ParameterFieldInfo = paramFields;
crvSTT.ReportSource = rp.tDoc;
crvSTT.DataBind();
Thanks in Adv.Balasubramanian K.
|
|
|
|
|
| Your message got posted twice, please delete the previous one. You do not indicate which line of your code gets the error so it is difficult to guess why it is going wrong. Please edit your message to show where the error occurs. txtspeak is the realm of 9 year old children, not developers. Christian Graus
|
|
|
|
|
All of my code lines are getting debug successfully without any error.
But error has been shown at my page by debugging all of my lines. Thanks in adv.Balasubramanian K.
modified on Wednesday, February 17, 2010 7:29 AM
|
|
|
|
|
BalasubramanianK wrote: All of my code lines are getting debug successfully without any error.
But error has been shown at my page by debugging all of my lines. Thanks in adv.
Which of these two statements is true?txtspeak is the realm of 9 year old children, not developers. Christian Graus
|
|
|
|
|
Hi guys,
I am having a few problems reading a line from an XML file on the web somewhere - say http://www.blah.com/myfile.xml - from within a c# application.
I do not even know roughly where to begin in order to read the XML file?
Do I need to download it to my desktop first, and then open it - because of security issues?
A poke in the right direction (or correct functions / concepts to use) would be greatly appreciated!!
Thanks!
Alex
|
|
|
|
|
|
Thank you very much for your help indeed!!
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
