|
First, there is no need to do the copy operation. pdmSecFile.Write((LPCTSTR) pStr, strLine.GetLength() * sizeof(TCHAR)); is sufficient (which also elminates the int totl = line.)
Second, you are writing out the NULL character with totl+1.
Third, the Flush is not needed.
Fourth, ReleaseBuffer is not needed.
Fifth, you should append the char immediately, and then test. Otherwise the last return never gets written.
Sixth, the last line may never get written if it doesn't end in a return.
Seventh, just use CStdioFile and have it read the entire string for you!
|
|
|
|
|
Thanks joe for your comments.
i changed code like this to eliminate char array.
CFile pdmFile;
CFile pdmSecFile;
pdmFile.Open(_T("c:\\strucadv15\\Work\\testpdms\\mod\\testpdms.pdm"),CFile::modeRead);
pdmSecFile.Open(_T("c:\\strucadv15\\Work\\testpdms\\mod\\testpdms_changed.pdm"),CFile::modeCreate | CFile::modeReadWrite);
CString strLinee;
totlen = pdmFile.GetLength();
for(int i = 0; i < totlen; i++)
{
UINT lBytesRead = pdmFile.Read(ch,1);
if(ch[0] == '\n')
{
pdmSecFile.Write(strLinee, strLinee.GetLength());
strLinee.Empty();
}
strLinee.AppendChar(ch[0]);
}
pdmFile.Close();
pdmSecFile.Close();
but still i got the same output like, after every character its appending one NULL
please give me some solution. 
Regards,
Jo
hi
|
|
|
|
|
totlen = pdmFile.GetLength(); <- This gives you no of chars in the file.
So for loop iterates for each char and you are inserting null char: -> strLinee.AppendChar(ch[0]);
You should look for a new line char to get the no of lines in the file.
|
|
|
|
|
Thanks Maya!
what you said is correct...
but i solved that problem in different way, I guess this is the easiest way. any how I am keeping that code here, it will be helpful for others.
I used CStdioFile instead of CFile, that really simplifies my work.
CStdioFile pdmFile;
CStdioFile pdmSecFile;
pdmFile.Open(m_sPdmFileName, CStdioFile::modeRead);
pdmSecFile.Open(_T("testpdms_changed.pdm"),CStdioFile::modeCreate | CStdioFile::modeReadWrite);
CString sKey;
CString sValue;
POSITION pos;
while(pdmFile.ReadString(strLine))
{
pos = mapingStrings.GetStartPosition();
while(pos != NULL)
{
mapingStrings.GetNextAssoc(pos, sKey, sValue);
strLine.Replace(sKey,sValue);
}
pdmSecFile.WriteString(strLine);
pdmSecFile.WriteString(_T("\n"));
}
pdmFile.Close();
pdmSecFile.Close();
Regards,
Jo
hi
|
|
|
|
|
That's not correct. He reads a character at a time and then appends it. The problem is that the concatenation operation is likely creating a UNICODE string.
|
|
|
|
|
Member 4399771 wrote: after every character its appending one NULL
You are writing a UNICODE string to the file. Each AppendChar() converts the character to a UNICODE character and appends it to the string. During your write, you'll also note that only half the string is being written. (CString::GetLength() returns the number of characters, not the number of bytes.)
|
|
|
|
|
hi ..
Use _tcscpy() to copy from CString to TCHAR array;
ex-
CString csMystring = L"Hi all";
TCHAR tchChar[MAX_PATH];
memset(tchChar, 0x00, MAX_PATH);
_tcscpy(tchChar, csMystring);
Hope it will help.
Thanks
MChauhan
|
|
|
|
|
Hello community, ive got a problem i hooked a function that has virtual table inside it and calls other functions:
Decompailed with hex rayz :
signed int __cdecl sub_4594F5()<br />
{<br />
signed int result;
<br />
result = -691773993;<br />
dword_4B0068 = (unsigned int)sub_40511C ^ 0xD6C45DD7;
dword_4B006C = (unsigned int)sub_438213 ^ 0xD6C45DD7;
dword_4B0070 = (unsigned int)sub_424041 ^ 0xD6C45DD7;
dword_4B0074 = (unsigned int)sub_42A4FC ^ 0xD6C45DD7;
dword_4B0078 = (unsigned int)sub_410B73 ^ 0xD6C45DD7;
dword_4B02F8 = (unsigned int)((char *)sub_416A34 + 4) ^ 0xD6C45DD7;
<br />
return result;<br />
}
This is second function from the virtual table that i want to hook
<br />
int (__cdecl* pointermy_sub_438213)(int, int, int, int);<br />
<br />
int __cdecl testmy_sub_438213(int a, int b, int c, int d)<br />
{<br />
<br />
return pointermy_sub_438213(a, b, c, d);<br />
<br />
}
This is the hooked vtable func i used ms detours to hook it :
<br />
int (__cdecl* pPBVTBLsub_4594F5)();<br />
<br />
<br />
int __cdecl myPBVTBLsub_4594F5()<br />
{<br />
<br />
int dword_4B006C;<br />
dword_4B006C = (unsigned int)testmy_sub_438213 ^ 0xD6C45DD7;<br />
<br />
return pPBVTBLsub_4594F5();<br />
}<br />
<br />
So in shortly the testmy_sub_438213 wont get hooked, so anyone knows what im doing wrong or mybe my aproach is false and this way cant be done vtable hooking any input is really welcome.
|
|
|
|
|
Umm - which bit is the function table? (Note - it is NOT a virtual function table - that has a specific meaning, which isn't the one you're using).
I see no function or function calls in sub_4594F5 at all.
Which could be why you can't hook any of them.
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
CodeProject MVP for 2010 - who'd'a thunk it!
|
|
|
|
|
No, no i mean sub_4594F5() is the function that has virtualtable inside it, so i hooked it with micorsoft detours and inside sub_4594F5()i want to do vtable hooking like that
int dword_4B006C;<br />
dword_4B006C = (unsigned int)testmy_sub_438213 ^ 0xD6C45DD7;
But function sub_438213 wont get hooked and that function is second function from the vtable
|
|
|
|
|
That is because testmy_sub_438213 isn't being called! They are XORing its address with 0xD6C45DD7.
There are no function calls there! So there's no way any hooking can intercept any calls.
Java, Basic, who cares - it's all a bunch of tree-hugging hippy cr*p
CodeProject MVP for 2010 - who'd'a thunk it!
|
|
|
|
|
hello
can anyone help me why this takes errors?
#include <stdio.h>
#include<iostream>
#include<list>
#include<iterator>
using namespace std;
class code_ch{
public:
char ch;
int number;
code_ch(){
ch=NULL;
number=0;
}
code_ch(int n,char ach){
ch=ach;
number=n;
}
friend istream &operator >> (istream &is,const code_ch &C){
cin>>C.number>>C.ch;
return is;
}
friend ostream &operator << (ostream &os,const code_ch &C){
cout<<C.ch<<" number="<<C.number;
return os;
}
bool operator < (code_ch &h2){
if(number<h2.number)
return true;
return false;
}
bool operator > (code_ch &h2){
if(number>h2.number)
return true;
return false;
}
bool operator <= (code_ch &h2){
if(number<=h2.number)
return true;
return false;
}
bool operator >= (code_ch &h2){
if(number>=h2.number)
return true;
return false;
}
bool operator == (code_ch &h2){
if(number==h2.number)
return true;
return false;
}
};
int main(int argc,char **argv){
if(argc==1){
cout<<"you haven't entered a file! exiting..."<<endl;
return 1;
}
list<code_ch>w;
int *a=new int [200];//for saving the number of each ch
for(int i=0;i<200;i++)
a[i]=0;
list<code_ch>::iterator l=w.begin();
cout<<"the list is:"<<endl;
copy(l.begin(),l.end(),ostream_iterator<code_ch>(cout," "));
}
and the error:
[sajad@sajad Desktop]$ g++ c++file.cpp
c++file.cpp: In function ‘std::istream& operator>>(std::istream&, const code_ch&)’:
c++file.cpp:19: error: ambiguous overload for ‘operator>>’ in ‘std::cin >> C->code_ch::number’
/usr/lib/gcc/i586-redhat-linux/4.4.0/../../../../include/c++/4.4.0/istream:119: note: candidates are: std::basic_istream<_CharT, _Traits>& std::basic_istream<_CharT, _Traits>::operator>>(std::basic_istream<_CharT, _Traits>& (*)(std::basic_istream<_CharT, _Traits>&)) [with _CharT = char, _Traits = std::char_traits<char>] <near match>
/usr/lib/gcc/i586-redhat-linux/4.4.0/../../../../include/c++/4.4.0/istream:123: note: std::basic_istream<_CharT, _Traits>& std::basic_istream<_CharT, _Traits>::operator>>(std::basic_ios<_CharT, _Traits>& (*)(std::basic_ios<_CharT, _Traits>&)) [with _CharT = char, _Traits = std::char_traits<char>] <near match>
/usr/lib/gcc/i586-redhat-linux/4.4.0/../../../../include/c++/4.4.0/istream:130: note: std::basic_istream<_CharT, _Traits>& std::basic_istream<_CharT, _Traits>::operator>>(std::ios_base& (*)(std::ios_base&)) [with _CharT = char, _Traits = std::char_traits<char>] <near match>
/usr/lib/gcc/i586-redhat-linux/4.4.0/../../../../include/c++/4.4.0/istream:238: note: std::basic_istream<_CharT, _Traits>& std::basic_istream<_CharT, _Traits>::operator>>(std::basic_streambuf<_CharT, _Traits>*) [with _CharT = char, _Traits = std::char_traits<char>] <near match>
c++file.cpp: In function ‘int main(int, char**)’:
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘begin’
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘end’
|
|
|
|
|
This isn't the problem you are asking about, but shouldn't your operator >> and operator << be using the stream passed to it as an argument instead of using cin/cout?
|
|
|
|
|
if you mean this yet the same error:
friend istream &operator >> (istream &is,const code_ch &C){
is>>C.number>>C.ch;
return is;
}
friend ostream &operator << (ostream &os,const code_ch &C){
os<<C.ch<<" number="<<C.number;
return os;
}
or :
<code><br />
friend istream &operator >> (istream &is,const code_ch &C){<br />
return is>>C.number>>C.ch; <br />
}<br />
<br />
friend ostream &operator << (ostream &os,const code_ch &C){<br />
<br />
return os<<C.ch<<" number="<<C.number;<br />
}<br />
<code>
|
|
|
|
|
Yes, that is what I was meant. As I said, it wasn't the problem that you were asking about, so it doesn't surprise me that it gives you the same error message. It was still a problem.
I just spotted something.
khomeyni wrote:
friend istream &operator >> ( istream &is, const code_ch &C )
{
is >> C.number >> C.ch;
return is;
}
This function changes the code_ch object passed to it. So the parameter can not be const.
|
|
|
|
|
ok thanks it solve my first problem but yet:
[sajad@sajad Desktop]$ g++ c++file.cpp
c++file.cpp: In function ‘int main(int, char**)’:
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘begin’
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘end’
|
|
|
|
|
oh sorry ,it is a part of huge program so i only copy it and no member is in the list.but when i fix it and add:
for(int i=0;i<10;i++){
code_ch *h=new code_ch;
h->number=i;
h->ch='1';
w.push_front(*h);
}
or :
code_ch H;
H.number=10;
H.ch='k';
w.push_front(H);
yet the same problem.
|
|
|
|
|
True, you still have this problem. Why don't you take a closer look at it.
khomeyni wrote:
int main(int argc,char **argv)
{
if(argc==1)
{
cout<<"you haven't entered a file! exiting..."<<endl;
return 1;
}
list<code_ch>w;
int *a=new int [200];
for(int i=0;i<200;i++)
a[i]=0;
list<code_ch>::iterator l=w.begin();
cout<<"the list is:"<<endl;
copy(l.begin(),l.end(),ostream_iterator<code_ch>(cout," "));
}
;
And your error message was:
khomeyni wrote: c++file.cpp: In function ‘int main(int, char**)’:
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘begin’
c++file.cpp:66: error: ‘struct std::_List_iterator<code_ch>’ has no member named ‘end’
That says that your iterator does not have a begin or end member. It is right, iterators don't. What does have a begin and end? What is it that you want to be copying from?
You should be able to get it from here.
|
|
|
|
|
if you mean this?
adding this in the main:
for(int i=0;i<10;i++){
code_ch *h=new code_ch;
h->number=i;
h->ch='1';
w.push_front(*h);
}
or :
code_ch H;
H.number=10;
H.ch='k';
w.push_front(H);
yet the same problem.
|
|
|
|
|
No, I don't mean that.
Play closer attention to the error message and the line it is referring to. It is telling you what the problem is and where it is. Go over each part of that line and look for a difference between what you intended and what you wrote.
|
|
|
|
|
i can not understand:
even for this does not work:
list<int> PL;
PL.push_front(100);
list<int>::iterator p=PL.begin();
copy(p.begin(),p.end(),ostream_iterator<int>(cout," "));
cout<<endl;
while in another where i wrote:
list<code_ch>::iterator p=t.begin();
int i=0;
while(p!=t.end()){
heap[i]=*p;
p++;
i++;
heapsize++;
}
//part of a program
and correctly works.
does list has not such ability to iterate over list elements as i want to do?
|
|
|
|
|
ok i must write:
copy(x.begin(),w.end(),ostr.....)
very simple error and stupidly error !!!
thanks.
|
|
|
|
|
Good. You got it.
Though of course its:
copy(w.begin(),w.end(),ostr.....)
|
|
|
|
|
I know it's a little more than a little funny  but I don't know how some process have the user name SYSTEM within the window task manager while they are not a system process. E.g some anti viruses and ...
|
|
|
|
|
SYSTEM is a user in the Windows system that has a different set of privileges than the interactive user.
This name of the user does not mean it only runs system processes.
For example, most of the services that you create are run in the SYSTEM user context.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
