Re: SqlServerCeException "There was an error parsing the query" help .... - C# Discussion Boards

Henry Minute1-Oct-09 10:50

1-Oct-09 10:50

This is not an answer to your question, mainly because I have too much difficulty in reading your code, to be able to spot any problems. If you enclose your code in <pre>your code</pre> tags it will be much, much easier to read. The PRE tags maintain the formatting and colourize the code.

You state that

waqasm wrote:
Im an extremely new programmer

,
so you have not yet had some bad habits ingrained. Before it becomes too late, each time that you add a Control to a Form give it a name that reflects what it does, e.g. validationButton instead of leaving it as button1, do this immediately after adding it, before you do anything else like writing a click handler. That way, in six months time, when you look at your code again, you will not be forever thinking, "now what on earth did button1 or textBox1 do?" Some people put the control type first - validationButton would be buttonValidation for them. I use a similar scheme to that except I have, over the years, evolved a set of abbreviations for the controls - 'btn' for a Button, 'txt' for a TextBox, 'lbl' for a Label, 'cbox' for a ComboBox, 'lbox' for a ListBox and so on, so for me it would be btnValidation. Devise whatever you feel comfortable with, but please, please don't just leave them as button1, button2 and so on. Smile | :)

Henry Minute

Do not read medical books! You could die of a misprint. - Mark Twain
Girl: (staring) "Why do you need an icy cucumber?"
“I want to report a fraud. The government is lying to us all.”

Re: XML, XSD VALIDATION

waqasm1-Oct-09 11:09

waqasm

1-Oct-09 11:09

Thanks Mr Minute for your response. I will keep that in mind for sure.

So i tried debugging my code, and I notice that the code does not go anywhere once I click on the validate button. Meaning it does not go to the validate function. It shows me error as follows "Illegal character paths"
I think the problem is with this function paramters "ValidateXML(strXML, strXSD, "urn:bookstore-schema");"

using System.Collections.Generic;
using System.Text;
using System.Windows.Forms;
using System;
using System.Collections;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.IO;
using System.Xml;
using System.Xml.Schema;

//void ValidateXML(string strXML,string strXSD,string strXSDNS)
namespace ValidateXML
{
      
    public partial class Form1 : Form
    
      {
         
        public Form1()
        {
        InitializeComponent();
        }
                
       string strXML; //- In put XML file
       string strXSD; //- In put XSD file
       string strXSDNS;

        void ValidateXML(string strXML, string strXSD, string strXSDNS)
        {
            
            //Create a XmlValidatingReader, XmlSchemaCollection and ValidationEventHandler objects to be used to validate the XML against an XSD file
           //XmlValidatingReader r = XmlValidatingReader.Create;
            
            XmlValidatingReader reader = null;
            XmlSchemaCollection myschema = new XmlSchemaCollection();
            //ValidationEventHandler eventHandler = new ValidationEventHandler(ShowCompileErrors);
            //string strXML = null;
            //string strXSD = null;
            
            try
            {
                //Create the XML fragment to be parsed.
                //strXML = "C:/Umar/1234_H1N1_00002.xml";
                //doc.Load("C:/Umar/1234_H1N1_00002.xml");

                StreamReader streamReader = new StreamReader("C:/Umar/1234_H1N1_00002.xml");
                strXML = streamReader.ReadToEnd();
                streamReader.Close();

                StreamReader streamReader1 = new StreamReader("C:/Umar/H1N1_Schema.xsd");
                strXSD = streamReader1.ReadToEnd();
                streamReader.Close();
                                                  
                XmlDocument doc = new XmlDocument();
                doc.Load(strXML);
                string xmlFrag = doc.InnerXml;
                           
                //Create an XmlParserContext object for use with the XMLValidatingReader:
                //String xmlFrag = "<author  xmlns='urn:bookstore-schema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'>" +
                // "<first-name>Herman</first-name>" +
                // "<last-name>Melville</last-name>" +
                //"</author>";
                //Create the XmlParserContext.
              
                XmlParserContext context = new XmlParserContext(null, null, "", XmlSpace.None);

                //Implement the reader. 
                reader = new XmlValidatingReader(xmlFrag, XmlNodeType.Element, context);

                // Add the relevant schema files (.XSD) to the name space we are checking
                //against and repeat until all the schema's have an associated XSD file with them.

                //Add the schema.
                myschema.Add(strXSD, strXSD);

                //Set the schema type and add the schema to the reader.
                reader.ValidationType = ValidationType.Schema;
                reader.Schemas.Add(myschema);
                // Read in the XML Data:
                
                while (reader.Read())
                {

                }
               
              //If there is no exception, display "Completed Validating" or return a value indicating success

                output.Text = "Completed validating " + strXML;
                
            }
            //Watch out for exceptions within the XML file and display them appropriately to the user:

            catch (XmlException XmlExp)
            {
                output.Text = "XMLException " + XmlExp.Message;
            }

           //XMLSchemaExceptions are thrown when the XML document does not match the schema provided.

            catch (XmlSchemaException XmlSchExp)
            {
                output.Text = "XMLSchemaException " + XmlSchExp.Message;
            }

            //Catch all other exceptions and report them to the user:

            catch (Exception GenExp)
           {
                output.Text = "Exception " + GenExp.Message;
           }
      }
          
       private void btn_Validate_Click(object sender, EventArgs e)
        {
            String a = null;
            String b = null; 
            if (txt_inputXML.Text == String.Empty)
            {
                output.Text = ("Warning: Upload a XML file");
            }
            else if (txt_inputXSD.Text == String.Empty)
            {
                output.Text = ("Warning: Upload a XSD File");
            }
            
            else
            {
                output.Text = "yoo";
                ValidateXML(strXML, strXSD, "urn:bookstore-schema");
                
               
            }
        }

     private void btn_BrowseXML_Click(object sender, EventArgs e)
        {
            //outputtext.Text = "";
            // Create an OpenFileDialog object.
            OpenFileDialog openFile1 = new OpenFileDialog();
            // Initialize the OpenFileDialog to look for text files.
            openFile1.Filter = "(*.xml)|*.xml";

          if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                txt_inputXML.Text = openFile1.FileName;
            }
        }

        private void btn_BrowseXSD_Click(object sender, EventArgs e)
        {
            //outputtext.Text = "";
            // Create an OpenFileDialog object.
            OpenFileDialog openFile1 = new OpenFileDialog();

            // Initialize the OpenFileDialog to look for text files.
            openFile1.Filter = "(*.xsd)|*.xsd";

            if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)

                txt_inputXSD.Text = openFile1.FileName;
        }    
    }
}

Re: XML, XSD VALIDATION

Henry Minute1-Oct-09 11:48

Henry Minute

1-Oct-09 11:48

waqasm wrote:
I think the problem is with this function paramters "ValidateXML(strXML, strXSD, "urn:bookstore-schema");"

I can see nothing wrong with that line as such.

However, there are two things that I have spotted in your ValidateXML method.

The

//Add the schema.
myschema.Add(strXSD, strXSD);

line is incorrect. It uses strXSD ("urn:bookstore-schema") for both parameters, strXSD is the namespace to use. The second parameter should be the URL of the file containing the schema to use.

Secondly you should not be using XmlSchemaCollection as it is Obsolete unless you are using .Net 1.0 or 1.1.
It will still work but you should really be using XmlSchemaSet instead.

Re: XML, XSD VALIDATION

waqasm2-Oct-09 3:56

waqasm

2-Oct-09 3:56

Hey,
I fixed what you had asked me to fix. But i am getting this error in my output box. "Exception Illegal characters in path."

using System.Collections.Generic;
using System.Text;
using System.Windows.Forms;
using System;
using System.Collections;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.IO;
using System.Xml;
using System.Xml.Schema;

//void ValidateXML(string strXML,string strXSD,string strXSDNS)
namespace ValidateXML
{
      
    public partial class Form1 : Form
    
      {
         
        public Form1()
        {
        InitializeComponent();
        }
                
       string strXML; //- In put XML file
       string strXSD; //- In put XSD file
       string strXSDNS;

        void ValidateXML(string strXML, string strXSD, string strXSDNS)
        {
            
            //Create a XmlValidatingReader, XmlSchemaCollection and ValidationEventHandler objects to be used to validate the XML against an XSD file
           
            
            XmlValidatingReader reader = null;
            //XmlSchemaCollection myschema = new XmlSchemaCollection();
            XmlSchemaSet myschema = new XmlSchemaSet();
            ValidationEventHandler eventHandler = new ValidationEventHandler(ShowCompileErrors);
                        
            try
            {
                
                                                  
                XmlDocument doc = new XmlDocument();
                doc.Load(strXML);
                string xmlFrag = doc.InnerXml;
                           
                //Create an XmlParserContext object for use with the XMLValidatingReader:
                //String xmlFrag = "<author  xmlns='urn:bookstore-schema' xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance'>" +
                // "<first-name>Herman</first-name>" +
                // "<last-name>Melville</last-name>" +
                //"</author>";
                //Create the XmlParserContext.
              
                XmlParserContext context = new XmlParserContext(null, null, "", XmlSpace.None);

                //Implement the reader. 
                reader = new XmlValidatingReader(xmlFrag, XmlNodeType.Element, context);

                // Add the relevant schema files (.XSD) to the name space we are checking
                //against and repeat until all the schema's have an associated XSD file with them.

                //Add the schema.
                //myschema.Add(strXSD, strXSD);
                myschema.Add(strXSD, "C:/Umar/C:/Umar/H1N1_Schema.xsd");
                //Set the schema type and add the schema to the reader.
                reader.ValidationType = ValidationType.Schema;
                reader.Schemas.Add(myschema);
                // Read in the XML Data:
                
                while (reader.Read())
                {

                }
               
              //If there is no exception, display "Completed Validating" or return a value indicating success

                output.Text = "Completed validating " + strXML;
                
            }
            //Watch out for exceptions within the XML file and display them appropriately to the user:

            catch (XmlException XmlExp)
            {
                output.Text = "XMLException " + XmlExp.Message;
            }

           //XMLSchemaExceptions are thrown when the XML document does not match the schema provided.

            catch (XmlSchemaException XmlSchExp)
            {
                output.Text = "XMLSchemaException " + XmlSchExp.Message;
            }

            //Catch all other exceptions and report them to the user:

            catch (Exception GenExp)
           {
                output.Text = "Exception " + GenExp.Message;
           }
      }
          
       private void button1_Click(object sender, EventArgs e)
        {
            String a = null;
            String b = null; 
            if (txt_inputXML.Text == String.Empty)
            {
                output.Text = ("Warning: Upload a XML file");
            }
            else if (txt_inputXSD.Text == String.Empty)
            {
                output.Text = ("Warning: Upload a XSD File");
            }
            
            else
            {
                output.Text = "yoo";
               ValidateXML(strXML, strXSD, "urn:bookstore-schema");
               /// ValidateXML(strXML, strXSD, "C:/Umar/H1N1_Schema.xsd");
               
            }
        }

     private void button2_Click(object sender, EventArgs e)
        {
            //outputtext.Text = "";
            // Create an OpenFileDialog object.
            OpenFileDialog openFile1 = new OpenFileDialog();
            // Initialize the OpenFileDialog to look for text files.
            openFile1.Filter = "(*.xml)|*.xml";

          if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                txt_inputXML.Text = openFile1.FileName;
            }
        }

        private void button3_Click(object sender, EventArgs e)
        {
            //outputtext.Text = "";
            // Create an OpenFileDialog object.
            OpenFileDialog openFile1 = new OpenFileDialog();

            // Initialize the OpenFileDialog to look for text files.
            openFile1.Filter = "(*.xsd)|*.xsd";

            if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)

                txt_inputXSD.Text = openFile1.FileName;
        }    
    }
}

ps. I was told that this website has tons of experienced programmers?? Why is there only one person helping me out Confused | :confused:

Re: XML, XSD VALIDATION

Henry Minute2-Oct-09 5:29

Henry Minute

2-Oct-09 5:29

There is one obvious line in your code, that might be causing your exception:

myschema.Add(strXSD, "C:/Umar/C:/Umar/H1N1_Schema.xsd");

What is "C:/Umar/C:/Umar/H1N1_Schema.xsd"?

If it is supposed to be "C:\Umar\H1N1_Schema.xsd", then try:

myschema.Add(strXSD, @"C:\Umar\H1N1_Schema.xsd");

waqasm wrote:
ps. I was told that this website has tons of experienced programmers?? Why is there only one person helping me out

This site does indeed have lots of experienced programmers. All of us help out, when we can, on a voluntary basis. On problems that interest us, for people who give full information about the problems they are having. Little things like what line in the code the error occurs on. Also, in general they do not like to interrupt, unless they see some obviously bad advice.

So, if you do not like the help that you are getting, for free, please feel free to ask elsewhere. If you do, however, I would suggest that you learn to use the debugger, which for all of your problems would have helped you to identify the problems for yourself, and include the information in your question.

Re: XML, XSD VALIDATION

waqasm7-Oct-09 6:14

waqasm

7-Oct-09 6:14

Yes, I know the help here is for free. But im sure that everyone benefits from knowledge, whether they are helping someone or being helped. I did manage to use the debugger, so thank you for your professional advice.

Anyhow, the code is finished so anyone having trouble with what I'm doing can benefit from my code.

using System.Collections.Generic;
using System.Text;
using System.Windows.Forms;
using System;
using System.Collections;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.IO;
using System.Xml;
using System.Xml.Schema;

namespace ValidateXML
    
{
    public partial class Form1 : Form    
   {
        public Form1()
        
        {
            InitializeComponent();
          
        }

        string strXML; 
        string strXSD;  
      //  string strXSDNS;
       
   
  private void button1_Click(object sender, EventArgs e)
        
   {
            if (txt_inputXML.Text == String.Empty)

            {
                output.Text = ("Warning: Upload a XML file");
            }

            else if (txt_inputXSD.Text == String.Empty)
            {
                output.Text = ("Warning: Upload a XSD File");
            }

            else
                
            {                             
                strXML = txt_inputXML.Text;
                strXSD = txt_inputXSD.Text;
                //XmlReader reader = null;
                //XmlSchemaSet myschema = new XmlSchemaSet();
                XmlValidatingReader reader = null;
               
                XmlSchemaCollection myschema = new XmlSchemaCollection();
                //ValidationEventHandler EventHandler = new ValidationEventHandler();
                //XmlValidatingReader reader = new XmlValidatingReader(reader);
                //XmlSchemaTotalDigitsFacet reader1 = new XmlSchemaTotalDigitsFacet(output);

                try
               {

                   XmlDocument doc = new XmlDocument();
                   doc.Load(strXML);
                   string xmlFrag = doc.InnerXml;
                   XmlParserContext context = new XmlParserContext(null, null, "", XmlSpace.None);
                  
                   reader = new XmlValidatingReader(xmlFrag, XmlNodeType.Element, context);
                   reader.ValidationType = ValidationType.Schema;


                   //myschema.Add(strXSD, @"C:\Umar\H1N1_Schema.xsd");
                   myschema.Add("http://tempuri.org/dsMinistryH1N1Export.xsd", strXSD);

                   //***reader.ValidationType = ValidationType.Schema; 
                   
                   //myschema.Add(null, reader);
                   reader.Schemas.Add(myschema);
                 
                    
                    //***myschema.Add("H1N1_Schema.xsd", @"C:\Umar\H1N1_Schema.xsd");
                   //reader.ValidationEventHandler += new ValidationEventHandler(ValidationError);

                   while (reader.Read())
                   {

                   }

                   output.Text = ("Completed validating " + strXML);
               }

               catch (XmlException XmlExp)
               {
                   output.Text = ("XMLException " + XmlExp.Message);
               }

               catch (XmlSchemaException XmlSchExp)
               {
                   output.Text = ("XMLSchemaException " + XmlSchExp.Message);
               }

               //Catch all other exceptions and report them to the user: 
               catch (Exception GenExp)
               {
                   output.Text = ("Exception " + GenExp.Message);
               } 
            }

        }
               
        private void button2_Click(object sender, EventArgs e)
        
       {        
            OpenFileDialog openFile1 = new OpenFileDialog();
            openFile1.Filter = "(*.xml)|*.xml";
            if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                txt_inputXML.Text = openFile1.FileName;
            }
       }

        private void button3_Click(object sender, EventArgs e)
        
       {
            
            OpenFileDialog openFile1 = new OpenFileDialog();
            openFile1.Filter = "(*.xsd)|*.xsd";
            if (openFile1.ShowDialog() == System.Windows.Forms.DialogResult.OK)
            {
                txt_inputXSD.Text = openFile1.FileName;
            }
       }
    }
}

SqlServerCeException "There was an error parsing the query" help ....

hande541-Oct-09 6:22

hande54

1-Oct-09 6:22

SqlCeConnection SqlCeConn = new SqlCeConnection(Information.ConnectionString);

SqlCeCommand SqlCeComm = new
SqlCeCommand("SELECT * FROM SystemUsers ", SqlCeConn);

try
{
if (SqlCeConn.State == ConnectionState.Closed)
SqlCeConn.Open();

SqlCeDataReader SqlRd = SqlCeComm.ExecuteReader();

if (SqlRd.Read()==true){}
when I run this code I get the error below. I could not find the reason behind it. I found that IF the query is wrong this type of error could occur but my query is totally works fine.

There was an error parsing the query. [ Token line number = 1,Token line offset = 8,Token in error = , ]

Re: SqlServerCeException "There was an error parsing the query" help ....

Md. Marufuzzaman1-Oct-09 7:07

Md. Marufuzzaman

1-Oct-09 7:07

try the following...

<code>
public string ExecuteScalar(string strConnectionSring, string strScript)
            {
                  SqlConnection ObjSqlConnection = null;
                  SqlCommand ObjSqlCommand = null;
                  ObjSqlConnection = new SqlConnection(strConnectionSring);
                  string strMessage = null;

                  try
                  {
                        ObjSqlCommand = new SqlCommand(strScript, ObjSqlConnection);
                        ObjSqlConnection.Open();
                        ObjSqlCommand.ExecuteScalar();
                        strMessage = "Succes";
                  }
                  catch (Exception ex)
                  {

                        strMessage = ex.Message.ToString();
                  }
                  finally
                  {
                        ObjSqlConnection.Close();
                        ObjSqlCommand = null;
                        ObjSqlConnection = null;
                        strScript = null;

                  }
                  return strMessage;
            }</code>

I will not say I have failed 1000 times; I will say that I have discovered 1000 ways that can cause failure – Thomas Edison.

Don't forget to click [Vote] / [Good Answer] on the post(s) that helped you.

Thanks
Md. Marufuzzaman

Re: SqlServerCeException "There was an error parsing the query" help ....

hande541-Oct-09 7:57

hande54

1-Oct-09 7:57

Thanks for your help. You saved my life Smile | :)

. I have tried it and it has worked fine. Moreover could you explain how I can fetch the query result ?

Re: SqlServerCeException "There was an error parsing the query" help ....

Md. Marufuzzaman1-Oct-09 8:29

Md. Marufuzzaman

1-Oct-09 8:29

You are most welcome... Smile | :)

Well.... You just need to use dataset to fetch query results.... Thumbs Up | :thumbsup:

I will not say I have failed 1000 times; I will say that I have discovered 1000 ways that can cause failure – Thomas Edison.

Don't forget to click [Vote] / [Good Answer] on the post(s) that helped you.

Thanks
Md. Marufuzzaman

Re: SqlServerCeException "There was an error parsing the query" help ....

hande541-Oct-09 8:50

hande54

1-Oct-09 8:50

I have no idea about dataset Frown | :(

could yo explain it ?

however I tried SqlCeDataReader SqlRd= ObjSqlCeCommand.ExecuteReader(); instead of ObjSqlCeCommand.ExecuteScalar();

and to check if result row number > 0 I used "if (SqlRd.Read() == true)" conditional check. Unfortunately It does not works for query string "SELECT Username, Name, Surname FROM SystemUsers where Username =' " + input + "' and Password = '" +passwd +"'"; there must be one row as a result but It does not return any thing. do you have any idea ?

Re: SqlServerCeException "There was an error parsing the query" help ....

Abhishek Sur1-Oct-09 10:31

Abhishek Sur

1-Oct-09 10:31

use this :

SqlCeDataReader reader; 
  using (reader = ObjSqlCeCommand.ExecuteReader()) 
  {  
      while(reader.Read())
      {
         // Read using reader(0) reader(1)  ... 
      }
  }

Abhishek Sur

My Latest Articles
Create CLR objects in SQL Server 2005
C# Uncommon Keywords
Read/Write Excel using OleDB
Don't forget to click "Good Answer" if you like to.

Re: SqlServerCeException "There was an error parsing the query" help ....

hande541-Oct-09 10:33

hande54

1-Oct-09 10:33

thank you very much Smile | :)

Re: SqlServerCeException "There was an error parsing the query" help ....

Md. Marufuzzaman1-Oct-09 20:15

Md. Marufuzzaman

1-Oct-09 20:15

SqlCommand..::.ExecuteScalar Method:
Executes the query, and returns the first column of the first row in the result set returned by the query. Additional columns or rows are ignored.

SqlCommand.ExecuteReader Method:
Sends the CommandText to the Connection and builds a SqlDataReader.

Dataset:
http://msdn.microsoft.com/en-us/library/system.data.dataset.aspx

I will not say I have failed 1000 times; I will say that I have discovered 1000 ways that can cause failure – Thomas Edison.

Don't forget to click [Vote] / [Good Answer] on the post(s) that helped you.

Thanks
Md. Marufuzzaman

socket problem: works in visual studio, not as release

TimWallace1-Oct-09 5:49

TimWallace

1-Oct-09 5:49

I am developing an application in which a connection to a server application on another computer within our network is established. I am using a System.Net.Sockets.Socket to establish the connection to said server app. Upon successfully connecting to the server app, I send a connect message with the login credentials the user provided. In response, the server app should send back a message to indicate a successful or unsuccessful login. My problem is this: when running from within the Visual Studio development, it works flawlessly. When I launch the executable directly, I do not receive the return message from the server app. Any ideas?

Re: socket problem: works in visual studio, not as release

Luc Pattyn1-Oct-09 6:22

Luc Pattyn

1-Oct-09 6:22

Do you log all exceptions? What are the symptoms other than "it does not work"?
Maybe you gave VS a permanent green light in your firewall, and it is blocking your app outside VS?

Smile | :)

Luc Pattyn

Local announcement (Antwerp region): Lange Wapper? Neen!

Re: socket problem: works in visual studio, not as release

TimWallace1-Oct-09 6:56

TimWallace

1-Oct-09 6:56

Luc:

No firewalls are on between "here" and "there". No exceptions are being thrown. The server application is logging the receipt of the message from the client application.

Re: socket problem: works in visual studio, not as release

Luc Pattyn1-Oct-09 7:09

Luc Pattyn

1-Oct-09 7:09

Odd. Did you try debug build running inside VS? release build running inside VS? debug build double-clicked in bin\debug folder? release build double-clicked in bin\release folder?

the difference would be optimizations (timing difference or bugs), and error handling (VS settings influence some).

Do you use time-outs? with sufficient value? and failures get logged? or is the client hanging, waiting on a reply?

Smile | :)

Luc Pattyn

Local announcement (Antwerp region): Lange Wapper? Neen!

[SOLVED] Re: socket problem: works in visual studio, not as release

TimWallace1-Oct-09 8:34

TimWallace

1-Oct-09 8:34

Luc:

There was one point where I was missing code in a catch statement. That was the exception that was getting thrown. After I added code to handle that exception, I discovered that the problem was stemming from a difference in the amount of data included in the message sent from my Test tier versus my local tier. Due to this size difference, a flaw in my received handler was being tripped. Fixed my code and everything works as expected.

Thanks for your question about exceptions. If forced me to go back and check all of my catch statements.

Tim

Re: [SOLVED] Re: socket problem: works in visual studio, not as release

Luc Pattyn1-Oct-09 8:41

Luc Pattyn

1-Oct-09 8:41

yep. catching and somehow showing all exceptions is a powerful technique.

whenever I see an empty catch statement (and that is quite frequently around here, some people think it is wise to skip or postpone error handling), I make sure the perpetrator will not forget about it any time soon ...

Smile | :)

Luc Pattyn

Local announcement (Antwerp region): Lange Wapper? Neen!

Method not calculating properly‏

Marcus Farrugia1-Oct-09 5:09

Marcus Farrugia

1-Oct-09 5:09

Hi, I'm creating an asp.net Pizza order form using c# for a night school course and I have a RadioButtonList for the Size of the pizza and a checkbox list for the Pizza Toppings. Both controls have autopostback enabled so that as a size is selected and a topping is added the Total Price label will automatically calculate the total price and size is selected and toppings added. I have a simple method that adds the ingredients price to the size price as selctions are made. The problem is that the value of the Total Price changes as selections are made to the size (2,4,6,8,10) but if a topping is selected then the value of the total price doesn't add the size price to the toppings price they are still calculated individually, can someone tell from my code how i can write and use my method to total the size price with the topping price? thanks in advance.

<br />
public partial class _Default : System.Web.UI.Page <br />
{<br />
    decimal TotalPrice = 0;<br />
    decimal IngredientsPrice = 0;<br />
    decimal SizePrice = 0;<br />
<br />
    private decimal MethodTotalPrice(decimal MethodIngredientsPrice,<br />
        decimal MethodSizePrice)<br />
    {<br />
        decimal MethodTotalPrice;<br />
        MethodTotalPrice = MethodIngredientsPrice + MethodSizePrice;<br />
        return MethodTotalPrice;<br />
    }<br />
<br />
    protected void Page_Load(object sender, EventArgs e)<br />
    {<br />
        <br />
    }<br />
    protected void RadioButtonList1_SelectedIndexChanged1(object sender, EventArgs e)<br />
    {<br />
        lblSize.Text = rblSize.SelectedItem.Text;<br />
<br />
        if (rblSize.SelectedValue == "Slice")<br />
        {<br />
            lblSize.Font.Size = 8;<br />
            SizePrice = 2;<br />
        }<br />
        if (rblSize.SelectedValue == "Small")<br />
        {<br />
            lblSize.Font.Size = 10;<br />
            SizePrice = 4;<br />
        }<br />
        if (rblSize.SelectedValue == "Medium")<br />
        {<br />
            lblSize.Font.Size = 12;<br />
            SizePrice = SizePrice + 6;<br />
        }<br />
        if (rblSize.SelectedValue == "Large")<br />
        {<br />
            lblSize.Font.Size = 14;<br />
            SizePrice = 8;<br />
        }<br />
        if (rblSize.SelectedValue == "Xtra Large")<br />
        {<br />
            lblSize.Font.Size = 16;<br />
            SizePrice = 10;<br />
        }<br />
        TotalPrice = MethodTotalPrice(IngredientsPrice, SizePrice);<br />
        lblPriceTotal.Text = TotalPrice.ToString();<br />
    }<br />
    protected void cblIngredients_SelectedIndexChanged(object sender, EventArgs e)<br />
    {<br />
        string Message;<br />
        Message = "";<br />
        for (int i = 0; i < cblIngredients.Items.Count; i++)<br />
        {<br />
            if (cblIngredients.Items[i].Selected)<br />
            {<br />
                Message = Message + cblIngredients.Items[i].Text + "<br>";<br />
                IngredientsPrice = IngredientsPrice + 1;<br />
            }<br />
        }<br />
        lblIngredients.Text = Convert.ToString(Message);<br />
        TotalPrice = MethodTotalPrice(IngredientsPrice, SizePrice);<br />
        lblPriceTotal.Text = TotalPrice.ToString();<br />
    }<br />
}<br />

Re: Method not calculating properly‏ [modified]

harold aptroot1-Oct-09 5:22

harold aptroot

1-Oct-09 5:22

Marcus Farrugia wrote:
SizePrice = SizePrice + 6;

Probably not intended
I mean, if you switch from Xtra large to medium, you're suddenly paying 16, right?

Marcus Farrugia wrote:
IngredientsPrice = IngredientsPrice + 1;

AKA IngredientsPrice++, just a style thing though. More important is that you don't reset it. It will just keep going up. That is not good.

Concatting "many" strings using the + operator is poor form, better use a StringBuilder, but that's not causing your problem.

Marcus Farrugia wrote:
MethodTotalPrice = MethodIngredientsPrice + MethodSizePrice;

Surprising calculation, but if it's supposed to work that way...

edit: D'Oh! | :doh:

right ASP.NET. Ok ignore this post. Why do people just keep posting ASP.NET questions here instead of at the ASP.NET forum?

Last modified: 45mins after originally posted --

Re: Method not calculating properly‏

PIEBALDconsult1-Oct-09 15:31

PIEBALDconsult

1-Oct-09 15:31

harold aptroot wrote:
Why do people just keep posting ASP.NET questions here

For the same reason they keep advertising ASP.net jobs as C# jobs. Roll eyes | :rolleyes:

Re: Method not calculating properly‏

Luc Pattyn1-Oct-09 5:34

Luc Pattyn

1-Oct-09 5:34

Hi,

When one choice changes, how are you going to keep the result from another choice made earlier? The page reloads, doesn't it? With new variables, initialized at zero?

the easiest and safest way is to calculate total prize in a separate method that collects all required data;
then invoke that method from within all your Changed handlers. So every change recalculates the total price.

Smile | :)

Luc Pattyn

Local announcement (Antwerp region): Lange Wapper? Neen!

Re: Method not calculating properly‏

J4amieC1-Oct-09 6:32

J4amieC

1-Oct-09 6:32

Well your code is a bit of a mess. As Luc has pointed out, ASP.NET will reset each of those class variables to zero on postback. There is the option of persisting values between postbacks but a more elegant solution would be to calculate the price whenever you need it.

I would approach this as follows, start with a method to do the actual proce calculation

private decimal CalculatePrice()
{
  decimal sizePrice = 0;
  switch(rblSize.SelectedValue)
  {
    case "Slice": sizePrice = 8;break;
    case "Small": sizePrice = 10;break;
    // -- etc.
  }

  decimal ingredientsPrice = 0;
  for (int i = 0; i < cblIngredients.Items.Count; i++)
  {
    if (cblIngredients.Items[i].Selected)
    {
      ingredientsPrice ++;
    }
  }

  return sizePrice + ingredientsPrice ;
}

Next have this method called when either action is performed

protected void RadioButtonList1_SelectedIndexChanged1(object sender, EventArgs e)
{
  decimal totalPrice = CalculatePrice();
  lblPriceTotal.Text = totalPrice.ToString();
)

protected void cblIngredients_SelectedIndexChanged(object sender, EventArgs e)
{
  decimal totalPrice = CalculatePrice();
  lblPriceTotal.Text = totalPrice.ToString();
}

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.