C / C++ / MFC

mass85 wrote:

There are no uninitialized variables in this block of code. I don't think there are any in whole program.

mass85 wrote:

I can't understand how uninitialized variables could result in such a behaviour of program.

void BEload::execute(){
	MSDU *msdu = new MSDU();
	msdu->ac = 2;
	msdu->type = DATA;
	msdu->arrivalTime = msdu->staArrivalTime = clock;
	msdu->id = id++;
	double temp = generator.getUpLinkRandom(staAddress);
	t += temp;
	cntr++;
	if (temp < upLinkRatio){
		//packet will be sent from STA to AP
		msdu->DA = 0;
		msdu->TA = msdu->SA = staAddress;
	}else{
		//packet will be sent from AP to STA
		msdu->SA = msdu->TA = 0;
		msdu->DA = staAddress;
	}
	Mac *s = sta[msdu->SA];
	msdu->RA = s->routing[msdu->DA];
	msdu->bitrate = s->bitrate[msdu->RA];
	msdu->size = packetSize;
	if (msdu->size + overhead > s->fragmTSH){ //fragment the frame					
		double fragments = double (msdu->size)/(s->fragmTSH - overhead);
		if (fragments != int(fragments)) fragments = int (fragments + 1);
		msdu->fragments = int(fragments);
		msdu->lastFragmSize = int(msdu->size - (s->fragmTSH - overhead)*(fragments - 1));		
	}else
		msdu->fragments = 1;
	s->bufOUT[2].insertLast(msdu);
		
	time = clock + generator.getTimeBE(staAddress, intensity);
	agenda.schedule(this);
}
double Generator::getUpLinkRandom(int staAddress){
		int x = uniform(coreUpLinkRatio[staAddress]);
		coreUpLinkRatio[staAddress] = x;
		return double(x)/m;
	}

if (temp < upLinkRatio)

if (temp < upLinkRatio){
     //packet will be sent from STA to AP
     msdu->DA = 0;
     msdu->TA = msdu->SA = staAddress;
 }

else{
		//packet will be sent from AP to STA
		msdu->SA = msdu->TA = 0;
		msdu->DA = staAddress;
	}

if (temp > upLinkRatio){

mass85 wrote:

There is just one version of code and I just change Solution configuration from debug to release, so temp is consistent.

mass85 wrote:

Most of the temp values are 0... which is of course incorrect. Do you know, what might be the reason for that?

mass85 wrote:

int uniform(int X){
h = int ( double (X) / q );
X = a*(X - q*h) - r*h;
if (X < 0) X = X + m;
return X;
}

for(int i = 1 + repeaters; i < staNr; i++){
    coreUpLinkRatio[i] = x;
    for(int j = 0; j < (runsNr*(2*beMsgsToObserve + shift + runShift)); j++)
        x = uniform(x);
}

   for(int i = 0; i < AC; i++){
    coreUpLinkRatio[i] = x;
    for(int j = 0; j < (runsNr*(2*beMsgsToObserve + shift + runShift)); j++)
        x = uniform(x);
}

mass85 wrote:

I have finally found the bug!

So when you wrote:

There are no uninitialized variables in this block of code. I don't think there are any in whole program.

You did not realize that:

In fact not whole coreUpLinkRatio array was initialized.

mass85 wrote:

Thank you for your help!

FredBrina wrote:

SAPI