Re: Copying a file with progress - C# Discussion Boards

Re: Copying a file with progress

Xmen Real 3-Jun-09 2:36

Xmen Real

3-Jun-09 2:36

dude, its a working code...it can even copy entire office Laugh | :laugh:

Its just a byte game.

TVMU^P[[IGIOQHG^JSH`A#@`RFJ\c^JPL>;"[,*/|+&WLEZGc`AFXc!L
%^]*IRXD#@GKCQ`R\^SF_WcHbORY87֦ʻ6ϣN8ȤBcRAV\Z^&SU~%CSWQ@#2
W_AD`EPABIKRDFVS)EVLQK)JKQUFK[M`UKs*$GwU#QDXBER@CBN%
R0~53%eYrd8mt^7Z6]iTF+(EWfJ9zaK-iTV.C\y<pjxsg-b$f4ia>

-----------------------------------------------
128 bit encrypted signature, crack if you can

Re: Copying a file with progress

musefan3-Jun-09 3:10

musefan

3-Jun-09 3:10

It's all good now, small mistake on my part. Thanks for your time anyway

Life goes very fast. Tomorrow, today is already yesterday.

Re: Copying a file with progress

harold aptroot3-Jun-09 0:27

harold aptroot

3-Jun-09 0:27

SharpZipLib contains Core.StreamUtils.Copy(some args including progress callback)
You could look how it works (it's quite short) and do something that looks like it..

When copying blocks did you use the right length and did you flush the output stream? I'm sure you did, but, just checking.. forgetting one or both can result in corruption

Re: Copying a file with progress

musefan3-Jun-09 0:42

musefan

3-Jun-09 0:42

Not using flush (don't think I need with code I'm using) but am sure the length is correct. Here's a snippet...

StreamReader sr = new StreamReader("inputfile.docx");
StreamWriter sw = new StreamWriter("outputfile.docx", false);

FileInfo fi = new FileInfo("inputfile.docx");
long total = fi.Length;

byte[] buffer = new byte[10000];
long byteCount = 0;

while(true)
{
  int bytesRead = sr.BaseStream.Read(buffer, 0, buffer.Length);//using .Length should ensure correct size
  byteCount += bytesRead;

  if(bytesRead == 0)//if end of file then break the loop
    break;

  //update progress
  sw.BaseStream.Write(buffer, 0, buffer.Length);
}

sr.Close();
sw.Close();

Life goes very fast. Tomorrow, today is already yesterday.

Re: Copying a file with progress [modified]

Alan N3-Jun-09 0:52

Alan N

3-Jun-09 0:52

musefan wrote:
sw.BaseStream.Write(buffer, 0, buffer.Length);

There's the mistake, see it? You must write the number of bytes read to correctly handle a partially filled buffer.

Alan.

modified on Wednesday, June 3, 2009 7:10 AM

Re: Copying a file with progress

musefan3-Jun-09 0:55

musefan

3-Jun-09 0:55

nice spot, thanks.

I will give it a go but it make perfect sense so I cant see it not working. Just for any others I am going to change that line to...

sw.BaseStream.Write(buffer, 0, bytesRead);

Life goes very fast. Tomorrow, today is already yesterday.

Re: Copying a file with progress [modified]

harold aptroot3-Jun-09 0:55

harold aptroot

3-Jun-09 0:55

Shouldn't that be: (untested and I give no guarantee that I'm even making sense)

StreamReader sr = new StreamReader("inputfile.docx");
StreamWriter sw = new StreamWriter("outputfile.docx", false);

FileInfo fi = new FileInfo("inputfile.docx");
long total = fi.Length;

byte[] buffer = new byte[10000];
long byteCount = 0;

while(true)
{
  int bytesRead = sr.BaseStream.Read(buffer, 0, buffer.Length);//using .Length should ensure correct size
  byteCount += bytesRead;

  if(bytesRead == 0)//if end of file then break the loop
    break;

  //update progress
  sw.BaseStream.Write(buffer, 0, bytesRead); //otherwise you would write a piece of unused buffer space
}

sr.Close();
sw.Close();

Last modified: 14mins after originally posted -- changed to answer

Re: Copying a file with progress

musefan3-Jun-09 1:05

musefan

3-Jun-09 1:05

Yeah, Alan has just said too. But thanks for the response. Rookie mistake really, but sometimes it happens. The problem is that it appeared to work fine with other files so I didn't notice there was an error. It was just because Microsoft Word actually noticed crap at the end of the file that pointed it out. So hey, thanks to Microsoft too Laugh | :laugh:

Oh, can either you out Alan change the post to be an 'answer' so I can mark as answer please.

Thanks again, to everyone who took an interest Smile | :)

Life goes very fast. Tomorrow, today is already yesterday.

Re: Copying a file with progress

Alan N3-Jun-09 1:05

Alan N

3-Jun-09 1:05

Hi,
The use of the Stream reader and writer is a bit odd as you just want the underlying streams. To eliminate the possibility of the reader and writer internal buffers causing a problem you should open the file directly with FileStream.

e.g.

void Copier(String src, String dest) {
  using (FileStream srcfile = new FileStream(src, FileMode.Open, FileAccess.Read)) {
    using (FileStream destfile = new FileStream(dest, FileMode.CreateNew, FileAccess.Write)){
      byte[] buffer = new byte[16 * 1024];
      Int32 bytesRead;
      while((bytesRead = srcfile.Read(buffer, 0, buffer.Length)) != 0 ){
        destfile.Write(buffer, 0, bytesRead);
      }
    }
  }
}

Alan.

Re: Copying a file with progress

musefan3-Jun-09 1:07

musefan

3-Jun-09 1:07

Yeah thanks, this is what I had first (well I was using FileStream) but changed the types to test, StreamReader being the last I tried with... I'll change it back now Smile | :)

Thanks again

Life goes very fast. Tomorrow, today is already yesterday.

How to Repeat execution of AT commands to read SMS from Mobile?

Md. Ali Naser Khan2-Jun-09 23:24

Md. Ali Naser Khan

2-Jun-09 23:24

I am using AT command to read sms from Mobile.

I am using 1> AT, 2> AT+CMGF, 3> AT+CSCS, 4> AT+CPMS, 5> AT+CNMI, 6> AT+CMGL commands to read sms. All are working. But when I try to execute the 1> AT command after 2/3 minutes later it is not working? What I have to do to repeat the execution of the AT command?

modified on Wednesday, June 3, 2009 5:42 AM

How to disable back button on IE?

svt gdwl2-Jun-09 23:17

svt gdwl

2-Jun-09 23:17

when an Internet Explorer is opened and navigated through other links continuously for sometime, back button(i.e., a navigation toolbar to going to previous url) sould be disabled. How can I do this using c#?

Re: How to disable back button on IE?

Blue_Boy2-Jun-09 23:25

Blue_Boy

2-Jun-09 23:25

you can use this javascript function:

window.history.forward(1);

but the Back function can always be achieved by right clicking on the page and choosing to go back.

I Love T-SQL
"Don't torture yourself,let the life to do it for you."
If my post helps you kindly save my time by voting my post.

Re: How to disable back button on IE?

J4amieC2-Jun-09 23:27

J4amieC

2-Jun-09 23:27

You can't.

Re: How to disable back button on IE?

Manas Bhardwaj2-Jun-09 23:39

Manas Bhardwaj

2-Jun-09 23:39

This is one of the question which appears almost every 2-3 days.

Look at this [^]

Please remember to rate helpful or unhelpful answers, it lets us and people reading the forums know if our answers are any good.

variable which is assing class value and array.sort problem

karayel_kara2-Jun-09 22:48

karayel_kara

2-Jun-09 22:48

i have a class and i assing this class value then

when i sorted this value or class value, both sorted

example code folowing :

int[] ggg=new int[5];
int[] ggg1=new int[5];
ggg = networks.layers[i].noron[j].sbaglanti;
ggg1 = ggg;
Array.Sort(ggg);

how can i solve this problem ?

regards

Re: variable which is assing class value and array.sort problem

S. Senthil Kumar2-Jun-09 22:54

S. Senthil Kumar

2-Jun-09 22:54

That is because System.Array is a reference type. When you assign ggg1 = ggg, both ggg and ggg1 refer to the same array instance, so calling Array.Sort on either reference will change that instance.

Check out MSDN[^] or search for value types and reference types in Google.

Regards
Senthil [MVP - Visual C#]
_____________________________
My Home Page |My Blog | My Articles | My Flickr | WinMacro

Re: variable which is assing class value and array.sort problem

karayel_kara2-Jun-09 23:00

karayel_kara

2-Jun-09 23:00

i understand but if arrays is referans value, how can i solve my problem?

Re: variable which is assing class value and array.sort problem

S. Senthil Kumar2-Jun-09 23:04

S. Senthil Kumar

2-Jun-09 23:04

You typically find a way to clone the source reference. In this case, Array.Copy should do the trick. Bear in mind that if the elements in the array themselves are reference types, then Array.Copy won't clone them.

Regards
Senthil [MVP - Visual C#]
_____________________________
My Home Page |My Blog | My Articles | My Flickr | WinMacro

Re: variable which is assing class value and array.sort problem

tom5720072-Jun-09 23:17

tom572007

2-Jun-09 23:17

That's what i said 10 minutes ago Sniff | :^)

Re: variable which is assing class value and array.sort problem

tom5720072-Jun-09 22:55

tom572007

2-Jun-09 22:55

have you tryed :

Array.Copy(ggg, ggg1, 5);

Re: variable which is assing class value and array.sort problem

CPallini2-Jun-09 23:03

CPallini

2-Jun-09 23:03

int[] ggg = new int[5];
ggg = networks.layers[i].noron[j].sbaglanti;
int[] ggg1 = (int[]) ggg.Clone();
Array.Sort(ggg);

If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.

This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke

[My articles]

Re: variable which is assing class value and array.sort problem

karayel_kara2-Jun-09 23:22

karayel_kara

2-Jun-09 23:22

thanks friends.
i solved with array.copy();
regards

Re: variable which is assing class value and array.sort problem

tom5720072-Jun-09 23:34

tom572007

2-Jun-09 23:34

Implementation of IUrlHistoryStg Interface in C#?

svt gdwl2-Jun-09 22:39

svt gdwl

2-Jun-09 22:39

How to implement IUrlHistoryStg Interface in c#?

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.