Click here to Skip to main content
15,895,667 members
Home / Discussions / C#
   

C#

 
QuestionRe: stack overflow Pin
Ian McCaul11-May-09 6:26
Ian McCaul11-May-09 6:26 
AnswerRe: stack overflow Pin
J4amieC11-May-09 6:34
J4amieC11-May-09 6:34 
AnswerRe: stack overflow Pin
Dan Neely11-May-09 6:56
Dan Neely11-May-09 6:56 
AnswerRe: stack overflow Pin
Dave Kreskowiak11-May-09 7:00
mveDave Kreskowiak11-May-09 7:00 
GeneralRe: stack overflow Pin
hotthoughtguy11-May-09 7:12
hotthoughtguy11-May-09 7:12 
GeneralRe: stack overflow Pin
Luc Pattyn11-May-09 7:27
sitebuilderLuc Pattyn11-May-09 7:27 
GeneralRe: stack overflow Pin
hotthoughtguy11-May-09 7:40
hotthoughtguy11-May-09 7:40 
GeneralRe: stack overflow Pin
Luc Pattyn11-May-09 8:04
sitebuilderLuc Pattyn11-May-09 8:04 
Hi,

1.
thank you for the code. It is unreadable, lacking PRE tags which would have preserved formatting. Also the start is missing i.e. how is the string input in this?

2.
you did not react on my simple suggestion to try a short word with repeat characters ("aha").

3.
your Node is carrying too much data, most of which is redundant, and hence a small mistake somewhere will make nodes inconsistent, and the algorithm very hard to debug.

4.
NextCousion never gets initialized?

5.
layers(current.parant.NextCousion); is the biggest suspect. If I understand anything of your code, it seems to move sideways in the family tree, but downwards on the stack. That is a very bad idea, especially as I don't see a sideway limiting factor.

6.
there is just too much code for the simple job at hand. less code typically is easier to understand, and easier to debug (although it probably needs it less, since it typically also contains fewer bugs to start with).

7.
suggestion: throw it all out the window; rethink the matter and start afresh.

Smile | :)

Luc Pattyn [Forum Guidelines] [My Articles]

The quality and detail of your question reflects on the effectiveness of the help you are likely to get.
Show formatted code inside PRE tags, and give clear symptoms when describing a problem.

GeneralRe: stack overflow Pin
hotthoughtguy11-May-09 8:08
hotthoughtguy11-May-09 8:08 
GeneralRe: stack overflow Pin
Dave Kreskowiak11-May-09 12:03
mveDave Kreskowiak11-May-09 12:03 
QuestionObtain value from a stored procedure Pin
Gresziu11-May-09 5:50
Gresziu11-May-09 5:50 
AnswerRe: Obtain value from a stored procedure Pin
Ian McCaul11-May-09 6:23
Ian McCaul11-May-09 6:23 
GeneralRe: Obtain value from a stored procedure Pin
Gresziu11-May-09 21:23
Gresziu11-May-09 21:23 
Questionstudent information system Pin
dotnetdev8111-May-09 5:49
dotnetdev8111-May-09 5:49 
AnswerRe: student information system Pin
OriginalGriff11-May-09 5:54
mveOriginalGriff11-May-09 5:54 
GeneralRe: student information system Pin
dotnetdev8111-May-09 7:12
dotnetdev8111-May-09 7:12 
JokeRe: student information system Pin
OriginalGriff11-May-09 8:12
mveOriginalGriff11-May-09 8:12 
General[Message Deleted] Pin
dotnetdev8111-May-09 8:15
dotnetdev8111-May-09 8:15 
GeneralRe: student information system Pin
EliottA11-May-09 8:20
EliottA11-May-09 8:20 
GeneralRe: student information system Pin
harold aptroot11-May-09 6:04
harold aptroot11-May-09 6:04 
AnswerRe: student information system Pin
DaveyM6911-May-09 6:06
professionalDaveyM6911-May-09 6:06 
AnswerRe: student information system [modified] Pin
0x3c011-May-09 6:54
0x3c011-May-09 6:54 
QuestionHow can i know when my database done update values ? Pin
Yanshof11-May-09 5:38
Yanshof11-May-09 5:38 
QuestionHow to a Control to the NonClient area of Form in C#? Pin
CodeVarma11-May-09 5:03
CodeVarma11-May-09 5:03 
AnswerRe: How to a Control to the NonClient area of Form in C#? Pin
Dave Kreskowiak11-May-09 5:11
mveDave Kreskowiak11-May-09 5:11 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.