Re: WPF Combobox databinding - WPF Discussion Boards

ABitSmart5-Mar-09 5:23

5-Mar-09 5:23

Well, did you try the INotifyPropertyChanged suggestion from Eslam that I shared? Or this[^]

babongita5-Mar-09 5:40

5-Mar-09 5:40

Yes the all of my base classes implement INotifyProperyChanged

ABitSmart5-Mar-09 5:57

5-Mar-09 5:57

Can you share how you are updating the object in code ? Try calling the property change notification explicitly using SendPropertyChanged("ParameterNameCollection").

babongita5-Mar-09 6:11

5-Mar-09 6:11

There are four different view models since there is are parent child relationships in this scenario.

Here is an attempt to explain

TabParameterViewModel
has a DP of ParameterCollection (which is of Type ObservableCollection)
has a DP of Parameter (bound to the selected item in a ListView)

ParameterViewModel
has a DP of Parameter which is set to a clone of TabParameterViewModel.Parameter
has a DP of ParameterDefaultCollection (again an ObservableCollection) this.Parameter.Defaults

ParameterDefaultsViewModel
has a DP of ParameterDefaultCollection bound to a ListView
has a DP of ParameterDefault bound to the selectedItem in the ListView

ParameterDefaultViewModel
has a DP of ParameterDefault which is set to a clone of ParameterDefaultsViewModel.ParameterDefault

The Parameter Model has a Name property which is a class of ParameterName, which contains other attributes that are needed for the ParameterName. It also has a string property called ParameterLabel which I have bound to a textbox, when I change the SelectedItem in the listbox int TabParameterView the corresponding attributes change in the ParameterView, but any item bound to an object (in this case a Combobox) that attribute is not populated.

ABitSmart5-Mar-09 16:47

5-Mar-09 16:47

Your orignal post had the ComboBox bound to "ParameterNameCollection" which doesn't appear in your description. What collection is it ?

babongita6-Mar-09 2:26

6-Mar-09 2:26

The ParameterViewModel has an ObservableCollection ParameterNameCollection which is a collection of possible names that it could be, with attributes associated to that name, so the Collection is what fills the combobox, but I want the SelectedItem to be the ParameterName of the Parameter object.

If I was to post the complete class for the ParameterViewModel it would look like this:
ParameterViewModel
has a ControlModeCollection (ObservableCollection)
has a ControlTypeCollection (ObservableCollection)
has a DataTypeCollection (ObservableCollection)
has a ParameterMethodCollection (ObservableCollection)
has a ParameterNameCollection (ObservableCollection)
has a DP of SelectedParameter (of Type Parameter)
has a DP of SelectedParameterDefaults (I think this is redundant since it is an ObservableCollection)

Then the Parameter class looks like the following
has a Name (of Type ParameterName)
has a DataType (of Type DataType)
has a ScreenLabel (of Type String)
etc. etc.

the TextBox XAML works as expected, the ComboBox doesn't

<TextBox x:Name="txtParameterLabel"
Style="{DynamicResource RoundedCornerTextBox}"
Grid.Row="1"
Grid.Column="1"
Grid.ColumnSpan="6"
Text="{Binding SelectedParameter.ScreenLabel}"
TabIndex="40"/>

<ComboBox x:Name="cboParameterName"
VerticalAlignment="Center"
IsSynchronizedWithCurrentItem="True"
TabIndex="10"
Grid.Column="1"
Grid.ColumnSpan="4"
ItemsSource="{Binding Path=ParameterNameCollection}"
SelectedValue="{Binding SelectedParameter.Name, Mode=TwoWay}"
Style="{DynamicResource BaseComboBox}">
<ComboBox.ItemTemplate>
<DataTemplate>
<TextBlock Text="{Binding ParameterDisplayName}"/>
</DataTemplate>
</ComboBox.ItemTemplate>
</ComboBox>

ABitSmart6-Mar-09 3:15

6-Mar-09 3:15

babongita wrote:
SelectedValue="{Binding SelectedParameter.Name, Mode=TwoWay}"

and

babongita wrote:
<TextBlock Text="{Binding ParameterDisplayName}"/>

I guess both of these are bound to the Parameter object. Was just curious to know if these are two different properties or a typo ? Cause your textbox is bound to a property names "ScreenLabel", which I think is the display label.

babongita wrote:
Then the Parameter class looks like the following
has a Name (of Type ParameterName)

In your description, you say, Name is of type "ParameterName". So then, I suspect this,

SelectedValue="{Binding SelectedParameter.Name, Mode=TwoWay}"

Here you are binding to SelectedParameter.Name where Name is of type ParamterName. The binding will fail since it is not binding to a string type.

If you open your output window in the solution explorer (assuming you are using VS) you would be able to see binding failure messages logged.

babongita6-Mar-09 3:32

6-Mar-09 3:32

First of all you are correct they are bound to different properties of the Parameter object.

My question is though, that I am binding the ComboBox to a Collection of Classes, and the Parameter object as a property which is a the same class, so I would think that the SelectedValue should be able to bind directly to that Value, since they are of the same type. It is just instead of it being a string object, is of another type. I tried using:

SelectedValue="{Binding SelectedParameter.Name.ParameterDisplayName, Mode=TwoWay}"

but then the actual property doesn't get set correctly.

How can I set that combobox to be the correct item then?

ABitSmart6-Mar-09 4:55

6-Mar-09 4:55

Give this a try,

<ComboBox x:Name="cboParameterName"
                           VerticalAlignment="Center"
                           IsSynchronizedWithCurrentItem="True"
                           TabIndex="10"
                           Grid.Column="1"
                           Grid.ColumnSpan="4"
                           ItemsSource="{Binding Path=ParameterNameCollection}"                                                 
                           SelectedValue="{Binding Path=SelectedParameter.Name.ParameterDisplayName}"
                           SelectedValuePath="Name.ParameterDisplayName"
                           Style="{DynamicResource BaseComboBox}">
                  <ComboBox.ItemTemplate>
                        <DataTemplate>
                              <TextBlock Text="{Binding Name.ParameterDisplayName}"/>
                        </DataTemplate>
                  </ComboBox.ItemTemplate>
            </ComboBox>

Note: Added SelectedValuePath and changed the DataTemplate
(fingers crossed ,X,, )

babongita6-Mar-09 5:08

6-Mar-09 5:08

I have been playing with using the SelectedIndex. And it seems to work, at least for now, the problem that I foresee is that I will have to go through the Combobox source to get the index each time, in the event that the Index would change, either by addition or substraction of Metadata.

What are your thoughts on that?

babongita6-Mar-09 5:10

6-Mar-09 5:10

BTW, I tried your suggestion and the first problem was that the combobox wasn't showing what was loaded, the second problem was that the parameter.name wasn't being set either

ABitSmart6-Mar-09 5:24

6-Mar-09 5:24

babongita wrote:
combobox wasn't showing what was loaded

What did it show then ? Was there any value in the SelectedParameter, since that is what is driving the SelectedItem.

babongita wrote:
parameter.name wasn't being set either

Why is this a combobox problem ?? Combobox is reading this value, someone has to be setting it ??

Did you check your output window? It would be logging DataBinding errors.

babongita6-Mar-09 5:29

6-Mar-09 5:29

I didn't check the output window to see what was happening. When I hit the dropdown on the combo I couldn't see anything in it, but the itemsource had the values.

But digging into the SelectedIndex seems to be the way to go here, it is performing as expected. But like I said, I will need to get the Index each time the screen loads, since the Index may change, not often but enough that I can't rely on that being the same

I guess I could create a converter for that couldn't I, then it would be more of an "automated" thing, right?

ABitSmart6-Mar-09 5:59

Re: WPF Combobox databinding [modified]

6-Mar-09 5:59

babongita wrote:
I didn't check the output window to see what was happening. When I hit the dropdown on the combo I couldn't see anything in it, but the itemsource had the values.

That is because some binding is failing. If you check the Output window it would clearly mention which binding is failing and why. The comboox SelectedItem is being driven by the SelectedParamter Dependency Property. Check what value it has. If it is null(or the Name property), then the combobox cannot do anything.

babongita wrote:
But digging into the SelectedIndex seems to be the way to go here, it is performing as expected. But like I said, I will need to get the Index each time the screen loads, since the Index may change, not often but enough that I can't rely on that being the same

So, if I understand you correct, you will search for the objects in the comboxbox and set the combobox SelectedIndex to it ? Would this be on the SelectionChange of your listviewm - where you would get the listview's selected item and search that in the combobox ?

babongita wrote:
I could create a converter

Well, that seems to be a *workaround*. I would fix the damn databinding issue Smile | :)

I think you could look at this as an option,

<ComboBox x:Name="cboParameterName"
                           VerticalAlignment="Center"
                           IsSynchronizedWithCurrentItem="True"
                           TabIndex="10"
                           Grid.Column="1"
                           Grid.ColumnSpan="4"
                           ItemsSource="{Binding Path=ParameterNameCollection}"  
                           SelectedItem="{Binding Path=SelectedParameter}" 
                           Style="{DynamicResource BaseComboBox}"
                  <ComboBox.ItemTemplate>
                        <DataTemplate>
                              <TextBlock Text="{Binding Name.ParameterDisplayName}"/>
                        </DataTemplate>
                  </ComboBox.ItemTemplate>
            </ComboBox>

One more thing is, since you are driving this combobox from a listview, why don't you bind the ListView's SelectedItem to the combobox's SelectedItem ,

<ComboBox x:Name="cboParameterName"
                           VerticalAlignment="Center"
                           IsSynchronizedWithCurrentItem="True"
                           TabIndex="10"
                           Grid.Column="1"
                           Grid.ColumnSpan="4"
                           ItemsSource="{Binding Path=ParameterNameCollection}"  
                           SelectedItem="{Binding ElementName="yourListView" Path=SelectedItem}" 
                           Style="{DynamicResource BaseComboBox}"
                  <ComboBox.ItemTemplate>
                        <DataTemplate>
                              <TextBlock Text="{Binding Name.ParameterDisplayName}"/>
                        </DataTemplate>
                  </ComboBox.ItemTemplate>
            </ComboBox>

Have fun

babongita6-Mar-09 6:38

6-Mar-09 6:38

I was thinking about binding to the ListView but the problem I had was that the user has the option to Add/Edit/Remove (all buttons on the view) a parameter, and I couldn't figure out how to add a new parameter and still have it be bound. Does that make sense? Can I email you offline? I would like to discuss this offline with some screen shots of what I am trying to duplicate.

modified on Friday, March 6, 2009 12:46 PM

ABitSmart6-Mar-09 6:41

6-Mar-09 6:41

I do not think it is a good idea to share yur email id in public.

babongita6-Mar-09 6:49

6-Mar-09 6:49

OK well I modified that post. But is it possible that we could continue this offline?

ABitSmart6-Mar-09 6:56

6-Mar-09 6:56

I am a dedicated member, always available at CP Smile | :)

babongita6-Mar-09 7:02

6-Mar-09 7:02

OK I am going back through now and trying you recommendations and this is the error that I am getting in the Output window

System.Windows.Data Error: 39 : BindingExpression path error: 'Name' property not found on 'object' ''ParameterName' (HashCode=62178992)'. BindingExpression:Path=Name.ParameterDisplayName; DataItem='ParameterName' (HashCode=62178992); target element is 'ComboBox' (Name='cboParameterName'); target property is 'NoTarget' (type 'Object')

babongita6-Mar-09 9:03

6-Mar-09 9:03

OK I have finally figured it out, but it really is a different work around. Or at least it seems like it. If instead of creating the ParameterName objects with all of the properties associated with it, if I only create a collection of strings and then bind them to the dropdown box then I can make the binding work. But it is not the object itself it is only one piece of the object.

ABitSmart6-Mar-09 17:47

6-Mar-09 17:47

I am suprised it does not work while binding to the the string property of the object. Well, if it is so, you can use a converter taking the object and returning a string for it rather than having to have a string collection. Which particular binding was failing, the one in the combobox DataTemplate ? I still feel that your data was not being populated correct.

ABitSmart6-Mar-09 3:05

6-Mar-09 3:05

babongita wrote:
but any item bound to an object (in this case a Combobox) that attribute is not populated

The above statement confuses me. It says any item bound to the object is not populated. You mean never or again just when you do something from code ?

babongita6-Mar-09 3:18

6-Mar-09 3:18

OK, There is a listbox below, which is bound to Collection of Parameters(this is a class, not what you would typically think of when you think parameters), then there is a "view" above it which shows the "detail" (attributes) of the SelectedItem in the listbox. All of the TextBoxes or the CheckBoxes show the "detail" (attributes) correctly. But when the "detail" (attribute) is an item in a Combobox the item doesn't show in the Combobox even though it is bound to that "detail"(attribute). The combobox is populated with all of the possible selections, but the SelectedItem, isn't shown in that combobox.

Member 40355135-Mar-09 5:03

Member 4035513

5-Mar-09 5:03

I think that you are missing the ElementName in the ItemsSource Binding. In this case the ElementName is the x:Name of your window or UserControl.

<combobox x:name="cboParameterName" xmlns:x="#unknown">
IsSynchronizedWithCurrentItem="True"
TabIndex="10"
Grid.Column="1"
Grid.ColumnSpan="4"
ItemsSource="{Binding Path=ParameterNameCollection, ElementName=UserControl, Mode=Default}"
SelectedValue="{Binding SelectedParameter.Name}"
Style="{DynamicResource BaseComboBox}">
<combobox.itemtemplate>
<datatemplate>
<textblock text="{Binding ParameterDisplayName}">

ABitSmart5-Mar-09 5:14