The Weird and The Wonderful

UPDATE [csForm] SET [CopyCommand] = N'SELECT @ValueList = ''''''''+REPLACE(ISNULL(CAST([Amount] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''','''''' + REPLACE(ISNULL(CAST([DocTitle] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''' FROM Documents WHERE DocID =|SELECT ''''''&IDENTITY&'''','''''' + REPLACE(ISNULL(CAST([WorkType] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''','''''' + REPLACE(ISNULL(CAST([WorkTypeID] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''','''''' + REPLACE(ISNULL(CAST([Amount] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''','''''' + REPLACE(ISNULL(CAST([Notes] as varchar(8000)),''Null''),'''''''','''''''''''') + '''''','''''' + REPLACE(ISNULL(CAST([LineType] as varchar(8000)),''Null''),'''''''','''''''''''')+'''''''' AS ValueList FROM DocItems WHERE DocID =|'

Brady Kelly wrote:

The reason for all the casts is historical

for(int i= 0; i < 2; i++)
{
  switch(i)
  {
    case 0:
      // do something
      break;
    case 1:
      // do something else
      break;
  };
}

«_Superman_» wrote:

Nothing is being repeated here.

PIEBALDconsult wrote:

Probably, but do //Do something and //Do something else alter the value of i?

// do something else could be:
{
   i=i-2;
   Console.WriteLine("once more");
}

Do something absolutely is critical here to know whether it is horrible or not.

The following sample indicates what you saw is not horrible:

See, I have two controls: Label0 and TextBox1. I can assign values to them:

 for (int i = 0; i < 2; i++)
 {
    if (i == 0)
    {
       Label lable = (Label)this.FindControl("Label" + i.ToString());
       if (lable != null)
         lable.Text = "Test Label " + i.ToString();
    }

    if (i == 1)
    {
       TextBox txt = (TextBox)this.FindControl("TextBox" + i.ToString());
       if (txt != null)
         txt.Text = "Test TextBox " + i.ToString();
    }
}

See it? It is not a usual way, but, not as horrible as you saw.

for(int i = 0; i < 2; i++)
{
  if(i==0)
    Console.WriteLine("This is a zero");
  if(i==1)
    Console.WriteLine("This is a one");
}