|
Pick me please, I could use the money! But lets do this off the forum. Send me your details at AnIdiot@Morons.com[^]
You may be right
I may be crazy
-- Billy Joel --
Within you lies the power for good - Use it!
|
|
|
|
|
Oh please not in this place,
software developers are people that normally use their brains... 
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
I have some $20 Mil Oceanfront Property in Arizona for sale if you're interested.
|
|
|
|
|
Don't you try and sell him something! - you may offend him.
He wants to donate without having any earthly reward for it (like your ridiculous 'Oceanfront Property in Arizona')...
Regards
Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the Universe trying to produce bigger and better idiots. So far, the Universe is winning.
Programmer - an organism that turns coffee into software.
|
|
|
|
|
Mister Kofi Ado,
If you have 9,5 mil (nine and a half million) that you want to get rid off...
share it with the codeproject community, we will be very happy with your money
you want anything in return? I'm sure we can provide you a good program that helps you spamming messageboards. (but we can't garantee bugs that might f**k up your pc)
<< Nearly all men can stand adversity, but if you want to test a man's character, give him power. >>
|
|
|
|
|
Dabi dabi dabi.
Me nim wo, Kofi Ado.
Wo n'ye.
|
|
|
|
|
Sounds tempting, however it occurs to me that if you're smart enough to steal that much from your company, then you're smart enough to cheat me out of my share, so just eff off.
|
|
|
|
|
Dear Mr.Kofi Ado, I've really very interested in you proposal, unfortunately I'm unreliable, dishonest and absolutely NOT trustworthy (you know, drugz...).
Anyway I beg you, since badly need your money!
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
Phht..this boss was not a true Klingon...The True Klingon boss I once worked for would say "You didn't update the comments? A pity, I thought you LIKED your job..."
|
|
|
|
|
I believe the phrase "Cowardly Programming" would be more apt...defending against problems that just aren't there.
|
|
|
|
|
Beautiful, i love it 
|
|
|
|
|
I was cleaning up some old mailing system code developed by some contractors at my work about 3 years before I even joined the company. It was designed in .NET 1.1, but it worked, so we never really upgraded it... I'll be re-writing the whole thing from scratch now that I've seen what it looks like (after we encountered our first issue).
Tell me if you can see the problem with this (pseudo code, as I cannot release the actual code for public display)...
try
{
}
catch (Exception ec)
{
}
As a temp measure to view the outcome, I changed the bugs email address to my own email address, to find that when the email sent, the error merely pointed at the catch{} lines of code, without giving any indication at all as to where inside the 200 lines of code the error was occuring!
|
|
|
|
|
Well, you know, exception handling automatically-magically-definitely solves the goto-spaghetti-code nightmare... 
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
[My articles]
|
|
|
|
|
He probably was told to use try-catch so he did, how could that be wrong? 
I have seen this kind of thing from people who aren't used to try-catch and/or are just putting it in the code because someone told them to do it. Of course, if you want the try-catch to be useful for tracking down issues in the code then having a huge block where there could be dozens of points of failure and not catching the individual types of exceptions is not the way to go.
Bill W
Just because code works, it doesn't mean that it is good code.
|
|
|
|
|
Once, many moons ago, I got talked to by another developer because I wasn't using try catch blocks to do error handling. I checked and validated results as I went, using if/elses. No, it wasn't particularly elegant and I would do it differently now but it worked and handled failures well.
A few days later I looked at some of his code to get an idea for how to structure it using try/catch and came upon something very much like what you posted. I was horrified, but because I knew try/catch was all the rage, and I was new, I thought his was more correct and didn't say anything. The company went out of business a few months later.
(Although, to be fair, that was more likely a result of us having free arcade games in the office and spur of the moment Quake tournaments.)
It was a long time before I realized the true benefits of properly structured exception handling, thanks to some early misguidance. I'm still appalled at how it gets frequently abused though.
He said, "Boy I'm just old and lonely,
But thank you for your concern,
Here's wishing you a Happy New Year."
I wished him one back in return.
|
|
|
|
|
I would not have minded if he made use of if/else statements or at least something to handle or track issues, but there was not of that, just a load of messy code! I found earlier this year, done by the same guy, some code which as a HUGE for-loop containing dozens of if/else statements to calculate values for paging data, when I was able to replace it all with one single line of math...
I could understand if this guy was a junior, but he was a "professional contractor"!
|
|
|
|
|
Professional contractors follow Sturgeon's Law closely, except that the percentage is more likely to be 98% in my experience.
|
|
|
|
|
David Kentley wrote: I'm still appalled at how it gets frequently abused though.
try
{
// some code
}
catch {}
is quite common. 
There can be some cases in which such a pattern is fine, though usually you should be catching a specific exception, but you should always explain why/what you're doing in such cases.
Kevin
|
|
|
|
|
Kevin McFarlane wrote: There can be some cases in which such a pattern is fine, though usually you should be catching a specific exception, but you should always explain why/what you're doing in such cases.
I wish .net included a few more 'tryDoSomething' methods. For example, if one thread has just changed some information that should be displayed be a control, a sensible thing to do is to BeginInvoke the control's update handler (preferably using a 'Threading.Interlocked.CompareExchange'ed flag to prevent excessive 'BeginInvoke's). Unfortunately, I know of no good way to avoid the risk of the control being disposed before the BeginInvoke. In a situation like that, a tryBeginInvoke would be extremely handy; if it works, great. If the control's been disposed or otherwise lacks a windowing context, there's no need to update it and the call may be safely ignored.
If a try block contains a single BeginInvoke and the catch block is empty, is that not sufficiently clear "Try this, and if it works great--if not, meh."
|
|
|
|
|
David Kentley wrote: I checked and validated results as I went, using if/elses.
I'm a fan of doing some error trapping this way. It's quick and you can log a very specific error message that says exactly what's wrong, like an object doesn't exist. That's good for the developer that has to fix the issue. Besides, having an exception thrown and being caught is expensive from a processor time point of view.
I've also seen large blocks of code wrapped in a try catch block where the catch block logged an "unhandled" exception. Might as well have said "s&*t happened"!
|
|
|
|
|
void(entity targ, entity attacker) ClientObituary =
{
local float rnum;
local string deathstring, deathstring2;
rnum = random();
...
if (targ.classname == "player")
{
if (attacker.classname == "player")
{
if (targ == attacker)
{
attacker.frags = attacker.frags - 1;
bprint (targ.netname);
if (targ.weapon == 64 && targ.waterlevel > 1)
{
bprint (" discharges into the water.\n");
return;
}
if (targ.weapon == IT_GRENADE_LAUNCHER)
bprint (" tries to put the pin back in\n");
else
bprint (" becomes bored with life\n");
return;
}
else
{
attacker.frags = attacker.frags + 1;
rnum = attacker.weapon;
if (rnum == IT_AXE)
{
deathstring = " was ax-murdered by ";
deathstring2 = "\n";
}
...
bprint (targ.netname);
bprint (deathstring);
bprint (attacker.netname);
bprint (deathstring2);
}
return;
}
else
{
targ.frags = targ.frags - 1;
bprint (targ.netname);
if (attacker.flags & FL_MONSTER)
{
if (attacker.classname == "monster_army")
bprint (" was shot by a Grunt\n");
if (attacker.classname == "monster_demon1")
bprint (" was eviscerated by a Fiend\n");
...
return;
}
if (attacker.classname == "explo_box")
{
bprint (" blew up\n");
return;
}
if (attacker.solid == SOLID_BSP && attacker != world)
{
bprint (" was squished\n");
return;
}
...
if (targ.deathtype == "falling")
{
targ.deathtype = "";
bprint (" fell to his death\n");
return;
}
bprint (" died\n");
The whole routine is about 250 lines long, but for whatever reason I particularly like the last comment.
|
|
|
|
|
Recently, I stumbled across this little gem. I don't have the exact code handy, but the gist of it is:
nErrorCode = cFtpConn.SetHost(HOST);
if (nErrorCode == 0)
{
nErrorCode = cFtpConn.SetUser(USERNAME);
if (nErrorCode == 0)
{
nErrorCode = cFtpConn.SetPassword(PASSWORD);
if (nErrorCode == 0)
{
nErrorCode = cFtpConn.SetPath(PATH);
if (nErrorCode == 0)
{
nErrorCode = cFtpConn.SetFilename(FILENAME);
if (nErrorCode == 0)
{
}
else
{
Log("Error setting filename");
}
}
else
{
Log("Error setting path");
}
}
else
{
Log("Error setting password");
}
}
else
{
Log("Error setting username");
}
}
else
{
Log("Error setting host");
}
|
|
|
|
|
C/C++ or C#?
If it's C#, the methods should probably throw Exceptions.
If it's C/C++, I see no real problem with it. Had I written it, it would be:
if ((nErrorCode = cFtpConn.SetHost(HOST)) == 0)
and the Log messages would include the value of nErrorCode.
How would you improve it?
|
|
|
|
|
Let's assume it's C++.
I consider sth. like the code above generally bad coding style. There is far to much nesting here. Supposed that most of the programmers (at least the ones I know, including myself) make an indentation of four spaces (not only two as in the 'sample'), you would quickly run out of monitor space...
I would suggest a kind of 'waterfall style' coding here:
if ((nErrorCode = cFtpConn.SetHost(HOST)) != 0)
{
Log(...);
return;
}
if ((nErrorCode = ...
{
Log(...);
return;
}
...
This is also not perfect since it introduces many returns, but it improves the readability of the code and the return conditions are trivial and repetitive.
PIEBALDconsult wrote: If it's C#, the methods should probably throw Exceptions.
Agreed. In a perfect world, C# - Methods would always throw exceptions and never signal an error by means of a return value. (As long as this is affordable in terms of performance).
Regards
Thomas
modified on Monday, November 3, 2008 4:55 AM
|
|
|
|
|
If you can't throw exceptions or the return type is already taken, there is another approach:
if ((nErrorCode = cFtpConn.SetHost(HOST)) != 0)
{
Log("Error setting host");
}
if (nErrorCode == 0 && (nErrorCode = cFtpConn.SetUser(USERNAME)) !=0)
{
Log("Error setting username");
}
if (nErrorCode == 0 && (nErrorCode = cFtpConn.SetPassword(PASSWORD)) != 0)
{
Log("Error setting password");
}
Once nErrorCode is non-zero the assignment and comparision are never done.
Sorted!
Panic, Chaos, Destruction.
My work here is done.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
