The Weird and The Wonderful

Re: Bonus points to anyone that can figure this one out.

8-Jun-08 8:29

So, what is this code doing and why? And I'm cleaning up hundreds of these methods. Sniff | :^)

public static ArrayList GetAll(CDataAccess db)
{
    ArrayList dataObjects = new ArrayList();
    ArrayList rtn = new ArrayList();
    try
    {
        dataObjects = Data.ExchangeRate.GetAll(db);
        IEnumerator ie = dataObjects.GetEnumerator();
        while (ie.MoveNext())
        {
            using (ExchangeRate businessExchangeRate = new ExchangeRate())
            {
                using (Data.ExchangeRate currentData = ie.Current as Data.ExchangeRate)
                {
                    businessExchangeRate._dataAccess = currentData;
                    rtn.Add(businessExchangeRate);
                }
            }
        }
    }
    catch (Exception ex)
    {
        throw new Exception("An error occurred while calling the GetAll() method.", ex);
    }
    finally
    {
    }
    return rtn;
}

I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon

PIEBALDconsult8-Jun-08 9:22

PIEBALDconsult

8-Jun-08 9:22

It seems the author doesn't know foreach. Nor how to cast.

Re: Bonus points to anyone that can figure this one out.

Andy Brummer8-Jun-08 9:36

Re: Bonus points to anyone that can figure this one out.

8-Jun-08 9:36

That's just the start, it gets better. Check out the using statements and where the objects are going.

I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon

Graeme_Grant8-Jun-08 12:36

Graeme_Grant

8-Jun-08 12:36

People like to make things hard for themselves. What was this guy smoking when he was coding? My thoughts are that he's an ex-C++ programming who landed a C# project.

Looks like this is part of the BO layer that works with multiple databases (db) that contains exchange rates. The database pointer is passed down to the data access layer, data is retrieved and parsed into a simple list and returned to the caller.

Not exactly an efficient way of doing it...

Am I close? Poke tongue | ;-P

Re: Bonus points to anyone that can figure this one out.

Andy Brummer8-Jun-08 18:38

Re: Bonus points to anyone that can figure this one out.

8-Jun-08 18:38

You're close. It's very similar to a common error new C++ developers make, and is something that garbage collection is supposed to fix, but they've managed to do it in C#. Think about the lifetime of the objects created in the loop and the using statement.

I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon

Graeme_Grant9-Jun-08 0:12

Graeme_Grant

9-Jun-08 0:12

Yeah... Trying to return data that's already expired! Nice one... lol Poke tongue | ;-P

Re: Bonus points to anyone that can figure this one out.

Andy Brummer9-Jun-08 3:58

Re: Bonus points to anyone that can figure this one out.

9-Jun-08 3:58

Yeah, since the dispose method closes database connections, then just wrap the object in a using and it will be automatically closed. OMG | :OMG:

They cut and pasted a standard dispose method including the check that it only runs once, so you can only close the database connection once, which is only an issue when you save one of the objects. D'Oh! | :doh:

I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon

bigbrownbeaver15-Jul-08 5:54

bigbrownbeaver

15-Jul-08 5:54

I don't understand .Net memory management myself... I seriously think a delete operator wouldnt hurt. Why is there a new and no delete? I don't blame this guy for making mistakes, at least his code is well formatted. I work on VB code that looks like it was written by monkies in a scientific experiment.

Re: Bonus points to anyone that can figure this one out.

Andy Brummer15-Jul-08 6:00

Sort by the first 3 characters

15-Jul-08 6:00

so,

for(int i=0; i<source.length;>   {
    result[i] = source[i];
    source[i].~object();
    result[i].~object();
}
return result;

Makes sense to you?

I can imagine the sinking feeling one would have after ordering my book,
only to find a laughably ridiculous theory with demented logic once the book arrives - Mark McCutcheon

leppie8-Jun-08 2:43

8-Jun-08 2:43

Complete class provided for entertainment purposes Poke tongue | ;-P

<font color="Blue">namespace</font> BusinessEntities
<font color="DarkBlue">{</font>
  <font color="Blue">public</font> <font color="Blue">class</font> <font color="Teal">DropDownLists</font>
  <font color="DarkBlue">{</font>
    <font color="Blue">private</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> myList<font color="DarkBlue">;</font>

    <font color="Blue">public</font> <font color="Blue">static</font> <font color="Teal">DropDownLists</font> Construct_DropDownLists<font color="DarkBlue">(</font><font color="DarkBlue">)</font>
    <font color="DarkBlue">{</font>
      <font color="Teal">DropDownLists</font> tmpDropDownLists <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">DropDownLists</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      <font color="Blue">return</font> tmpDropDownLists<font color="DarkBlue">;</font>
    <font color="DarkBlue">}</font>

    <font color="Blue">public</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> MyList
    <font color="DarkBlue">{</font>
      <font color="Blue">get</font>
      <font color="DarkBlue">{</font>
        <font color="Blue">if</font> <font color="DarkBlue">(</font>myList <font color="DarkBlue">==</font> <font color="Blue">null</font><font color="DarkBlue">)</font>
        <font color="DarkBlue">{</font>
          myList <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
        <font color="DarkBlue">}</font>
        <font color="Blue">return</font> myList<font color="DarkBlue">;</font>
      <font color="DarkBlue">}</font>
      <font color="Blue">set</font> <font color="DarkBlue">{</font> myList <font color="DarkBlue">=</font> <font color="Blue">value</font><font color="DarkBlue">;</font> <font color="DarkBlue">}</font>
    <font color="DarkBlue">}</font>

    <font color="DimGray">///</font> <font color="DimGray"><summary></font>
    <font color="DimGray">///</font><font color="DarkGreen"> This method can be customized to return a list of data from any source, e.g database, xml file, object, etc.</font>
    <font color="DimGray">///</font> <font color="DimGray"></summary></font>
    <font color="DimGray">///</font> <font color="DimGray"><param name="tmpDropDownLists"></font><font color="DarkGreen">Object instance of DropDownLists class.</font><font color="DimGray"></param></font>
    <font color="DimGray">///</font> <font color="DimGray"><returns></font><font color="DarkGreen">ItemCollection</font><font color="DimGray"><string></font><font color="DimGray"></returns></font>
    <font color="Blue">public</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> GetTitles<font color="DarkBlue">(</font><font color="Teal">DropDownLists</font> tmpDropDownLists<font color="DarkBlue">)</font>
    <font color="DarkBlue">{</font>
      <font color="DarkGreen">//Currently the data is hardcoded, but can also be queried from a database.</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="Teal">ListItem</font> li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Value <font color="DarkBlue">=</font> <font color="Maroon">"1"</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Text <font color="DarkBlue">=</font> <font color="Maroon">"Mr."</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Value <font color="DarkBlue">=</font> <font color="Maroon">"2"</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Text <font color="DarkBlue">=</font> <font color="Maroon">"Mrs."</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Value <font color="DarkBlue">=</font> <font color="Maroon">"3"</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Text <font color="DarkBlue">=</font> <font color="Maroon">"Me."</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Value <font color="DarkBlue">=</font> <font color="Maroon">"4"</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Text <font color="DarkBlue">=</font> <font color="Maroon">"Dr."</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Value <font color="DarkBlue">=</font> <font color="Maroon">"5"</font><font color="DarkBlue">;</font>
      li<font color="DarkBlue">.</font>Text <font color="DarkBlue">=</font> <font color="Maroon">"Prof."</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="Blue">string</font><font color="DarkBlue">[]</font> myKeys <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Blue">string</font><font color="DarkBlue">[</font>tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Count<font color="DarkBlue">]</font><font color="DarkBlue">;</font>
      <font color="Blue">string</font><font color="DarkBlue">[]</font> myValues <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Blue">string</font><font color="DarkBlue">[</font>tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Count<font color="DarkBlue">]</font><font color="DarkBlue">;</font>
      <font color="Blue">int</font> counter <font color="DarkBlue">=</font> <font color="Red">0</font><font color="DarkBlue">;</font>
      <font color="Blue">foreach</font> <font color="DarkBlue">(</font><font color="Teal">ListItem</font> lit <font color="Blue">in</font> tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">)</font>
      <font color="DarkBlue">{</font>
        myKeys<font color="DarkBlue">[</font>counter<font color="DarkBlue">]</font> <font color="DarkBlue">=</font> lit<font color="DarkBlue">.</font>Value<font color="DarkBlue">;</font>
        myValues<font color="DarkBlue">[</font>counter<font color="DarkBlue">]</font> <font color="DarkBlue">=</font> lit<font color="DarkBlue">.</font>Text<font color="DarkBlue">;</font>
        counter<font color="DarkBlue">++</font><font color="DarkBlue">;</font>
      <font color="DarkBlue">}</font>

      <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> tmpList <font color="DarkBlue">=</font> <font color="Blue">this</font><font color="DarkBlue">.</font>SortItemsAlphabetically<font color="DarkBlue">(</font>myKeys<font color="DarkBlue">,</font> myValues<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList <font color="DarkBlue">=</font> tmpList<font color="DarkBlue">;</font>
      <font color="Blue">return</font> tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">;</font>
    <font color="DarkBlue">}</font>

    <font color="DimGray">///</font> <font color="DimGray"><summary></font>
    <font color="DimGray">///</font><font color="DarkGreen"> This method can be customized to return a list of data from any source, e.g database, xml file, object, etc.</font>
    <font color="DimGray">///</font> <font color="DimGray"></summary></font>
    <font color="DimGray">///</font> <font color="DimGray"><param name="tmpDropDownLists"></font><font color="DarkGreen">Object instance of DropDownLists class.</font><font color="DimGray"></param></font>
    <font color="DimGray">///</font> <font color="DimGray"><returns></font><font color="DarkGreen">ItemCollection</font><font color="DimGray"><string></font><font color="DimGray"></returns></font>
    <font color="Blue">public</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> GetCountries<font color="DarkBlue">(</font><font color="Teal">DropDownLists</font> tmpDropDownLists<font color="DarkBlue">)</font>
    <font color="DarkBlue">{</font>
      <font color="DarkGreen">//Currently the data is hardcoded, but can also be queried from a database.</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="Teal">ListItem</font> li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="Maroon">"Argentina"</font><font color="DarkBlue">,</font> <font color="Maroon">"AR"</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="Maroon">"Bangladesh"</font><font color="DarkBlue">,</font> <font color="Maroon">"BD"</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      <font color="DarkGreen">// huge list snipped</font>

      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="Maroon">"Venezuela"</font><font color="DarkBlue">,</font> <font color="Maroon">"VE"</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      li <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font><font color="Maroon">"Vietnam"</font><font color="DarkBlue">,</font> <font color="Maroon">"VN"</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>li<font color="DarkBlue">)</font><font color="DarkBlue">;</font>

      <font color="Blue">string</font><font color="DarkBlue">[]</font> myKeys <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Blue">string</font><font color="DarkBlue">[</font>tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Count<font color="DarkBlue">]</font><font color="DarkBlue">;</font>
      <font color="Blue">string</font><font color="DarkBlue">[]</font> myValues <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Blue">string</font><font color="DarkBlue">[</font>tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">.</font>Count<font color="DarkBlue">]</font><font color="DarkBlue">;</font>
      <font color="Blue">int</font> counter <font color="DarkBlue">=</font> <font color="Red">0</font><font color="DarkBlue">;</font>
      <font color="Blue">foreach</font> <font color="DarkBlue">(</font><font color="Teal">ListItem</font> lit <font color="Blue">in</font> tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">)</font>
      <font color="DarkBlue">{</font>
        myKeys<font color="DarkBlue">[</font>counter<font color="DarkBlue">]</font> <font color="DarkBlue">=</font> lit<font color="DarkBlue">.</font>Value<font color="DarkBlue">;</font>
        myValues<font color="DarkBlue">[</font>counter<font color="DarkBlue">]</font> <font color="DarkBlue">=</font> lit<font color="DarkBlue">.</font>Text<font color="DarkBlue">;</font>
        counter<font color="DarkBlue">++</font><font color="DarkBlue">;</font>
      <font color="DarkBlue">}</font>

      <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> tmpList <font color="DarkBlue">=</font> <font color="Blue">this</font><font color="DarkBlue">.</font>SortItemsAlphabetically<font color="DarkBlue">(</font>myKeys<font color="DarkBlue">,</font> myValues<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      tmpDropDownLists<font color="DarkBlue">.</font>myList <font color="DarkBlue">=</font> tmpList<font color="DarkBlue">;</font>
      <font color="Blue">return</font> tmpDropDownLists<font color="DarkBlue">.</font>myList<font color="DarkBlue">;</font>
    <font color="DarkBlue">}</font>

    <font color="DimGray">///</font> <font color="DimGray"><summary></font>
    <font color="DimGray">///</font><font color="DarkGreen"> Sorts the items alphabetically.</font>
    <font color="DimGray">///</font> <font color="DimGray"></summary></font>
    <font color="DimGray">///</font> <font color="DimGray"><param name="myKeys"></font><font color="DarkGreen">My keys.</font><font color="DimGray"></param></font>
    <font color="DimGray">///</font> <font color="DimGray"><param name="myValues"></font><font color="DarkGreen">My values.</font><font color="DimGray"></param></font>
    <font color="DimGray">///</font> <font color="DimGray"><returns></font><font color="DarkGreen">Collection</font><font color="DimGray"><ListItem></font><font color="DarkGreen">.</font><font color="DimGray"></returns></font>
    <font color="Blue">private</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> SortItemsAlphabetically<font color="DarkBlue">(</font><font color="Blue">string</font><font color="DarkBlue">[]</font> myKeys<font color="DarkBlue">,</font> <font color="Blue">string</font><font color="DarkBlue">[]</font> myValues<font color="DarkBlue">)</font>
    <font color="DarkBlue">{</font>
      <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font> list <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">Collection</font><font color="DarkBlue"><</font><font color="Teal">ListItem</font><font color="DarkBlue">></font><font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="DarkGreen">// Sorts a section of the Array using the default comparer.</font>
      Array<font color="DarkBlue">.</font>Sort<font color="DarkBlue">(</font>myKeys<font color="DarkBlue">,</font> myValues<font color="DarkBlue">,</font> <font color="Red">1</font><font color="DarkBlue">,</font> <font color="Red">3</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="Blue">for</font> <font color="DarkBlue">(</font><font color="Blue">int</font> i <font color="DarkBlue">=</font> <font color="Red">0</font><font color="DarkBlue">;</font> i <font color="DarkBlue"><</font> myKeys<font color="DarkBlue">.</font>Length<font color="DarkBlue">;</font> i<font color="DarkBlue">++</font><font color="DarkBlue">)</font>
      <font color="DarkBlue">{</font>
        <font color="Teal">ListItem</font> lit <font color="DarkBlue">=</font> <font color="Blue">new</font> <font color="Teal">ListItem</font><font color="DarkBlue">(</font>myValues<font color="DarkBlue">[</font>i<font color="DarkBlue">]</font><font color="DarkBlue">.</font>ToString<font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">,</font> myKeys<font color="DarkBlue">[</font>i<font color="DarkBlue">]</font><font color="DarkBlue">.</font>ToString<font color="DarkBlue">(</font><font color="DarkBlue">)</font><font color="DarkBlue">)</font><font color="DarkBlue">;</font>
        list<font color="DarkBlue">.</font>Add<font color="DarkBlue">(</font>lit<font color="DarkBlue">)</font><font color="DarkBlue">;</font>
      <font color="DarkBlue">}</font>
      <font color="Blue">return</font> list<font color="DarkBlue">;</font>
    <font color="DarkBlue">}</font>
  <font color="DarkBlue">}</font>
<font color="DarkBlue">}</font>

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

Re: Sort by the first 3 characters [modified]

Zani Jnior8-Jun-08 2:52

Zani Jnior

8-Jun-08 2:52

Congratulations to these "self-studies".

-+--+--+--+--+--+--+-+-+-+
Carlos Zani - SP - Brazil
Powered by Microsof.Net

PIEBALDconsult8-Jun-08 5:08

PIEBALDconsult

8-Jun-08 5:08

But which part do you particularly wish to point out?

I find the use of string.ToString() the most humorous.

I'm also not sure what you mean by the title;
Array.Sort(myKeys, myValues, 1, 3);
won't "Sort by the first 3 characters", it sorts the second through fourth items.

modified on Sunday, June 8, 2008 11:14 AM

leppie8-Jun-08 5:32

8-Jun-08 5:32

PIEBALDconsult wrote:
I'm also not sure what you mean by the title;
Array.Sort(myKeys, myValues, 1, 3);
won't "Sort by the first 3 characters", it sorts the second through fourth items.

Exactly

Thats the real horror, how he gets there is a horror too!

All this has been reduced to 2 lines of code getting data straight from the DB.

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

leppie8-Jun-08 5:37

8-Jun-08 5:37

I see now where it comes from! MSDN copy and paste code (and steal the comment while you at it)!! Sigh | :sigh:

http://msdn.microsoft.com/en-us/library/73z19xf7.aspx[^]

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

KarstenK10-Jun-08 1:07

KarstenK

10-Jun-08 1:07

This enhances readability. Blush | :O

Greetings from Germany

Pete O'Hanlon8-Jun-08 9:36

Pete O'Hanlon

8-Jun-08 9:36

leppie wrote:
///
/// This method can be customized to return a list of data from any source, e.g database, xml file, object, etc. ///
/// <param name="tmpDropDownLists" />Object instance of DropDownLists class. /// <returns>ItemCollection<string> public Collection<listitem> GetTitles(DropDownLists tmpDropDownLists) { //Currently the data is hardcoded, but can also be queried from a database. tmpDropDownLists.myList = new Collection<listitem>(); ListItem li = new ListItem(); li.Value = "1"; li.Text = "Mr."; tmpDropDownLists.myList.Add(li); li = new ListItem(); li.Value = "2"; li.Text = "Mrs."; tmpDropDownLists.myList.Add(li); li = new ListItem(); li.Value = "3"; li.Text = "Me."; tmpDropDownLists.myList.Add(li); li = new ListItem(); li.Value = "4"; li.Text = "Dr."; tmpDropDownLists.myList.Add(li); li = new ListItem(); li.Value = "5"; li.Text = "Prof."; tmpDropDownLists.myList.Add(li);

Oh, if only there existed some technology where you could add items from some source of data. That would be sure to catch on. Roll eyes | :rolleyes:

Deja View - the feeling that you've seen this post before.

My blog | My articles

PIEBALDconsult8-Jun-08 17:14

PIEBALDconsult

8-Jun-08 17:14

Only if you publish documentation... perhaps on a website.

This really happened

Zani Jnior8-Jun-08 2:08

Zani Jnior

8-Jun-08 2:08

A team member wrote this peace of code and I still don't know what she wanted with:

string _attempt = "3";
if( _attempt.ToUpper() == 3 )
   // Do Something...

OMG, sometimes I ask myself: Will not be better if I was pastryman?

-+--+--+--+--+--+--+-+-+-+
Carlos Zani - SP - Brazil
Powered by Microsof.Net

leppie8-Jun-08 2:36

8-Jun-08 2:36

I wonder if you are using the same guy as we did! Poke tongue | ;-P

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

Zani Jnior8-Jun-08 2:42

Zani Jnior

8-Jun-08 2:42

This kind of person is in anywhere.

-+--+--+--+--+--+--+-+-+-+
Carlos Zani - SP - Brazil
Powered by Microsof.Net

leppie8-Jun-08 2:45

8-Jun-08 2:45

See my 'little' horror I just posted. Smile | :)

xacc.ide - now with TabsToSpaces support
IronScheme - 1.0 alpha 4a out now (29 May 2008)

Rick York9-Jun-08 21:19

Rick York

9-Jun-08 21:19

Zani Jnior wrote:
sometimes I ask myself: Will not be better if I was pastryman?

I often ask myself the very same thing.

We have a running joke at work : there are career opportunities at Taco Bell. Wink | ;)

Megidolaon18-Jun-08 3:52

Megidolaon

18-Jun-08 3:52

I just realized I use stuff like that all the time.
Well, for testing anyway.

Especially when I'm not sure what the check will be later.
For example I first write the code between the parenthesis and add the check at a later time, but in the mean time, I can't leave it empty because that makes debugging the code in the parenthesis harder.

Maybe the team member wasn't done testing or forgot he wasn't done.