|
The function will ALWAYS return. The try{ return; } are the first 3 lines in the method & where the PreProcess() is called is already wrapped in a try..catch block.
But fortunately we have the nanny-state politicians who can step in to protect us poor stupid consumers, most of whom would not know a JVM from a frozen chicken. Bruce Pierson
Because programming is an art, not a science. Marc Clifton
|
|
|
|
|
like it...
try to return... if you fail, catch the exception and return...
if you can... 
(yes|no|maybe)*
|
|
|
|
|
I cannot begin to imagine how the person who wrote this code thinks...
|
|
|
|
|
MarkBrock wrote: I cannot begin to imagine how the person who wrote this code thinks...
A couple of judicious edits and, voila:
"I cannot imagine the person who wrote this code thinks."
|
|
|
|
|
Don't be so hard on the programmer. There might be couple of reasons for this. May be code skeleton was written to be filled later. Maybe there was function body was well but over time it was removed but function itself was not removed.
-Saurabh
|
|
|
|
|
Saurabh.Garg wrote: it was removed but function itself was not removed
Don't you think that's a little dangerous?
At best it's careless & sloppy. I don't want careless, sloppy devs on my team - do you?
But fortunately we have the nanny-state politicians who can step in to protect us poor stupid consumers, most of whom would not know a JVM from a frozen chicken. Bruce Pierson
Because programming is an art, not a science. Marc Clifton
|
|
|
|
|
I agree that it shows carelessness but how is it dangerous? Actually since I knew nothing about code base and its history I was giving benefit of doubt to the developer.
-Saurabh
|
|
|
|
|
Saurabh.Garg wrote: since I knew nothing about code base
Granted. Suffice it to say that this code forms part of a banking simulator.
Dangerous in that it sets a precedent. This kind of sloppy code shouldn't be checked back into source control. Seriously, if the dev who wrote this was too lazy to clean this up there's a real danger that he'll take shortcuts in other places too. This in itself is already bad & poses a danger to our product as a whole.
So yeah... In my book that's dangerous 
But fortunately we have the nanny-state politicians who can step in to protect us poor stupid consumers, most of whom would not know a JVM from a frozen chicken. Bruce Pierson
Because programming is an art, not a science. Marc Clifton
|
|
|
|
|
least there isn't a performance hit. It could have been throwing exceptions 
protected void Foo()
{
PreProcess(arg);
}
private void PreProcess(string arg)
{
try
{
throw new Exception("Still being worked on..");
}
catch(Exception ex)
{
}
return;
}
|
|
|
|
|
|
<br />
<br />
string drinkType = tbDrinkType.Text;<br />
<br />
if (drinkType != "")<br />
{<br />
tbDrinkType.Text = drinktype;<br />
}<br />
<br />
|
|
|
|
|
Funny.
He/she still keeps on coding?
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
|
|
|
|
|
|
He should be a Technical Lead now.
Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips
A pessimist sees only the dark side of the clouds, and mopes; a philosopher sees both sides, and shrugs; an optimist doesn't see the clouds at all - he's walking on them. --Leonard Louis Levinson
|
|
|
|
|
Definitely.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
This is going on my arrogant assumptions. You may have a superb reason why I'm completely wrong.
-- Iain Clarke
|
|
|
|
|
Not technical lead, but management.
|
|
|
|
|
|
There's a difference in your shop?!? Lucky ruddy you!
N.B. The above expression of technical information and/or opinion shall not be construed as having anything to do with any previous, current, future or potential client; with competitors, successors and/or assigns of the same; nor with any organisation staffed exclusively by individuals each of whom posess at least two functioning brain cells.
N.N.B. The exceptions to the preceding disclaimer should be obvious, self-evident and not in any way identified by (and therefore actionable against) me. So there. 
|
|
|
|
|
Some people like hitting themselves on the head with a hammer. Others even enjoy hitting other people on the head with a hammer. This mental singularity obviously is one who innovates on the second group with a jackhammer.
Jeff Dickey
Seven Sigma Software and Services
Phone/SMS: +65 8333 4403
Yahoo! IM: jeff_dickey
MSN IM: jeff_dickey at hotmail.com
ICQ IM: 8053918
Skype: jeff_dickey
|
|
|
|
|
Can i categorize it with advice ?
http://www.wiltech-center.com
|
|
|
|
|
It's very useful debugging technique, especially in loops, although you can use "Breakpoint Conditions" for that matter:
for(int i=0;i<100;i++)
{
if(i==10)
i=i;
}
Mostly, when you see programmers, they aren't doing anything. One of the attractive things about programmers is that you cannot tell whether or not they are working simply by looking at them. Very often they're sitting there seemingly drinking coffee and gossiping, or just staring into space. What the programmer is trying to do is get a handle on all the individual and unrelated ideas that are scampering around in his head. (Charles M Strauss)
|
|
|
|
|
Mladen Jankovic wrote: It's very useful debugging technique, especially in loops, although you can use "Breakpoint Conditions" for that matter:
sometime I insert quick and crappy code for debugging purposes. But always I comment that portion as being a debug code and not to be included in production. I insert the comment in case I forgot to remove the code and some one may catch it.
Most of the time I use break point conditions
/* I can C */
// or !C
Yusuf
|
|
|
|
|
maybe too much:
drinkType == Whiskey
|
|
|
|
|
this could only be better with getter/setter methods!!
tbDrinkType.Text
{
get
{
return drinkType;
}
set
{
drinkType = value;
}
}
|
|
|
|
|
Management material. Why?
1. discussing what management likes to discuss most, drinking
2. In the way management communicats: repetition and redundancy
3. In the way management thinks: nonsensical
Marc
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
