C / C++ / MFC

CPallini wrote:

The above scenario breaks your code too (unless he starts a single thread per class instance).

class gladiator
{
	gladiator() {}
	virtual ~gladiator()
	{
		// moriuntur te salute
		_beginthread(&threadFunction, 0, this);
	}

	static void threadFunction(void *pargList)
	{
		if (!pargList)
			return;

		gladiator * pActor = static_cast<gladiator *>(pargList);
		
		// pActor dead or about to be; using it will be deadly.

		_endthread();
	}
};

class gladiator
{
	gladiator()
	:	m_bThreadAlive(false),
		m_bStopThread(false),
		m_hThread(-1)
	{
		m_hThread = _beginthread(&threadFunction, 0, this);
		// check for error return value (-1)
	}
	virtual ~gladiator()
	{
		shutdown();
	}

protected:
	bool m_bThreadAlive; 
	bool m_bStopThread; 
	HANDLE m_hThread;

	virtual void shutdown()
	{
		if (m_bThreadAlive) {
			do {
				m_bStopThread = true;
			} while (m_bThreadAlive);
		}
	}

	static void threadFunction(void *pargList)
	{
		if (!pargList)
			return;

		gladiator * pActor = static_cast<gladiator *>(pargList);
		pActor->m_bThreadAlive = true;
		
		while (!pActor->m_bStopThread) {
			// fight
		}

		pActor->m_bThreadAlive = false;
		_endthread();
	}
}; 

void shutdown()
{
	if (m_bThreadAlive) {
		m_bStopThread = true;
		long lCoundown = 10000L;
		do {
			if (--lCoundown < 1L) {
				if (!TerminateThread(m_hThread, -1)) {
					// throw an exception
				}
				m_bThreadAlive = false;
			}
		} while (m_bThreadAlive);
	}
}

Lord_Draconis wrote:

It seems to work on XP but not on Vista but I maybe wrong.

BOOL CBullet::GoDown()
{
    if((m_ptPosition.y+m_rtThis.Height())>m_rtParent.bottom)
    {
        m_ptPosition.y+=2;
        m_bCanGo=TRUE;
        return TRUE;
    }
    else
    {
<code>        m_bCanGo=FALSE;
        ::WaitForSingleObject(m_pThread, INFINITE);
</code>
        this->DestroyWindow();
        m_bCreated=FALSE;
        return FALSE;
    }
}

Mark Salsbery
Microsoft MVP - Visual C++