|
No other documentation exists except for the code below. Some may be personal preference, but I counted four problems. Maybe you can spot more. 
(The code is supposed to be compliant with Java 5.0)
public interface InvitationInterface {
...
public ArrayList sendMulipleInvitations (List listemailAddresses,String msg);
...
}
-- modified at 18:35 Friday 16th November, 2007
|
|
|
|
|
One big thing stands out. Java. Urgghhhhh. Just stop there, move along - there's nothing to see, move along.
|
|
|
|
|
|
Excellent. 'Got tired of all these "great" Java tools. (DB2 Command Center is my personal favorite).
Perhaps is the moment to get back to the roots - "do one thing, and do it well".
Nuclear launch detected
|
|
|
|
|
Vasudevan Deepak Kumar wrote: No official Java support from Microsoft after December 31, 2007.
So, at last they are burying their long dead crippled Java-look-alike obscenity?
Fine. We all use SUNs VM for years now.
Please do not try to sound like there will be no more Java.
Someone might actually believe you. 
And those who do not and read the whole story will come to see you as a liar.
One does not have to like Java, but at the very least one has to acknoledgr that it inspired MS to bring us .NET 
Let's think the unthinkable, let's do the undoable, let's prepare to grapple with the ineffable itself, and see if we may not eff it after all.
Douglas Adams, "Dirk Gently's Holistic Detective Agency"
|
|
|
|
|
1) I don't like that "Interface" suffix. And that Invitation is an interface (why?). And what it does anyway? Can't say without complete definition, but IInvitationSender sounds better to me.
2) sendMulipleInvitations should be sendMultipleInvitations (unless you did that typo while posting)
3) listemailAddresses - get rid of that "list" prefix
4) um, what the hell sendMulipleInvitations returns? All invitations that were sucessfully send? Or else I dunno... Either the method has wrong name, or strange return type. Anyway, yeah, List of addresses, hmm better use some EmailAddressCollectionn or List<EmailAddress> (assuming there is class like that, otherwise something like StringCollection).
[ My Blog] "Visual studio desperately needs some performance improvements. It is sometimes almost as slow as eclipse." - Rüdiger Klaehn "Real men use mspaint for writing code and notepad for designing graphics." - Anna-Jayne Metcalfe
|
|
|
|
|
Let's be positive about this one:
1. there IS an interface, supporting loosely coupled designs
2. it is public, everyone could use it
3. its name starts with capital I
4. all parentheses and brackets are nicely balanced
5. the elipses show where the comments could go
6. maybe documentation will be added eventually?
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips:
- use PRE tags to preserve formatting when showing multi-line code snippets
- before you ask a question here, search CodeProject, then Google
|
|
|
|
|
I found some meaningless code in my project. do you have any idea about its logic?
protected void Page_Load(object sender, EventArgs e)<br />
{<br />
string sHafta = string.Empty;<br />
try<br />
{<br />
sHafta = ddlHafta.SelectedValue;<br />
}<br />
catch (Exception)<br />
{<br />
sHafta = "0";<br />
}<br />
}
note that sHafta is a local variable
-- modified at 5:27 Tuesday 13th November, 2007
|
|
|
|
|
Looks like the code is "shaftad"
Poor pun sorry.
I still remember having to write your own code in FORTRAN rather than be a cut and paste merchant being pampered by colour coded Intellisense - ahh proper programming - those were the days
|
|
|
|
|
classic!
WPF - Imagineers Wanted
Follow your nose using DoubleAnimationUsingPath
|
|
|
|
|
Leftover debugging code, you know, no one ever has to understand a single line of debugging code, as long as you remember to remove it
xacc.ideIronScheme a R5RS-compliant Scheme on the DLR
The rule of three: "The first time you notice something that might repeat, don't generalize it. The second time the situation occurs, develop in a similar fashion -- possibly even copy/paste -- but don't generalize yet. On the third time, look to generalize the approach."
|
|
|
|
|
hi there, i think that maybe you don't need this code in this part, because you're doing nothing , the local variables end in the end of method and I think that this code is just for spending a little more your memory....
exists any posibility that this code has the logic that you wanted to set this variable to any of you controls (like label, textbox etc), but you did not set to anyone of your control.
I think that you forgot to set this value to any of your control.
respect
spaps
|
|
|
|
|
They must have been using the Hafta.net testing framework: Hafta.net.
|
|
|
|
|
There is missing some logic, as assigning sHafta to a member. I hope so...
Greetings from Germany
|
|
|
|
|
I've just read an article that included this little gem
:
if (Convert.ToInt16(chkdate.Length.ToString()) != 11)
{
return false;
}I really don't know where to start (and yes, chkdate is a string).
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
Odd that it does "actually" check for 11 characters. I wonder what the code looks like that ensures the "dd/MMM/yyyy" format. There's likely a gem or two in that as well.
|
|
|
|
|
Here[^] you go. Enjoy.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
Great. It doesn't validate a thing. 
|
|
|
|
|
|
It is now. It was removed because it was so bad and about the best comment against it was that it was complete and utter rubbish.
Deja View - the feeling that you've seen this post before.
|
|
|
|
|
Pete O`Hanlon wrote: It was removed
It should have been 'An Article of Horror'. It is bad that it was removed and CP deprived many of a viewing pleasure. 
|
|
|
|
|
It worries me that we are spiralling into some kind of recursive software hellhole:
void WritePoorCode()
{
bool stuck = true;
if (stuck)
{
GetHelpFromAnotherMuppet();
}
}
void GetHelpFromAnotherMuppet()
{
WritePoorCode();
}
|
|
|
|
|
|
Add tail calls, and it will run forever
xacc.ideIronScheme a R5RS-compliant Scheme on the DLR
The rule of three: "The first time you notice something that might repeat, don't generalize it. The second time the situation occurs, develop in a similar fashion -- possibly even copy/paste -- but don't generalize yet. On the third time, look to generalize the approach."
|
|
|
|
|
Kermit the coder.
Deja View - the feeling that you've seen this post before.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
