The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Assignment [modified]

Jim Warburton5-Nov-07 6:39

Jim Warburton

5-Nov-07 6:39

Spent about 45 min trying to figure out why title was lost after returning at the end of the function Blush | :O

DoSomething(Text *text_store, int seven)<br />
{<br />
   char *text;<br />
   text = (char*) malloc(sizeof(char) * seven);<br />
//more code<br />
   text_store.title = text;<br />
   free(text);<br />
} <br />

-- modified at 15:05 Monday 5th November, 2007
And yes text_store.title is a pointer

this thing looks like it was written by an epileptic ferret
Dave Kreskowiak

Re: Assignment

James R. Twine5-Nov-07 6:45

James R. Twine

5-Nov-07 6:45

Is your post missing some content?

Peace!

-=- James
Please rate this message - let me know if I helped or not!<HR>If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
See DeleteFXPFiles

Re: Assignment

leppie5-Nov-07 8:23

leppie

5-Nov-07 8:23

I think thats what the // more code is for Smile | :)

xacc.ide

The rule of three: "The first time you notice something that might repeat, don't generalize it. The second time the situation occurs, develop in a similar fashion -- possibly even copy/paste -- but don't generalize yet. On the third time, look to generalize the approach."

Re: Assignment

James R. Twine5-Nov-07 12:00

James R. Twine

5-Nov-07 12:00

The post originally showed no code, then was modified (after my post).

Peace!

Re: Assignment

Chris Meech5-Nov-07 8:55

Chris Meech

5-Nov-07 8:55

Well if the type of 'text_store.title' is pointer, then you are freeing the memory that it points to. That will usually create havoc. Smile | :)

Chris Meech
I am Canadian. [heard in a local bar]
Donate to help Conquer Cancer[^]

Re: Assignment

KarstenK8-Nov-07 2:59

KarstenK

8-Nov-07 2:59

Make title a CString and it should work fine. Blush | :O

Greetings from Germany

Re: Assignment

Tomas Brennan19-Nov-07 4:53

Tomas Brennan

19-Nov-07 4:53

Uhh....loooks like you've forgotten 1 extra for NUL terminated char...

text = (char*)malloc(sizeof(char) * (seven + 1));

And also...check for NULL if this fails...my c skills are a bit rusty so excuse if I trip up, from what I can remember this nice terse statement which was favourite of mine..

if (!(text = (char*)malloc(sizeof(char) * (seven+1)))){
...mem is gud...
}else{
...phffft...
}

this is a nice lil exercise since I used to program in C professionally, then switched over to C# cos the skillset was dwindling in the IT sector here in Ireland... not sure why you'd free the pointer though...I think that you'll have garbage in text_store.title...I could be way off here on this...

Take care,

Tom

#define STOOPID
#if STOOPID
Console.WriteLine("I'm stoopid!");
#endif

For loop horror

Llasus1-Nov-07 14:12

Llasus

1-Nov-07 14:12

I just spent an hour trying to think why the process didn't work.

for(int nindex = MIN_VAL; nindex <= MAX_VAL; nindex++);<br />
{<br />
  //50 lines of code that processes something<br />
}

Maybe everyone has these kind of moments. D'Oh! | :doh:

The Weird and The Wonderful

MY NEW BLOG