|
When happened to me, I thought for a (long) while about a compiler bug, before finding the ****** semicolon.
If the Lord God Almighty had consulted me before embarking upon the Creation, I would have recommended something simpler.
-- Alfonso the Wise, 13th Century King of Castile.
|
|
|
|
|
took me about five seconds to see the error.
maybe I've stumbled into most sh*t already.
Larswad
|
|
|
|
|
A simple example of how not to copy a string...
sprintf(packet.data.header.filter, "%s", "wild");
it works, I suppose.
Rob Grainger
|
|
|
|
|
The ones I love are these (assuming 8-bit characters) :
strncpy( szDestination, szSource, sizeof(szSource) );
or
strncpy( szDestination, szSource, strlen(szSource) );
or
strncpy( szDestination, szSource, strlen(szDestination) );
|
|
|
|
|
For us noobs, what is wrong with the last one? At least it uses the destination length.
|
|
|
|
|
I am noob too, but I dare to guess that it loses terminating zero.
[ My Blog] "Visual studio desperately needs some performance improvements. It is sometimes almost as slow as eclipse." - Rüdiger Klaehn "Real men use mspaint for writing code and notepad for designing graphics." - Anna-Jayne Metcalfe
|
|
|
|
|
|
It works if the current contents of the destination are smaller than the source string. It won't copy entirely if the current destination contents are less than the source, even if the buffer is physically large enough to hold the source. By using strlen, it does not use the full available length of the destination buffer. strlen versus sizeof
Judy
|
|
|
|
|
Spot on 
|
|
|
|
|
well, imagine that:
char szDestination[] = { 0xFF, 0xFF };<br />
<br />
strncpy(szDestination, szSource, strlen(szDestination));
what do you think would be strlen() here?
-- modified at 22:38 Thursday 1st November, 2007
|
|
|
|
|
It's an improved random generator!
|
|
|
|
|
Steve Hansen wrote: It's an improved random generator!
ROFL
I ought to patent this!
Except if you do strncpy() as given you would most likely overwrite the return address or whatever comes next in enclosing function.
|
|
|
|
|
back in K&R C days this was always special:
memcpy( dest, src );
|
|
|
|
|
Seen the same dumb stuff to "clear a string":
sprintf( pcSomeStringBuffer, "%s", "");
<code>
strcpy( pcSomeStringBuffer, "" ); Peace!
-=- James Please rate this message - let me know if I helped or not!<HR>If you think it costs a lot to do it right, just wait until you find out how much it costs to do it wrong!
Avoid driving a vehicle taller than you and remember that Professional Driver on Closed Course does not mean your Dumb Ass on a Public Road!
See DeleteFXPFiles
|
|
|
|
|
Who the hell names database fields 'from' and 'to'? Need I say more? 
|
|
|
|
|
This can be a lot of fun if you have to work with that
Cheers
You have the thought that modern physics just relay on assumptions, that somehow depends on a smile of a cat, which isn’t there.( Albert Einstein)
|
|
|
|
|
SELECT [SELECT], [FROM], [TO], [WHERE], [ORDER] FROM [WHERE] WHERE [WHERE]='GROUP BY OR HAVING'
This blanket smells like ham
|
|
|
|
|
 This same schema just caught me again, as I have a policy of naming all my DAL parameters the exactly the same as the column names, which works Ok until a column that is called IsNew in a view is actually called 'new' in the table.
|
|
|
|
|
That reminds me of some fun I used to have (aeons ago) in Coral-66:
'FOR' FOR = 0 'TO' TO 'STEP' STEP 'UNTIL' UNTIL
'BEGIN'
BEGIN;
END;
'END'
something like that anyway - I can't remember the exact syntax
Phil
The opinions expressed in this post are not necessarily those of the author, especially if you find them impolite, inaccurate or inflammatory.
|
|
|
|
|
Database designers who don't have to write any SQL.
|
|
|
|
|
I also deal with gems like Tax%. Hey, 'like Tax%'...
|
|
|
|
|
I myself just created a table named Group. I also have a table named Parameter. And a field named When. But (so far) only I need to deal with them.
|
|
|
|
|
PIEBALDconsult wrote: But (so far) only I need to deal with them.
So you still have the chance to fix this foolishness before it gets into the real world... 
-------------------------------------------
Don't walk in front of me, I may not follow;
Don't walk behind me, I may not lead;
Just bugger off and leave me alone!!
|
|
|
|
|
PIEBALDconsult wrote: And a field named When
And a field named "Poof"?
Luc Pattyn [Forum Guidelines] [My Articles]
this months tips:
- use PRE tags to preserve formatting when showing multi-line code snippets
- before you ask a question here, search CodeProject, then Google
|
|
|
|
|
I once had to deal with a database that had dashes in the field names. That was the first time we ever had to lookup how to quote identifiers and were horrified to find that there was no standard. What worked on one system just made it a quoted string on another. 
Meddle not in the affairs of dragons, for you are crunchy and taste good with catchup.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
