Re: CString return - C / C++ / MFC Discussion Boards

jhwurmbach15-Aug-07 21:39

15-Aug-07 21:39

GetText is checking its input data.
What are you inputting to it?
Use the debugger to set a breakpoint and check the value.

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 22:10

tyagineha

15-Aug-07 22:10

I dont want return value of GetText() function
i want return value of _case variable

NT

Re: CString return

jhwurmbach15-Aug-07 22:12

jhwurmbach

15-Aug-07 22:12

Sure. But you are calling GetText() with index and _case.
And GetText is checking its paramteres...

Did you ever check the value of index?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 22:16

tyagineha

15-Aug-07 22:16

But i think the function of GetText() is that watever text is at index(watevr value) will be stored in _case.

just tell the way i m returning the value of _case is correct or not????

NT

Re: CString return

jhwurmbach15-Aug-07 22:40

jhwurmbach

15-Aug-07 22:40

tyagineha wrote:
But i think the function of GetText() is that watever text is at index(watevr value) will be stored in _case.

You could have read MSDN about GetText(). The index is zerobased.

Hence my repeated question (which you seem to refuse to answer): What are you calling GetText() with?
Are you calling it with invalid indices (like, perchance, -1)?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:00

tyagineha

15-Aug-07 23:00

ok i m sorry 4 that....
i m inputting a ListBox value..........

NT

Re: CString return

jhwurmbach15-Aug-07 23:04

jhwurmbach

15-Aug-07 23:04

And your Listbox does have 5 entries?
Or does it have 4, and the last one is selected?

Then you have falling in the ole off-by-one trap. Poke tongue | ;-P

Indices are counting from 0: the last element of the Listbox has the index (SizeOfListbox -1)

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:12

tyagineha

15-Aug-07 23:12

rite now listbox has only one entry.
this function i m defining in one class and calling in another class...

the problem which u r saying..

that problem i m nt gntng when i m in same class
but when calling this function fron another class then error is cuming.

tell me watshld i do now??

Nt

Re: CString return

jhwurmbach15-Aug-07 23:16

jhwurmbach

15-Aug-07 23:16

tyagineha wrote:
tell me watshld i do now??

Write proper English. I am not a native speaker and may get your abbreviations wrong. Also, this stuff is complicated enough.

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:23

tyagineha

15-Aug-07 23:23

Tell me what should i do now????

NT

Re: CString return

jhwurmbach15-Aug-07 23:25

jhwurmbach

15-Aug-07 23:25

Set a breakpoint on return _case; and see if it looks OK in the debugger.

If it does, single step into your other class and look if it is still OK.

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:35

tyagineha

15-Aug-07 23:35

its not ok in debugger...
its giving debug error.

i just want to return the value which is in _case.

i want to use this value furthur.

NT

Re: CString return

jhwurmbach15-Aug-07 23:37

jhwurmbach

15-Aug-07 23:37

tyagineha wrote:
i just want to return the value which is in _case.

So the CString _case is ok at the end of your function (as listed above). And it is not OK in the function calling that?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

jhwurmbach15-Aug-07 23:32

jhwurmbach

15-Aug-07 23:32

tyagineha wrote:
rite now listbox has only one entry.

But you are calling for the 4th one?
Could this work?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:38

tyagineha

15-Aug-07 23:38

sorry i m not getting you.

Nt

Re: CString return

jhwurmbach15-Aug-07 23:41

jhwurmbach

15-Aug-07 23:41

You said:
"The index is 4"
and
"rite now listbox has only one entry."

Are you calling CListBox::GetText( 4, _case) in a CListBox that has only 1 entry?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

tyagineha15-Aug-07 23:46

tyagineha

15-Aug-07 23:46

hey i didnt said 4....
i said only that my listbox has only 1 entry..

NT

Re: CString return

jhwurmbach15-Aug-07 23:48

jhwurmbach

15-Aug-07 23:48

You are right. I was unable to decipher you SMS-style 1337-speak.
Here.[^]

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return [modified]

tyagineha15-Aug-07 23:45

tyagineha

15-Aug-07 23:45

Okey let me explain in detail.

void CMyProj::OnSelchangeList()
{
CClientdemoDlg dlgobj;
dlgobj.OnClientChangeListbox();
}

void CClientdemoDlg::OnClientChangeListbox()
{
CMyProj objnew;
CString _temp;
_temp=objnew.OnTextList();
}

CString CMyProj::OnTextList()
{
int index;
CString _case;
index = m_caselist.GetCurSel();

m_caselist.GetText(index,_case);

return _case;
}

notice the classes.......

NT

-- modified at 5:54 Thursday 16th August, 2007

NT

Re: CString return

kakan15-Aug-07 23:51

kakan

15-Aug-07 23:51

tyagineha wrote:
void CClientdemoDlg::OnClientChangeListbox()
{
CMyProj objnew;
CString _temp;
_temp=objnew.OnText();
}

But in your example you show the code for CMyProj::OnTextList().

It seems as you think you are calling CMyProj::OnTextList(), but in your sample you call CMyProj::OnText()

Maybe you should look for the problem in CMyProj::OnText() ?

Alcohol. The cause of, and the solution to, all of life's problems - Homer Simpson

Re: CString return

jhwurmbach15-Aug-07 23:52

jhwurmbach

15-Aug-07 23:52

Ok. What and where is your Error?
Not just "Debug Assert", but complete details, please.

I get from what you have written, that _case ist still OK, but after it has been assigned to _temp it is no longer OK?

Though I speak with the tongues of men and of angels, and have not money, I am become as a sounding brass, or a tinkling cymbal.
George Orwell, "Keep the Aspidistra Flying", Opening words

Re: CString return

kakan16-Aug-07 0:12

kakan

16-Aug-07 0:12

So you corrected your code sample without telling anyone?

I suggest you do like this:

1. Learn how to use the debugger. (It's not too hard).
2. Put a breakpoint on this line: _temp=objnew.OnTextList();
3. Single-step your code, line by line and examine what's happening.

That's it. And that's exactly what other people do, IMO.
For a good reason.

Alcohol. The cause of, and the solution to, all of life's problems - Homer Simpson

Re: CString return

JudyL_MD16-Aug-07 2:34

JudyL_MD

16-Aug-07 2:34

Short answer: You have created an object of type CClinetdemoDlg but you have not created the actual dialog. The call to both GetCurSel and GetText will fail because they required a window to operate on.

Long answer: You appear to be creating lots of temporary instances of the dialog and your CMyProj class. The act of creating the instance does NOT associate the just-created instance with the already existing one. In OnSelChangeList, you create a CClientdemoDlg. This is NOT associated with the actual dialog that I assume you created elsewhere. You then call OnClientChangeListbox in an instance not associated with a window. This causes the problem I mentioned earlier. Also, in that function, you create an instance of CMyProj. This instance is NOT the same as the one that called the function. This is important because you then call OnTextList in the just-created instance of CMyProj and in that function reference the member variable m_caselist. This variable is not the same as the one in the original class that started this calling chain. Accessing this variable will not affect the original caller.

Judy

Re: CString return

David Crow16-Aug-07 3:14

David Crow

16-Aug-07 3:14

What line of what file is asserting?

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Re: CString return

David Crow16-Aug-07 3:16

David Crow

16-Aug-07 3:16

tyagineha wrote:
can any body tell me why i m getting error in this code?????????

You failed to indicate the error. We are not mind readers. Roll eyes | :rolleyes:

Set a breakpoint on the GetCurSel() statement and single-step over each statement, noting the values of index and _case along the way.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.