Simplify this code - C# Discussion Boards

Re: Binary conversion , Help please!!

Fara762-Aug-07 15:54

Fara76

2-Aug-07 15:54

I finally fixed the code, it is working now! thanks anyway

Aspect Oriented Programing in C#

Kevin Kinnett1-Aug-07 8:33

Kevin Kinnett

1-Aug-07 8:33

I am trying to implement state verification as part of our automated testing framework. I want to use aspects to run a pre check and post check of any particular method call and only have an attribute indicating that that would be a verifiable method. This would be transparent to both the called and client code, performance is not an issue.

There are two articles i have fond on the code project that touch on aspects in C#:
http://www.codeproject.com/cs/design/aopsimplestscenario.asp?msg=2160427&mode=all&userid=3765364#xx2160427xx
http://www.codeproject.com/csharp/aspectintercept.asp?msg=2145384&mode=all&userid=3765364#xx2145384xx

Both use ContextBoundObject in their implementations. It seems that both solutions suffer from the same problem. Method injection does not work when a method is called from inside its own class. Something like this.

/***Will properly call pre and post methods*****/
MyClass myClass = new MyClass();
myClass.CallMethod();

/***Will not call pre and post methods*****/
this.CallMethod()

Has anyone else run into this problem? Am i going down the wrong path? Is there a better solution to the problem?

Re: Aspect Oriented Programing in C#

Not Active1-Aug-07 9:38

Not Active

1-Aug-07 9:38

Not sure if it's what you are looking for, but have you looked at the Policy Injection Block in the latest Enterprise Library release?

http://www.codeplex.com/entlib[^]

only two letters away from being an asset

How to adjust timeouts when loading from web (help!)

doug11111-Aug-07 8:33

doug1111

1-Aug-07 8:33

Hi folks-- first post

I'm encountering timeouts when opening URLs to a long-running webpage. It's actually a web service of sorts; the url returns an XML-encoded query result. The problem is that the result is pretty big and can take more than a minute to run. The C# program fails with an exception related to the timeout.

XmlReader reader = XmlReader.Create("http://theserver/thequery?param=1");

The problem is, I can't figure out how to adjust the timeout. That setting is in one of the hidden classes that XMLReader wraps (possibly System.IO.Stream.ReadTimeout or .CanTimeout), but I there doesn't seem to be a way to get to it to change or turn off the timeout.

Help??

Re: How to adjust timeouts when loading from web (help!)

Not Active1-Aug-07 9:07

Not Active

1-Aug-07 9:07

May you should change tactics then. Use a WebRequest and create the XmlReader after the results have been returned.

only two letters away from being an asset

Re: How to adjust timeouts when loading from web (help!)

doug11111-Aug-07 9:27

doug1111

1-Aug-07 9:27

Hi Mark
thanks for the tip. WebRequest does have a timeout setting.

I have yet to test this, but is this the right approach?

HttpWebRequest hwReq = HttpWebRequest.Create("http://server/query");<br />
hwReq.Timeout = 120000;   //120 seconds<br />
WebResponse wRes = hwReq.GetResponse();<br />
XmlReader reader = XmlReader( wRes.GetResponseStream() );

Also, do you know whether the WebRequest.Timeout property deals with time to open the http connection, time between request and response, or time for response to complete? The response stream itself does have its own Timeout setting.

thanks again!

Re: How to adjust timeouts when loading from web (help!)

Not Active1-Aug-07 9:33

Not Active

1-Aug-07 9:33

The timeout is inclusive. You can also use it asynchronously.

only two letters away from being an asset

Simplify this code

eggie51-Aug-07 8:16

eggie5

1-Aug-07 8:16

if(!reader.IsDBNull(4))
                {
                    c.SourceVideoClip=reader.GetString(4).Trim();
                }

Can the above code, be refactored to use the tertiary operator?

/\ |_ E X E GG

Re: Simplify this code

eggie51-Aug-07 8:31

eggie5

1-Aug-07 8:31

Does this work:

c.SourceVideoClip= (!reader.IsDBNull(4)) ? c.SourceVideoClip = reader.GetString(4).Trim() : null;

/\ |_ E X E GG

Re: Simplify this code

Luc Pattyn1-Aug-07 8:43

Luc Pattyn

1-Aug-07 8:43

No, when false no assignment should occur. Where did the null come from ?

The one possibility I see is:

c.SourceVideoClip= (!reader.IsDBNull(4)) ?
reader.GetString(4).Trim() : c.SourceVideoClip;

but even that is not absolutely correct; in several situations it could differ
from the original (when the condition is false):

when c is null;
when SourceVideoClip is a property without a getter;
when it is a property with side effects in its getter;
when it is a property that is not returning what you set it to (you should not do this, but you could...)
when it is volatile, i.e. other threads (or hardware) may cause it to change;

There may be a better attempt if something more was known about the c type !

Smile | :)

Luc Pattyn

try { [Search CP Articles] [Search CP Forums] [Forum Guidelines] [My Articles] }
catch { [Google] }

Re: Simplify this code

Not Active1-Aug-07 9:04

Not Active

1-Aug-07 9:04

Sure

SELECT param1, param2, param3, param4, ISNULL(SourceVideoClip, '')
FROM MyTable

c.SourceVideoClip=reader.GetString(4).Trim();

only two letters away from being an asset

ListViews and Context Menus..,

Shy Agam1-Aug-07 7:49

Shy Agam

1-Aug-07 7:49

Hello experts,

I'm trying to have a certain context menu popup when right clicking a ListView's headers, and another context menu popup when right clicking inside of the ListView.

Problem is I can't find a way to monitor right clicks on the headers.
The ColumnClick event only gets fired when left clicking, and the MouseUp, MouseDown, MouseClick, etc. events are only fired when the mouse is bellow the headers (inside of the ListView).

Any suggestions?

Thanks in advance,
Shy.

Re: ListViews and Context Menus..,

Shy Agam1-Aug-07 8:56

Shy Agam

1-Aug-07 8:56

I've developed a simple workaround...
Here it is in case someone finds this post in the future...

The ContextMenuStrip property of the ListView is initially set to hold the context menu used when clicking the headers.
Assuming that the ListView is called "list", the context menu for the headers is called "ctxtHeaders", and the context menu for the body of the list is called "ctxtBody", here is the implementation:

private void list_MouseDown(object sender, MouseEventArgs e)
{
    if (e.Button == MouseButtons.Right)
        list.ContextMenuStrip = ctxtBody;
}

private void ctxtBody_Closing(object sender, ToolStripDropDownClosingEventArgs e)
{
    list.ContextMenuStrip = ctxtHeaders;
}

The code is settings the list's context menu to the body's context menu every time it is about to be shown (i.e. when the right mouse botton is clicked).
Then, when the context menu is closed, the list's context menu is set to the headers context menu.

TableAdapter Configuration failure

lsconyer1-Aug-07 7:14

lsconyer

1-Aug-07 7:14

Hello world,

I'm working with vs 2005 using a typed dataset. I have a table, 'Trans', that has a relationship with 3 different parent tables ('Participants', 'Service Types', & 'Dependents'). In my actual database, Trans has a foreign key called 'serviceTypeID' which is the primary key in ServiceTypes. I just added a relationship with the other tables in visual studio. The problem lies in a column I created named 'service' in the Trans table. It's expression is Parent(FK_Transactions_ServiceTypes).service. This works fine when I run my program but as soon as I try to configure my TransactionsTableAdapter, I get this weird error 'Cannot find the parent relation 'FK_Transactions_ServiceTypes''. Mind you, I didn't rename the relation or even create it. It was done automatically and all the spelling is correct. Like I said, the expression works when I run my program. Anybody else run across this problem?

Lester
http://www.lestersconyers.com

DataGrid

ramdil1-Aug-07 5:59

ramdil

1-Aug-07 5:59

Hi all
I am working with datagrid of 2005.I have 10 rows in it.It has three columns.
Id,Name,ParentId
Now my scenario is that if first records id is the parent id for all other 9 records, i need to select entire rows.for that i was using grid.select property but its not working,means its not getting selected
i am giving the partial code..can anyone give me what is gng wrong in this code
Advnaced thanks
for (int tmpCnt = 0; tmpCnt < AuthorisedTable.Rows.Count; tmpCnt++)
{
//if (dataGridAuthorised.IsSelected(tmpCnt) )//
if (AuthorisedTable.Rows[tmpCnt]["Type"].ToString()=="Meeting")
{
string tmpOtherID = (AuthorisedTable.Rows[tmpCnt]["EventId"].ToString());
for (int tmpRace = 0; tmpRace < AuthorisedTable.Rows.Count; tmpRace++)
{
if (AuthorisedTable.Rows[tmpRace]["OtherID"].ToString() == tmpOtherID)
{
this.dataGridAuthorised.Select(tmpRace);
}
}
}
}

Regards
DilipRam

Re: DataGrid

il_masacratore1-Aug-07 6:36

il_masacratore

1-Aug-07 6:36

Try to replace the
this.dataGridAuthorised.Select(tmpRace);
to
this.dataGridAuthorised.Rows[tmpRace].Selected=true;

And check the selection mode property.

Visit my blog at http://dotnetforeveryone.blogspot.com/

Re: DataGrid

ramdil1-Aug-07 6:46

ramdil

1-Aug-07 6:46

Hi thanks for the reply, but i am not getting dataGridAuthorised.Rows property

Any idea

Regards
DilipRam

How can i know witch button send me the event ?

Yanshof1-Aug-07 5:32

Yanshof

1-Aug-07 5:32

I have some Form - and i have some User Control on it.
I have also 6 button on the form and 4 button on the User Control.

In Form code i have some function that collect all the event from all the button ( The Form button and also from the User Control Button) .

My problem is that i need to know in run time witch button send me the event.

I cant use the "Tag" of the button because i using it for other target.

How to do it ?

How can i know if the button is Form relevant or relevant User control ???

Thanks for any help.

Re: How can i know witch button send me the event ?

Tarakeshwar Reddy1-Aug-07 5:38

Tarakeshwar Reddy

1-Aug-07 5:38

You can use the sender to find out which button was clicked

((Button)sender).Name<br />

Re: How can i know witch button send me the event ?

Yanshof1-Aug-07 5:41

Yanshof

1-Aug-07 5:41

I cant use this way because there are some button with same name on the Form and on the userControl.

I need some way to know who the owner of this button.

Is it the Form OR is it any of the userControls ....

Re: How can i know witch button send me the event ?

il_masacratore1-Aug-07 5:49

il_masacratore

1-Aug-07 5:49

Use the sender and the ((Control)sender).Parent property together to know which control is.

Visit my blog at http://dotnetforeveryone.blogspot.com/

Re: How can i know witch button send me the event ?

Martin#1-Aug-07 5:52

Martin#

1-Aug-07 5:52

Hello,

I would use the 'as' operator for the casting.

Button actButton = sender as Button;
if(actButton!=null)
{
    actButton.Name

    //for the validation of the "owner", use the parent property and the 'is' operator
    if(actButton.Parent!=null)
    {
        if(actButton.Parent is YourUserControl_1)
        {

        }
        else if(actButton.Parent is YourUserControl_2)
        {
        
        }
    }
}

All the best,

Martin

Thanks

Yanshof1-Aug-07 6:04

Yanshof

1-Aug-07 6:04

Thanks.

You are wellcome!

Martin#1-Aug-07 6:15

Martin#

1-Aug-07 6:15

All the best,

Martin

Re: How can i know witch button send me the event ?

Scott Dorman1-Aug-07 13:32

Scott Dorman

1-Aug-07 13:32

You can also check out this thread, which asked almost the same question.
http://www.codeproject.com/script/comments/forums.asp?forumid=387161&Page=3&userid=157870&mode=all&select=2094274&df=100&fr=231.5#xx2094274xx[^]

As others have already pointed out, casting the sender to a Button and then looking at it's properties (name, tag, etc.) to determine which button it is will be the best way to go.

The question that it seems no one asked is why do you need to route 10 buttons through the same event handler? Surely all 10 buttons don't do the same thing? If they actually do different things and you are trying to use 1 event handler to do some common things (like logging, for instance) you would probably be better off to use separate event handlers for each button and then have each event handler call a separate common method.

-----------------------------
In just two days, tomorrow will be yesterday.

http://geekswithblogs.net/sdorman

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.