Re: Grey Scale Image error?? - C# Discussion Boards

Software_Specialist19-Jun-07 5:04

19-Jun-07 5:04

Hi below is the code for conversion to grey scale image.
But i am getting exception at first line of the GrayScale function that
Object reference not set to an instance of an object.
I am using VS2005.

Any help would be appreciated....
Thanks

<br />
<br />
private Bitmap b;<br />
<br />
private void GrayScaleMenuItem_Click(object sender, System.EventArgs e)<br />
		{<br />
			if(GrayScale(b))<br />
			this.Invalidate();<br />
		}<br />
<br />
<br />
public static bool GrayScale(Bitmap b)<br />
		{<br />
		BitmapData bmData = b.LockBits(new Rectangle(0, 0, b.Width, b.Height), ImageLockMode.ReadWrite, PixelFormat.Format24bppRgb);<br />
<br />
			int stride = bmData.Stride;<br />
			System.IntPtr Scan0 = bmData.Scan0;<br />
<br />
			unsafe<br />
			{<br />
				byte * p = (byte *)(void *)Scan0;<br />
<br />
				int nOffset = stride - b.Width*3;<br />
<br />
				byte red, green, blue;<br />
	<br />
				for(int y=0;y<b.Height;++y)<br />
				{<br />
					for(int x=0; x < b.Width; ++x )<br />
					{<br />
						blue = p[0];<br />
						green = p[1];<br />
						red = p[2];<br />
<br />
						p[0] = p[1] = p[2] = (byte)(.299 * red + .587 * green + .114 * blue);<br />
<br />
						p += 3;<br />
					}<br />
					p += nOffset;<br />
				}<br />
			}<br />
<br />
			b.UnlockBits(bmData);<br />
<br />
			return true;<br />
		}

Re: Grey Scale Image error??

Giorgi Dalakishvili19-Jun-07 5:20

Giorgi Dalakishvili

19-Jun-07 5:20

It seems that variable b is not initialized and its value is null

#region signature
my articles
#endregion

Re: Grey Scale Image error??

Software_Specialist19-Jun-07 5:30

Software_Specialist

19-Jun-07 5:30

oh yeh...now i initialized it as
b = new Bitmap(2,2);

exception is solved but after i press button for grey scale..Nothing is happening.
Cursor is going to Invalidate. And no change in pic

Thanks

Re: Grey Scale Image error??

Luc Pattyn19-Jun-07 5:40

Luc Pattyn

19-Jun-07 5:40

You have modified a bitmap in memory; how would that affect your display ?

To get a visual change you must:
- make sure the bitmap is shown somewhere in a Form or Control (e.g. it gets drawn
in a Panel);
- tell that Form/Control that it needs to redraw because its content has changed;
you do this by calling Control.Invalidate()

Now a 2*2 bitmap probably is hardly visible at all, so dont expect a
huge change in your display when you grayscale it !

Smile | :)

Luc Pattyn

[My Articles] [Forum Guidelines]

Re: Grey Scale Image error??

Software_Specialist19-Jun-07 5:57

Software_Specialist

19-Jun-07 5:57

Sorry but its not too clear to me....

How to show bitmap on form or control ???
How to tell the form that it needs to redraw...?
And then how can i get a good change in display if 2*2 wont make much differnce..?

Thanks

Re: Grey Scale Image error??

Luc Pattyn19-Jun-07 6:08

Luc Pattyn

19-Jun-07 6:08

Software_Specialist wrote:
How to show bitmap on form or control ???

by drawing it in the form/control's paint handler, using Graphics.DrawImage

Software_Specialist wrote:
How to tell the form that it needs to redraw...?

see previous message

Software_Specialist wrote:
And then how can i get a good change in display if 2*2 wont make much differnce..?

try a larger bitmap !

Luc Pattyn

[My Articles] [Forum Guidelines]

Re: Grey Scale Image error??

Software_Specialist21-Jun-07 4:46

Software_Specialist

21-Jun-07 4:46

ok now i know what you mean...

you mean to write as shown below:::

<br />
protected override void OnPaint (PaintEventArgs e)<br />
		{<br />
			Graphics g = e.Graphics;<br />
<br />
			g.DrawImage(m_Bitmap, new Rectangle(this.AutoScrollPosition.X, this.AutoScrollPosition.Y, (int)(m_Bitmap.Width*Zoom), (int)(m_Bitmap.Height * Zoom)));<br />
		}<br />

And for this i have to remove the picture box from the form. But i am writing an application for image viewer. i.e. Slide show and for that i need few of the image processing stuff..So for that i guess i need to have picture box ..

Moreover its not working out for me. I have just tried to load the picture with a following code

<br />
private void File_Load(object sender, System.EventArgs e)<br />
		{<br />
			OpenFileDialog openFileDialog = new OpenFileDialog();<br />
<br />
			openFileDialog.InitialDirectory = "c:\\" ;<br />
			openFileDialog.Filter = "Bitmap files (*.bmp)|*.bmp|Jpeg files (*.jpg)|*.jpg|All valid files (*.bmp/*.jpg)|*.bmp/*.jpg";<br />
			openFileDialog.FilterIndex = 2 ;<br />
			openFileDialog.RestoreDirectory = true ;<br />
<br />
			if(DialogResult.OK == openFileDialog.ShowDialog())<br />
			{<br />
				m_Bitmap = (Bitmap)Bitmap.FromFile(openFileDialog.FileName, false);<br />
				this.AutoScroll = true;<br />
				this.AutoScrollMinSize = new Size ((int)(m_Bitmap.Width * Zoom), (int)(m_Bitmap.Height * Zoom));<br />
				this.Invalidate();<br />
			}<br />
		}<br />

But it gives me a blinkin form..I mean photo is not stable. It comes and go off every msec...

Well i am referring http://www.codeproject.com/cs/media/csharpgraphicfilters11.asp

Any solution...???
Thanks

Re: Grey Scale Image error??

Luc Pattyn21-Jun-07 5:02

Luc Pattyn

21-Jun-07 5:02

I never felt the need for a PictureBox, I prefer drawing on a Panel, so I know
exactly what is being drawn, how it gets scaled, etc.

I never used AutoScroll but I think your AutoScrollMinSize is wrong;
I suggest you try it once without that line...

Smile | :)

Luc Pattyn

[My Articles] [Forum Guidelines]

Re: Grey Scale Image error??

Software_Specialist21-Jun-07 5:07

Software_Specialist

21-Jun-07 5:07

well no its not working without that aswell...
I am referring to CG article and in his demo its workin fine.

And yeah i am not drawing it on panel...Its just a form and that override command.
And what about slide show ? Would i be able to get that functionality if i draw on form without using picturbox.. ?
Thanks

Re: Grey Scale Image error??

Luc Pattyn21-Jun-07 5:22

Luc Pattyn

21-Jun-07 5:22

a picturebox is like a panel that knows how to load an image file,
and how to draw an image; you already did both.

To make a slide show you just need to load and display consecutive images,
triggered by something (maybe a button click, maybe a timer tick).

BTW: you must Dispose of your OpenFileDialog !

Smile | :)

Luc Pattyn

[My Articles] [Forum Guidelines]

Re: Grey Scale Image error??

Software_Specialist21-Jun-07 5:30

Software_Specialist

21-Jun-07 5:30

yo removed OpenFileDialog and now using direct instance of it..
But no work as yet..Ok ill try to figure it out ....
Actually i am new to IP. But thanks for pointing me out these basic things..and so to basically we dont need any panel or picturebox dropped over form..We can just draw it once...oks
ill try to figure out the prob nw...
cheers

Re: Grey Scale Image error??

Luc Pattyn21-Jun-07 5:48

Luc Pattyn

21-Jun-07 5:48

What I meant is you must call openFileDialog.Dispose() when you no longer need
that instance of OpenFileDialog, otherwise you may get a memory leak.

Smile | :)

Luc Pattyn

[My Articles] [Forum Guidelines]

Re: Grey Scale Image error??

Software_Specialist21-Jun-07 6:26

Software_Specialist

21-Jun-07 6:26

yeh got the solution to it...well doublebuffer property was set to false...
So i setted it to true and is working now...
Smile | :)

Re: Grey Scale Image error??

Amar Chaudhary19-Jun-07 6:25

Amar Chaudhary

19-Jun-07 6:25

Debug

Adding event handler to custom control

berghain19-Jun-07 4:56

berghain

19-Jun-07 4:56

Hi,

I have created my own control, which extends another one. I am trying to add an event handler to an event raised by the parent class. How would I do this from within the constructor of the inheriting class?

For example the MouseClick event in a custom button. I want my control to handle its own event.

Thanks.

Re: Adding event handler to custom control

Manas Bhardwaj19-Jun-07 5:03

Manas Bhardwaj

19-Jun-07 5:03

override this event Rose | [Rose]

Avoid trailing while dragging control

sinosoidal19-Jun-07 4:49

sinosoidal

19-Jun-07 4:49

Hi,

I have implemented a control dragging system.

Basicly i'm dragging panels inside a panel.

The thing is that i decided to put an image in the main panel background.

But that makes my other panels leave a trail when i drag them.

Does anyone has an explanation/solution for this?

Thx,

Nuno

Re: Avoid trailing while dragging control

Alaric_19-Jun-07 5:08

Alaric_

19-Jun-07 5:08

...A persistent trail? Meaning, it ghosts the panel all over the place and they artifact the screen? Try putting your panels inside a BufferedGraphics object(you need to double buffer your screen display....a BufferedGraphics object will implement the backbuffer for you)

Welcome my son...Welcome..to the Machine

Re: Avoid trailing while dragging control

sinosoidal19-Jun-07 5:10

sinosoidal

19-Jun-07 5:10

Hi,

Thx for your reply.

Can you point me an example?

Thx,

Nuno

Re: Avoid trailing while dragging control

Alaric_19-Jun-07 9:14

Alaric_

19-Jun-07 9:14

...just check out the BufferedGraphics entry in the msdn. That should get you started...repost in this thread if you still need further help after that and I'll see what I can pull up for you.

Welcome my son...Welcome..to the Machine

Re: Avoid trailing while dragging control

Alaric_19-Jun-07 9:14

Alaric_

19-Jun-07 9:14

Oh....btw, are you using .NET 1.1 or .NET 2.0? ...The BufferedGraphics object is only available in 2.0

Welcome my son...Welcome..to the Machine

3D cube

Noharyiasa19-Jun-07 4:03

Noharyiasa

19-Jun-07 4:03

Hi, do you have c# program that draw cube?

Noha.Y

Re: 3D cube

Alaric_19-Jun-07 4:09

Alaric_

19-Jun-07 4:09

no...It doesn't work that way: But you can

look into Microsoft's XNA framework, and you can look up Direct3D tutorials.  Building a 3D cube will be one of the first things you will build

do it the old fashioned way...register a Win32 Window, register your callback and message loop, and hack away inside your render code to build a cube(in Direct3D, OpenGL...or whatever graphics library you like)

My suggestion would be to look into the XNA. You'll be able to execute your DirectX code inside the CLR, so all of your resources will be inherently Managed. Smile | :)

Welcome my son...Welcome..to the Machine

Re: 3D cube

Noharyiasa19-Jun-07 4:16

Noharyiasa

19-Jun-07 4:16

How can I enter to XNA is?

Noha.Y

Re: 3D cube

Alaric_19-Jun-07 4:12

Alaric_

19-Jun-07 4:12

try http://www.gamedev.net to find DirectX and OpenGL tutorials

Welcome my son...Welcome..to the Machine

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.