Re: Exception Handling: Object creation within try block - C# Discussion Boards

Re: Exception Handling: Object creation within try block

4-May-07 2:03

I'm currently getting into exception handling and have encountered the following problem. Let's say we have a class SampleClass. The SampleClass constructor takes various input parameters and is to check whether these are valid. If not exceptions might be thrown. Ideally I would like to have the code creating an object of type SampleClass to handle the potential exceptions. This does not quite work, as the compiler reports "Use of unassigned local variable..." outside the try block.

Here's the code:

<code>
public class SampleClass
{
public SampleClass(int param1, int param2)
{
int param1;
int param2;

if (param1 % param2 != 0)
{
throw new Exception();
}

this.param1 = param1;
this.param2 = param2;
}

public void Action()
{
// Some weird stuff in here.
}
}

public class Tester
{
class Program
{
static void Main(string[] args)
{
SampleClass s;

try
{
s = new SampleClass(20, 20);
}
catch (Exception e)
{
// Do processing here.
}

s.Action(); // Compiler says: Use of unassigned local variable 's'
}
}
}
</code>

I'd be quite pleased if someone could direct me into a promising direction. How to create object instances within try? You might say, just incorporate s.Action() within the try block. The problem is that in the real world example there is lots of code referencing 's'. So I'd end up with a massive try block and dozens of catch blocks afterwards. I reckon that's not what you would call best practices.

Thanks in advance.
All the best.
Goebel

Pete O'Hanlon4-May-07 2:09

Pete O'Hanlon

4-May-07 2:09

You can't use s to do something outside the try/catch if the constructor fails. This is because the compiler can't guarantee that it is uninitialised. If your code is so interdependent then this suggests that you probably need to refactor the code where possible.

Deja View - the feeling that you've seen this post before.

Re: Exception Handling: Object creation within try block

Goebel4-May-07 2:23

Re: Exception Handling: Object creation within try block

4-May-07 2:23

<blockquote class="FQ"><div class="FQA">Pete O`Hanlon wrote:</div>If your code is so interdependent then this suggests that you probably need to refactor the code where possible</blockquote>

Thanks Pete, but I'm not sure how to apply the refactoring approach. The object instance of SampleClass will be passed to other objects yielding object composition. So quite a few lines of code depend on 's'.

public class Tester
{
class Program
{
static void Main(string[] args)
{
SampleClass s;

try
{
s = new SampleClass(20, 20);
}
catch (Exception e)
{
// Do processing here.
}

A1Class a1 = new A1Class(s);
A2Class a2 = new A2Class(s);
//...
AnClass an = new AnClass(s);
}
}
}

Pete O'Hanlon4-May-07 2:27

Pete O'Hanlon

4-May-07 2:27

Is there some reason that your classes A1Class, etc..., aren't inside the try/catch block. I can see no reason why you couldn't do that.

Deja View - the feeling that you've seen this post before.

Re: Exception Handling: Object creation within try block

Goebel4-May-07 2:47

Re: Exception Handling: Object creation within try block

4-May-07 2:47

Good point, Pete! I haven't thought of that as there is lots of preprocessing to do in order to setup classes A1Class, A2Class,...

But I could easily do the preprocessing first and at a later stage initialise an object of SampleClass and create the various other objects within the try block.

Thanks for helping me out.
Goebel

Tim Paaschen4-May-07 2:13

Tim Paaschen

4-May-07 2:13

public class Tester
{
    class Program
    {
        static void Main(string[] args)
        {
            SampleClass s = null; 

            try
            {
                s = new SampleClass(20, 20);
            }
            catch (Exception e)
            {
                // Do processing here.
                s = null;
            }


            if( s != null )
            {
                s.Action();  // Compiler says: Use of unassigned local variable 's'
            }
        }
    }
}

This version should do the trick.

Regards,
Tim

Re: Exception Handling: Object creation within try block

Goebel4-May-07 2:33

Re: Exception Handling: Object creation within try block

4-May-07 2:33

Thanks Tim. Your approach made me think of something else. So far there is no SampleClass default constructor. But I could provide one resulting in a valid object initialisation. In doing so we'd guarantee that there is an object of type SampleClass. Thereby I could avoid checking for null-reference whenever I use 's'. Is that too much of a workaround?

public class SampleClass
{
public SampleClass()
{
this.param1 = 1;
this.param2 = 1;
}

public SampleClass(int param1, int param2)
{
int param1;
int param2;

if (param1 % param2 != 0)
{
throw new Exception();
}

this.param1 = param1;
this.param2 = param2;
}

public void Action()
{
// Some weird stuff in here.
}
}

public class Tester
{
class Program
{
static void Main(string[] args)
{
SampleClass s = new SampleClass();

try
{
s = new SampleClass(20, 20);
}
catch (Exception e)
{
// Do processing here.
}

s.Action();
}
}
}

Thanks again,
Goebel

Tim Paaschen4-May-07 2:48

Tim Paaschen

4-May-07 2:48

If you provide a default constructor, I would recommend not to use a second constructor for your purpose. Instead provide a method.
Currently you assign a new object within the try/catch-block and I'm not sure what happens to s, if an exception is thrown within the second constructor.

Goebel wrote:

public class SampleClass
{
    public SampleClass()
    {
        this.param1 = 1;
        this.param2 = 1; 
    }

    public Assign(int param1, int param2)
    {
            int param1;
            int param2; 

            if (param1 % param2 != 0)
            {
                throw new Exception(); 
            }

            this.param1 = param1;
            this.param2 = param2; 
    }

    public void Action()
    {
        // Some weird stuff in here.
    }
}

public class Tester
{
    class Program
    {
        static void Main(string[] args)
        {
            SampleClass s = new SampleClass(); 

            try
            {
                s.Assign(20, 20);
            }
            catch (Exception e)
            {
                // Do processing here.
            }

            s.Action();
        }
    }
}

Regards,
Tim

Re: Exception Handling: Object creation within try block

Goebel4-May-07 2:57

Re: Exception Handling: Object creation within try block

4-May-07 2:57

Very good, got that.

Things are a lot clearer now!

Thanks.
Goebel

AFSEKI7-May-07 3:22

AFSEKI

7-May-07 3:22

It is not a bug, only a good warning Wink | ;)

do this: SampleClass s = null;

Re: Exception Handling: Object creation within try block [modified]

gumi_r@msn.com7-May-07 6:31

gumi_r@msn.com

7-May-07 6:31

The error you are getting is simply the compiler warning you that you are using a variable that may not be explicitly initialized during runtime depending which path the execution flow takes.

In your case, you are using an uninitialised variable named s. The compiler is simply detecting that the execution might reach the catch and finally blocks with s never being explicitly initialized in your code and will therefore warn you because it's not sure if you know what you're doing (in your code this would happen if your class constructor throws an exception).

On the other hand, if you explicitly initialize the variable s to null, which makes no difference at runtime to what you originally coded, the compiler understands that you know what you are doing and that you have factored in the possibility of s being null if the catch and finally blocks are ever executed.

Please note that this is not something specific to try catch-blocks and constructors. You would get the same error in the following code (the code does not make much sense at all but its a valid example):

public void example(bool dummy)
           {
                myClass s;

                if (dummy)
                {
                    s = new myClass();
                }
                else
                {
                    if (s==null)
                        //do something
                    else
                        //do something else
                }
                    
           }

Hope this clears it up a little for you.

P.D. About the default constructor, C# does not work the same as C++. Having a default constructor will not make your variable s use it when its defined:

myClass s; //this will not call the default constructor as in C++. C# initializes objects to null.

Please note that the compiler error is not really necessary as the s variable is truely null even if not explicitly initialized and will therefore not cause unexpected behaviour reading uninitialised memory, etc. Its more an aid and a reminder to the coder that might be overlooking a possible execution path where the variable may not have the expected value. This becomes evident if instead of using your class you try your same code with int s; You will still get exactly the same error even though s is by default initialized to 0 and has a perfectly valid value.

-- modified at 13:11 Monday 7th May, 2007

Need solution

DON3454-May-07 1:58

DON345

4-May-07 1:58

Hi Every one
while iam parsing one file my output file looks like this:
1aDOCSTART_3:
GENEVAVERSION:5.0
BILLSTYLE:2
BILLTYPE:1
BILLTEMPLATE:3
BILLSEQ:1
BILLVERSION:1
ACCCURRENCYCODE:GBP
BILLLANGID:1
BILLLANGNAME:English
BILLLANGLOCALE:en_GB
PAYMETHODID:4
FORMATREQ:TEST014/0001
COPYBILLNUM Blush | :O

BILLPURPOSE:1
BILLPURPOSENAME:Master
ADDRESS1:11
ADDRESS4:London
ZIPCODE:SW1V
COUNTRY:United
Start of BSTARTACCFADDR
ACCFADDR_1:11
ACCFADDR_2:London
ACCFADDR_3:SW1V
ACCFADDR_4:United
End of theBENDACCFADDR
CUSTOMERREF:TEST014
CUSTOMERTYPE:UK
ACCTAXSTATUS:Exclusive
INVOICINGCONAME:Genie
ACCOUNTNO:TEST014
DEPOSIT:000
CUSTCONTACTADDR1:11
CUSTCONTACTADDR4:London
CUSTCONTACTZIP:SW1V
CUSTCONTACTCOUNTRY:United
Start of BSTARTCUSTFADDR
CUSTFADDR_1:11
CUSTFADDR_2:London
CUSTFADDR_3:SW1V
CUSTFADDR_4:United
End of theBENDCUSTFADDR

i want to show this data as xml output.pls any one give me solution for this.
it is more helpful for me.

Thanks&Regards
RENU

Pete O'Hanlon4-May-07 2:13

Pete O'Hanlon

4-May-07 2:13

Would you please stop posting the same question again and again? People have given you answers and suggestions to this question elsewhere. If you have a problem with the answer, then it is only polite to respond to them.

Posting this question again and again looks like you are spamming the boards and will not actually prompt anyone to help you.

Deja View - the feeling that you've seen this post before.

Paul Conrad4-May-07 13:55

Paul Conrad

4-May-07 13:55

Pete O'Hanlon wrote:
Would you please stop posting the same question again and again? People have given you answers and suggestions to this question elsewhere.

Another one of those posters Hmmm | :|

Sandeep Akhare4-May-07 3:06

4-May-07 3:06

DON345 wrote:
i want to show this data as xml output

Means what ? Do you want to converet this file into xml ?

DON345 wrote:
pls any one give me solution for this.

Yesturday we discuss it Frown | :(

DON345 wrote:
it is more helpful for me.

Actually you don't know whay you have to do.
Its difficult in first attempt but you should try once again
Reply what you want only out put key values or XML file having different elements with key value pair

Thanks and Regards
Sandeep

If you want something you never had,
do something you have never done!

DON3454-May-07 3:52

DON345

4-May-07 3:52

Hi sandeep
sorry for disturbing you again and again
actually i want output as XML file having different elements with key value pair .

Thanks&Regards
RENU

Sandeep Akhare4-May-07 3:55

4-May-07 3:55

OK But file is like this only key value seperated by : colon
need to develop logic its simple give some time

Thanks and Regards
Sandeep

If you want something you never had,
do something you have never done!

Sandeep Akhare4-May-07 4:47

4-May-07 4:47

Hi Renu here is your solution

<br />
// method call on button click<br />
protected void Button1_Click(object sender, EventArgs e)<br />
    {<br />
        StreamReader streamreader = File.OpenText(Server.MapPath("TextFile.txt"));<br />
        XmlTextWriter xmlTextWriter= this.CreateXML();<br />
        while (!streamreader.EndOfStream)<br />
        {<br />
            string line = streamreader.ReadLine();<br />
<br />
            string[] values = line.Split(':');<br />
            if(values.Length>1)<br />
            writeElement(xmlTextWriter, values[0], values[1]);<br />
        }<br />
        this.EndXml(xmlTextWriter);<br />
        xmlTextWriter.Close();<br />
    }<br />
<br />
  public XmlTextWriter CreateXML()<br />
    {<br />
        XmlTextWriter xTextWriter = new XmlTextWriter(Server.MapPath("Ouput.xml"), System.Text.Encoding.UTF8);<br />
        xTextWriter.WriteStartDocument();<br />
        xTextWriter.WriteStartElement("RootElement");<br />
          <br />
        <br />
<br />
        return xTextWriter;<br />
    <br />
    }<br />
<br />
    public void EndXml(XmlTextWriter xmlTextWriter)<br />
    {<br />
        xmlTextWriter.WriteEndElement();<br />
        xmlTextWriter.WriteEndDocument();<br />
    <br />
    }<br />
<br />
    public void writeElement(XmlTextWriter xmlTextWriter, string key, string value)<br />
    {<br />
        xmlTextWriter.WriteStartElement("Field");<br />
        xmlTextWriter.WriteAttributeString("Key", key);<br />
        xmlTextWriter.WriteAttributeString("Value", value);<br />
        xmlTextWriter.WriteEndElement();<br />
        <br />
    <br />
    }<br />

Expecting positive reply from you Smile | :)

Thanks and Regards
Sandeep

If you want something you never had,
do something you have never done!

jayart4-May-07 6:55

jayart

4-May-07 6:55

Dont you think you are spoon feeding Renu?

Sandeep Akhare6-May-07 19:28

6-May-07 19:28

Hi Arti
I know its like that but i am here in CP to learn something. Renu wanted the solution from last 3 days i had given 2 days but Renu coudn't find the solution that's why i provided solution

Thanks and Regards
Sandeep

If you want something you never had,
do something you have never done!

DON3454-May-07 18:54

DON345

4-May-07 18:54

Hi sandeep thank you for sending solution.can we show the xml output like
staring and ending tags of each line is key and in between start and elements attribute as value
Ex:<key>value

Thanks&Regards
RENU

Sandeep Akhare6-May-07 19:35