The Weird and The Wonderful

The Weird and The Wonderful forum is a place to post Coding Horrors, Worst Practices, and the occasional flash of brilliance.

We all come across code that simply boggles the mind. Lazy kludges, embarrassing mistakes, horrid workarounds and developers just not quite getting it. And then somedays we come across - or write - the truly sublime.

Post your Best, your worst, and your most interesting. But please - no programming questions . This forum is purely for amusement and discussions on code snippets. All actual programming questions will be removed.

Re: Using Else with blank If

Marcus J. Smith8-Mar-07 3:22

Marcus J. Smith

8-Mar-07 3:22

I think it is just easier to read when you say say what you want it to equal.

If boolean = True

instead of just saying

If boolean

I just couldnt think of a good example but what I was getting at is really saying something like

If strType = "GOOD" OrElse strType = "COOL" Then 
'Good Record
Else
blnError = True
End If

instead of saying

If strType <> "GOOD" AndAlso strType <> "COOL" Then 
blnError = True
End If

_Cle^aKO

"I think you'll be okay here, they have a thin candy shell. 'Surprised you didn't know that." - Tommy Boy
"Fill it up again! Fill it up again! Once it hits your lips, it's so good!" - Frank the Tank (Old School)

Re: Using Else with blank If

jhwurmbach8-Mar-07 4:23

jhwurmbach

8-Mar-07 4:23

CleaKO wrote:
think it is just easier to read when you say say what you want it to equal.

If boolean = True

instead of just saying

If boolean

Funny.
For me its just the opposite: The superfluous = True imposes the nagging feel in me, I have missed something while reading the code.

But then, the whole VB code gives me a screaming fit anyway.
Roll eyes | :rolleyes:

Failure is not an option - it's built right in.

Re: Using Else with blank If

John R. Shaw9-Mar-07 10:41

John R. Shaw

9-Mar-07 10:41

jhwurmbach wrote:
But then, the whole VB code gives me a screaming fit anyway.

I know the feeling. Wink | ;)

INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

Re: Using Else with blank If

Kevin McFarlane10-Mar-07 12:11

Kevin McFarlane

10-Mar-07 12:11

jhwurmbach wrote:
But then, the whole VB code gives me a screaming fit anyway.

But you see such style in the C-family languages too, though it's probably less common.

Kevin

Re: Using Else with blank If

Dave Kreskowiak8-Mar-07 5:04

Dave Kreskowiak

8-Mar-07 5:04

Yeah, it's just the opposite for me too. Especially if you name your boolean properties or methods correctly.

If UserIsInRole(user, role) Then

Just the name of the function implies that it returns a True/False value.

Dave Kreskowiak
Microsoft MVP - Visual Basic

Re: Using Else with blank If

PIEBALDconsult8-Mar-07 10:16

PIEBALDconsult

8-Mar-07 10:16

CleaKO wrote:
If boolean = True

But then you may have trouble when the code is ported to C, so you really need:

If True = boolean

--| "Every tool is a hammer." |--

Re: Using Else with blank If

John R. Shaw9-Mar-07 10:35

John R. Shaw

9-Mar-07 10:35

It is a good idea to place the constant value to the left of the equality symbol in any language that supports them, to catch syntax errors.

It just feels so unnatural to type it that way. Wink | ;)

INTP
"Program testing can be used to show the presence of bugs, but never to show their absence."Edsger Dijkstra

Re: Using Else with blank If

Shog⁹9-Mar-07 12:08

Shog⁹

9-Mar-07 12:08

You might still have trouble in C, if you run up against code that uses other non-zero values for "true"...

----

It appears that everybody is under the impression that I approve of the documentation. You probably also blame Ken Burns for supporting slavery.

--Raymond Chen on MSDN

Re: Using Else with blank If

AncientCodeslinger9-Mar-07 15:14

AncientCodeslinger

9-Mar-07 15:14

If that's how you use booleans, you might as well just use an integer set to 1 or 0 or a string set to "Y" or "N" (or "True" or "False"). How about:

<br />
somethingIsWrong = (type <> "GOOD" AndAlso type <> "Cool")<br />

With a variable name that clearly expresses the condition represented by the boolean, the comparison to True or False becomes clearly redundant.

Re: Using Else with blank If

Kevin McFarlane10-Mar-07 12:09

Kevin McFarlane

10-Mar-07 12:09

The reason for the first is that some people have a fixation about negative conditionals, such that they will try and avoid them at all costs - such as the cost you describe!

Kevin

Re: Using Else with blank If

peterchen12-Mar-07 5:56

peterchen

12-Mar-07 5:56

boolean = True

but that's a boolean expression again, which could be true.. or false.
So to make absoultely clear you want b = true to be true (not false), you write
If (boolean = True) = True

lather, rinse, repeat

Roll eyes | :rolleyes:

Developers, Developers, Developers, Developers, Developers, Developers, Velopers, Develprs, Developers!
We are a big screwed up dysfunctional psychotic happy family - some more screwed up, others more happy, but everybody's psychotic joint venture definition of CP
Linkify!|Fold With Us!

Re: Using Else with blank If

Shog⁹8-Mar-07 7:31

Shog⁹

8-Mar-07 7:31

I prefer

If ( isFlag ) Then Continue

Succinct.

----

It appears that everybody is under the impression that I approve of the documentation. You probably also blame Ken Burns for supporting slavery.

--Raymond Chen on MSDN

On rare occassion

Ennis Ray Lynch, Jr.12-Mar-07 4:20

Ennis Ray Lynch, Jr.

12-Mar-07 4:20

If there is a complicated method and I want to indicate that I did indeed accomodate both possibilities I will, ocassionaly, leave a blank if. However, I almost never check a boolean variable against a boolean and instead prefer :

<br />
if(isFlagSet){<br />
   //Some commented out code or not about<br />
   //Why not used<br />
<br />
}<br />
else if(!isFlagSet){<br />
   //Some Actual code<br />
   ...<br />
}<br />
else{<br />
   //File Not Found<br />
}<br />

Just kidding with the File not found!

File Not Found

The daily WTF!

Magnus L Karlsson7-Mar-07 7:28

Magnus L Karlsson

7-Mar-07 7:28

or http://worsethanfailure.com as it is caled now, is worth checking out if you like this forum.

Magnus

Nice catch!

webmarco6-Mar-07 21:38

webmarco

6-Mar-07 21:38

The code below is part of an eventhandler
Very informative and easy to debug Cry | :((

The worse part is that there are quite a few of these constructions in the application at hand. Shouldn't there be a law against such 'programmers'?
.....
try
{
int startNummer = Convert.ToInt32(dataGrid1[dataGrid1.CurrentRowIndex, 0]);
Hashtable ht = Logica.HaalEquipeIDBijStartnummer(editieID);
equipeID = (int) ht[startNummer];

if (!Logica.IsTijdControleIngevoerd(etappeID))
return;

}
catch
{
return;
}
....

Keep smiling,
Marco

Re: Nice catch!

AnthonyC6-Mar-07 23:21

AnthonyC

6-Mar-07 23:21

It is in Dutch. I have no problem reading it, and I don't even speak the language (2 minutes at Babelfish will do it). Get a Dutch programmer to translate it for you. Or does program code always have to be in English? Sigh | :sigh:

Re: Nice catch!

webmarco6-Mar-07 23:28

webmarco

6-Mar-07 23:28

Can you explain to me what is meant by the catch in this piece of code?

Regards,
Marco

Re: Nice catch!

Code_Digger7-Mar-07 0:25

Code_Digger

7-Mar-07 0:25

Sure. It could do with somewhat more comment lines, but the governing logic is clear:

- do some lookups
- return immediately if something is wrong:
---- some data is not found when looking it up in "Logica"
---- an exception is thrown, for example in the conversion of text to int32 (hence the catch)
- proceed if all assumptions are valid

Re: Nice catch!

webmarco7-Mar-07 0:39

webmarco

7-Mar-07 0:39

Aha! so ignore any exception, just return. That is indeed the way to do it. Silly me, what was i thinking? Blush | :O

Regards,
Marco

Pretty Typical...

JohnnySacks8-Mar-07 3:05

JohnnySacks

8-Mar-07 3:05

Really, what were you thinking. Will the end user report any mysterious issues before you manage to get a new and better job?

Besides, 'some day' we're going to integrate an error capture and/or logging methodology into this business critical high visibility application which re-engineers our business case to leverage best-practice synergies to pro actively actualize our bottom line but at this point we really don't know what features are required and we're REALLY in a hurry to get something done so for now, we'll just put the blocks in place and fill them in later.

Every application I support in this place is filled with this crap. Every programmer who spews this crap out rapidly is a hero (and soon off to bigger and better jobs)

Re: Pretty Typical...

Erik Burger9-Mar-07 1:03

Erik Burger

9-Mar-07 1:03

JohnnySacks wrote:
Besides, 'some day' we're going to integrate an error capture and/or logging methodology into this business critical high visibility application which re-engineers our business case to leverage best-practice synergies to pro actively actualize our bottom line but at this point we really don't know what features are required and we're REALLY in a hurry to get something done so for now, we'll just put the blocks in place and fill them in later.

This sounds so scarily like my manager..no wonder we've decided not to listen to him anymore Poke tongue | ;-P

Re: Nice catch!

Erik Burger7-Mar-07 22:39

Erik Burger

7-Mar-07 22:39

arc_10spd wrote:
Or does program code always have to be in English?

If you ever want to start a lobby for making a law that states that all code should be in English, I'll make the buttons Cool | :cool:

Re: Nice catch!

AnthonyC7-Mar-07 23:03

AnthonyC

7-Mar-07 23:03

There are about currently about 4,000 unique languages remaining in the world. English will overrun most of them within the next 100 years at the cost of an extraordinary and fascinating diversity in human culture and history stretching back for over 10,000 years (at least that is what some historical linguists claim they can reconstruct). I for one would find it a tragedy if Dutch were to go as well ("not so much a language as an organised method for clearing one's throat"). However, ErikDD, if you MUST have it in English, here is a guess:

....
try
{
int startNumber = Convert.ToInt32(dataGrid1[dataGrid1.CurrentRowIndex, 0]);
Hashtable ht = Logic.ObtainTeamIDAtStartnumber(editID);
teamID = (int) ht[Startnumber];

if (!Logic.IsTimeControlIntroduced(teamID)
return;

}
catch
{
return;
}
...
Poke tongue | ;-P

Re: Nice catch!

AnthonyC7-Mar-07 23:11

AnthonyC

7-Mar-07 23:11

Sorry.

Probably should translate etappe as "stage":

...
if (!Logic.IsTimeControlIntroduced(stageID)
...

not

...
if (!Logic.IsTimeControlIntroduced((editID))
...

Blush | :O

Re: Nice catch!

Erik Burger8-Mar-07 2:00

Erik Burger

8-Mar-07 2:00

*grins* I happen to be one of the relatively few people who actually speak Dutch (aka a Dutchman) but I do appreciate the effort Smile | :)

As for Dutch disappearing, I wouldn't miss it, but I don't enjoy the prospect. It's just that I also believe in code mobility and reusability.

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.