Visual Basic

4-Sep-06 21:44

I having a weird problem now... all the function run correctly, but the msgboc just didnt show out... it may make my user confuse is the function been run or not.
when i test it the function just run correct, save item if there is no record of it which mean Add new record, if there is record in it then dont perform anything.

Do
On Error Resume Next
temp = rs![custNO]
rs.MoveNext
Loop Until (rs.EOF)

If ccustno.Text <> rs![custNO] Then
rs.AddNew 'Add detail to record
rs.Fields("CustNo") = ccustno.Text
rs.Fields("Customer") = UCase(ccus.Text)
rs.Fields("Area") = UCase(carea.Text)
rs.Fields("Address") = UCase(caddress.Text)
rs.Fields("Tel") = cphone.Text
rs.Fields("Fax") = cfax.Text
rs.Fields("Name") = UCase(cattn.Text)

rs.update 'update u record
rs.MoveFirst
MsgBox ("Customer Information Recorded")

Else: MsgBox ("Customer already been create, please use the UPDATE function for update"): Exit Sub
End If
---

i have edit the code, it works well now Smile | :)

'move the return the database at first data if not it will have no current record error
'using DO loop to set the value to temp then compare it again and perform action with another ifelse outside the loop.

rs.MoveFirst <br />
Do<br />
If ccustno.Text <> rs![custno] Then<br />
ElseIf ccustno.Text = rs![custno] Then<br />
temp = rs![custno]<br />
End If<br />
rs.MoveNext<br />
Loop Until (rs.EOF)

<br />
If ccustno.Text <> temp Then<br />
....

-- modified at 22:52 Tuesday 5th September, 2006

Guffa4-Sep-06 22:08

4-Sep-06 22:08

You are mistaken, the function doesn't run correctly at all.

When you exit the loop the recordset will always be read to the end, so when you try to use rs![custNO], you will get an error as you can not read anything from the recordset beyond the last record.

You are using On Error Resume Next, but you are not checking for errors anywhere, which means that you silently ignore anything that goes wrong.

---
b { font-weight: normal; }

campbells4-Sep-06 22:15

4-Sep-06 22:15

ok now i have cancel the on error resume

I having error on handle my error control, when user try to save a new data which alreayd been create in database then i will show an error msg out with IF -ELSE but i not sure y the error keep pop out ask me to debug as it said there is duplication in the database.

I have already put the If else statment to control it ....but not really work...

If ccustno.Text <> rs![custno] Then
rs.AddNew 'Add detail to record
rs.Fields("CustNo") = ccustno.Text
rs.Fields("Customer") = UCase(ccus.Text)
rs.Fields("Area") = UCase(carea.Text)
rs.Fields("Address") = UCase(caddress.Text)
rs.Fields("Tel") = cphone.Text
rs.Fields("Fax") = cfax.Text
rs.Fields("Name") = UCase(cattn.Text)
rs.update 'update u record ------->highlight ERROR
rs.MoveFirst
MsgBox ("Customer Information Recorded")

ElseIf ccustno.Text = rs![custno] Then
MsgBox ("Customer already been create, please use the UPDATE function for update")
Exit Sub
End If

Guffa5-Sep-06 6:29

5-Sep-06 6:29

when user try to save a new data which alreayd been create in database then i will show an error msg out with IF -ELSE

What code do you use to make that check?

campbells wrote:
but i not sure y the error keep pop out ask me to debug as it said there is duplication in the database.

The reason is very simple. You get the error message for the reason that is clearly stated in the error message. You are trying to create a duplicate in the database.

---
b { font-weight: normal; }

campbells4-Sep-06 22:40

4-Sep-06 22:40

When i put the "on error resume next" my function work well REcently i just use that for temporary atleast my function work well.., cause i see the result myself. When user save something that already been save it will not save any change, if the record no exist then Add the new record. But the problem here is it always pop up the msgbox that record been save even when the record didnt save at all. suppose it have to pop up the other msgbox about the data didnt save in my elseif statement ccustno.Text = rs![custno].

Guffa5-Sep-06 6:35

5-Sep-06 6:35

campbells wrote:
When i put the "on error resume next" my function work well

It only works well as long as there is no error. If there is an error, it doesn't work, but you don't notice it. At least not until later...

When user save something that already been save it will not save any change

That is because you are ignoring the error. Handling errors by ignoring them is not a good way to handle them. That is like turning the radio up when the car starts to sound funny...

But the problem here is it always pop up the msgbox that record been save even when the record didnt save at all.

That is because you ignore the error.

---
b { font-weight: normal; }

S Douglas4-Sep-06 23:22

S Douglas

4-Sep-06 23:22

This just doesn’t make any sense what so ever.

[Warning This is Pseudo Code!] Blush | :O

Why not do a
Select Count(CustNo) as CountOfCustNo from Table where CustNo = ccustno.Text
[The above sql query doesn’t protect again SQL injection attacks.]

Then you can just do a simple
Int iCount
iCount = rs.Fields("CountOfCustNo”).Value
if iCount > 0 then
Msgbox “Customer Number in use”
Else
Update the record

I'd love to help, but unfortunatley I have prior commitments monitoring the length of my grass. :Andrew Bleakley:

FeRtoll5-Sep-06 11:59

FeRtoll

5-Sep-06 11:59

campbells wrote:
MsgBox ("Customer Information Recorded")

Try using Messagebox.Show("Blablabla") Big Grin | :-D

FeRtoll Software.net
------------
E-Mail me
WebPage

Guffa5-Sep-06 19:01

Re: cant show the msgbox?? [modified]

5-Sep-06 19:01

Yes, that works, but I have seldom seen it done in such an inefficient way...

Instead of looping throught the entire recordset, select the record you are interrested in. Then you just have to check if the recordset is empty or not.

---
b { font-weight: normal; }

campbells5-Sep-06 20:24