Re: C++ Array Of Function Pointers problem - C / C++ / MFC Discussion Boards

Re: C++ Array Of Function Pointers problem

CNewbie13-Jun-05 6:16

13-Jun-05 6:16

yes, I am using VS.NET 2003 or VC++ 7.1 whichever way you want to look at it.

My problem would seem to come down to the fact that I am not defining the array correctly, but I dont see why. Maybe you could see what I am doing wrong.

Re: C++ Array Of Function Pointers problem

David Crow13-Jun-05 6:27

David Crow

13-Jun-05 6:27

CNewbie wrote:
Maybe you could see what I am doing wrong.

Try these articles:

http://www.everything2.com/index.pl?node_id=1509071

http://oopweb.com/CPP/Documents/FunctionPointers/Volume/CCPP/FPT/em_fpt.html

http://mail.nl.linux.org/kernelnewbies/2003-05/msg00447.html

http://www.newty.de/fpt/fpt.html

http://lists.trolltech.com/qt-interest/2004-07/thread00496-0.html

http://publications.gbdirect.co.uk/c_book/chapter5/function_pointers.html

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie15-Jun-05 19:32

CNewbie

15-Jun-05 19:32

Hey David. i just wanted to update you on my Function Pointer array problem.

I have solved the problem of the arrays not being initialized by filling them within a member thread using an instance of my class as such:

CDialog Function;
Function.call_function[0] = &CDialog::dFunction1;
Function.call_function[1] = &CDialog::dFunction2;

However, these are only Local definitions and would need to be redefined whenver this function is called. So what I would rather do is define them globally, but I have not been able to figure out how to do it without error.

According to books I read. To declare instances (objects) of a class, you do so by including them at the end of the class declaration outside of the ending curly bracket. I did this using the "extern" keyword so the object could be used throughout all of my source files as such:

<br />
class CDialog<br />
{<br />
       public:<br />
             CDialog(CWnd* pParent = NULL);	// standard constructor<br />
       protected:<br />
             virtual void DoDataExchange(CDataExchange* pDX);	// DDX/DDV support<br />
       protected:<br />
                 // Generated message map functions<br />
                 virtual BOOL OnInitDialog();<br />
                 DECLARE_MESSAGE_MAP()<br />
       public:<br />
       CEdit m_sigstrEdit;<br />
}extern Function;<br />

I then defined the instance globally in one of my source files as such:

CDialog Function;

and it compiled without syntax error, but as soon as the program starts I get an assertion error in Line 26 of afxwin1.inl. If I do not use the "extern" keyword i get linker errors about the object already being defined. So I am at a loss about how to implement this globally.

I really appreciate your help thus far.

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 2:56

David Crow

16-Jun-05 2:56

CNewbie wrote:
CDialog Function;
Function.call_function[0] = &CDialog::dFunction1;
Function.call_function[1] = &CDialog::dFunction2;

If call_function is an array of function pointers, why not initialize it in the dialog's OnInitDialog() method? The other odd-looking thing is that dFunction1 and dFunction1 do not belong to CDialog.

CNewbie wrote:
To declare instances (objects) of a class, you do so by including them at the end of the class declaration outside of the ending curly bracket.

You can instantiate an object anytime after the class has been declared. Doing so in the class' header file is odd.

CNewbie wrote:
}extern Function;

I'm surprised this compiled. In any case, I don't think it's necessary. But without a better understanding of what exactly it is you are after, my suggestions are sparse.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 5:30

CNewbie

16-Jun-05 5:30

What I want to do is define the 2 function pointer arrays with the appropriate functions globally so that I can use them throughout the problem without having to redefine them each time I have to use them.

The 2 function pointer arrays are as follows:

void (*call_cmd_function[160])();
void (*call_ins_function[48])();

The functions (NOTE: I did declare them in my class, just didnt put them in the class example above) for both of these arrays are named "dFunction 1 through 45" and "dFunction 46 through 99".

My Class is CDialog.

If you need anymore info Please ask, I really appreciate the help.

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 5:43

David Crow

16-Jun-05 5:43

CNewbie wrote:
What I want to do is define the 2 function pointer arrays with the appropriate functions globally so that I can use them throughout the problem without having to redefine them each time I have to use them.

Right. The compiler is never happy when it encounters a redefinition. You can certainly make the arrays global to the entire program. However, they must be initialized within some function (e.g., main()). After that, they can be used from wherever they are needed. And, as you have already discovered, if the arrays are needed in more than one file, you'll need to employ the extern keyword. This means the arrays are visible from files other than the one in which they are defined.

CNewbie wrote:
My Class is CDialog.

Does this mean that you are not using MFC?

I'm sure you've figured this much out:

void (*call_cmd_function[160])(void);
 
void Func1( void )
{
    cout << "Func1" << endl;
}
 
void Func2( void )
{
    cout << "Func2" << endl;
}
 
void Func3( void )
{
    cout << "Func3" << endl;
}
 
void main( void )
{
    call_cmd_function[0] = Func1;
    call_cmd_function[1] = Func2;
    call_cmd_function[2] = Func3;
 
    (*call_cmd_function[2])();
    (*call_cmd_function[1])();
    (*call_cmd_function[0])();
}

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 5:54

CNewbie

16-Jun-05 5:54

Actually I am using MFC. "CDialog" is a ficticious name.

As I pointed out in the last post, I declared both of the arrays in my header file as such:

<br />
	void (*call_cmd_function[160])();<br />
	void (*call_ins_function[48])();<br />

Then I defined them "globally" at the top of one of my source files as such:

<br />
        void (CflowlogDlg::*call_ins_function[48])() = {NULL};<br />
        void (CflowlogDlg::*call_cmd_function[160])() = {NULL};<br />

As you said without the "extern" keyword this would not be seen within all of my source files. The wierd thing is that I reference these arrays in more then one of my source files and the compiler didnt give me any errors when compiling with this code.

Now I do define these arrays in my InitDialog() as such:

<br />
	CflowlogDlg INSFunction;<br />
	INSFunction.call_ins_function[0] = &CflowlogDlg::doins00;<br />
	INSFunction.call_ins_function[46] = &CflowlogDlg::doins5C;<br />

but when I get to reference the array in another member function it is not defined. Instead of the array having the function addresses in them they have the default memory address of 0xCCCCCCCC in them. The definition only works if i put the definition of the arrays in the same member function as the one I reference them from. Now obviously I am doing something wrong here, but i do not know what

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 6:11

David Crow

16-Jun-05 6:11

CNewbie wrote:
void (*call_cmd_function[160])();
void (*call_ins_function[48])();

Then I defined them "globally" at the top of one of my source files as such:

void (CflowlogDlg::*call_ins_function[48])() = {NULL};
void (CflowlogDlg::*call_cmd_function[160])() = {NULL};

Here you have two separate copies of call_ins_function and call_cmd_function.

Are call_cmd_function and call_ins_function supposed to be a member of CflowlogDlg?

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 6:13

CNewbie

16-Jun-05 6:13

Yes, both call_ins_function and call_cmd_function are members of CflowlogDlg.

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 6:21

David Crow

16-Jun-05 6:21

See if this helps:

class CflowlogDlg
{
public:

    void Func1( void )
    {
        cout << "Func1()" << endl;
    }
 
    void Func2( void )
    {
        cout << "Func2()" << endl;
    }
 
    void Func3( void )
    {
        cout << "Func3()" << endl;
    }
 
    typedef void (CflowlogDlg::*call_cmd_function)(void);
};
 
void main( void )
{
    CflowlogDlg::call_cmd_function arr[160];
    
    arr[0] = CflowlogDlg::Func1;
    arr[1] = CflowlogDlg::Func2;
    arr[2] = CflowlogDlg::Func3;
 
    CflowlogDlg m;
    (m.*arr[2])();
    (m.*arr[1])();
    (m.*arr[0])();
}

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 6:34

CNewbie

16-Jun-05 6:34

That worked as local definitions, but didn't work for the global aspect. The reference of call_cmd_function and call_ins function as well as the class referencein my other source files go unresolved.

I can pinpoint my problem to the fact that I need to globalize my class instance. I can lcoalize them by defining them in a member function like so:

CflowlogDlg Instance;

but again i dont know how to globalize it and extern it so it can be used throughout all of my source files. I tried doing it like I read in the c++ book I have, but it doesnt seen to work correctly as I get Linker errors.

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 7:06

David Crow

16-Jun-05 7:06

At this point, I suggest you boil the problem down to just what is absolutely necessary. From there you can post a code snippet and we can put it to rest once and for all.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 7:46

CNewbie

16-Jun-05 7:46

Ok I decided to make both arrays static so that I wouldn't have to use any class instances to access them. Plus it boads better for my program to do it this way since all of the member functions that the array uses are already static.Now I know that static variable (even global ones) are only known within the file that it is declared in. Here is what I did:

Within my Header file I declare the 2 arrays as static:

<br />
	static void (*call_cmd_function[160])();<br />
	static void (*call_ins_function[48])();<br />

Then I define them at the top of the source files where I reference them:

<br />
void (CflowlogDlg::*call_cmd_function[160])() = {NULL}; //goes into flowlogcmds.cpp<br />
void (CflowlogDlg::*call_ins_function[48])() = {NULL};  //goes into flowlogins.cpp<br />

When I compile I get unresolved external symbol errors:

<br />
flowlogcmds.obj : error LNK2001: unresolved external symbol "public: static void (__cdecl** CflowlogDlg::call_cmd_function)(void)" (?call_cmd_function@CflowlogDlg@@2PAP6AXXZA)<br />
flowlogins.obj : error LNK2001: unresolved external symbol "public: static void (__cdecl** CflowlogDlg::call_ins_function)(void)" (?call_ins_function@CflowlogDlg@@2PAP6AXXZA)<br />

neither are referenced outside of its file, so I dont know why I am getting the Linker errors.

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 8:24

David Crow

16-Jun-05 8:24

if call_cmd_function, call_ins_function, doins00, and doins5C are all static members, why put them in a class at all? That's seems to make things unnecessarily complicated. Does this work:

class CflowlogDlg
{
    public:
 
    static void Func1( void )
    {
        cout << "Func1()" << endl;
    }
 
    static void Func2( void )
    {
        cout << "Func2()" << endl;
    }
 
    static void Func3( void )
    {
        cout << "Func3()" << endl;
    }
};
    
void (*call_cmd_function[3])(void);
 
void main( void )
{
    call_cmd_function[0] = CflowlogDlg::Func1;
    call_cmd_function[1] = CflowlogDlg::Func2;
    call_cmd_function[2] = CflowlogDlg::Func3;
 
    (*call_cmd_function[2])();
    (*call_cmd_function[1])();
    (*call_cmd_function[0])();
}

Now you can reference call_cmd_function[] from other files, too.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

CNewbie16-Jun-05 8:46

CNewbie

16-Jun-05 8:46

Thank you David. Finally got it working.

Thank you for all of the help Smile | :)

Re: C++ Array Of Function Pointers problem

David Crow16-Jun-05 8:49

David Crow

16-Jun-05 8:49

CNewbie wrote:
Finally got it working

So what was the final solution?

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Re: C++ Array Of Function Pointers problem

coadtoad13-Jun-05 6:23

coadtoad

13-Jun-05 6:23

Your functions are public members. Are you initializing them in the .cpp file at the global scope or in a member function? If global, then I think that you are defining a new array that happens to have the same name as your member variable. You are not assigning values to your member array. Then when you call the function, the array is not initialized. Try this:

In your OnInitDialog():

// Init the functions pointers here
functionarray1[0] = CDialog::Func1 ;
functionarray1[1] = CDialog::Func2 ;

Later:
// call the functions
functionarray1[0]() ;
functionarray1[1]() ;

Make sure you declare Func1 and Func2 as static in CDialog.h

void (*functionarray1[48])();
void static Func1() ;
void static Func2() ;

Coadtoad

Re: C++ Array Of Function Pointers problem

CNewbie13-Jun-05 11:49

CNewbie

13-Jun-05 11:49

yes coadtoad, that is exactly what I am doing. I am initializing them at the global level in the .cpp file as such:

void (TMyClass::*funcArr2[48])() = {CDialog::func1,CDialog::func2};

I did it this way because I already know what functions I want in there, this is the way I did it in C and because it is less code to wirte then If i do it within a member function like initdialog.

Also is it a rule that the member functions have to be static?

Re: C++ Array Of Function Pointers problem

coadtoad14-Jun-05 5:58

coadtoad

14-Jun-05 5:58

If you want to have function pointers, I believe that the functions must be static, then you can't see the member variables from the static function. You may need to use a different approach like calling a CDialog member function that uses a switch statement to call the member functions. A little bit more messy, but you will have better encapsulation than writing a series of static functions.

Coadtoad

Access variables in CMyView

hcmuns12-Jun-05 17:26

hcmuns

12-Jun-05 17:26

BOOL CMainFrame::OnCommand(WPARAM wParam, LPARAM lParam)
{
CMainFrame* pFrame = (CMainFrame*)AfxGetMainWnd();
CMyView* pView= (CMyView*)pFrame->GetActiveView();
pView->m_MyVar = 8;//<== Error occur here

//...........
}

How can I access variables in CMyView ?

Thanks in advance Smile | :)

Re: Access variables in CMyView

PJ Arends12-Jun-05 17:38

PJ Arends

12-Jun-05 17:38

What is the error you are getting? We are not mind readers (at least I'm not) and we can not see your screen, so you are going to have to give more infomation.

Re: Access variables in CMyView

hcmuns12-Jun-05 17:49

hcmuns

12-Jun-05 17:49

It appearces an error : Unhandled exception in ClipboardViewer.exe: 0xC0000005: Access Violation

Re: Access variables in CMyView

Tom Archer12-Jun-05 18:22

Tom Archer

12-Jun-05 18:22

The first *major* error that you're making is that you're not even verifying that the view pointer is valid. Since you're getting an access violation, it would appear that the view pointer is not valid. I would guess that you're calling GetActiveView in a state before the view is created.

Re: Access variables in CMyView

hcmuns12-Jun-05 21:21

hcmuns

12-Jun-05 21:21

I run my MDI project, in the first time, my program has one view, but when I click menu, the error occurres

Could you tell me how I can access variables in CMyView from CMainFrame

Thanks in advance Smile | :)

Re: Access variables in CMyView

hcmuns12-Jun-05 22:41

hcmuns

12-Jun-05 22:41

I found ways to get CMyView

(*)Get CMyView for SDI

+Method 1:
CMyView* pView = (CMyView*)AfxGetMainWnd();

+Method 2:
CMainFrame* pFrame = (CMainFrame*)AfxGetMainWnd();
CMyView* pView = (CMyView*)pFrame->GetActiveView();

(*)Get CMyView for MDI

CMDIFrameWnd *pFrame = (CMDIFrameWnd*)AfxGetApp()->m_pMainWnd;

CMDIChildWnd* pChild = (CMDIChildWnd*)pFrame->GetActiveFrame();

CMyView* pView = (CMyView*)pChild->GetActiveView();
Smile | :)

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.