C / C++ / MFC

11-Apr-05 22:07

How to convert a LONGLONG data type to binary ?
Thanks for any help.

Re: LONGLONG [Edited]

Joel Holdsworth11-Apr-05 22:56

11-Apr-05 22:56

I guess you mean convert to a binary string... right? If you can't find a runtime library function to do it, try something like this:

LONGLONG value = 12345;
TCHAR mystring[sizeof(LONGLONG)*8 + 1];
for(int i = 0; i < sizeof(LONGLONG)*8; i++)
	mystring[i] = ((value >> (sizeof(LONGLONG)*8 - i - 1)) & 1) ? _T('1') : _T('0');
mystring[sizeof(LONGLONG)*8] = 0;

Hope that helps.

Joel Holdsworth

Wanna give me a job this summer?
Check out my online CV and project history[^]

fardak11-Apr-05 23:22

11-Apr-05 23:22

Thank you.
I tried to put the answer to the code you gave me in a message box like that:

void CMyBitsDlg::ConvertLLtoBin()
{ LONGLONG value = 12345;
TCHAR mystring[sizeof(LONGLONG)];
for(int i = 0; i < sizeof(LONGLONG); i++)
mystring[i] = ((value >> (sizeof(LONGLONG) - i - 1)) & 1) ? _T('1') : _T('0');
AfxMessageBox(mystring);
}

The answer is 00111001P@
Any idea about the error?

toxcct11-Apr-05 23:27

11-Apr-05 23:27

you forgot to end your string with

mystring[i] = '\0';

that doesn't happend with my CString (see here[^])

of course, int i; should be declared before for() loop...

TOXCCT >>> GEII power
[toxcct][VisualCalc]

Joel Holdsworth12-Apr-05 0:06

12-Apr-05 0:06

Yes the thought just popped into my mind, and I just returned now to correct my mistake.

Joel Holdsworth

Wanna give me a job this summer?
Check out my online CV and project history[^]

Re: LONGLONG [edited]

toxcct11-Apr-05 23:08

11-Apr-05 23:08

datas are written in binary format in memory...

however, if you like to print an integer in binary format, this link[^] should help.
here is the sample :

<font color=#0000FF>LONGLONG</font> iVal = 125932;   <font color=#008000>// For example</font>
CString strVal = <font color=#808080>""</font>;      <font color=#008000>// CString because more easy to use</font>

<font color=#0000FF>for</font> (<font color=#0000FF>int</font> i = 0; i < <font color=#0000FF>sizeof</font>(LONGLONG); i++) {
    strVal.Insert(0, ((iVal & 0x00000001) ? <font color=#808080>"1"</font> : <font color=#808080>"0"</font>));
    iVal >>= 1;
}

cheers,

TOXCCT >>> GEII power
[toxcct][VisualCalc]

fardak11-Apr-05 23:42

11-Apr-05 23:42

Thank you.
Pls read my reply to Joel Holdsworth.

toxcct11-Apr-05 23:47

11-Apr-05 23:47

fardak wrote:
Pls read my reply to Joel Holdsworth

hey, already done...

you define mystring as a TCHAR[], which need a trailing '\0' to be displayed correctly...

TOXCCT >>> GEII power
[toxcct][VisualCalc]

fardak12-Apr-05 0:05

12-Apr-05 0:05

Thanks again.
I rewrote this:
void CMyBitsDlg::ConvertLLtoBin()
{ LONGLONG value = 12345;
TCHAR mystring[sizeof(LONGLONG)];
for(int i = 0; i < sizeof(LONGLONG); i++)
mystring[i] = ((value >> (sizeof(LONGLONG) - i - 1)) & 1) ? _T('1') : _T('0');
mystring[i]='\0'; //added
AfxMessageBox(mystring);
}

And the answer is 00111001 which is 39 hexadecimal.
So something is wrong.
But the strange thing happening now is that I have an error memory reading message.

Joel Holdsworth12-Apr-05 0:11

12-Apr-05 0:11

Almost correct. You need to change

TCHAR mystring[sizeof(LONGLONG)];

TCHAR mystring[sizeof(LONGLONG) + 1];

and instead of writing

mystring[i]='\0';

try

mystring[sizeof(LONGLONG)] = 0;

I think that might help

Joel Holdsworth

Wanna give me a job this summer?
Check out my online CV and project history[^]

fardak12-Apr-05 0:26

12-Apr-05 0:26

Thanks again.
Ok the last version is

void CMyBitsDlg::ConvertLLtoBin()
{ //LONGLONG value = 12345;
LONGLONG value = 0xFF FF FF FF FF FF FF FF;
TCHAR mystring[sizeof(LONGLONG)+1];
for(int i = 0; i < sizeof(LONGLONG); i++)
mystring[i] = ((value >> (sizeof(LONGLONG) - i - 1)) & 1) ? _T('1') : _T('0');
mystring[sizeof(LONGLONG)]='\0';
AfxMessageBox(mystring);
}

And the answer is 11 11 11 11
Instead od a 64 times '1'.
Where the rest has gone ?

Joel Holdsworth12-Apr-05 0:30

12-Apr-05 0:30

Read this[^], and see my update original code at the bottom of the tree: http://www.codeproject.com/script/comments/forums.asp?msg=1081046&forumid=1647#xx1081046xx[^]

Joel Holdsworth

Wanna give me a job this summer?
Check out my online CV and project history[^]

fardak12-Apr-05 0:42

12-Apr-05 0:42

Thank you for yor time and effort.
I tried you edited code with a value of
0xFF FF FF FF FF FF FF FF (//16 F)
and it gives 64 1's which is the correct answer .
Thanks again.

Joel Holdsworth12-Apr-05 0:50

12-Apr-05 0:50

Phew finally - I'm being a donkey today D'Oh! | :doh:

Joel Holdsworth

Wanna give me a job this summer?
Check out my online CV and project history[^]

toxcct12-Apr-05 0:14

12-Apr-05 0:14

hum, well, it seems that the code is printing only the LSB and is missing the 0b 00110000 00111001

did you try my code ?

TOXCCT >>> GEII power
[toxcct][VisualCalc]

fardak12-Apr-05 0:35

12-Apr-05 0:35

Not yet,but I will and tell you about it.
Right now my head is spinning..dangerously!!

fardak12-Apr-05 1:59

12-Apr-05 1:59

Thanks for the code you supplied.
I tried the one given by Joel Holdsworth,and it works perfectly well.
Here's the final version.
void CMyBitsDlg::ConvertLLtoBin()
{
LONGLONG value = 0xFFFFFFFFFFFFFFFF;//16 F
TCHAR mystring[sizeof(LONGLONG)*8 + 1];
for(int i = 0; i < sizeof(LONGLONG)*8; i++)
mystring[i] = ((value >> (sizeof(LONGLONG)*8 - i - 1)) & 1) ? _T('1') : _T('0');
mystring[sizeof(LONGLONG)*8] = 0;
AfxMessageBox(mystring);
}
The result is a 64 1's.

Joel Holdsworth12-Apr-05 0:26