C / C++ / MFC

27-Aug-02 11:57

I have this timer that sets some buttons but it doesn't take place in the dialog window until I click the button or if I have a break in the code when I come out.

void CStatus::OnTimer(UINT nIDEvent)
{
if(nIDEvent == 3153)
{
UpdateData(true);

m_153_tti_enab.m_MouseOnButton = true;
m_153_tti_inhbt.m_MouseOnButton = true;
m_153_min_inhbt.m_MouseOnButton = true;
m_153_test.m_MouseOnButton = true;
m_153_malf.m_MouseOnButton = true;
m_153_rt.m_MouseOnButton = true;

UpdateData(false);

}
Any ideas as to why this won't update the window?

Thanks for all the help!!!

Christian Graus27-Aug-02 12:02

Christian Graus

27-Aug-02 12:02

Try forcing the window to repaint itself with Invalidate(FALSE); after the UpdateData call.

Christian

We're just observing the seasonal migration from VB to VC. Most of these birds will be killed by predators or will die of hunger. Only the best will survive - Tomasz Sowinski 29-07-2002 ( on the number of newbie posters in the VC forum )

Cats, and most other animals apart from mad cows can write fully functional vb code. - Simon Walton - 6-Aug-2002

jimNLX27-Aug-02 12:03

27-Aug-02 12:03

The Invalidate() does cause the window to update...GOOD. but it blinks really bad. Any easy way to smooth this out?

Christian Graus27-Aug-02 12:17

Christian Graus

27-Aug-02 12:17

Invalidate(FALSE) should cause the window to redraw itself WITHOUT erasing first, and should therefore not flicker. Beyond that, my MFC is a little rusty, I'm sorry. Is your WM_PAINT message doing anything strange ?

Christian

We're just observing the seasonal migration from VB to VC. Most of these birds will be killed by predators or will die of hunger. Only the best will survive - Tomasz Sowinski 29-07-2002 ( on the number of newbie posters in the VC forum )

Cats, and most other animals apart from mad cows can write fully functional vb code. - Simon Walton - 6-Aug-2002

Andreas Saurwein27-Aug-02 13:33

27-Aug-02 13:33

Is the application busy?
And what is ...m_MouseOnButton?
What is it expected to do?

Give a little more insight to your app.

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

jimNLX28-Aug-02 3:15

28-Aug-02 3:15

The app isn't busy...m_MouseOnButton is a way of setting the button to the active state. So what I'm doing is reading in some values and if they are true then I set the button on and hope it updates on the page by changing color.

Thanks for the help.

Andreas Saurwein28-Aug-02 3:43

28-Aug-02 3:43

jimNLX wrote:
if they are true then I set the button on and hope it updates

Hope is the last to die, people say. Wink | ;)

How exactly are you setting the button on? Where does it happen? When?

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

jimNLX28-Aug-02 3:56

28-Aug-02 3:56

enab.m_MouseOnButton = true; this is how I set the button state to on and I do this in OnTimer()

Andreas Saurwein28-Aug-02 4:08

28-Aug-02 4:08

Sorry, where does the button actually react on the flag? is it a check button? and the variable is DDX'd to it?

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

jimNLX28-Aug-02 4:15

28-Aug-02 4:15

I'm using CButtonST (from this board) and subclass this in OnInit then OnTimer reads a flag and sets

OnInit code:
m_jam.SubclassDlgItem(IDC_JAM,this);
m_jam.SetTooltipText(IDS_TRNFREEZE);
m_jam.SetActiveBgColor(COLOR_ORANGE);

OnTimer code:

m_jam.m_MouseOnButton = true;

Andreas Saurwein28-Aug-02 4:42

28-Aug-02 4:42

Did you try using a standard button instead? If it works with the standard button I would say its a bug in the CButtonST class.

btw: your call to UpdateData(true) isnt needed at all as far as I see from your code.

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

crash !! Help

ns27-Aug-02 11:41

27-Aug-02 11:41

If I run it w/o breakpoints, it puts up three CFIleDialogs like it should, but then crashes - memory could not be read.

If I try to debug it with a breakpoint, it says its an NTDLL first chance exception - invalid handle. and never even puts up the three dialogs! I can put the breakpoint anywhere even quite early and I stil ge this. In the call stack I havent gone very far when it happens. I'm troubled that a direct run, and a breakpoint debug run arent following the same route? Although The three CFILEDLgs are postmessage triggered, so maybe thats significant?

Helppp!
ns

Weirder yet, after the three fldialogs get their inputs they save then to the registry. and then crashes. But if you run the program again after these keys have been created, it runs just fine!!

SO its a crash about an invalid handle but doesnt allow the filedlgs to popup like they do when the program is run without debug mode.

Re: crash !! Help

Christian Graus27-Aug-02 12:01

Christian Graus

27-Aug-02 12:01

And the code ?

Is the program single threaded ? What are you storing in the registry ? How does your programs execution path differ once those keys exist ?

Christian

We're just observing the seasonal migration from VB to VC. Most of these birds will be killed by predators or will die of hunger. Only the best will survive - Tomasz Sowinski 29-07-2002 ( on the number of newbie posters in the VC forum )

Cats, and most other animals apart from mad cows can write fully functional vb code. - Simon Walton - 6-Aug-2002

My registry code

Anonymous27-Aug-02 16:21

Anonymous

27-Aug-02 16:21

Its single threaded. I'm storing names of databases etc (strings). Once the registry keys are in, I dont postmessage to trigger the open CFiledlgs, but get the registry info. at this point its fine. I do this(no error trapping):

void CTrain1View::QueryRegistry()
{
	CString dbName;

	
	HKEY keyHandle1, keyHandle2, keyHandle3;
	CString str;
;
	
	DWORD valSize = sizeof(DWORD);

	// Open the Software key under HKEY_CURRENT_USER.
	RegOpenKeyEx(HKEY_CURRENT_USER, "Software",
		0, KEY_ALL_ACCESS, &keyHandle1);


	// Open the MyCompany key under Software.
		LONG res = RegOpenKeyEx(keyHandle1, "MyCompany4",
		0, KEY_ALL_ACCESS, &keyHandle2);


	// Open the MyApplication key under MyCompany.
	RegOpenKeyEx(keyHandle2, "MyApplication4",
		0, KEY_ALL_ACCESS, &keyHandle3);

	
	DWORD size=128;
	DWORD	type = REG_SZ;
	LPSTR psz = dbName.GetBuffer(size);
	LONG result =	RegQueryValueEx( keyHandle3,"Database Name",0,&type,(LPBYTE)psz,&size );
	dbName.ReleaseBuffer();


	 size=128;
//	DWORD	type = REG_SZ;
	LPSTR psz1 = m_PhotoDBPath.GetBuffer(size);
	 result =	RegQueryValueEx( keyHandle3,"Photo Database Name",0,&type,(LPBYTE)psz1,&size );
	m_PhotoDBPath.ReleaseBuffer();




	 size=128;
//	DWORD	type = REG_SZ;
	LPSTR psz2 = m_ImageFolderLoc.GetBuffer(size);
	 result =	RegQueryValueEx( keyHandle3,"Image Folder Location",0,&type,(LPBYTE)psz2,&size );
	m_ImageFolderLoc.ReleaseBuffer();

	gImageFolderLoc = m_ImageFolderLoc;
	
	// Close all the open keys.
	RegCloseKey(keyHandle1);
	RegCloseKey(keyHandle2);
	RegCloseKey(keyHandle3);

	// query for DB name here and if no name, pop up showOpen. Get name
//	if name in registry, get name
	//Call function wrappper for DLLgetKeywords (getstuff at the mo) - this is a member function of the doc, so call via pointer
	//: Wrapper because when the DB buton is directly activated, we need to duplicate the process - pass of name into wrapper which calls Dllgetkeywords
//	CTrain1Doc * pDoc = GetDocument();
	
	if (result == ERROR_SUCCESS) //return  dbName; 
	
	{
		gDatabaseName=dbName; //this is the whole path being used in this program

		CString filename = DatabaseName(dbName); //extracts just abc.mdb from full path.
		//AfxMessageBox(filename);
		GetStuff(dbName );
		InitDisplay();
	}

//	if( result != ERROR_SUCCESS)popup showopen.Basically trigger  the select db menu
	if ( dbName =="")//( result != ERROR_SUCCESS)
{
PostMessage(WM_COMMAND, ID_SELECTDATABASE);

}
	}

and the postmessage is handled as:

CFileDialog fileDlg(TRUE, NULL, NULL, OFN_HIDEREADONLY|OFN_FILEMUSTEXIST, "Database Files(*.mdb)|*.mdb||",NULL); 

// Initializes m_ofn structure 
fileDlg.m_ofn.lpstrTitle = "Open Database";

// Call DoModal
if ( fileDlg.DoModal() == IDOK)
{
    m_szlstfile = fileDlg.GetPathName(); // This is your selected file name with path

	//if extension of the file isnt mdb, error msg -file selected is not a db.
  //  AfxMessageBox("Your file name is :" +m_szlstfile );
	CString fileExt = fileDlg.GetFileExt();

//	AfxMessageBox(fileExt);
	if(fileExt != "MDB" && fileExt != "mdb" )
	{
	m_badfilename=TRUE;
	AfxMessageBox ("The file selected is not a database file");
	imageMap.clear();
	/////

	InitDisplay(); //isnt doing it the way things are at the moment. Might work.
	//blank out pictures, "invalid database" in textboxes, blank out display list, blank out search screen.(delete all items)
	return;
	}
	//always do
	m_listdisplay.DeleteAllItems();



	//////aug27

	CFileDialog fileDlg(TRUE, NULL, NULL, OFN_HIDEREADONLY|OFN_FILEMUSTEXIST, "Database Files(*.mdb)|*.mdb||",NULL); 

	// Initializes m_ofn structure 
	fileDlg.m_ofn.lpstrTitle = "Select Database For Photographs";

	// Call DoModal

	int nRetPhoto = fileDlg.DoModal();

	if ( nRetPhoto == IDOK)
	{
		m_PhotoDBPath = fileDlg.GetPathName(); // This is your selected file name with path

		//if extension of the file isnt mdb, error msg -file selected is not a db.
		//  AfxMessageBox("Your file name is :" +m_szlstfile );
		CString fileExt = fileDlg.GetFileExt();

		//	AfxMessageBox(fileExt);
		if(fileExt != "MDB" && fileExt != "mdb" )
		{
		//	m_badfilename=TRUE;
			AfxMessageBox ("The file selected is not a database file. No record added");

			return;
		}



	}



	CFileDialogST	dlg;
	int				nRetValue;
	CString			sFolder;

	nRetValue = dlg.SelectFolder(_T("Please select the Image folder"), _T("c:\\"), 0x40|BIF_RETURNFSANCESTORS | BIF_RETURNONLYFSDIRS, this);
	if (nRetValue == IDOK)
	{
		m_ImageFolderLoc = dlg.GetSelectedFolder();

		gImageFolderLoc = m_ImageFolderLoc;    
		MessageBox(m_ImageFolderLoc, _T("GetSelectedFolder"), MB_ICONINFORMATION);
	} // if

	
	HKEY keyHandle1, keyHandle2, keyHandle3;
	CString str;
	DWORD disp;
    
    // Open the Software key under HKEY_CURRENT_USER.
    RegOpenKeyEx(HKEY_CURRENT_USER, "Software",
        0, KEY_ALL_ACCESS, &keyHandle1);

	//These keys already exist since mainframe precreated them if reqd, while looking for loading info.
    // open the MyCompany key under Software.
    RegCreateKeyEx(keyHandle1, "MyCompany4", 0, "",
        REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL,
        &keyHandle2, &disp);

    // open the MyApplication key under MyCompany.
    RegCreateKeyEx(keyHandle2, "MyApplication4", 0, "",
        REG_OPTION_NON_VOLATILE, KEY_ALL_ACCESS, NULL,
        &keyHandle3, &disp);

   	// string
	DWORD type = REG_SZ;
	DWORD size = m_szlstfile.GetLength();
	LONG result = RegSetValueEx( keyHandle3,"Database Name",0,type,(LPBYTE)LPCSTR(m_szlstfile),size );

	   	// string
//	DWORD type = REG_SZ;
	 size = m_PhotoDBPath.GetLength();
	 result = RegSetValueEx( keyHandle3,"Photo Database Name",0,type,(LPBYTE)LPCSTR(m_PhotoDBPath),size );


	   	// string
//	DWORD type = REG_SZ;
	 size = m_ImageFolderLoc.GetLength();
	 result = RegSetValueEx( keyHandle3,"Image Folder Location",0,type,(LPBYTE)LPCSTR(m_ImageFolderLoc),size );

	
	if (result != ERROR_SUCCESS)
		AfxMessageBox("Registry error");
   

	// Close all the open keys.
	RegCloseKey(keyHandle1);
	RegCloseKey(keyHandle2);
	RegCloseKey(keyHandle3);



	gDatabaseName = m_szlstfile;

	if (pDoc->m_db.IsOpen()) pDoc->m_db.Close();

	GetStuff(m_szlstfile );	
	InitDisplay();

I have two CFiledlgs with the same name, but even making them distinct doesnt help.
Thanks for helping!

ns

Re: My registry code

Andreas Saurwein27-Aug-02 23:22

27-Aug-02 23:22

Seems that its really what I suggested: you dont check the return values from the first RegOpenKey(...) calls. They will definitly fail and thus you have a invalid handle in keyHandle1, so the next call to RegOpenKey() to open the MyCompany key will fail and throw your exception.

Always check for return values - even if you are sure it will succeed (which it doesnt in your case).

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

Re: crash !! Help

Andreas Saurwein27-Aug-02 13:42

sorry for the ultra long post above. Desperate!

27-Aug-02 13:42

ns wrote:
Weirder yet, after the three fldialogs get their inputs they save then to the registry. and then crashes. But if you run the program again after these keys have been created, it runs just fine!!

Could it be that you read this registry keys too? If so, I suppose that you do a RegOpenKey(..) which fails, thus you have a invalid handle that you dont check for, thus the next use of this handle will fail again.

Take a look in this areas.

int x=1, y=5; 
x^=y^=x^=y; // whats the content of x and y now?
<a href="http://www.codeproject.com/tips/StupidXORTrick.asp" target="_blank">ClickHereForHelp();</a>

Anonymous27-Aug-02 16:24

Anonymous

27-Aug-02 16:24

When i do read it (after the initial crash) its successful. I dont know if the source I posted above gives any clues...

Thanks,
ns

Weird Resolution to problem

ns28-Aug-02 3:23

28-Aug-02 3:23

Well, I changed PostMessage to sendMessage and things worked! Apparently there was a timing issue and the code that needed to be run didnt, while the code that triggered the postmessage went on as though it had the data from the postmessage function already. This only recently became a problem, since it worked fine before. It was impossible to debug, and the only way was a lucky trial and error. I had no hope.

ANyways, now I'm not so thrilled (but can live with it) with the fact that CFileDialogs pop up out of the blue when the app starts with no background blank UI suggesting which program is spawning them. SO its not very informative, and not traditional really. ANy ideas on how I can make things so that the blank UI comes up behind the CFileDialog (like it used to when I postMessaged the CFileDialog).

This was a nightmare crash and I cant yet believe its resolved. Nothing in the debugging suggested that that was the problem. In fact the postmessage never got triggered when a breakpoint was put at it(it got there and went past). But when I ran it directly, I did get the postmessaged CFileDialog. So there was no similarity between debug mode and run mode events. However the postmessage in a simpler version of my program would trigger just fine at the right time and get things done in time for the main program to use the data and not crash.

Thanks everyone for helping, and sorry again for the ultra long post,but I wanted to put forth as much information as possible to get your input.

APpreciate the help,
ns

Confused | :confused:

Re: Weird Resolution to problem

Andreas Saurwein28-Aug-02 3:29