what is tha error in this code

Question

1.60/5 (2 votes)

See more:

C#

SqlConnection con = new SqlConnection();
            con.Open();
            con.ConnectionString = "Data Source=GHARONDA-15; Initial Catalog=RagestrationDetail; Integrated Security=SSPI";
            
            SqlCommand cmd = new SqlCommand();
            cmd.Connection=con;
            con.Close();
            cmd.CommandType=CommandType.Text;
            cmd.CommandText= "insert into Form1(Name,FatherName,Address,DateOfBirth,JoiningDate,Experience,EducationalQualification)values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3.Text+"','"+textBox4.Text+"','"+textBox5.Text+"','"+textBox6.Text+"','"+textBox7.Text+"')";
            cmd.ExecuteNonQuery();
            MessageBox.Show("Record Saved");

Error is
The ConnectionString property has not been initialized.

Posted 18-May-15 21:57pm

Member 11701625

Updated 18-May-15 22:14pm

_Asif_

v2

Add a Solution

4 solutions

Solution 1

Just Define con.ConnectionString property before con.Open()

and one more thing use con.Close() after your cmd.ExecuteNonQuery()

:-)

Posted 18-May-15 22:03pm

Hemant Singh Rautela

Updated 18-May-15 22:05pm

v2

Solution 3

you have to Open and Close Connection object

Quote:

SqlConnection con = new SqlConnection();
con.ConnectionString = "Data Source=GHARONDA-15; Initial Catalog=RagestrationDetail; Integrated Security=SSPI";
SqlCommand cmd = new SqlCommand();
cmd.Connection=con;
using(con.open())
{
cmd.CommandType=CommandType.Text;
cmd.CommandText= "insert into Form1(Name,FatherName,Address,DateOfBirth,JoiningDate,Experience,EducationalQualification)values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3.Text+"','"+textBox4.Text+"','"+textBox5.Text+"','"+textBox6.Text+"','"+textBox7.Text+"')";
cmd.ExecuteNonQuery();
MessageBox.Show("Record Saved");
}

Posted 18-May-15 23:00pm

Pankit Patel

Updated 18-May-15 23:01pm

v2

Solution 4

con.Open();

should be called after connection string is innitlized

SqlConnection con = new SqlConnection();

con.ConnectionString = "Data Source=GHARONDA-15; Initial Catalog=RagestrationDetail; Integrated Security=SSPI";
con.Open();

SqlCommand cmd = new SqlCommand();
cmd.Connection=con;
con.Close();
cmd.CommandType=CommandType.Text;
cmd.CommandText= "insert into Form1(Name,FatherName,Address,DateOfBirth,JoiningDate,Experience,EducationalQualification)values('"+textBox1.Text+"','"+textBox2.Text+"','"+textBox3.Text+"','"+textBox4.Text+"','"+textBox5.Text+"','"+textBox6.Text+"','"+textBox7.Text+"')";
cmd.ExecuteNonQuery();
MessageBox.Show("Record Saved");

Posted 18-May-15 23:04pm

abhishek4official

Updated 18-May-15 23:05pm

v2

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2015-05-18T22:14:00

There are a lot of problems here!
The problem you have noticed is pretty simple: You are setting the connection string after you try to open the connection.
And please, don't do it like that! Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead
Try this:

C#

using (SqlConnection con = new SqlConnection(@"Data Source=GHARONDA-15; Initial Catalog=RagestrationDetail; Integrated Security=SSPI"))
    {
    con.Open();    
    using (SqlCommand cmd = new SqlCommand("INSERT INTO Form1 (Name, FatherName, Address, DateOfBirth, JoiningDate, Experience, EducationalQualification) VALUES (@NM, @FN, @AD, @DOB, @JD, @EX, @EQ)", con))
        {
        cmd.Parameters.AddWithValue("@NM", textBox1.Text);
        cmd.Parameters.AddWithValue("@FN", textBox2.Text);
        cmd.Parameters.AddWithValue("@AD", textBox3.Text);
        cmd.Parameters.AddWithValue("@DOB", textBox4.Text);
        cmd.Parameters.AddWithValue("@JD", textBox5.Text);
        cmd.Parameters.AddWithValue("@EX", textBox6.Text);
        cmd.Parameters.AddWithValue("@EQ", textBox7.Text);
        cmd.ExecuteNonQuery();
        MessageBox.Show("Record Saved");
        }
    }

But...You need to validate the dates are "real" dates, or SQL will throw an exception - and I'm hoping you are storing them as DATETIME values, or you will be giving yourself some really nasty problems in future.

And do yourself a favour, and stop using Visual Studio default names for everything - you may remember that "TextBox4" is the date of birth today, but when you have to modify it is three weeks time, will you then? Use descriptive names - "tbBirthdate" for example - and your code becomes easier to read, more self documenting, easier to maintain - and surprisingly quicker to code because Intellisense can get to to "tbBirthdate" in three keystrokes, where "TextBox8" takes thinking about and 8 keystrokes...