static vector push_back crashes

Question

1.00/5 (1 vote)

See more:

Hi,
I got a crash while adding item to a static vector in class A ;

static std::vector< pegshort > keys;

In another class, I try to insert item as follows ;

A::keys.push_back(x); // the program crashes in this code block
(x is a pegshort type variable )

When I do all steps for a non-static vector it works OK. But I need a static vector.
Could you please help about the cause of crash ?

Posted 28-Aug-14 4:07am

no_-_namee

Updated 28-Aug-14 4:17am

v3

Add a Solution

Comments

Richard MacCutchan 28-Aug-14 10:46am

Please show the exact details of the error, including the line of code where it occurs and the values of all variables relevant to the problem.

nv3 28-Aug-14 11:00am

That could be caused by adding an item at a time when the keys vector has not been initialized yet. For example you might add an element from a piece of code in the constructor of another static object. Such initialization problems are quite common.

Sergey Alexandrovich Kryukov 28-Aug-14 14:20pm

Good point. I actually cannot see other possibilities. OP is recommended to use the debugger and put a breakpoint on that line.
—SA

Philippe Mori 28-Aug-14 21:42pm

In such case using Singleton pattern might be adequate.

nv3 29-Aug-14 3:11am

Exactly! Thanks for the hint, Philippe.

no_-_namee 29-Aug-14 3:18am

If I summarize the problem, there are two classes.
And I should be able to access a parameter of the first class from the other class. It is not possible to create an instance of the class in the other class. So, I thought that I can define a static vector, and send the param via this vector. Do you have any other suggestion to resolve this problem ?

nv3 29-Aug-14 5:58am

Let's first clarify whether your problem results from an initialization issue. Is the consuming code (the one in which you query the parameter from the other class) also in static code? That would hint in the direction of problems in the static initialization order.

no_-_namee 29-Aug-14 6:27am

I add item to the the static vector in a non-static event.

nv3 29-Aug-14 8:10am

Then it seems not to be an initialization problem. I think you need to post your actual code (the relevant parts of it). That would make it easier for anybody to diagnose what's going on here.

Sergey Alexandrovich Kryukov 28-Aug-14 14:15pm

[... — SA]

Sergey Alexandrovich Kryukov 28-Aug-14 14:19pm

Why static?!
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Eugen Podsypalnikov · Answer 1 · 2014-11-03T23:39:00

Solution 1

C++

// On-Demand Test.cpp :)

#include "pegshort.h"
#include <vector>

typedef std::vector<pegshort> vecKeys;

vecKeys& GetStaticKeys()
{
  static vecKeys s_keys;
  return s_kes;
}

class Test
{
public:
  Test()
  {
    GetStaticKeys().push_back(pegshort(3));
  }
} testIt;

Posted 3-Nov-14 23:39pm

Eugen Podsypalnikov

Updated 3-Nov-14 23:46pm

v3