how to solve this MS sql query it gives me error

Question

1.00/5 (2 votes)

See more:

SQL

cmd = new SqlCommand("SELECT (invoiceNo) as [Invoice No],(InvoiceDate) as [Invoice Date],(Sales.CustomerID) as [Customer ID],(CustomerName) as [Customer Name],(GrandTotal) as [Grand Total],(TotalPayment) as [Total Payment],(PaymentDue) as [Payment Due] from Sales,Customer where Sales.CustomerID=Customer.CustomerID and InvoiceDate between #" + DateTimePicker2.Text + "# And #" + DateTimePicker1.Text + "# and PaymentDue > 0 order by InvoiceDate desc", con);

Posted 7-Jul-14 23:07pm

pagal panti

Add a Solution

Comments

Dilan Shaminda 8-Jul-14 5:13am

what is the error you are getting?

pagal panti 8-Jul-14 5:28am

no error is syntax error Near "#"

_Asif_ 8-Jul-14 5:36am

Please do not post questions that you already have posted

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

George Jonsson · Answer 1 · 2014-07-07T23:26:00

You can use a more formatted string build up to make it easier to see the error.

C#

    StringBuilder cmdString = new StringBuilder();
    cmdString.Append(@"SELECT (invoiceNo) as [Invoice No]");
    cmdString.Append(@",(InvoiceDate) as [Invoice Date]");
    cmdString.Append(@",(Sales.CustomerID) as [Customer ID]");
    cmdString.Append(@",(CustomerName) as [Customer Name]");
    cmdString.Append(@",(GrandTotal) as [Grand Total]");
    cmdString.Append(@",(TotalPayment) as [Total Payment]");
    cmdString.Append(@",(PaymentDue) as [Payment Due]");
->  cmdString.Append(@"from Sales, Customer");
    cmdString.Append(@"where Sales.CustomerID = Customer.CustomerID");
    cmdString.Append(@"and InvoiceDate between #");
    cmdString.Append(DateTimePicker2.Text);
    cmdString.Append(@"# And #");
    cmdString.Append(DateTimePicker1.Text);
    cmdString.Append(@"# and PaymentDue > 0");
    cmdString.Append(@"order by InvoiceDate desc");

Have a look at the line pointed out by ->.
Is that syntax correct?

DaveAuld · Answer 2 · 2014-07-07T23:28:00

First thing I would do is restructure the query to put the various AND statements in brackets;

e.g.

SQL

cmd = new SqlCommand("SELECT (invoiceNo) as [Invoice No],
                             (InvoiceDate) as [Invoice Date],
                             (Sales.CustomerID) as [Customer ID],
                             (CustomerName) as [Customer Name],
                             (GrandTotal) as [Grand Total],
                             (TotalPayment) as [Total Payment],
                             (PaymentDue) as [Payment Due]
                      FROM Sales,Customer
                      WHERE (Sales.CustomerID = Customer.CustomerID) 
                      AND   (InvoiceDate BETWEEN #" + DateTimePicker2.Text + "# 
                                             AND #" + DateTimePicker1.Text + "#)
                      AND   (PaymentDue > 0)
                      ORDER BY InvoiceDate desc"
               , con);

Check the date fields to make sure you haven't got the later one before the early one.

Also, Format the DateFields to make sure they are appearing correctly to SQL. i always format to YYYY-MMM-DD so there is always no ambiguity.

Did you test the two seperate parts? i.e. the Sales data and the Customer data using known variables? then join the two parts together to test as a complete query.

vani suresh · Answer 3 · 2014-07-08T22:51:00

Hi ,

cmd = new SqlCommand("SELECT (invoiceNo) as [Invoice No],(InvoiceDate) as [Invoice Date],(Sales.CustomerID) as [Customer ID],(CustomerName) as [Customer Name],(GrandTotal) as [Grand Total],(TotalPayment) as [Total Payment],(PaymentDue) as [Payment Due] from Sales,Customer where Sales.CustomerID=Customer.CustomerID and InvoiceDate between '" + DateTimePicker2.Text + "' And '" + DateTimePicker1.Text + "' and PaymentDue > 0 order by InvoiceDate desc", con);

Try to use instead # use ' this one

Gauri Chodanker · Answer 4 · 2014-07-09T04:31:00

Solution 5

As far as I know, the # character works for microsoft access database. For SQL database replace it with a single quote and try doing it.

Please let me also know if that works for you

Posted 9-Jul-14 4:31am

Gauri Chodanker

how to solve this MS sql query it gives me error

4 solutions

Solution 1

Solution 2

Solution 3

Solution 5

Add your solution here

Preview 0