How to get rid of this SQL errot?

Question

2.00/5 (1 vote)

See more:

SQL-Server-2008R2

, +

Dear all,

here i'm struggling with sql syntax error.here i have posted my sql strore procedure and error..

please find where's that error.Please help me...

SQL

GO
CREATE PROCEDURE SP_ADD_ENQUIRIES(
@POL VARCHAR(50),
@POD VARCHAR(50),
@FPOD VARCHAR(50),
@WEIGHT REAL,
@SHIPPER VARCHAR(150),
@CONSIGNEE VARCHAR(150)
)
AS
DECLARE @SUFFIX INT;
DECLARE @PREFIX VARCHAR(3);
DECLARE @RESULT VARCHAR(MAX);
SET @PREFIX='ENQ';
DECLARE @ENQUIRY_ID VARCHAR(MAX);
IF NOT EXISTS(SELECT * FROM ENQUIRY_MASTER)
INSERT INTO ENQUIRY_MASTER VALUES('ENQ_1',@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)
ELSE
SET @SUFFIX=SELECT MAX(ENQUIRY) FROM ENQUIRY_MASTER;
INSERT INTO ENQUIRY_MASTER VALUES(@PREFIX+@SUFFIX,@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)

Error is,

Incorrect syntax near the keyword 'SELECT'.

Posted 4-Apr-14 4:32am

nixonanand

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Guruprasad.K.Basavaraju · Accepted Answer · 2014-04-04T04:49:00

Please change the line that is underlined below.

SQL

GO
CREATE PROCEDURE SP_ADD_ENQUIRIES(
@POL VARCHAR(50),
@POD VARCHAR(50),
@FPOD VARCHAR(50),
@WEIGHT REAL,
@SHIPPER VARCHAR(150),
@CONSIGNEE VARCHAR(150)
)
AS
DECLARE @SUFFIX INT;
DECLARE @PREFIX VARCHAR(3);
DECLARE @RESULT VARCHAR(MAX);
SET @PREFIX='ENQ';
DECLARE @ENQUIRY_ID VARCHAR(MAX);
IF NOT EXISTS(SELECT * FROM ENQUIRY_MASTER)
INSERT INTO ENQUIRY_MASTER VALUES('ENQ_1',@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)
ELSE
SELECT @SUFFIX= MAX(ENQUIRY) FROM ENQUIRY_MASTER;
INSERT INTO ENQUIRY_MASTER VALUES(@PREFIX+@SUFFIX,@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)

Maciej Los · Accepted Answer · 2014-04-04T04:45:00

Solution 1

Replace:

SQL

IF NOT EXISTS(SELECT * FROM ENQUIRY_MASTER)

with:

SQL

IF NOT EXISTS(SELECT ENQ_ID FROM ENQUIRY_MASTER WHERE ENQ_ID=@EID)

Replace:

SQL

SET @SUFFIX=SELECT MAX(ENQUIRY) FROM ENQUIRY_MASTER;

with

SQL

SELECT @SUFFIX=MAX(ENQUIRY) FROM ENQUIRY_MASTER;

Posted 4-Apr-14 4:45am

Maciej Los

Schatak · Accepted Answer · 2014-04-04T07:15:00

Your final code should be:

CREATE PROCEDURE SP_ADD_ENQUIRIES(
@POL VARCHAR(50),
@POD VARCHAR(50),
@FPOD VARCHAR(50),
@WEIGHT REAL,
@SHIPPER VARCHAR(150),
@CONSIGNEE VARCHAR(150)
)
AS
DECLARE @SUFFIX INT;
DECLARE @PREFIX VARCHAR(3);
DECLARE @RESULT VARCHAR(MAX);
SET @PREFIX='ENQ';
DECLARE @ENQUIRY_ID VARCHAR(MAX);
IF NOT EXISTS(SELECT ENQ_ID FROM ENQUIRY_MASTER WHERE ENQ_ID=@EID)
INSERT INTO ENQUIRY_MASTER VALUES('ENQ_1',@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)
ELSE
SELECT @SUFFIX= MAX(ENQUIRY) FROM ENQUIRY_MASTER;
INSERT INTO ENQUIRY_MASTER VALUES(@PREFIX+@SUFFIX,@POL,@POD,@FPOD,@WEIGHT,@SHIPPER,@CONSIGNEE)

OriginalGriff · Accepted Answer · 2014-04-04T04:46:00

Solution 2

You forgot the brackets:

SQL

SET @SUFFIX=SELECT MAX(ENQUIRY) FROM ENQUIRY_MASTER;

Becomes

SQL

SET @SUFFIX=(SELECT MAX(ENQUIRY) FROM ENQUIRY_MASTER);

Posted 4-Apr-14 4:46am

OriginalGriff

How to get rid of this SQL errot?

4 solutions

Solution 3

Solution 1

Solution 4

Solution 2

Add your solution here

Preview 0