problem in mail attachment file

Question

0.00/5 (No votes)

See more:

hello friends, i have to send email via my website with multiple file attached, but when i'm attaching any file the control jump into catch block.otherwise it's working well.
code is below please have a look.

C#

protected void btnSend_Click(object sender, EventArgs e)
    {
        try
        {
            string str = "";
            HttpFileCollection fileCollection = Request.Files;
            for (int i = 0; i < fileCollection.Count; i++)
            {
                HttpPostedFile uploadfile = fileCollection[i];

                string fileName = Path.GetFileName(uploadfile.FileName);
               // fileName = GetUniqueFileName(fileName);
                if (uploadfile.ContentLength > 0)
                {
                    uploadfile.SaveAs(Server.MapPath("~/Upload/MailAttachments/") + fileName);
                    str += fileName + ",";
                }
            }

            string BodyText = "";
            BodyText = "<b>Dear User,</b><br><br>";
            BodyText = BodyText + "Following are the details of the patient who has requested for a appointment you through your website 'ahms.co.in'<br /><br />";
            BodyText = BodyText + "Patient Name:  " + txtPatient.Text + "<br>";
            BodyText = BodyText + "Email :  " + txtEmail.Text + "<br>";
            BodyText = BodyText + "Mobile Number:  " + txtMobile.Text + "<br>";
            BodyText = BodyText + "Health issues:  " + txthealthissue.Text + "<br> <br />";
            BodyText = BodyText + "Appointment Date:  "+txtDate.Text+"<br/>";
            BodyText = BodyText + "Time Slot choosed: " + ddtimeslot.Text + "<br/>";
            BodyText = BodyText + "Thanks,<br />Web Admin";

           

            if (obj.SendMail("info@ahms.co.in", "mail@ahms.co.in ", "Request for Appointment from : ahms.co.in", BodyText, str) == "mailsend")
                {
                    lblMsg.Text = "Thankyou!!We'll get back to you soon";
                    Reset();
                }
                else
                {
                    lblMsg.Text = "Mail server encounter an error.Try again.";

                }
     }

        catch (Exception ex)
        {
            Response.Write(ex);
        }



    }

here is mail sending function

C#

public String SendMail(String MailTo, String MailFrom, String Subject, String MailBody, string pAttachmentPath)
    {
        try
        {
            MailMessage msg = new MailMessage();
            MailAddress mailaddressfrom = new MailAddress(MailFrom);
            MailAddress mailaddressTo = new MailAddress(MailTo);
            msg.From = mailaddressfrom;
            msg.To.Add(mailaddressTo);
            msg.Subject = Subject;
            msg.Body = MailBody;
            msg.IsBodyHtml = true;

            if (pAttachmentPath.Trim() != "")
            {
                System.Net.Mail.Attachment MyAttachment = new System.Net.Mail.Attachment(pAttachmentPath);
                msg.Attachments.Add(MyAttachment);
                msg.Priority = System.Net.Mail.MailPriority.High;
            }
            SmtpClient objSmtp = new SmtpClient();
            
            objSmtp.Send(msg);
            return "mailsend";
        }
        catch (Exception ex)
        {
            return ex.ToString();
        }
    }

Posted 24-Oct-13 20:16pm

Mohd Arif Khan

Updated 24-Oct-13 20:54pm

ridoy

v3

Add a Solution

Comments

Khandwawala Hatim 25-Oct-13 2:21am

What is the exception you are getting in catch block?

Mohd Arif Khan 25-Oct-13 2:55am

file not found

Mohd Arif Khan 25-Oct-13 2:59am

i mailsending function the error has thrown.
ex = {"Could not find file 'C:\\Program Files\\Common Files\\Microsoft Shared\\DevServer\\10.0\\2.jpg,'.":"C:\\Program Files\\Common Files\\Microsoft Shared\\DevServer\\10.0\\2.jpg,"}

Mohd Arif Khan 25-Oct-13 3:00am

it can not find the path of the uploaded file. phil.o the , is for sepration for multiple files

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

phil.o · Answer 1 · 2013-10-24T20:56:00

Solution 1

C#

str += fileName + ",";

Try to remove + "," and see what happens. It's just a guess, we would need the exact exception message, and the line from where it has been thrown.

Posted 24-Oct-13 20:56pm

phil.o

Hemant Singh Rautela · Answer 2 · 2013-10-24T21:37:00

Solution 2

Hi,

As you use here...

C#

uploadfile.SaveAs(Server.MapPath("~/Upload/MailAttachments/") + fileName);
                    str += fileName + ",";

Modified :

C#

string path = Server.MapPath("~/Upload/MailAttachments/") + fileName;
uploadfile.SaveAs(Server.MapPath(path);
str = "Upload/MailAttachments/" + fileName;

// here you want to add multiple files so beware about last comma...(I use it as single file. first try this.)
// one more suggestion you use filename as uploaded file name, But I think you can generate a random string for this for all time...

or a alternate method also you can try I describe in my blog[^].

Hope it will help you.

Thanks

Posted 24-Oct-13 21:37pm

Hemant Singh Rautela

Updated 24-Oct-13 23:04pm

v2

Comments

Mohd Arif Khan 25-Oct-13 4:43am

no it's not working, exception is thrown it is a physical path but virtual path is expected

Hemant Singh Rautela 25-Oct-13 4:55am

Then you can try as I posted in my BLOG...It is working solution for attachement.

you should read this ...
http://msdn.microsoft.com/en-us/library/56wesadc.aspx for use of Attachment(Attachment data = new Attachment(textMessage);)

Hemant Singh Rautela 25-Oct-13 5:04am

I updated my code as
str = "Upload/MailAttachments/" + fileName;
try this one...

Mohd Arif Khan 25-Oct-13 5:10am

this way i have already tried. not worked

Hemant Singh Rautela 25-Oct-13 5:34am

Then you have to read this:
http://msdn.microsoft.com/en-us/library/System.Net.Mail.Attachment(v=vs.110).aspx

Or as I explained in my blog...